From: khilman@baylibre.com (Kevin Hilman)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v2 7/9] mmc: meson-gx: reduce bounce buffer size
Date: Fri, 03 Feb 2017 10:18:41 -0800 [thread overview]
Message-ID: <7hvasruohq.fsf@baylibre.com> (raw)
In-Reply-To: <90d34a64-bd3e-dcf2-4c36-5ef4e2ac8666@gmail.com> (Heiner Kallweit's message of "Wed, 1 Feb 2017 07:49:18 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> A bounce buffer of 512K isn't needed as the max request size is
> 511 * 512 byte.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
> ---
> v2:
> - no changes
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 883263c5..48ce4ba4 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -785,7 +785,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
>
> /* data bounce buffer */
> - host->bounce_buf_size = SZ_512K;
> + host->bounce_buf_size = mmc->max_req_size;
> host->bounce_buf =
> dma_alloc_coherent(host->dev, host->bounce_buf_size,
> &host->bounce_dma_addr, GFP_KERNEL);
WARNING: multiple messages have this Message-ID (diff)
From: Kevin Hilman <khilman@baylibre.com>
To: Heiner Kallweit <hkallweit1@gmail.com>
Cc: Ulf Hansson <ulf.hansson@linaro.org>,
Carlo Caione <carlo@caione.org>,
linux-mmc@vger.kernel.org, linux-amlogic@lists.infradead.org
Subject: Re: [PATCH v2 7/9] mmc: meson-gx: reduce bounce buffer size
Date: Fri, 03 Feb 2017 10:18:41 -0800 [thread overview]
Message-ID: <7hvasruohq.fsf@baylibre.com> (raw)
In-Reply-To: <90d34a64-bd3e-dcf2-4c36-5ef4e2ac8666@gmail.com> (Heiner Kallweit's message of "Wed, 1 Feb 2017 07:49:18 +0100")
Heiner Kallweit <hkallweit1@gmail.com> writes:
> A bounce buffer of 512K isn't needed as the max request size is
> 511 * 512 byte.
>
> Signed-off-by: Heiner Kallweit <hkallweit1@gmail.com>
Reviewed-by: Kevin Hilman <khilman@baylibre.com>
Tested-by: Kevin Hilman <khilman@baylibre.com>
> ---
> v2:
> - no changes
> ---
> drivers/mmc/host/meson-gx-mmc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
> index 883263c5..48ce4ba4 100644
> --- a/drivers/mmc/host/meson-gx-mmc.c
> +++ b/drivers/mmc/host/meson-gx-mmc.c
> @@ -785,7 +785,7 @@ static int meson_mmc_probe(struct platform_device *pdev)
> mmc->max_req_size = mmc->max_blk_count * mmc->max_blk_size;
>
> /* data bounce buffer */
> - host->bounce_buf_size = SZ_512K;
> + host->bounce_buf_size = mmc->max_req_size;
> host->bounce_buf =
> dma_alloc_coherent(host->dev, host->bounce_buf_size,
> &host->bounce_dma_addr, GFP_KERNEL);
next prev parent reply other threads:[~2017-02-03 18:18 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <584e5061-d359-1436-05ee-3767a5a4b10f@gmail.com>
2017-02-01 6:48 ` [PATCH v2 2/9] mmc: meson-gx: minor improvements in meson_mmc_set_ios Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-01 6:48 ` [PATCH v2 3/9] mmc: meson-gx: improve meson_mmc_clk_set Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-01 6:48 ` [PATCH v2 4/9] mmc: meson-gx: improve meson_mmc_irq_thread Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-03 18:03 ` Kevin Hilman
2017-02-03 18:03 ` Kevin Hilman
2017-02-01 6:48 ` [PATCH v2 5/9] mmc: meson-gx: improve interrupt handling Heiner Kallweit
2017-02-01 6:48 ` Heiner Kallweit
2017-02-03 18:10 ` Kevin Hilman
2017-02-03 18:10 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 6/9] mmc: meson-gx: set max block count and request size Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-01 6:49 ` [PATCH v2 7/9] mmc: meson-gx: reduce bounce buffer size Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-03 18:18 ` Kevin Hilman [this message]
2017-02-03 18:18 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 8/9] mmc: meson-gx: remove unneeded checks in remove Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
2017-02-03 18:20 ` Kevin Hilman
2017-02-03 18:20 ` Kevin Hilman
2017-02-01 6:49 ` [PATCH v2 9/9] mmc: meson-gx: add support for HS400 mode Heiner Kallweit
2017-02-01 6:49 ` Heiner Kallweit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7hvasruohq.fsf@baylibre.com \
--to=khilman@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.