From: Kevin Hilman <khilman@kernel.org>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
linux-pm@vger.kernel.org, Len Brown <len.brown@intel.com>,
Pavel Machek <pavel@ucw.cz>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Lina Iyer <lina.iyer@linaro.org>
Subject: Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor
Date: Thu, 03 Dec 2015 16:05:22 -0800 [thread overview]
Message-ID: <7htwnz13jx.fsf@deeprootsystems.com> (raw)
In-Reply-To: <1449061707-16030-1-git-send-email-ulf.hansson@linaro.org> (Ulf Hansson's message of "Wed, 2 Dec 2015 14:08:27 +0100")
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Recently genpd removed the requirement of a having a driver bound for its
> attached devices to allow genpd to power off. That change should also have
> removed a corresponding validation in the governor, let's correct that.
>
> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
> ---
> drivers/base/power/domain_governor.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
> index e60dd12..1e937ac 100644
> --- a/drivers/base/power/domain_governor.c
> +++ b/drivers/base/power/domain_governor.c
> @@ -160,9 +160,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd)
> struct gpd_timing_data *td;
> s64 constraint_ns;
>
> - if (!pdd->dev->driver)
> - continue;
> -
> /*
> * Check if the device is allowed to be off long enough for the
> * domain to turn off and on (that's how much time it will
next prev parent reply other threads:[~2015-12-04 0:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-02 13:08 [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor Ulf Hansson
2015-12-02 23:28 ` Rafael J. Wysocki
2015-12-04 0:05 ` Kevin Hilman [this message]
2015-12-04 0:28 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7htwnz13jx.fsf@deeprootsystems.com \
--to=khilman@kernel.org \
--cc=geert+renesas@glider.be \
--cc=len.brown@intel.com \
--cc=lina.iyer@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=rjw@rjwysocki.net \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.