[PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor

[PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor

[Ulf Hansson]

Recently genpd removed the requirement of a having a driver bound for its
attached devices to allow genpd to power off. That change should also have
removed a corresponding validation in the governor, let's correct that.

Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
 drivers/base/power/domain_governor.c | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
index e60dd12..1e937ac 100644
--- a/drivers/base/power/domain_governor.c
+++ b/drivers/base/power/domain_governor.c
@@ -160,9 +160,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd)
 		struct gpd_timing_data *td;
 		s64 constraint_ns;
 
-		if (!pdd->dev->driver)
-			continue;
-
 		/*
 		 * Check if the device is allowed to be off long enough for the
 		 * domain to turn off and on (that's how much time it will
-- 
1.9.1

Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor

[Rafael J. Wysocki]

On Wednesday, December 02, 2015 02:08:27 PM Ulf Hansson wrote:
> Recently genpd removed the requirement of a having a driver bound for its
> attached devices to allow genpd to power off. That change should also have
> removed a corresponding validation in the governor, let's correct that.
> 
> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Applied, thanks!

Rafael

Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor

[Kevin Hilman]

Ulf Hansson <ulf.hansson@linaro.org> writes:

> Recently genpd removed the requirement of a having a driver bound for its
> attached devices to allow genpd to power off. That change should also have
> removed a corresponding validation in the governor, let's correct that.
>
> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

Acked-by: Kevin Hilman <khilman@linaro.org>

> ---
>  drivers/base/power/domain_governor.c | 3 ---
>  1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
> index e60dd12..1e937ac 100644
> --- a/drivers/base/power/domain_governor.c
> +++ b/drivers/base/power/domain_governor.c
> @@ -160,9 +160,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd)
>  		struct gpd_timing_data *td;
>  		s64 constraint_ns;
>  
> -		if (!pdd->dev->driver)
> -			continue;
> -
>  		/*
>  		 * Check if the device is allowed to be off long enough for the
>  		 * domain to turn off and on (that's how much time it will

Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor

[Rafael J. Wysocki]

On Fri, Dec 4, 2015 at 1:05 AM, Kevin Hilman <khilman@kernel.org> wrote:
> Ulf Hansson <ulf.hansson@linaro.org> writes:
>
>> Recently genpd removed the requirement of a having a driver bound for its
>> attached devices to allow genpd to power off. That change should also have
>> removed a corresponding validation in the governor, let's correct that.
>>
>> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>

Applied with both ACKs and the Fixes: tag.

I've also tagged it for "stable".

Thanks,
Rafael