* [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor
@ 2015-12-02 13:08 Ulf Hansson
2015-12-02 23:28 ` Rafael J. Wysocki
2015-12-04 0:05 ` Kevin Hilman
0 siblings, 2 replies; 4+ messages in thread
From: Ulf Hansson @ 2015-12-02 13:08 UTC (permalink / raw)
To: Rafael J. Wysocki, Kevin Hilman, Ulf Hansson, linux-pm
Cc: Len Brown, Pavel Machek, Geert Uytterhoeven, Lina Iyer
Recently genpd removed the requirement of a having a driver bound for its
attached devices to allow genpd to power off. That change should also have
removed a corresponding validation in the governor, let's correct that.
Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
---
drivers/base/power/domain_governor.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
index e60dd12..1e937ac 100644
--- a/drivers/base/power/domain_governor.c
+++ b/drivers/base/power/domain_governor.c
@@ -160,9 +160,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd)
struct gpd_timing_data *td;
s64 constraint_ns;
- if (!pdd->dev->driver)
- continue;
-
/*
* Check if the device is allowed to be off long enough for the
* domain to turn off and on (that's how much time it will
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor
2015-12-02 13:08 [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor Ulf Hansson
@ 2015-12-02 23:28 ` Rafael J. Wysocki
2015-12-04 0:05 ` Kevin Hilman
1 sibling, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-12-02 23:28 UTC (permalink / raw)
To: Ulf Hansson
Cc: Kevin Hilman, linux-pm, Len Brown, Pavel Machek,
Geert Uytterhoeven, Lina Iyer
On Wednesday, December 02, 2015 02:08:27 PM Ulf Hansson wrote:
> Recently genpd removed the requirement of a having a driver bound for its
> attached devices to allow genpd to power off. That change should also have
> removed a corresponding validation in the governor, let's correct that.
>
> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Applied, thanks!
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor
2015-12-02 13:08 [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor Ulf Hansson
2015-12-02 23:28 ` Rafael J. Wysocki
@ 2015-12-04 0:05 ` Kevin Hilman
2015-12-04 0:28 ` Rafael J. Wysocki
1 sibling, 1 reply; 4+ messages in thread
From: Kevin Hilman @ 2015-12-04 0:05 UTC (permalink / raw)
To: Ulf Hansson
Cc: Rafael J. Wysocki, linux-pm, Len Brown, Pavel Machek,
Geert Uytterhoeven, Lina Iyer
Ulf Hansson <ulf.hansson@linaro.org> writes:
> Recently genpd removed the requirement of a having a driver bound for its
> attached devices to allow genpd to power off. That change should also have
> removed a corresponding validation in the governor, let's correct that.
>
> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
Acked-by: Kevin Hilman <khilman@linaro.org>
> ---
> drivers/base/power/domain_governor.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/base/power/domain_governor.c b/drivers/base/power/domain_governor.c
> index e60dd12..1e937ac 100644
> --- a/drivers/base/power/domain_governor.c
> +++ b/drivers/base/power/domain_governor.c
> @@ -160,9 +160,6 @@ static bool default_power_down_ok(struct dev_pm_domain *pd)
> struct gpd_timing_data *td;
> s64 constraint_ns;
>
> - if (!pdd->dev->driver)
> - continue;
> -
> /*
> * Check if the device is allowed to be off long enough for the
> * domain to turn off and on (that's how much time it will
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor
2015-12-04 0:05 ` Kevin Hilman
@ 2015-12-04 0:28 ` Rafael J. Wysocki
0 siblings, 0 replies; 4+ messages in thread
From: Rafael J. Wysocki @ 2015-12-04 0:28 UTC (permalink / raw)
To: Kevin Hilman
Cc: Ulf Hansson, Rafael J. Wysocki, linux-pm@vger.kernel.org,
Len Brown, Pavel Machek, Geert Uytterhoeven, Lina Iyer
On Fri, Dec 4, 2015 at 1:05 AM, Kevin Hilman <khilman@kernel.org> wrote:
> Ulf Hansson <ulf.hansson@linaro.org> writes:
>
>> Recently genpd removed the requirement of a having a driver bound for its
>> attached devices to allow genpd to power off. That change should also have
>> removed a corresponding validation in the governor, let's correct that.
>>
>> Fixes: 298cd0f08801 ("PM / Domains: Remove dev->driver check for runtime")
>> Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>
>
> Acked-by: Kevin Hilman <khilman@linaro.org>
Applied with both ACKs and the Fixes: tag.
I've also tagged it for "stable".
Thanks,
Rafael
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-12-04 0:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-12-02 13:08 [PATCH] PM / Domains: Validate cases of a non-bound driver in genpd governor Ulf Hansson
2015-12-02 23:28 ` Rafael J. Wysocki
2015-12-04 0:05 ` Kevin Hilman
2015-12-04 0:28 ` Rafael J. Wysocki
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.