All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sui Jingfeng <sui.jingfeng@linux.dev>
To: Icenowy Zheng <uwu@icenowy.me>, Xi Ruoyao <xry111@xry111.site>,
	WANG Xuerui <kernel@xen0n.name>,
	Huacai Chen <chenhuacai@kernel.org>
Cc: Andrew Morton <akpm@linux-foundation.org>,
	"Mike Rapoport (IBM)" <rppt@kernel.org>,
	Baoquan He <bhe@redhat.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>,
	David Hildenbrand <david@redhat.com>,
	Zhen Lei <thunder.leizhen@huawei.com>,
	Thomas Gleixner <tglx@linutronix.de>,
	Zhihong Dong <donmor3000@hotmail.com>,
	loongarch@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap_wc
Date: Thu, 19 Dec 2024 10:54:01 +0800	[thread overview]
Message-ID: <80e0813a-0651-41cf-a82d-776acbf1a5bc@linux.dev> (raw)
In-Reply-To: <932a9a93c00082645df465862231f6d8c91f3bf6.camel@icenowy.me>


On 2024/12/18 20:43, Icenowy Zheng wrote:
> For the fact of drm/ast's dramatical drop, it's because write to the
> framebuffer can no longer be reordered.


No, your understanding is wrong, very very wrong and a big wrong.

It's not because it can't reorder the write. Rather, it's because
that the CPU can't do write gathering and can't do burst write any
more.

So do you still think your patch is harmless?


-- 
Best regards,
Sui


  reply	other threads:[~2024-12-19  2:54 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-09  4:28 [PATCH v2] loongarch/mm: disable WUC for pgprot_writecombine as same as ioremap_wc Icenowy Zheng
2023-10-09 14:32 ` Sui Jingfeng
2023-10-10  0:15   ` WANG Xuerui
2023-10-10  3:02     ` Sui Jingfeng
2023-10-10 12:26       ` Xi Ruoyao
2023-10-13 11:12         ` Sui Jingfeng
2023-10-13 12:51         ` Sui Jingfeng
2023-10-13 13:15           ` Xi Ruoyao
2023-10-13 13:53             ` Xi Ruoyao
2025-01-21  9:19               ` Sui Jingfeng
2024-12-02 16:23         ` Sui Jingfeng
2024-12-17 18:18           ` Shuah
2024-12-18  3:24             ` Sui Jingfeng
2024-12-18  6:23               ` Icenowy Zheng
2024-12-18 10:05                 ` Sui Jingfeng
2024-12-18 12:37                   ` Icenowy Zheng
2024-12-19  3:17                     ` Sui Jingfeng
2024-12-19  4:54                       ` Icenowy Zheng
2024-12-20 16:43               ` Shuah
2024-12-17 23:44           ` Icenowy Zheng
2024-12-18  3:05             ` Sui Jingfeng
2024-12-18  5:47               ` Icenowy Zheng
2024-12-18 10:29                 ` Sui Jingfeng
2024-12-18 12:43                   ` Icenowy Zheng
2024-12-19  2:54                     ` Sui Jingfeng [this message]
2024-12-19  4:49                       ` Icenowy Zheng
2024-12-19  5:49                         ` Sui Jingfeng
2024-12-19  6:34                           ` Icenowy Zheng
2024-12-19  7:46                             ` Sui Jingfeng
2024-12-19  6:38                           ` Icenowy Zheng
2024-12-19 10:39                             ` Sui Jingfeng
2023-10-10  0:50   ` Icenowy Zheng

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=80e0813a-0651-41cf-a82d-776acbf1a5bc@linux.dev \
    --to=sui.jingfeng@linux.dev \
    --cc=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=chenhuacai@kernel.org \
    --cc=david@redhat.com \
    --cc=donmor3000@hotmail.com \
    --cc=kernel@xen0n.name \
    --cc=linux-kernel@vger.kernel.org \
    --cc=loongarch@lists.linux.dev \
    --cc=rppt@kernel.org \
    --cc=tglx@linutronix.de \
    --cc=thunder.leizhen@huawei.com \
    --cc=uwu@icenowy.me \
    --cc=willy@infradead.org \
    --cc=xry111@xry111.site \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.