* [patch] fix nsp32.c .text.exit error
@ 2003-03-27 22:14 Adrian Bunk
2003-03-28 0:18 ` GOTO Masanori
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2003-03-27 22:14 UTC (permalink / raw)
To: YOKOTA Hiroshi, GOTO Masanori, Marcelo Tosatti, Linus Torvalds
Cc: linux-kernel
In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the
pointer to it isn't __devexit_p resulting in a .text.exit compile error
if !CONFIG_HOTPLUG.
The following patch is needed:
--- linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c.old 2003-03-27 22:35:04.000000000 +0100
+++ linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c 2003-03-27 22:36:14.000000000 +0100
@@ -2125,7 +2125,7 @@
.name = "nsp32",
.id_table = nsp32_pci_table,
.probe = nsp32_probe,
- .remove = nsp32_remove,
+ .remove = __devexit_p(nsp32_remove),
#ifdef CONFIG_PM
/* .suspend = nsp32_suspend,*/
/* .resume = nsp32_resume,*/
This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
compilation with 2.4.21-pre6.
Please apply
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [patch] fix nsp32.c .text.exit error
2003-03-27 22:14 [patch] fix nsp32.c .text.exit error Adrian Bunk
@ 2003-03-28 0:18 ` GOTO Masanori
0 siblings, 0 replies; 2+ messages in thread
From: GOTO Masanori @ 2003-03-28 0:18 UTC (permalink / raw)
To: Adrian Bunk
Cc: YOKOTA Hiroshi, GOTO Masanori, Marcelo Tosatti, Linus Torvalds,
linux-kernel
At Thu, 27 Mar 2003 23:14:11 +0100,
Adrian Bunk wrote:
> In drivers/scsi/nsp32.c the function nsp32_remove is __devexit but the
> pointer to it isn't __devexit_p resulting in a .text.exit compile error
> if !CONFIG_HOTPLUG.
>
> The following patch is needed:
>
> --- linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c.old 2003-03-27 22:35:04.000000000 +0100
> +++ linux-2.4.21-pre6-full-nohotplug/drivers/scsi/nsp32.c 2003-03-27 22:36:14.000000000 +0100
> @@ -2125,7 +2125,7 @@
> .name = "nsp32",
> .id_table = nsp32_pci_table,
> .probe = nsp32_probe,
> - .remove = nsp32_remove,
> + .remove = __devexit_p(nsp32_remove),
> #ifdef CONFIG_PM
> /* .suspend = nsp32_suspend,*/
> /* .resume = nsp32_resume,*/
>
>
> This patch applies against 2.4.21-pre6 and 2.5.66. I've tested the
> compilation with 2.4.21-pre6.
Looks fine. Thanks!
Regards,
-- gotom
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2003-03-28 0:07 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2003-03-27 22:14 [patch] fix nsp32.c .text.exit error Adrian Bunk
2003-03-28 0:18 ` GOTO Masanori
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.