Re: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220

Re: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220

[Takashi Iwai]

On Mon, 18 May 2020 11:13:48 +0200,
Pshou wrote:
> 
> Hi Takash:
> 
> I have added the "Signed-off-by" line.
> Can you see if you can?
> 
> Signed-off-by: Pshou <pshou@realtek.com>

We need a real full name here to Signed-off-by line.  It's a legal
requirement.  Could you fill it and resend?


thanks,

Takashi

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> 
> Best regards
> Pshou
> 
> -----原始郵件-----
> 寄件者: Takashi Iwai <tiwai@suse.de> 
> 寄件日期: 2020年5月15日 17:45
> 收件者: Pshou <pshou@realtek.com>
> 副本: tiwai@suse.com; Kailang <kailang@realtek.com>
> 主旨: Re: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220
> 
> On Fri, 15 May 2020 11:24:45 +0200,
> Pshou wrote:
> > 
> > Hi Takashi:
> > 
> > Can you help me add some source code to patch_realtek.c?
> > 
> > Add some CLEVO SSID in the alc1220.
> > 
> >         SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", 
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> >       SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
> 
> Sure, could you give your Signed-off-by line, so that I can rearrange, submit to alsa-devel and merge to upstream?
> 
> 
> thanks,
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> [2 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch <application/octet-stream (base64)>]
> 

回覆: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220

[Pshou]

[-- Attachment #1: Type: text/plain, Size: 2290 bytes --]

Hi Takash:

Is it okay to change this way?

PeiSen Hou <pshou@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c

Best regards
pshou

-----原始郵件-----
寄件者: Takashi Iwai <tiwai@suse.de> 
寄件日期: 2020年5月18日 22:15
收件者: Pshou <pshou@realtek.com>
副本: alsa-devel@alsa-project.org; tiwai@suse.com; Kailang <kailang@realtek.com>
主旨: Re: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220

On Mon, 18 May 2020 11:13:48 +0200,
Pshou wrote:
> 
> Hi Takash:
> 
> I have added the "Signed-off-by" line.
> Can you see if you can?
> 
> Signed-off-by: Pshou <pshou@realtek.com>

We need a real full name here to Signed-off-by line.  It's a legal requirement.  Could you fill it and resend?


thanks,

Takashi

> diff --git a/sound/pci/hda/patch_realtek.c 
> b/sound/pci/hda/patch_realtek.c
> 
> Best regards
> Pshou
> 
> -----原始郵件-----
> 寄件者: Takashi Iwai <tiwai@suse.de>
> 寄件日期: 2020年5月15日 17:45
> 收件者: Pshou <pshou@realtek.com>
> 副本: tiwai@suse.com; Kailang <kailang@realtek.com>
> 主旨: Re: CLEVO uses the model name and SSID list of Realtek audio CODEC 
> ALC1220
> 
> On Fri, 15 May 2020 11:24:45 +0200,
> Pshou wrote:
> > 
> > Hi Takashi:
> > 
> > Can you help me add some source code to patch_realtek.c?
> > 
> > Add some CLEVO SSID in the alc1220.
> > 
> >         SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", 
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> > +      SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170",
> > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > 
> >       SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", 
> > ALC882_FIXUP_EAPD),
> 
> Sure, could you give your Signed-off-by line, so that I can rearrange, submit to alsa-devel and merge to upstream?
> 
> 
> thanks,
> 
> Takashi
> 
> ------Please consider the environment before printing this e-mail.
> [2 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch 
> <application/octet-stream (base64)>]
> 

[-- Attachment #2: 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch --]
[-- Type: application/octet-stream, Size: 1016 bytes --]

PeiSen Hou <pshou@realtek.com>
diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
index 2f988f8..c37e4fc 100644
--- a/sound/pci/hda/patch_realtek.c
+++ b/sound/pci/hda/patch_realtek.c
@@ -2474,6 +2474,9 @@ static const struct snd_pci_quirk alc882_fixup_tbl[] = {
 	SND_PCI_QUIRK(0x1558, 0x97e1, "Clevo P970[ER][CDFN]", ALC1220_FIXUP_CLEVO_P950),
 	SND_PCI_QUIRK(0x1558, 0x65d1, "Clevo PB51[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
 	SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
+	SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
+	SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
+	SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170", ALC1220_FIXUP_CLEVO_PB51ED_PINS),
 	SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", ALC882_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x161f, 0x2054, "Medion laptop", ALC883_FIXUP_EAPD),
 	SND_PCI_QUIRK(0x17aa, 0x3a0d, "Lenovo Y530", ALC882_FIXUP_LENOVO_Y530),

Re: 回覆: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220

[Takashi Iwai]

On Tue, 19 May 2020 08:39:45 +0200,
Pshou wrote:
> 
> Hi Takash:
> 
> Is it okay to change this way?
> 
> PeiSen Hou <pshou@realtek.com>

OK, I created a proper patch and submitted now.


Takashi

> diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c
> 
> Best regards
> pshou
> 
> -----原始郵件-----
> 寄件者: Takashi Iwai <tiwai@suse.de> 
> 寄件日期: 2020年5月18日 22:15
> 收件者: Pshou <pshou@realtek.com>
> 副本: alsa-devel@alsa-project.org; tiwai@suse.com; Kailang <kailang@realtek.com>
> 主旨: Re: 回覆: CLEVO uses the model name and SSID list of Realtek audio CODEC ALC1220
> 
> On Mon, 18 May 2020 11:13:48 +0200,
> Pshou wrote:
> > 
> > Hi Takash:
> > 
> > I have added the "Signed-off-by" line.
> > Can you see if you can?
> > 
> > Signed-off-by: Pshou <pshou@realtek.com>
> 
> We need a real full name here to Signed-off-by line.  It's a legal requirement.  Could you fill it and resend?
> 
> 
> thanks,
> 
> Takashi
> 
> > diff --git a/sound/pci/hda/patch_realtek.c 
> > b/sound/pci/hda/patch_realtek.c
> > 
> > Best regards
> > Pshou
> > 
> > -----原始郵件-----
> > 寄件者: Takashi Iwai <tiwai@suse.de>
> > 寄件日期: 2020年5月15日 17:45
> > 收件者: Pshou <pshou@realtek.com>
> > 副本: tiwai@suse.com; Kailang <kailang@realtek.com>
> > 主旨: Re: CLEVO uses the model name and SSID list of Realtek audio CODEC 
> > ALC1220
> > 
> > On Fri, 15 May 2020 11:24:45 +0200,
> > Pshou wrote:
> > > 
> > > Hi Takashi:
> > > 
> > > Can you help me add some source code to patch_realtek.c?
> > > 
> > > Add some CLEVO SSID in the alc1220.
> > > 
> > >         SND_PCI_QUIRK(0x1558, 0x67d1, "Clevo PB71[ER][CDF]", 
> > > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > > 
> > > +      SND_PCI_QUIRK(0x1558, 0x50d3, "Clevo PC50[ER][CDF]",
> > > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > > 
> > > +      SND_PCI_QUIRK(0x1558, 0x70d1, "Clevo PC70[ER][CDF]",
> > > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > > 
> > > +      SND_PCI_QUIRK(0x1558, 0x7714, "Clevo X170",
> > > ALC1220_FIXUP_CLEVO_PB51ED_PINS),
> > > 
> > >       SND_PCI_QUIRK_VENDOR(0x1558, "Clevo laptop", 
> > > ALC882_FIXUP_EAPD),
> > 
> > Sure, could you give your Signed-off-by line, so that I can rearrange, submit to alsa-devel and merge to upstream?
> > 
> > 
> > thanks,
> > 
> > Takashi
> > 
> > ------Please consider the environment before printing this e-mail.
> > [2 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch 
> > <application/octet-stream (base64)>]
> > 
> [2 0001-Add-several-Clevo-SSID-in-the-ALC1220.patch <application/octet-stream (base64)>]
>