From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org,
Daniel Baluta <daniel.baluta@nxp.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Keyon Jie <yang.jie@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Takashi Iwai <tiwai@suse.com>, Mark Brown <broonie@kernel.org>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
Brent Lu <brent.lu@intel.com>,
sound-open-firmware@alsa-project.org
Subject: Re: [Sound-open-firmware] [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP
Date: Fri, 12 Jun 2020 09:45:38 -0500 [thread overview]
Message-ID: <8530e0d0-de78-3f60-a849-99ef4f577ae0@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006121522440.3186@eliteleevi.tm.intel.com>
On 6/12/20 7:24 AM, Kai Vehmanen wrote:
> Hey Brent,
>
> On Fri, 12 Jun 2020, Takashi Iwai wrote:
>
>> On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote:
>>>
>>> Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
>>> WP") from legacy HDA driver to fix the get response timeout issue.
>>> Current SOF driver does not suffer from this issue because sync write
>>> is enabled in hda_init. The issue will come back if the sync write is
>>> disabled for some reason.
>>>
>>> Signed-off-by: Brent Lu <brent.lu@intel.com>
>>
>> Reviewed-by: Takashi Iwai <tiwai@suse.de>
>
> thanks, looks good now:
>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
CI results initiated by Kai don't show any regression and change looks
good so:
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Brent!
WARNING: multiple messages have this Message-ID (diff)
From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: Kai Vehmanen <kai.vehmanen@linux.intel.com>,
Takashi Iwai <tiwai@suse.de>
Cc: alsa-devel@alsa-project.org,
Bard Liao <yung-chuan.liao@linux.intel.com>,
Cezary Rojewski <cezary.rojewski@intel.com>,
Takashi Iwai <tiwai@suse.com>,
Keyon Jie <yang.jie@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
Mark Brown <broonie@kernel.org>,
Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
Jaroslav Kysela <perex@perex.cz>,
Daniel Baluta <daniel.baluta@nxp.com>,
Brent Lu <brent.lu@intel.com>,
linux-kernel@vger.kernel.org,
sound-open-firmware@alsa-project.org
Subject: Re: [Sound-open-firmware] [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP
Date: Fri, 12 Jun 2020 09:45:38 -0500 [thread overview]
Message-ID: <8530e0d0-de78-3f60-a849-99ef4f577ae0@linux.intel.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2006121522440.3186@eliteleevi.tm.intel.com>
On 6/12/20 7:24 AM, Kai Vehmanen wrote:
> Hey Brent,
>
> On Fri, 12 Jun 2020, Takashi Iwai wrote:
>
>> On Fri, 12 Jun 2020 12:50:48 +0200, Brent Lu wrote:
>>>
>>> Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
>>> WP") from legacy HDA driver to fix the get response timeout issue.
>>> Current SOF driver does not suffer from this issue because sync write
>>> is enabled in hda_init. The issue will come back if the sync write is
>>> disabled for some reason.
>>>
>>> Signed-off-by: Brent Lu <brent.lu@intel.com>
>>
>> Reviewed-by: Takashi Iwai <tiwai@suse.de>
>
> thanks, looks good now:
>
> Reviewed-by: Kai Vehmanen <kai.vehmanen@linux.intel.com>
CI results initiated by Kai don't show any regression and change looks
good so:
Reviewed-by: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Thanks Brent!
next prev parent reply other threads:[~2020-06-12 15:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-12 10:50 [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP Brent Lu
2020-06-12 10:50 ` Brent Lu
2020-06-12 11:01 ` Takashi Iwai
2020-06-12 11:01 ` Takashi Iwai
2020-06-12 12:24 ` Kai Vehmanen
2020-06-12 12:24 ` Kai Vehmanen
2020-06-12 14:45 ` Pierre-Louis Bossart [this message]
2020-06-12 14:45 ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-06-15 15:05 ` Mark Brown
2020-06-15 15:05 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8530e0d0-de78-3f60-a849-99ef4f577ae0@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=brent.lu@intel.com \
--cc=broonie@kernel.org \
--cc=cezary.rojewski@intel.com \
--cc=daniel.baluta@nxp.com \
--cc=kai.vehmanen@linux.intel.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=ranjani.sridharan@linux.intel.com \
--cc=sound-open-firmware@alsa-project.org \
--cc=tiwai@suse.com \
--cc=tiwai@suse.de \
--cc=yang.jie@linux.intel.com \
--cc=yingjiang.zhu@linux.intel.com \
--cc=yung-chuan.liao@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.