All of lore.kernel.org
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Brent Lu <brent.lu@intel.com>
Cc: alsa-devel@alsa-project.org,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Takashi Iwai <tiwai@suse.com>,
	Keyon Jie <yang.jie@linux.intel.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Mark Brown <broonie@kernel.org>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
	linux-kernel@vger.kernel.org,
	sound-open-firmware@alsa-project.org
Subject: Re: [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP
Date: Fri, 12 Jun 2020 13:01:23 +0200	[thread overview]
Message-ID: <s5h5zbwczuk.wl-tiwai@suse.de> (raw)
In-Reply-To: <1591959048-15813-1-git-send-email-brent.lu@intel.com>

On Fri, 12 Jun 2020 12:50:48 +0200,
Brent Lu wrote:
> 
> Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
> WP") from legacy HDA driver to fix the get response timeout issue.
> Current SOF driver does not suffer from this issue because sync write
> is enabled in hda_init. The issue will come back if the sync write is
> disabled for some reason.
> 
> Signed-off-by: Brent Lu <brent.lu@intel.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


Thanks!

Takashi

WARNING: multiple messages have this Message-ID (diff)
From: Takashi Iwai <tiwai@suse.de>
To: Brent Lu <brent.lu@intel.com>
Cc: <alsa-devel@alsa-project.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>,
	Liam Girdwood <lgirdwood@gmail.com>,
	Ranjani Sridharan <ranjani.sridharan@linux.intel.com>,
	Kai Vehmanen <kai.vehmanen@linux.intel.com>,
	Daniel Baluta <daniel.baluta@nxp.com>,
	Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
	Takashi Iwai <tiwai@suse.com>,
	Cezary Rojewski <cezary.rojewski@intel.com>,
	Zhu Yingjiang <yingjiang.zhu@linux.intel.com>,
	Keyon Jie <yang.jie@linux.intel.com>,
	Bard Liao <yung-chuan.liao@linux.intel.com>,
	<sound-open-firmware@alsa-project.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP
Date: Fri, 12 Jun 2020 13:01:23 +0200	[thread overview]
Message-ID: <s5h5zbwczuk.wl-tiwai@suse.de> (raw)
In-Reply-To: <1591959048-15813-1-git-send-email-brent.lu@intel.com>

On Fri, 12 Jun 2020 12:50:48 +0200,
Brent Lu wrote:
> 
> Port commit 6d011d5057ff ("ALSA: hda: Clear RIRB status before reading
> WP") from legacy HDA driver to fix the get response timeout issue.
> Current SOF driver does not suffer from this issue because sync write
> is enabled in hda_init. The issue will come back if the sync write is
> disabled for some reason.
> 
> Signed-off-by: Brent Lu <brent.lu@intel.com>

Reviewed-by: Takashi Iwai <tiwai@suse.de>


Thanks!

Takashi

  reply	other threads:[~2020-06-12 11:02 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-06-12 10:50 [PATCH v3] ASoC: SOF: Intel: hda: Clear RIRB status before reading WP Brent Lu
2020-06-12 10:50 ` Brent Lu
2020-06-12 11:01 ` Takashi Iwai [this message]
2020-06-12 11:01   ` Takashi Iwai
2020-06-12 12:24   ` Kai Vehmanen
2020-06-12 12:24     ` Kai Vehmanen
2020-06-12 14:45     ` [Sound-open-firmware] " Pierre-Louis Bossart
2020-06-12 14:45       ` Pierre-Louis Bossart
2020-06-15 15:05 ` Mark Brown
2020-06-15 15:05   ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=s5h5zbwczuk.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=alsa-devel@alsa-project.org \
    --cc=brent.lu@intel.com \
    --cc=broonie@kernel.org \
    --cc=cezary.rojewski@intel.com \
    --cc=daniel.baluta@nxp.com \
    --cc=kai.vehmanen@linux.intel.com \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pierre-louis.bossart@linux.intel.com \
    --cc=ranjani.sridharan@linux.intel.com \
    --cc=sound-open-firmware@alsa-project.org \
    --cc=tiwai@suse.com \
    --cc=yang.jie@linux.intel.com \
    --cc=yingjiang.zhu@linux.intel.com \
    --cc=yung-chuan.liao@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.