Re: [Buildroot] [PATCH 1/1] package/containerd: fix build with toolchain without Gold linker

From: Fiona Klute via buildroot <buildroot@buildroot.org>
To: Arnout Vandecappelle <arnout@mind.be>, buildroot@buildroot.org
Cc: Christian Stewart <christian@aperture.us>,
	yann.morin@orange.com, Thomas Perale <thomas.perale@mind.be>
Subject: Re: [Buildroot] [PATCH 1/1] package/containerd: fix build with toolchain without Gold linker
Date: Wed, 5 Feb 2025 12:40:22 +0100	[thread overview]
Message-ID: <8572588d-6e13-4ebe-a1eb-45cc63f07468@gmx.de> (raw)
In-Reply-To: <f2073884-da55-4f02-8bb4-a39702bc4794@mind.be>

Hi Arnout!

Am 05.02.25 um 11:33 schrieb Arnout Vandecappelle:
>   Hi Fiona,
>
> On 04/02/2025 15:32, Fiona Klute wrote:
>> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
>>
>> Go forces use of the Gold linker on aarch64 due to a bug in BFD (the
>> default GNU linker) that is fixed in Binutils >= 2.41 [1]. All
>> toolchains provided by Buildroot have the fix, and none of them
>> provide Gold, so the forced setting breaks dynamic linking in
>> Buildroot. Set EXTLDFLAGS to use BFD instead.
>>
>> Additionally disable PIE on musl to fix "read-only segment has dynamic
>> relocations" errors during linking [2].
>>
>> [1] https://github.com/golang/go/issues/22040
>> [2] https://github.com/golang/go/issues/17847
>>
>> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
>> ---
>> This patch requires Yann E. Morin's patch that introduces
>> PACKAGE_EXTLDFLAGS:
>> https://patchwork.ozlabs.org/project/buildroot/
>> patch/876f3a7bb6a2375193fc8f06ab856d2449f83727.1699547993.git.yann.morin@orange.com/
>
>   After all this discussion, could you respin this as:
>
> - a series where Yann's patch is 1/2. It's quite confusing for us
> maintainers to have a patch that depends on another patch, unless when
> it's part of a series. You can just apply that patch on your branch, add
> your own signed-off-by, and include it in your own series;
> - add the use-ld=bfd as part of the golang infrastructure;
> - I'm not sure about the PIE part yet, but you can try building any
> other CGO package with a musl toolchain and if it fails as well it needs
> to be in the infra.

Thanks, I've just sent the updated series:
https://patchwork.ozlabs.org/project/buildroot/list/?series=442939

I've tested building docker-engine, docker-cli, and runc, and they build
fine without the --no-pie override, so I've kept that to containerd only.

Best regards,
Fiona

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot