Re: [Buildroot] [PATCH 1/1] package/containerd: fix build with toolchain without Gold linker

[Arnout Vandecappelle via buildroot <buildroot@buildroot.org>]

  Hi Fiona,

On 04/02/2025 15:32, Fiona Klute wrote:
> From: "Fiona Klute (WIWA)" <fiona.klute@gmx.de>
> 
> Go forces use of the Gold linker on aarch64 due to a bug in BFD (the
> default GNU linker) that is fixed in Binutils >= 2.41 [1]. All
> toolchains provided by Buildroot have the fix, and none of them
> provide Gold, so the forced setting breaks dynamic linking in
> Buildroot. Set EXTLDFLAGS to use BFD instead.
> 
> Additionally disable PIE on musl to fix "read-only segment has dynamic
> relocations" errors during linking [2].
> 
> [1] https://github.com/golang/go/issues/22040
> [2] https://github.com/golang/go/issues/17847
> 
> Signed-off-by: Fiona Klute (WIWA) <fiona.klute@gmx.de>
> ---
> This patch requires Yann E. Morin's patch that introduces
> PACKAGE_EXTLDFLAGS:
> https://patchwork.ozlabs.org/project/buildroot/patch/876f3a7bb6a2375193fc8f06ab856d2449f83727.1699547993.git.yann.morin@orange.com/

  After all this discussion, could you respin this as:

- a series where Yann's patch is 1/2. It's quite confusing for us maintainers to 
have a patch that depends on another patch, unless when it's part of a series. 
You can just apply that patch on your branch, add your own signed-off-by, and 
include it in your own series;
- add the use-ld=bfd as part of the golang infrastructure;
- I'm not sure about the PIE part yet, but you can try building any other CGO 
package with a musl toolchain and if it fails as well it needs to be in the infra.


  Regards,
  Arnout


> Based on the linked issue the --no-pie linker flag should be needed
> only for musl, but I'd be grateful if anyone could test with glibc.
> 
>   package/containerd/containerd.mk | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/package/containerd/containerd.mk b/package/containerd/containerd.mk
> index ee07c22495..cb648f87a9 100644
> --- a/package/containerd/containerd.mk
> +++ b/package/containerd/containerd.mk
> @@ -49,6 +49,20 @@ ifneq ($(BR2_PACKAGE_CONTAINERD_CRI),y)
>   CONTAINERD_TAGS += no_cri
>   endif
>   
> +ifeq ($(BR2_aarch64),y)
> +# Go forces use of the Gold linker on aarch64 due to a bug in BFD that
> +# is fixed in Binutils >= 2.41 (so all versions provided by
> +# Buildroot). Forcing Gold will break with toolchains that don't
> +# provide it, so override the flag and use BFD.
> +# See: https://github.com/golang/go/issues/22040
> +CONTAINERD_EXTLDFLAGS += -fuse-ld=bfd
> +ifeq ($(BR2_TOOLCHAIN_USES_MUSL),y)
> +# Go exe build with PIE doesn't work with musl.
> +# See: https://github.com/golang/go/issues/17847
> +CONTAINERD_EXTLDFLAGS += -Wl,--no-pie
> +endif
> +endif
> +
>   define CONTAINERD_INSTALL_INIT_SYSTEMD
>   	$(INSTALL) -D -m 0644 $(@D)/containerd.service \
>   		$(TARGET_DIR)/usr/lib/systemd/system/containerd.service

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot