Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes

From: Krzysztof Kozlowski <krzk@kernel.org>
To: Varadarajan Narayanan <quic_varada@quicinc.com>
Cc: bhelgaas@google.com, lpieralisi@kernel.org, kw@linux.com,
	manivannan.sadhasivam@linaro.org, robh@kernel.org,
	krzk+dt@kernel.org, conor+dt@kernel.org, vkoul@kernel.org,
	kishon@kernel.org, andersson@kernel.org, konradybcio@kernel.org,
	p.zabel@pengutronix.de, dmitry.baryshkov@linaro.org,
	quic_nsekar@quicinc.com, linux-arm-msm@vger.kernel.org,
	linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, linux-phy@lists.infradead.org,
	Praveenkumar I <quic_ipkumar@quicinc.com>,
	Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
Subject: Re: [PATCH v9 6/7] arm64: dts: qcom: ipq5332: Add PCIe related nodes
Date: Wed, 5 Feb 2025 14:47:13 +0100	[thread overview]
Message-ID: <85f54baa-7d3d-43c3-9944-8f5f3c3006da@kernel.org> (raw)
In-Reply-To: <Z6NCSo98YRgG666Q@hu-varada-blr.qualcomm.com>

On 05/02/2025 11:49, Varadarajan Narayanan wrote:
> On Mon, Feb 03, 2025 at 05:30:32PM +0100, Krzysztof Kozlowski wrote:
>> On 28/01/2025 07:27, Varadarajan Narayanan wrote:
>>>
>>> @@ -479,6 +519,230 @@ frame@b128000 {
>>>  				status = "disabled";
>>>  			};
>>>  		};
>>> +
>>> +		pcie1: pcie@18000000 {
>>> +			compatible = "qcom,pcie-ipq5332", "qcom,pcie-ipq9574";
>>> +			reg = <0x00088000 0x3000>,
>>
>> So as Konrad pointed out now, this was never tested. It's not we who
>> should run tests for you. It's you.
> 
> This was tested and it did not flag an error since it is having the order
> specified in the bindings. qcom,pcie.yaml has 4 reg specifications. Two of

Hm, then please paste results of dtbs_check W=1 testing. Here.

I am 100% sure you have there warning and I don't understand your
reluctance to run the tests even after pointing it out by two people.

Best regards,
Krzysztof