All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Fuad Tabba <fuad.tabba@linux.dev>
Cc: sashiko-reviews@lists.linux.dev, Oliver Upton <oupton@kernel.org>,
	kvmarm@lists.linux.dev
Subject: Re: [PATCH] KVM: arm64: Reject the stage-2 MMU pointer hypercalls under pKVM
Date: Tue, 15 Sep 2026 10:20:22 +0100	[thread overview]
Message-ID: <861pau7twp.wl-maz@kernel.org> (raw)
In-Reply-To: <CA+EHjTwfY++rZNMmWvAAzHMLbGGy9NpBjAPaMLD_n02Vabx63w@mail.gmail.com>

On Mon, 14 Sep 2026 19:11:59 +0100,
Fuad Tabba <fuad.tabba@linux.dev> wrote:
> 
> On Mon, 14 Sept 2026 at 18:58, <sashiko-bot@kernel.org> wrote:
> >
> > Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
> >
> > Pre-existing issues:
> > - [Critical] Hypercall handlers `handle___kvm_adjust_pc`, `handle___vgic_v5_save_apr`, and `handle___vgic_v5_restore_vmcr_apr` dereference host-provided pointers via `kern_hyp_va()` without validation, allowing a malicious host to corrupt EL2-private memory under pKVM.
> 
> All three are correct, and all three are already being fixed.
> handle___kvm_adjust_pc in [1], the GICv5 handlers in [2], and the rest
> in this patch.

But that's part of the problem. I see a bunch of random patches
addressing similar problems, sent without any logic.

You really need to group related patches together, because the only
possible outcome of your current way of posting things is that I'll
drop something on the floor.

	M.

-- 
Without deviation from the norm, progress is not possible.

  reply	other threads:[~2026-09-15  9:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 17:45 [PATCH] KVM: arm64: Reject the stage-2 MMU pointer hypercalls under pKVM Fuad Tabba
2026-09-14 17:58 ` sashiko-bot
2026-09-14 18:11   ` Fuad Tabba
2026-09-15  9:20     ` Marc Zyngier [this message]
2026-09-15  9:24 ` Marc Zyngier
2026-09-15  9:30   ` Fuad Tabba

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=861pau7twp.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=fuad.tabba@linux.dev \
    --cc=kvmarm@lists.linux.dev \
    --cc=oupton@kernel.org \
    --cc=sashiko-reviews@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.