From: Marc Zyngier <marc.zyngier@arm.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: christoffer.dall@linaro.org, linux@armlinux.org.uk,
catalin.marinas@arm.com, will.deacon@arm.com,
linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
huangshaoyu@huawei.com, wuquanming@huawei.com
Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort
Date: Sun, 29 Oct 2017 01:12:32 +0000 [thread overview]
Message-ID: <861slmaha7.fsf@arm.com> (raw)
In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800")
On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
> For this matching, switch expression uses fault type which is
> not {I,D}FSC value, but the case expression uses {I,D}FSC,
> they are incompatible. So change the switch expression to
> use {I,D}FSC.
I'm sorry, but I can't manage to parse this commit message. How about
something like this?
"kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
thus reducing the scope of the check. This doesn't cause any observable
bug yet as we end-up matching a closely related syndrome for which we
return the same value.
Using kvm_vcpu_trap_get_fault() instead fixes it for good"
Otherwise:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
WARNING: multiple messages have this Message-ID (diff)
From: marc.zyngier@arm.com (Marc Zyngier)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort
Date: Sun, 29 Oct 2017 01:12:32 +0000 [thread overview]
Message-ID: <861slmaha7.fsf@arm.com> (raw)
In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800")
On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
> For this matching, switch expression uses fault type which is
> not {I,D}FSC value, but the case expression uses {I,D}FSC,
> they are incompatible. So change the switch expression to
> use {I,D}FSC.
I'm sorry, but I can't manage to parse this commit message. How about
something like this?
"kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
thus reducing the scope of the check. This doesn't cause any observable
bug yet as we end-up matching a closely related syndrome for which we
return the same value.
Using kvm_vcpu_trap_get_fault() instead fixes it for good"
Otherwise:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <marc.zyngier@arm.com>
To: Dongjiu Geng <gengdongjiu@huawei.com>
Cc: <christoffer.dall@linaro.org>, <linux@armlinux.org.uk>,
<catalin.marinas@arm.com>, <will.deacon@arm.com>,
<linux-arm-kernel@lists.infradead.org>,
<kvmarm@lists.cs.columbia.edu>, <linux-kernel@vger.kernel.org>,
<huangshaoyu@huawei.com>, <wuquanming@huawei.com>
Subject: Re: [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort
Date: Sun, 29 Oct 2017 01:12:32 +0000 [thread overview]
Message-ID: <861slmaha7.fsf@arm.com> (raw)
In-Reply-To: <1509173159-30579-1-git-send-email-gengdongjiu@huawei.com> (Dongjiu Geng's message of "Sat, 28 Oct 2017 14:45:59 +0800")
On Sat, Oct 28 2017 at 2:45:59 pm BST, Dongjiu Geng <gengdongjiu@huawei.com> wrote:
> For this matching, switch expression uses fault type which is
> not {I,D}FSC value, but the case expression uses {I,D}FSC,
> they are incompatible. So change the switch expression to
> use {I,D}FSC.
I'm sorry, but I can't manage to parse this commit message. How about
something like this?
"kvm_vcpu_dabt_isextabt() tries to match a full fault syndrome, but
calls kvm_vcpu_trap_get_fault_type() that only returns the fault class,
thus reducing the scope of the check. This doesn't cause any observable
bug yet as we end-up matching a closely related syndrome for which we
return the same value.
Using kvm_vcpu_trap_get_fault() instead fixes it for good"
Otherwise:
Acked-by: Marc Zyngier <marc.zyngier@arm.com>
M.
--
Jazz is not dead. It just smells funny.
next prev parent reply other threads:[~2017-10-29 1:12 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-28 6:45 [PATCH v3] KVM: arm/arm64: fix the incompatible matching for external abort Dongjiu Geng
2017-10-28 6:45 ` Dongjiu Geng
2017-10-28 6:45 ` Dongjiu Geng
2017-10-29 1:12 ` Marc Zyngier [this message]
2017-10-29 1:12 ` Marc Zyngier
2017-10-29 1:12 ` Marc Zyngier
2017-10-30 1:13 ` gengdongjiu
2017-10-30 1:13 ` gengdongjiu
2017-10-30 1:13 ` gengdongjiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=861slmaha7.fsf@arm.com \
--to=marc.zyngier@arm.com \
--cc=catalin.marinas@arm.com \
--cc=christoffer.dall@linaro.org \
--cc=gengdongjiu@huawei.com \
--cc=huangshaoyu@huawei.com \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=will.deacon@arm.com \
--cc=wuquanming@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.