Re: [PATCH v2 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties

From: "Patil, Shubham Sanjay" <shubpati@amd.com>
To: Frank Li <Frank.li@oss.nxp.com>,
	Shubham Patil <shubhamsanjay.patil@amd.com>
Cc: alexandre.belloni@bootlin.com, Frank.Li@kernel.org,
	robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org,
	linux-i3c@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org, git@amd.com
Subject: Re: [PATCH v2 1/3] dt-bindings: i3c: xlnx: Add IBI and hot-join capability properties
Date: Wed, 2 Sep 2026 15:40:39 +0530	[thread overview]
Message-ID: <86433bb2-59f0-4591-b249-c2cc6c7171d5@amd.com> (raw)
In-Reply-To: <aoxd2Rq3qIoNIosY@SMW015318>

Hi Frank,

On 8/24/2026 8:36 PM, Frank Li wrote:
> Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding.
> 
> 
> On Mon, Aug 24, 2026 at 10:18:33AM +0530, Shubham Patil wrote:
>> In-Band Interrupt and Hot-Join are synthesis-time options of the AXI I3C
>> IP. Describe them with two boolean properties.
>>
>> A Hot-Join request is acknowledged by the IBI machinery, so a hot-join
>> capable design is always IBI capable as well. Both events are reported
>> through the controller interrupt, which is therefore required whenever
>> the capability is present.
>>
>> Signed-off-by: Shubham Patil <shubhamsanjay.patil@amd.com>
>> ---
>> Changes in V2:
>> - Rename the properties to "xlnx,in-band-interrupt-capable" and
>>    "xlnx,hot-join-capable", and expand their descriptions.
>> - Express the interrupt requirement with dependencies: instead of an
>>    allOf/if-then clause.
>> ---
>>   .../bindings/i3c/xlnx,axi-i3c-1.0.yaml        | 24 +++++++++++++++++++
>>   1 file changed, 24 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
>> index 2caa245a8656..a04becc07374 100644
>> --- a/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
>> +++ b/Documentation/devicetree/bindings/i3c/xlnx,axi-i3c-1.0.yaml
>> @@ -32,11 +32,33 @@ properties:
>>     interrupts:
>>       maxItems: 1
>>
>> +  xlnx,in-band-interrupt-capable:
>> +    type: boolean
>> +    description:
>> +      The IP is synthesized with In-Band Interrupt support. An In-Band
>> +      Interrupt lets a target signal the controller over the SDA and SCL
>> +      pair instead of a dedicated side-band interrupt line, by driving its
>> +      own dynamic address during bus arbitration. Such requests are
>> +      reported through the controller interrupt.
>> +
>> +  xlnx,hot-join-capable:
>> +    type: boolean
>> +    description:
>> +      The IP is synthesized with Hot-Join support. Hot-Join lets a target
>> +      attached or powered up after the bus is already running announce
>> +      itself using the reserved Hot-Join address, so that the controller
>> +      can assign it a dynamic address. The request is acknowledged by the
>> +      same machinery as an In-Band Interrupt.
>> +
> 
> I perfer put both to i3c.yaml

Thanks. I'll move both into i3c.yaml as generic booleans 
in-band-interrupt-capable and hot-join-capable, drop the xlnx, prefix, 
and keep the interrupt/HJ-vs-IBI dependencies in the AMD binding because 
those are specific to this IP.

Thanks,
Shubham

> 
> Frank
> 
>>   required:
>>     - compatible
>>     - reg
>>     - clocks
>>
>> +dependencies:
>> +  xlnx,hot-join-capable: ["xlnx,in-band-interrupt-capable"]
>> +  xlnx,in-band-interrupt-capable: [interrupts]
>> +
>>   allOf:
>>     - $ref: i3c.yaml#
>>
>> @@ -54,5 +76,7 @@ examples:
>>           interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
>>           #address-cells = <3>;
>>           #size-cells = <0>;
>> +        xlnx,in-band-interrupt-capable;
>> +        xlnx,hot-join-capable;
>>       };
>>   ...
>> --
>> 2.34.1
>>

-- 
linux-i3c mailing list
linux-i3c@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-i3c