Re: [PATCH 1/3] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3582

From: Marc Zyngier <maz@kernel.org>
To: FUKAUMI Naoki <naoki@radxa.com>
Cc: heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, tglx@linutronix.de, jonas@kwiboo.se,
	macromorgan@hotmail.com, andyshrk@163.com,
	liujianfeng1994@gmail.com, dmt.yashin@gmail.com,
	dsimic@manjaro.org, tim@feathertop.org,
	marcin.juszkiewicz@linaro.org, michael.riesch@wolfvision.net,
	alchark@gmail.com, sebastian.reichel@collabora.com,
	jbx6244@gmail.com, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-rockchip@lists.infradead.org
Subject: Re: [PATCH 1/3] irqchip/gic-v3: Enable Rockchip 3588001 erratum workaround for RK3582
Date: Sun, 22 Dec 2024 09:04:29 +0000	[thread overview]
Message-ID: <86msgoozqa.wl-maz@kernel.org> (raw)
In-Reply-To: <20241222030355.2246-2-naoki@radxa.com>

On Sun, 22 Dec 2024 03:03:53 +0000,
FUKAUMI Naoki <naoki@radxa.com> wrote:
> 
> Rockchip RK3582 is a scaled down version of Rockchip RK3588(S). Apply
> Rockchip 3588001 erratum workaround to RK3582.
> 
> Signed-off-by: FUKAUMI Naoki <naoki@radxa.com>
> ---
>  drivers/irqchip/irq-gic-v3-its.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/irqchip/irq-gic-v3-its.c b/drivers/irqchip/irq-gic-v3-its.c
> index 92244cfa0464..c59ce9332dc0 100644
> --- a/drivers/irqchip/irq-gic-v3-its.c
> +++ b/drivers/irqchip/irq-gic-v3-its.c
> @@ -4861,7 +4861,8 @@ static bool __maybe_unused its_enable_rk3588001(void *data)
>  {
>  	struct its_node *its = data;
>  
> -	if (!of_machine_is_compatible("rockchip,rk3588") &&
> +	if (!of_machine_is_compatible("rockchip,rk3582") &&
> +	    !of_machine_is_compatible("rockchip,rk3588") &&
>  	    !of_machine_is_compatible("rockchip,rk3588s"))
>  		return false;
>  

Please use the relevant property for that purpose ("dma-noncoherent")
at the distributor and ITS levels. We're not adding extra compatibles
for this anymore, and you might as well fix the core dtsi to expose
such property.

Thanks,

	M.

-- 
Without deviation from the norm, progress is not possible.