All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Kunkun Jiang <jiangkunkun@huawei.com>,
	dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com,
	mst@redhat.com, Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Gavin Shan <gshan@redhat.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	"open list:IRQCHIP DRIVERS" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	wanghaibin.wang@huawei.com
Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI
Date: Mon, 04 Dec 2023 09:00:21 +0000	[thread overview]
Message-ID: <86r0k2bavu.wl-maz@kernel.org> (raw)
In-Reply-To: <CACGkMEub4f0FWsrJzSK4e+9cC6LUNFm3vAcfSkpsp6pD=WM5qA@mail.gmail.com>

On Mon, 04 Dec 2023 08:47:49 +0000,
Jason Wang <jasowang@redhat.com> wrote:
> 
> On Mon, Dec 4, 2023 at 4:39 PM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Sat, Dec 2, 2023 at 8:20 PM Marc Zyngier <maz@kernel.org> wrote:
> > >
> > > Hi Kunkun,
> > >
> > > On Wed, 08 Nov 2023 09:45:51 +0000,
> > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > >
> > > > Hi Marc,
> > > >
> > > > On 2023/11/6 23:33, Marc Zyngier wrote:
> > > > > On Mon, 06 Nov 2023 14:59:01 +0000,
> > > > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > > >> The virtio-pci driver write entry1-6
> > > > >> massage.data in the msix-table and trap to QEMU for processing. The
> > > > >> massage.data is as follow:
> > > > >>> entry-0 0
> > > > >>> entry-1 1
> > > > >>> entry-2 1
> > > > >>> entry-3 1
> > > > >>> entry-4 1
> > > > >>> entry-5 1
> > > > >>> entry-6 1
> >
> > It looks like a bug from the driver. It should only use vector 0 and 1
> > in this case.
> >
> > Could you please check the queue_msix_vector for each queue in this case?
> 
> Or did you actually mean queue_msix_vector here? I'm not familiar with
> ARM but 0 doesn't seem to be a good message.data anyhow.

Why? What's special about 0? 0 is a perfectly fine value.

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Jason Wang <jasowang@redhat.com>
Cc: Kunkun Jiang <jiangkunkun@huawei.com>,
	dongli.zhang@oracle.com, cohuck@redhat.com, stefanha@redhat.com,
	mst@redhat.com, Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Suzuki K Poulose <suzuki.poulose@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Gavin Shan <gshan@redhat.com>,
	Jean-Philippe Brucker <jean-philippe@linaro.org>,
	"open list:IRQCHIP DRIVERS" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev,
	wanghaibin.wang@huawei.com
Subject: Re: [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI
Date: Mon, 04 Dec 2023 09:00:21 +0000	[thread overview]
Message-ID: <86r0k2bavu.wl-maz@kernel.org> (raw)
In-Reply-To: <CACGkMEub4f0FWsrJzSK4e+9cC6LUNFm3vAcfSkpsp6pD=WM5qA@mail.gmail.com>

On Mon, 04 Dec 2023 08:47:49 +0000,
Jason Wang <jasowang@redhat.com> wrote:
> 
> On Mon, Dec 4, 2023 at 4:39 PM Jason Wang <jasowang@redhat.com> wrote:
> >
> > On Sat, Dec 2, 2023 at 8:20 PM Marc Zyngier <maz@kernel.org> wrote:
> > >
> > > Hi Kunkun,
> > >
> > > On Wed, 08 Nov 2023 09:45:51 +0000,
> > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > >
> > > > Hi Marc,
> > > >
> > > > On 2023/11/6 23:33, Marc Zyngier wrote:
> > > > > On Mon, 06 Nov 2023 14:59:01 +0000,
> > > > > Kunkun Jiang <jiangkunkun@huawei.com> wrote:
> > > > >> The virtio-pci driver write entry1-6
> > > > >> massage.data in the msix-table and trap to QEMU for processing. The
> > > > >> massage.data is as follow:
> > > > >>> entry-0 0
> > > > >>> entry-1 1
> > > > >>> entry-2 1
> > > > >>> entry-3 1
> > > > >>> entry-4 1
> > > > >>> entry-5 1
> > > > >>> entry-6 1
> >
> > It looks like a bug from the driver. It should only use vector 0 and 1
> > in this case.
> >
> > Could you please check the queue_msix_vector for each queue in this case?
> 
> Or did you actually mean queue_msix_vector here? I'm not familiar with
> ARM but 0 doesn't seem to be a good message.data anyhow.

Why? What's special about 0? 0 is a perfectly fine value.

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2023-12-04  9:00 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-02 14:35 [RFC PATCH] KVM: arm/arm64: GICv4: Support shared VLPI Kunkun Jiang
2023-11-02 14:35 ` Kunkun Jiang
2023-11-04 10:29 ` Marc Zyngier
2023-11-04 10:29   ` Marc Zyngier
2023-11-06 15:33   ` Kunkun Jiang
     [not found]   ` <1fb8353e-e9c4-2570-c2ca-ec537c18ac4d@huawei.com>
2023-11-06 15:33     ` Marc Zyngier
2023-11-06 15:33       ` Marc Zyngier
2023-11-08  9:45       ` Kunkun Jiang
2023-11-08  9:45         ` Kunkun Jiang
2023-12-02 12:20         ` Marc Zyngier
2023-12-02 12:20           ` Marc Zyngier
2023-12-04  8:39           ` Jason Wang
2023-12-04  8:39             ` Jason Wang
2023-12-04  8:47             ` Jason Wang
2023-12-04  8:47               ` Jason Wang
2023-12-04  9:00               ` Marc Zyngier [this message]
2023-12-04  9:00                 ` Marc Zyngier
2023-12-04  9:06                 ` Jason Wang
2023-12-04  9:06                   ` Jason Wang
2023-12-04  8:52             ` Marc Zyngier
2023-12-04  8:52               ` Marc Zyngier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86r0k2bavu.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=cohuck@redhat.com \
    --cc=dongli.zhang@oracle.com \
    --cc=gshan@redhat.com \
    --cc=james.morse@arm.com \
    --cc=jasowang@redhat.com \
    --cc=jean-philippe@linaro.org \
    --cc=jiangkunkun@huawei.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=oliver.upton@linux.dev \
    --cc=stefanha@redhat.com \
    --cc=suzuki.poulose@arm.com \
    --cc=wanghaibin.wang@huawei.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.