All of lore.kernel.org
 help / color / mirror / Atom feed
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v5 2/2] KVM: arm64: Move FGT value configuration to vCPU state
Date: Thu, 13 Jul 2023 16:22:41 +0100	[thread overview]
Message-ID: <86ttu7vnsu.wl-maz@kernel.org> (raw)
In-Reply-To: <9dedca62-7821-461f-805f-9550b17efd48@sirena.org.uk>

On Thu, 13 Jul 2023 16:15:36 +0100,
Mark Brown <broonie@kernel.org> wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Thu, Jul 13, 2023 at 10:48:54AM +0100, Suzuki K Poulose wrote:
> > On 12/07/2023 13:50, Mark Brown wrote:
> 
> > > +	/* We currently assume the host configuration never changes */
> > > +	vcpu->arch.hfgrtr_el2_host = read_sysreg_s(SYS_HFGRTR_EL2);
> > > +	vcpu->arch.hfgwtr_el2_host = read_sysreg_s(SYS_HFGWTR_EL2);
> 
> > Doesn't this crash an nVHE host ?
> 
> This series is probably moot given Marc's nv series (or at least needs
> another rework) but could you expand on the issue you're seeing please?

You're reading EL2 registers from EL1. What could possibly go wrong?

	M.

-- 
Without deviation from the norm, progress is not possible.

WARNING: multiple messages have this Message-ID (diff)
From: Marc Zyngier <maz@kernel.org>
To: Mark Brown <broonie@kernel.org>
Cc: Suzuki K Poulose <suzuki.poulose@arm.com>,
	Oliver Upton <oliver.upton@linux.dev>,
	James Morse <james.morse@arm.com>,
	Zenghui Yu <yuzenghui@huawei.com>,
	Catalin Marinas <catalin.marinas@arm.com>,
	Will Deacon <will@kernel.org>, Joey Gouly <joey.gouly@arm.com>,
	linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev
Subject: Re: [PATCH v5 2/2] KVM: arm64: Move FGT value configuration to vCPU state
Date: Thu, 13 Jul 2023 16:22:41 +0100	[thread overview]
Message-ID: <86ttu7vnsu.wl-maz@kernel.org> (raw)
In-Reply-To: <9dedca62-7821-461f-805f-9550b17efd48@sirena.org.uk>

On Thu, 13 Jul 2023 16:15:36 +0100,
Mark Brown <broonie@kernel.org> wrote:
> 
> [1  <text/plain; us-ascii (7bit)>]
> On Thu, Jul 13, 2023 at 10:48:54AM +0100, Suzuki K Poulose wrote:
> > On 12/07/2023 13:50, Mark Brown wrote:
> 
> > > +	/* We currently assume the host configuration never changes */
> > > +	vcpu->arch.hfgrtr_el2_host = read_sysreg_s(SYS_HFGRTR_EL2);
> > > +	vcpu->arch.hfgwtr_el2_host = read_sysreg_s(SYS_HFGWTR_EL2);
> 
> > Doesn't this crash an nVHE host ?
> 
> This series is probably moot given Marc's nv series (or at least needs
> another rework) but could you expand on the issue you're seeing please?

You're reading EL2 registers from EL1. What could possibly go wrong?

	M.

-- 
Without deviation from the norm, progress is not possible.

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2023-07-13 15:22 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-12 12:50 [PATCH v5 0/2] KVM: arm64: Support for per-guest fine grained traps configuration Mark Brown
2023-07-12 12:50 ` Mark Brown
2023-07-12 12:50 ` [PATCH v5 1/2] arm64: Add feature detection for fine grained traps Mark Brown
2023-07-12 12:50   ` Mark Brown
2023-07-16 14:44   ` Zenghui Yu
2023-07-16 14:44     ` Zenghui Yu
2023-07-16 14:46     ` Mark Brown
2023-07-16 14:46       ` Mark Brown
2023-07-12 12:50 ` [PATCH v5 2/2] KVM: arm64: Move FGT value configuration to vCPU state Mark Brown
2023-07-12 12:50   ` Mark Brown
2023-07-13  9:48   ` Suzuki K Poulose
2023-07-13  9:48     ` Suzuki K Poulose
2023-07-13 15:15     ` Mark Brown
2023-07-13 15:15       ` Mark Brown
2023-07-13 15:22       ` Suzuki K Poulose
2023-07-13 15:22         ` Suzuki K Poulose
2023-07-13 15:22       ` Marc Zyngier [this message]
2023-07-13 15:22         ` Marc Zyngier
2023-07-13 15:35         ` Mark Brown
2023-07-13 15:35           ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86ttu7vnsu.wl-maz@kernel.org \
    --to=maz@kernel.org \
    --cc=broonie@kernel.org \
    --cc=catalin.marinas@arm.com \
    --cc=james.morse@arm.com \
    --cc=joey.gouly@arm.com \
    --cc=kvmarm@lists.linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=oliver.upton@linux.dev \
    --cc=suzuki.poulose@arm.com \
    --cc=will@kernel.org \
    --cc=yuzenghui@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.