From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Eliav Farber <farbere@amazon.com>
Cc: <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
<mwalle@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads
Date: Mon, 09 Feb 2026 11:51:47 +0100 [thread overview]
Message-ID: <871piu196k.fsf@bootlin.com> (raw)
In-Reply-To: <20260208061919.30498-1-farbere@amazon.com> (Eliav Farber's message of "Sun, 8 Feb 2026 06:19:15 +0000")
Hi Eliav,
On 08/02/2026 at 06:19:15 GMT, Eliav Farber <farbere@amazon.com> wrote:
> This series fixes block protection handling for the following Winbond
> SPI-NOR devices:
> - w25q256jwm
> - w25q256jw
> - w25q64jvm
>
> The devices do not correctly describe their Status Register layout and
> protection capabilities (locking flags, TB bit, BP bit configuration).
> As a result, the spi-nor core rejects protection requests and locking
> operations fail with -EINVAL, e.g.:
>
> flash_lock -l /dev/mtd29
> flash_lock: error!: could not lock device: /dev/mtd29
> error 22 (Invalid argument)
>
> Update the device flags to match the actual hardware behavior so that
> locking and unlocking regions work correctly.
>
> Additionally, enable Dual and Quad read support for w25q64jvm when SFDP
> is not used.
>
> All changes were validated using flash_lock on the affected devices.
>
> Eliav Farber (4):
> mtd: spi-nor: winbond: Fix locking support for w25q256jwm
> mtd: spi-nor: winbond: Fix locking support for w25q256jw
> mtd: spi-nor: winbond: Fix locking support for w25q64jvm
> mtd: spi-nor: winbond: Enable Dual and Quad support for w25q64jvm
>
> drivers/mtd/spi-nor/winbond.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Looks sensible, I was looking to find Fixes tags but due to the number
of refactorings, these are hard to track, so I'm fine keeping the
commits as they are.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/
WARNING: multiple messages have this Message-ID (diff)
From: Miquel Raynal <miquel.raynal@bootlin.com>
To: Eliav Farber <farbere@amazon.com>
Cc: <tudor.ambarus@linaro.org>, <pratyush@kernel.org>,
<mwalle@kernel.org>, <richard@nod.at>, <vigneshr@ti.com>,
<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads
Date: Mon, 09 Feb 2026 11:51:47 +0100 [thread overview]
Message-ID: <871piu196k.fsf@bootlin.com> (raw)
In-Reply-To: <20260208061919.30498-1-farbere@amazon.com> (Eliav Farber's message of "Sun, 8 Feb 2026 06:19:15 +0000")
Hi Eliav,
On 08/02/2026 at 06:19:15 GMT, Eliav Farber <farbere@amazon.com> wrote:
> This series fixes block protection handling for the following Winbond
> SPI-NOR devices:
> - w25q256jwm
> - w25q256jw
> - w25q64jvm
>
> The devices do not correctly describe their Status Register layout and
> protection capabilities (locking flags, TB bit, BP bit configuration).
> As a result, the spi-nor core rejects protection requests and locking
> operations fail with -EINVAL, e.g.:
>
> flash_lock -l /dev/mtd29
> flash_lock: error!: could not lock device: /dev/mtd29
> error 22 (Invalid argument)
>
> Update the device flags to match the actual hardware behavior so that
> locking and unlocking regions work correctly.
>
> Additionally, enable Dual and Quad read support for w25q64jvm when SFDP
> is not used.
>
> All changes were validated using flash_lock on the affected devices.
>
> Eliav Farber (4):
> mtd: spi-nor: winbond: Fix locking support for w25q256jwm
> mtd: spi-nor: winbond: Fix locking support for w25q256jw
> mtd: spi-nor: winbond: Fix locking support for w25q64jvm
> mtd: spi-nor: winbond: Enable Dual and Quad support for w25q64jvm
>
> drivers/mtd/spi-nor/winbond.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
Looks sensible, I was looking to find Fixes tags but due to the number
of refactorings, these are hard to track, so I'm fine keeping the
commits as they are.
Reviewed-by: Miquel Raynal <miquel.raynal@bootlin.com>
Thanks,
Miquèl
next prev parent reply other threads:[~2026-02-09 10:52 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-08 6:19 [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads Eliav Farber
2026-02-08 6:19 ` Eliav Farber
2026-02-08 6:19 ` [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm Eliav Farber
2026-02-08 6:19 ` Eliav Farber
2026-02-10 7:38 ` Michael Walle
2026-02-10 7:38 ` Michael Walle
2026-02-08 6:19 ` [PATCH 2/4] mtd: spi-nor: winbond: Fix locking support for w25q256jw Eliav Farber
2026-02-08 6:19 ` Eliav Farber
2026-02-10 7:39 ` Michael Walle
2026-02-10 7:39 ` Michael Walle
2026-02-08 6:19 ` [PATCH 3/4] mtd: spi-nor: winbond: Fix locking support for w25q64jvm Eliav Farber
2026-02-08 6:19 ` Eliav Farber
2026-02-10 7:40 ` Michael Walle
2026-02-10 7:40 ` Michael Walle
2026-02-08 6:19 ` [PATCH 4/4] mtd: spi-nor: winbond: Enable Dual and Quad " Eliav Farber
2026-02-08 6:19 ` Eliav Farber
2026-02-10 7:48 ` Michael Walle
2026-02-10 7:48 ` Michael Walle
2026-02-09 10:51 ` Miquel Raynal [this message]
2026-02-09 10:51 ` [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads Miquel Raynal
2026-02-10 7:37 ` Michael Walle
2026-02-10 7:37 ` Michael Walle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871piu196k.fsf@bootlin.com \
--to=miquel.raynal@bootlin.com \
--cc=farbere@amazon.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=mwalle@kernel.org \
--cc=pratyush@kernel.org \
--cc=richard@nod.at \
--cc=tudor.ambarus@linaro.org \
--cc=vigneshr@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.