All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael Walle" <mwalle@kernel.org>
To: "Eliav Farber" <farbere@amazon.com>, <tudor.ambarus@linaro.org>,
	<pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm
Date: Tue, 10 Feb 2026 08:38:56 +0100	[thread overview]
Message-ID: <DGB403FZHES3.1QMYF6PL3O2YV@kernel.org> (raw)
In-Reply-To: <20260208061919.30498-2-farbere@amazon.com>


[-- Attachment #1.1: Type: text/plain, Size: 1311 bytes --]

On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote:
> The Winbond w25q256jwm device supports four Block Protect (BP) bits and
> uses Status Register bit 6 as the Top/Bottom (TB) protect bit.
>
> Update the flash parameters by enabling SPI_NOR_4BIT_BP and
> SPI_NOR_TB_SR_BIT6. Without these flags, the locking configuration is
> incorrect.
>
> Reference:
> https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&DocNo=DA00-W25Q256JW.1
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index fb855fe44733..55f1209936d5 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -337,7 +337,7 @@ static const struct flash_info winbond_nor_parts[] = {
>  		.id = SNOR_ID(0xef, 0x80, 0x19),
>  		.name = "w25q256jwm",
>  		.size = SZ_32M,
> -		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
> +		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_NOR_4BIT_BP,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>  	}, {
>  		.id = SNOR_ID(0xef, 0x80, 0x20),

Reviewed-by: Michael Walle <mwalle@kernel.org>

-michael

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

[-- Attachment #2: Type: text/plain, Size: 144 bytes --]

______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/

WARNING: multiple messages have this Message-ID (diff)
From: "Michael Walle" <mwalle@kernel.org>
To: "Eliav Farber" <farbere@amazon.com>, <tudor.ambarus@linaro.org>,
	<pratyush@kernel.org>, <miquel.raynal@bootlin.com>,
	<richard@nod.at>, <vigneshr@ti.com>,
	<linux-mtd@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm
Date: Tue, 10 Feb 2026 08:38:56 +0100	[thread overview]
Message-ID: <DGB403FZHES3.1QMYF6PL3O2YV@kernel.org> (raw)
In-Reply-To: <20260208061919.30498-2-farbere@amazon.com>

[-- Attachment #1: Type: text/plain, Size: 1311 bytes --]

On Sun Feb 8, 2026 at 7:19 AM CET, Eliav Farber wrote:
> The Winbond w25q256jwm device supports four Block Protect (BP) bits and
> uses Status Register bit 6 as the Top/Bottom (TB) protect bit.
>
> Update the flash parameters by enabling SPI_NOR_4BIT_BP and
> SPI_NOR_TB_SR_BIT6. Without these flags, the locking configuration is
> incorrect.
>
> Reference:
> https://www.winbond.com/hq/support/documentation/levelOne.jsp?__locale=en&DocNo=DA00-W25Q256JW.1
>
> Signed-off-by: Eliav Farber <farbere@amazon.com>
> ---
>  drivers/mtd/spi-nor/winbond.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/spi-nor/winbond.c b/drivers/mtd/spi-nor/winbond.c
> index fb855fe44733..55f1209936d5 100644
> --- a/drivers/mtd/spi-nor/winbond.c
> +++ b/drivers/mtd/spi-nor/winbond.c
> @@ -337,7 +337,7 @@ static const struct flash_info winbond_nor_parts[] = {
>  		.id = SNOR_ID(0xef, 0x80, 0x19),
>  		.name = "w25q256jwm",
>  		.size = SZ_32M,
> -		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB,
> +		.flags = SPI_NOR_HAS_LOCK | SPI_NOR_HAS_TB | SPI_NOR_TB_SR_BIT6 | SPI_NOR_4BIT_BP,
>  		.no_sfdp_flags = SECT_4K | SPI_NOR_DUAL_READ | SPI_NOR_QUAD_READ,
>  	}, {
>  		.id = SNOR_ID(0xef, 0x80, 0x20),

Reviewed-by: Michael Walle <mwalle@kernel.org>

-michael

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 297 bytes --]

  reply	other threads:[~2026-02-10  7:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-02-08  6:19 [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads Eliav Farber
2026-02-08  6:19 ` Eliav Farber
2026-02-08  6:19 ` [PATCH 1/4] mtd: spi-nor: winbond: Fix locking support for w25q256jwm Eliav Farber
2026-02-08  6:19   ` Eliav Farber
2026-02-10  7:38   ` Michael Walle [this message]
2026-02-10  7:38     ` Michael Walle
2026-02-08  6:19 ` [PATCH 2/4] mtd: spi-nor: winbond: Fix locking support for w25q256jw Eliav Farber
2026-02-08  6:19   ` Eliav Farber
2026-02-10  7:39   ` Michael Walle
2026-02-10  7:39     ` Michael Walle
2026-02-08  6:19 ` [PATCH 3/4] mtd: spi-nor: winbond: Fix locking support for w25q64jvm Eliav Farber
2026-02-08  6:19   ` Eliav Farber
2026-02-10  7:40   ` Michael Walle
2026-02-10  7:40     ` Michael Walle
2026-02-08  6:19 ` [PATCH 4/4] mtd: spi-nor: winbond: Enable Dual and Quad " Eliav Farber
2026-02-08  6:19   ` Eliav Farber
2026-02-10  7:48   ` Michael Walle
2026-02-10  7:48     ` Michael Walle
2026-02-09 10:51 ` [PATCH 0/4] mtd: spi-nor: winbond: Fix protection handling and enable dual/quad reads Miquel Raynal
2026-02-09 10:51   ` Miquel Raynal
2026-02-10  7:37 ` Michael Walle
2026-02-10  7:37   ` Michael Walle

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DGB403FZHES3.1QMYF6PL3O2YV@kernel.org \
    --to=mwalle@kernel.org \
    --cc=farbere@amazon.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    --cc=miquel.raynal@bootlin.com \
    --cc=pratyush@kernel.org \
    --cc=richard@nod.at \
    --cc=tudor.ambarus@linaro.org \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.