All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: Tyler S <tylerjstachecki@gmail.com>
Cc: alexander.duyck@gmail.com, anthony.l.nguyen@intel.com,
	ast@kernel.org, bigeasy@linutronix.de, bpf@vger.kernel.org,
	daniel@iogearbox.net, davem@davemloft.net, hawk@kernel.org,
	ilias.apalodimas@linaro.org, intel-wired-lan@lists.osuosl.org,
	jesse.brandeburg@intel.com, john.fastabend@gmail.com,
	kuba@kernel.org, lorenzo@kernel.org, netdev@vger.kernel.org,
	richardcochran@gmail.com, sven.auhagen@voleatech.de,
	Maciej Fijalkowski <maciej.fijalkowski@intel.com>
Subject: Re: [PATCH net v2] igb: Fix XDP with PTP enabled
Date: Mon, 26 Apr 2021 16:15:08 +0200	[thread overview]
Message-ID: <871rax9loz.fsf@kurt> (raw)
In-Reply-To: <CAMfj=-YEh1ZnLB8zye7i-5Y2S015n0qat+FQ6JW7bFKwBUHBPg@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 635 bytes --]

On Sun Apr 25 2021, Tyler S wrote:
> Thanks for this work; I was having trouble using XDP on my I354 NIC until this.
>
> Hopefully I have not err'd backporting it to 5.10 -- but I'm seeing
> jumbo frames dropped after applying this (though as previously
> mentioned, non-skb/full driver XDP programs do now work).
>
> Looking at the code, I'm not sure why that is.

I'm also not sure, yet.

Can you try with version 3 of this patch [1] and see if there are still
issues with jumbo frames? Can you also share the backported patch for
v5.10?

Thanks,
Kurt

[1] - https://lkml.kernel.org/netdev/20210422052617.17267-1-kurt@linutronix.de/

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v2] igb: Fix XDP with PTP enabled
Date: Mon, 26 Apr 2021 16:15:08 +0200	[thread overview]
Message-ID: <871rax9loz.fsf@kurt> (raw)
In-Reply-To: <CAMfj=-YEh1ZnLB8zye7i-5Y2S015n0qat+FQ6JW7bFKwBUHBPg@mail.gmail.com>

On Sun Apr 25 2021, Tyler S wrote:
> Thanks for this work; I was having trouble using XDP on my I354 NIC until this.
>
> Hopefully I have not err'd backporting it to 5.10 -- but I'm seeing
> jumbo frames dropped after applying this (though as previously
> mentioned, non-skb/full driver XDP programs do now work).
>
> Looking at the code, I'm not sure why that is.

I'm also not sure, yet.

Can you try with version 3 of this patch [1] and see if there are still
issues with jumbo frames? Can you also share the backported patch for
v5.10?

Thanks,
Kurt

[1] - https://lkml.kernel.org/netdev/20210422052617.17267-1-kurt at linutronix.de/
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210426/9e7ca922/attachment.asc>

  reply	other threads:[~2021-04-26 14:15 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-25 23:09 [PATCH net v2] igb: Fix XDP with PTP enabled Tyler S
2021-04-25 23:09 ` [Intel-wired-lan] " Tyler S
2021-04-26 14:15 ` Kurt Kanzenbach [this message]
2021-04-26 14:15   ` Kurt Kanzenbach
2021-04-27 23:11   ` Tyler S
2021-04-27 23:11     ` [Intel-wired-lan] " Tyler S
2021-05-03  7:31     ` Kurt Kanzenbach
2021-05-03  7:31       ` [Intel-wired-lan] " Kurt Kanzenbach
  -- strict thread matches above, loose matches on Subject: below --
2021-04-19  7:23 Kurt Kanzenbach
2021-04-20 16:33 ` Nguyen, Anthony L
2021-04-21  6:35   ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=871rax9loz.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=alexander.duyck@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=maciej.fijalkowski@intel.com \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=sven.auhagen@voleatech.de \
    --cc=tylerjstachecki@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.