All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kurt Kanzenbach <kurt@linutronix.de>
To: "Nguyen\, Anthony L" <anthony.l.nguyen@intel.com>,
	"davem\@davemloft.net" <davem@davemloft.net>,
	"kuba\@kernel.org" <kuba@kernel.org>, "Brandeburg\,
	Jesse" <jesse.brandeburg@intel.com>
Cc: "bigeasy\@linutronix.de" <bigeasy@linutronix.de>,
	"daniel\@iogearbox.net" <daniel@iogearbox.net>,
	"bpf\@vger.kernel.org" <bpf@vger.kernel.org>,
	"ast\@kernel.org" <ast@kernel.org>,
	"hawk\@kernel.org" <hawk@kernel.org>,
	"lorenzo\@kernel.org" <lorenzo@kernel.org>,
	"john.fastabend\@gmail.com" <john.fastabend@gmail.com>,
	"alexander.duyck\@gmail.com" <alexander.duyck@gmail.com>,
	"ilias.apalodimas\@linaro.org" <ilias.apalodimas@linaro.org>,
	"richardcochran\@gmail.com" <richardcochran@gmail.com>,
	"netdev\@vger.kernel.org" <netdev@vger.kernel.org>,
	"sven.auhagen\@voleatech.de" <sven.auhagen@voleatech.de>,
	"intel-wired-lan\@lists.osuosl.org" 
	<intel-wired-lan@lists.osuosl.org>
Subject: Re: [PATCH net v2] igb: Fix XDP with PTP enabled
Date: Wed, 21 Apr 2021 08:35:06 +0200	[thread overview]
Message-ID: <874kg0b0x1.fsf@kurt> (raw)
In-Reply-To: <c1eed5fe05a59f86ff868580e3ae89e251f498ec.camel@intel.com>

[-- Attachment #1: Type: text/plain, Size: 341 bytes --]

>> +		/* pull rx packet timestamp if available */
>> +		if (igb_test_staterr(rx_desc, E1000_RXDADV_STAT_TSIP))
>> {
>> +			timestamp = igb_ptp_rx_pktstamp(rx_ring-
>> >q_vector,
>> +							pktbuf);
>
> The timestamp should be checked for failure and not adjust these values
> if the timestamp was invalid.

OK. I'll adjust it.

Thanks,
Kurt

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

WARNING: multiple messages have this Message-ID (diff)
From: Kurt Kanzenbach <kurt@linutronix.de>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH net v2] igb: Fix XDP with PTP enabled
Date: Wed, 21 Apr 2021 08:35:06 +0200	[thread overview]
Message-ID: <874kg0b0x1.fsf@kurt> (raw)
In-Reply-To: <c1eed5fe05a59f86ff868580e3ae89e251f498ec.camel@intel.com>

>> +		/* pull rx packet timestamp if available */
>> +		if (igb_test_staterr(rx_desc, E1000_RXDADV_STAT_TSIP))
>> {
>> +			timestamp = igb_ptp_rx_pktstamp(rx_ring-
>> >q_vector,
>> +							pktbuf);
>
> The timestamp should be checked for failure and not adjust these values
> if the timestamp was invalid.

OK. I'll adjust it.

Thanks,
Kurt
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 832 bytes
Desc: not available
URL: <http://lists.osuosl.org/pipermail/intel-wired-lan/attachments/20210421/b45d280f/attachment.asc>

  reply	other threads:[~2021-04-21  6:35 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-19  7:23 [PATCH net v2] igb: Fix XDP with PTP enabled Kurt Kanzenbach
2021-04-19  7:23 ` [Intel-wired-lan] " Kurt Kanzenbach
2021-04-20 16:33 ` Nguyen, Anthony L
2021-04-20 16:33   ` [Intel-wired-lan] " Nguyen, Anthony L
2021-04-21  6:35   ` Kurt Kanzenbach [this message]
2021-04-21  6:35     ` Kurt Kanzenbach
  -- strict thread matches above, loose matches on Subject: below --
2021-04-25 23:09 Tyler S
2021-04-26 14:15 ` Kurt Kanzenbach
2021-04-27 23:11   ` Tyler S
2021-05-03  7:31     ` Kurt Kanzenbach

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kg0b0x1.fsf@kurt \
    --to=kurt@linutronix.de \
    --cc=alexander.duyck@gmail.com \
    --cc=anthony.l.nguyen@intel.com \
    --cc=ast@kernel.org \
    --cc=bigeasy@linutronix.de \
    --cc=bpf@vger.kernel.org \
    --cc=daniel@iogearbox.net \
    --cc=davem@davemloft.net \
    --cc=hawk@kernel.org \
    --cc=ilias.apalodimas@linaro.org \
    --cc=intel-wired-lan@lists.osuosl.org \
    --cc=jesse.brandeburg@intel.com \
    --cc=john.fastabend@gmail.com \
    --cc=kuba@kernel.org \
    --cc=lorenzo@kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=sven.auhagen@voleatech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.