* [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 9:45 ` Yoann Padioleau
0 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 9:45 UTC (permalink / raw)
To: kernel-janitors; +Cc: jdike, user-mode-linux-devel, akpm, linux-kernel
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E =
- 0
+ NULL
@@
expression *E;
@@
E !- 0
+ NULL
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: jdike@karaya.com
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: akpm@linux-foundation.org
---
sys-i386/fault.c | 2 +-
sys-x86_64/fault.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-i386/fault.c b/arch/um/sys-i386/fault.c
index 745b4fd..8004023 100644
--- a/arch/um/sys-i386/fault.c
+++ b/arch/um/sys-i386/fault.c
@@ -20,7 +20,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
diff --git a/arch/um/sys-x86_64/fault.c b/arch/um/sys-x86_64/fault.c
index 4636b14..67d4a19 100644
--- a/arch/um/sys-x86_64/fault.c
+++ b/arch/um/sys-x86_64/fault.c
@@ -19,7 +19,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 9:45 ` Yoann Padioleau
0 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 9:45 UTC (permalink / raw)
To: kernel-janitors; +Cc: jdike, user-mode-linux-devel, akpm, linux-kernel
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E ==
- 0
+ NULL
@@
expression *E;
@@
E !=
- 0
+ NULL
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: jdike@karaya.com
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: akpm@linux-foundation.org
---
sys-i386/fault.c | 2 +-
sys-x86_64/fault.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-i386/fault.c b/arch/um/sys-i386/fault.c
index 745b4fd..8004023 100644
--- a/arch/um/sys-i386/fault.c
+++ b/arch/um/sys-i386/fault.c
@@ -20,7 +20,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
diff --git a/arch/um/sys-x86_64/fault.c b/arch/um/sys-x86_64/fault.c
index 4636b14..67d4a19 100644
--- a/arch/um/sys-x86_64/fault.c
+++ b/arch/um/sys-x86_64/fault.c
@@ -19,7 +19,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
^ permalink raw reply related [flat|nested] 9+ messages in thread* [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 9:45 ` Yoann Padioleau
0 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 9:45 UTC (permalink / raw)
To: kernel-janitors; +Cc: jdike, akpm, linux-kernel, user-mode-linux-devel
When comparing a pointer, it's clearer to compare it to NULL than to 0.
Here is an excerpt of the semantic patch:
@@
expression *E;
@@
E ==
- 0
+ NULL
@@
expression *E;
@@
E !=
- 0
+ NULL
Signed-off-by: Yoann Padioleau <padator@wanadoo.fr>
Cc: jdike@karaya.com
Cc: user-mode-linux-devel@lists.sourceforge.net
Cc: akpm@linux-foundation.org
---
sys-i386/fault.c | 2 +-
sys-x86_64/fault.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/um/sys-i386/fault.c b/arch/um/sys-i386/fault.c
index 745b4fd..8004023 100644
--- a/arch/um/sys-i386/fault.c
+++ b/arch/um/sys-i386/fault.c
@@ -20,7 +20,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
diff --git a/arch/um/sys-x86_64/fault.c b/arch/um/sys-x86_64/fault.c
index 4636b14..67d4a19 100644
--- a/arch/um/sys-x86_64/fault.c
+++ b/arch/um/sys-x86_64/fault.c
@@ -19,7 +19,7 @@ int arch_fixup(unsigned long address, un
const struct exception_table_entry *fixup;
fixup = search_exception_tables(address);
- if(fixup != 0){
+ if(fixup != NULL){
UPT_IP(regs) = fixup->fixup;
return(1);
}
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH 18/68] 0 -> NULL, for arch/um
2007-07-27 9:45 ` [uml-devel] " Yoann Padioleau
(?)
@ 2007-07-27 16:35 ` Jeff Dike
-1 siblings, 0 replies; 9+ messages in thread
From: Jeff Dike @ 2007-07-27 16:35 UTC (permalink / raw)
To: Yoann Padioleau
Cc: kernel-janitors, user-mode-linux-devel, akpm, linux-kernel
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
ACK
> sys-i386/fault.c | 2 +-
> sys-x86_64/fault.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Except you should probably diff from the top of the kernel tree.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 16:35 ` Jeff Dike
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Dike @ 2007-07-27 16:35 UTC (permalink / raw)
To: Yoann Padioleau
Cc: kernel-janitors, user-mode-linux-devel, akpm, linux-kernel
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
ACK
> sys-i386/fault.c | 2 +-
> sys-x86_64/fault.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Except you should probably diff from the top of the kernel tree.
Jeff
--
Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 16:35 ` Jeff Dike
0 siblings, 0 replies; 9+ messages in thread
From: Jeff Dike @ 2007-07-27 16:35 UTC (permalink / raw)
To: Yoann Padioleau
Cc: akpm, kernel-janitors, linux-kernel, user-mode-linux-devel
On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
> When comparing a pointer, it's clearer to compare it to NULL than to 0.
ACK
> sys-i386/fault.c | 2 +-
> sys-x86_64/fault.c | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
Except you should probably diff from the top of the kernel tree.
Jeff
--
Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/68] 0 -> NULL, for arch/um
2007-07-27 16:35 ` [uml-devel] " Jeff Dike
(?)
@ 2007-07-27 16:49 ` Yoann Padioleau
-1 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 16:49 UTC (permalink / raw)
To: Jeff Dike
Cc: Yoann Padioleau, kernel-janitors, user-mode-linux-devel, akpm,
linux-kernel
Jeff Dike <jdike@addtoit.com> writes:
> On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
>> When comparing a pointer, it's clearer to compare it to NULL than to 0.
>
> ACK
>
>> sys-i386/fault.c | 2 +-
>> sys-x86_64/fault.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Except you should probably diff from the top of the kernel tree.
Sorry. I will use diffstat -p1 from now on.
>
> Jeff
>
> --
> Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 16:49 ` Yoann Padioleau
0 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 16:49 UTC (permalink / raw)
To: Jeff Dike
Cc: Yoann Padioleau, kernel-janitors, user-mode-linux-devel, akpm,
linux-kernel
Jeff Dike <jdike@addtoit.com> writes:
> On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
>> When comparing a pointer, it's clearer to compare it to NULL than to 0.
>
> ACK
>
>> sys-i386/fault.c | 2 +-
>> sys-x86_64/fault.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Except you should probably diff from the top of the kernel tree.
Sorry. I will use diffstat -p1 from now on.
>
> Jeff
>
> --
> Work email - jdike at linux dot intel dot com
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [uml-devel] [PATCH 18/68] 0 -> NULL, for arch/um
@ 2007-07-27 16:49 ` Yoann Padioleau
0 siblings, 0 replies; 9+ messages in thread
From: Yoann Padioleau @ 2007-07-27 16:49 UTC (permalink / raw)
To: Jeff Dike
Cc: kernel-janitors, akpm, Yoann Padioleau, linux-kernel,
user-mode-linux-devel
Jeff Dike <jdike@addtoit.com> writes:
> On Fri, Jul 27, 2007 at 11:45:56AM +0200, Yoann Padioleau wrote:
>> When comparing a pointer, it's clearer to compare it to NULL than to 0.
>
> ACK
>
>> sys-i386/fault.c | 2 +-
>> sys-x86_64/fault.c | 2 +-
>> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> Except you should probably diff from the top of the kernel tree.
Sorry. I will use diffstat -p1 from now on.
>
> Jeff
>
> --
> Work email - jdike at linux dot intel dot com
-------------------------------------------------------------------------
This SF.net email is sponsored by: Splunk Inc.
Still grepping through log files to find problems? Stop.
Now Search log events and configuration files using AJAX and a browser.
Download your FREE copy of Splunk now >> http://get.splunk.com/
_______________________________________________
User-mode-linux-devel mailing list
User-mode-linux-devel@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/user-mode-linux-devel
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2007-07-27 16:51 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-07-27 9:45 [PATCH 18/68] 0 -> NULL, for arch/um Yoann Padioleau
2007-07-27 9:45 ` Yoann Padioleau
2007-07-27 9:45 ` [uml-devel] " Yoann Padioleau
2007-07-27 16:35 ` Jeff Dike
2007-07-27 16:35 ` Jeff Dike
2007-07-27 16:35 ` [uml-devel] " Jeff Dike
2007-07-27 16:49 ` Yoann Padioleau
2007-07-27 16:49 ` Yoann Padioleau
2007-07-27 16:49 ` [uml-devel] " Yoann Padioleau
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.