SMB client testing wiki

SMB client testing wiki

[Tom Talpey]

The testing wiki page was last updated almost a year ago.
   https://wiki.samba.org/index.php/Xfstesting-cifs

Is there an updated list of tests expected to pass, and/or
any update for the scripting? Anything else I need to run in
a basic local environment, to test smb3.ko client to ksmbd.ko
and Samba servers on a pair of test machines?

Thanks for any suggestions.

Tom.

Re: SMB client testing wiki

[Paulo Alcantara]

Tom Talpey <tom@talpey.com> writes:

> Is there an updated list of tests expected to pass, and/or
> any update for the scripting? Anything else I need to run in
> a basic local environment, to test smb3.ko client to ksmbd.ko
> and Samba servers on a pair of test machines?

For the testing environment, I'd say there is nothing special.  Just
create two shares in both samba and ksmbd servers and specify them in
local.config when running xfstests.  We usually name them as 'test' and
'scratch', respectively.

For testing SMB3 over samba, you would have something like this in your
local.config:

  [smb3samba]
  FSTYP=cifs
  TEST_DEV=//tom.samba/test
  TEST_DIR=/mnt/test
  TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
  export MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
  export SCRATCH_DEV=//tom.samba/scratch
  export SCRATCH_MNT=/mnt/scratch

and then run xfstests

  ./check -s smb3samba ...

Re: SMB client testing wiki

[Tom Talpey]

On 8/26/2022 10:53 AM, Paulo Alcantara wrote:
> Tom Talpey <tom@talpey.com> writes:
> 
>> Is there an updated list of tests expected to pass, and/or
>> any update for the scripting? Anything else I need to run in
>> a basic local environment, to test smb3.ko client to ksmbd.ko
>> and Samba servers on a pair of test machines?
> 
> For the testing environment, I'd say there is nothing special.  Just
> create two shares in both samba and ksmbd servers and specify them in
> local.config when running xfstests.  We usually name them as 'test' and
> 'scratch', respectively.
> 
> For testing SMB3 over samba, you would have something like this in your
> local.config:
> 
>    [smb3samba]
>    FSTYP=cifs
>    TEST_DEV=//tom.samba/test
>    TEST_DIR=/mnt/test
>    TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
>    export MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
>    export SCRATCH_DEV=//tom.samba/scratch
>    export SCRATCH_MNT=/mnt/scratch
> 
> and then run xfstests
> 
>    ./check -s smb3samba ...

Easy enough! How do I know if it "passes" though? My understanding
is that a bunch of tests are expected to fail, or at least warn.
Do I need to test a clean client, then compare results? Or am I
misunderstanding, and FSTYP=cifs is taking care of it?

I'll probably be specifying vers=3.1.1 :)

Are MFS symlinks required to run the tests? That's a surprise.

Tom.

Re: SMB client testing wiki

[Paulo Alcantara]

Tom Talpey <tom@talpey.com> writes:

> Easy enough! How do I know if it "passes" though? My understanding
> is that a bunch of tests are expected to fail, or at least warn.
> Do I need to test a clean client, then compare results? Or am I
> misunderstanding, and FSTYP=cifs is taking care of it?

That's a really good question.  We have a pre-defined list of tests that
get run by a specfic SMB version, server, if multichannel, etc.

Steve might send you the list of pre-defined tests that get run on our
buildbot so you can try it out.  He usually keeps those lists
up-to-date.

Re: SMB client testing wiki

[Tom Talpey]

On 8/26/2022 12:01 PM, Paulo Alcantara wrote:
> Tom Talpey <tom@talpey.com> writes:
> 
>> Easy enough! How do I know if it "passes" though? My understanding
>> is that a bunch of tests are expected to fail, or at least warn.
>> Do I need to test a clean client, then compare results? Or am I
>> misunderstanding, and FSTYP=cifs is taking care of it?
> 
> That's a really good question.  We have a pre-defined list of tests that
> get run by a specfic SMB version, server, if multichannel, etc.

Yeah, there are a few exclusion files on the wiki, but they look
really old. Also, I cannot believe that "vers=3.0" is the proper
default, as linked there!!!

> Steve might send you the list of pre-defined tests that get run on our
> buildbot so you can try it out.  He usually keeps those lists
> up-to-date.

The buildbot doesn't do RDMA, or I'd consider that. But it's a lot
more convenient to have a local harness either way.

Thanks!

Tom.

Re: SMB client testing wiki

[Paulo Alcantara]

Tom Talpey <tom@talpey.com> writes:

>
> On 8/26/2022 12:01 PM, Paulo Alcantara wrote:
>> Tom Talpey <tom@talpey.com> writes:
>> 
>>> Easy enough! How do I know if it "passes" though? My understanding
>>> is that a bunch of tests are expected to fail, or at least warn.
>>> Do I need to test a clean client, then compare results? Or am I
>>> misunderstanding, and FSTYP=cifs is taking care of it?
>> 
>> That's a really good question.  We have a pre-defined list of tests that
>> get run by a specfic SMB version, server, if multichannel, etc.
>
> Yeah, there are a few exclusion files on the wiki, but they look
> really old. Also, I cannot believe that "vers=3.0" is the proper
> default, as linked there!!!

Yeah :-(  We should definitely update it.

>> Steve might send you the list of pre-defined tests that get run on our
>> buildbot so you can try it out.  He usually keeps those lists
>> up-to-date.
>
> The buildbot doesn't do RDMA, or I'd consider that. But it's a lot
> more convenient to have a local harness either way.

It currently doesn't, unfortunately.  You could at least get the same
set of tests that run over 3.1.1 against samba and/or ksmbd and then
change mount options to get RDMA enabled.  And of course, let us know
when you get it working and let's add it to our buildbot as well ;-)

Re: SMB client testing wiki

[Tom Talpey]

Well ok, but my question is really about what to run and how to
be sure I'm not breaking anything. I want to test my SMB Direct
patch(es) so I'd focus on 3.1.1.

Or, can I say "it didn't oops, ship it"? :)

Tom.

On 8/26/2022 11:19 AM, Steve French wrote:
> Nite that vers=3.0 can be much slower in some cases (like encryption) 
> than default (or default for version 3 or higher ie vers=3 or vers=3.1.1)
> 
> On Fri, Aug 26, 2022, 09:55 Paulo Alcantara <pc@cjr.nz 
> <mailto:pc@cjr.nz>> wrote:
> 
>     Tom Talpey <tom@talpey.com <mailto:tom@talpey.com>> writes:
> 
>      > Is there an updated list of tests expected to pass, and/or
>      > any update for the scripting? Anything else I need to run in
>      > a basic local environment, to test smb3.ko client to ksmbd.ko
>      > and Samba servers on a pair of test machines?
> 
>     For the testing environment, I'd say there is nothing special.  Just
>     create two shares in both samba and ksmbd servers and specify them in
>     local.config when running xfstests.  We usually name them as 'test' and
>     'scratch', respectively.
> 
>     For testing SMB3 over samba, you would have something like this in your
>     local.config:
> 
>        [smb3samba]
>        FSTYP=cifs
>        TEST_DEV=//tom.samba/test
>        TEST_DIR=/mnt/test
>       
>     TEST_FS_MOUNT_OPTS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
>        export
>     MOUNT_OPTIONS='-ousername=tom,password=***,noperm,vers=3.0,mfsymlinks'
>        export SCRATCH_DEV=//tom.samba/scratch
>        export SCRATCH_MNT=/mnt/scratch
> 
>     and then run xfstests
> 
>        ./check -s smb3samba ...
>