From: Michael Ellerman <mpe@ellerman.id.au>
To: Nick Desaulniers <ndesaulniers@google.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: Christophe Leroy <christophe.leroy@c-s.fr>,
Michael Ellerman <patch-notifications@ellerman.id.au>,
LKML <linux-kernel@vger.kernel.org>,
Nicholas Piggin <npiggin@gmail.com>,
clang-built-linux <clang-built-linux@googlegroups.com>,
Paul Mackerras <paulus@samba.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto'
Date: Sat, 13 Jun 2020 20:47:11 +1000 [thread overview]
Message-ID: <87366zfdjk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAKwvOdkKywb1KZ-SDwwuvQEmbsaAzJj9mEPqVG=qw1F5Ogv8rw@mail.gmail.com>
Nick Desaulniers <ndesaulniers@google.com> writes:
> On Thu, Jun 11, 2020 at 4:53 PM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
>>
>> On Thu, Jun 11, 2020 at 03:43:55PM -0700, Nick Desaulniers wrote:
>> > Segher, Cristophe, I suspect Clang is missing support for the %L and %U
>> > output templates [1].
...
>
> IIUC the bug report correctly, it looks like LLVM is failing for the
> __put_user_asm2_goto case for -m32. A simple reproducer:
> https://godbolt.org/z/jBBF9b
If you add `-mregnames` you get register names:
https://godbolt.org/z/MxLjhF
foo:
stw %r3, 0(%r5)
stw %r4, 4(%r5)
blr
cheers
WARNING: multiple messages have this Message-ID (diff)
From: Michael Ellerman <mpe@ellerman.id.au>
To: Nick Desaulniers <ndesaulniers@google.com>,
Segher Boessenkool <segher@kernel.crashing.org>
Cc: Michael Ellerman <patch-notifications@ellerman.id.au>,
Christophe Leroy <christophe.leroy@c-s.fr>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
LKML <linux-kernel@vger.kernel.org>,
linuxppc-dev <linuxppc-dev@lists.ozlabs.org>,
Nicholas Piggin <npiggin@gmail.com>,
Paul Mackerras <paulus@samba.org>,
clang-built-linux <clang-built-linux@googlegroups.com>
Subject: Re: [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto'
Date: Sat, 13 Jun 2020 20:47:11 +1000 [thread overview]
Message-ID: <87366zfdjk.fsf@mpe.ellerman.id.au> (raw)
In-Reply-To: <CAKwvOdkKywb1KZ-SDwwuvQEmbsaAzJj9mEPqVG=qw1F5Ogv8rw@mail.gmail.com>
Nick Desaulniers <ndesaulniers@google.com> writes:
> On Thu, Jun 11, 2020 at 4:53 PM Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
>>
>> On Thu, Jun 11, 2020 at 03:43:55PM -0700, Nick Desaulniers wrote:
>> > Segher, Cristophe, I suspect Clang is missing support for the %L and %U
>> > output templates [1].
...
>
> IIUC the bug report correctly, it looks like LLVM is failing for the
> __put_user_asm2_goto case for -m32. A simple reproducer:
> https://godbolt.org/z/jBBF9b
If you add `-mregnames` you get register names:
https://godbolt.org/z/MxLjhF
foo:
stw %r3, 0(%r5)
stw %r4, 4(%r5)
blr
cheers
next prev parent reply other threads:[~2020-06-13 10:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-17 17:08 [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Christophe Leroy
2020-04-17 17:08 ` Christophe Leroy
2020-04-17 17:08 ` [PATCH v4 2/2] powerpc/uaccess: Implement unsafe_copy_to_user() as a simple loop Christophe Leroy
2020-04-17 17:08 ` Christophe Leroy
2020-05-29 4:24 ` Michael Ellerman
2020-05-05 14:27 ` [PATCH v4 1/2] powerpc/uaccess: Implement unsafe_put_user() using 'asm goto' Michael Ellerman
2020-05-05 14:27 ` Michael Ellerman
2020-05-05 15:32 ` Segher Boessenkool
2020-05-05 15:32 ` Segher Boessenkool
2020-05-06 0:58 ` Michael Ellerman
2020-05-06 0:58 ` Michael Ellerman
2020-05-06 17:58 ` Segher Boessenkool
2020-05-06 17:58 ` Segher Boessenkool
2020-05-06 18:10 ` Christophe Leroy
2020-05-06 18:10 ` Christophe Leroy
2020-05-06 22:18 ` Segher Boessenkool
2020-05-06 22:18 ` Segher Boessenkool
2020-05-05 15:40 ` Christophe Leroy
2020-05-05 15:40 ` Christophe Leroy
2020-05-05 15:59 ` Segher Boessenkool
2020-05-05 15:59 ` Segher Boessenkool
2020-05-06 1:36 ` Michael Ellerman
2020-05-06 1:36 ` Michael Ellerman
2020-05-06 18:09 ` Segher Boessenkool
2020-05-06 18:09 ` Segher Boessenkool
2020-05-29 4:24 ` Michael Ellerman
2020-06-11 22:43 ` Nick Desaulniers
2020-06-11 22:43 ` Nick Desaulniers
2020-06-11 23:52 ` Segher Boessenkool
2020-06-11 23:52 ` Segher Boessenkool
2020-06-12 21:33 ` Nick Desaulniers
2020-06-12 21:33 ` Nick Desaulniers
2020-06-13 1:08 ` Segher Boessenkool
2020-06-13 1:08 ` Segher Boessenkool
2020-06-13 6:46 ` Christophe Leroy
2020-06-13 6:46 ` Christophe Leroy
2020-06-13 10:47 ` Michael Ellerman [this message]
2020-06-13 10:47 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87366zfdjk.fsf@mpe.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=christophe.leroy@c-s.fr \
--cc=clang-built-linux@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=ndesaulniers@google.com \
--cc=npiggin@gmail.com \
--cc=patch-notifications@ellerman.id.au \
--cc=paulus@samba.org \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.