All of lore.kernel.org
 help / color / mirror / Atom feed
From: Eric Anholt <eric@anholt.net>
To: Helen Koike <helen.koike@collabora.com>
Cc: stefan.wahren@i2se.com, devicetree@vger.kernel.org,
	linus.walleij@linaro.org, linux-kernel@vger.kernel.org,
	lkundrak@v3.sk, bcm-kernel-feedback-list@broadcom.com,
	linux-rpi-kernel@lists.infradead.org, kernel@collabora.com,
	linux-arm-kernel@lists.infradead.org
Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Date: Mon, 04 Mar 2019 12:27:11 -0800	[thread overview]
Message-ID: <8736o2tmg0.fsf@anholt.net> (raw)
In-Reply-To: <20190304185454.18043-1-helen.koike@collabora.com>


[-- Attachment #1.1: Type: text/plain, Size: 806 bytes --]

Helen Koike <helen.koike@collabora.com> writes:

> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.

We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts
agrees.

Reviewed-by: Eric Anholt <eric@anholt.net>

Thanks!  If Stefan doesn't pick this up shortly, I can.

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Helen Koike <helen.koike@collabora.com>
Cc: linux-rpi-kernel@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, stefan.wahren@i2se.com,
	linus.walleij@linaro.org, lkundrak@v3.sk,
	bcm-kernel-feedback-list@broadcom.com,
	devicetree@vger.kernel.org, kernel@collabora.com
Subject: Re: rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts
Date: Mon, 04 Mar 2019 12:27:11 -0800	[thread overview]
Message-ID: <8736o2tmg0.fsf@anholt.net> (raw)
In-Reply-To: <20190304185454.18043-1-helen.koike@collabora.com>

[-- Attachment #1: Type: text/plain, Size: 806 bytes --]

Helen Koike <helen.koike@collabora.com> writes:

> Hello,
>
> I have a rpi-b-rev2 (two holes, 512M) and when I was trying to test vc4
> driver, the HDMI wans't being detected.
>
> So I changed the hpd-gpios from ACTIVE_LOW to ACTIVE_HIGH and now it
> works correctly. I can see that modeprint from libdrm detects correctly
> when the display is plugged and when it is unpluggled.
>
> So I was wondering if this is just in my board or if there is an error
> in the dts (which I think it's unlikely).
>
> In any case I am dropping this email here in case anyone else see this
> problem, if you do, try appliying the patch below.

We even have the GPIO labeled as "HDMI_HPD_P" above, and dt-blob.dts
agrees.

Reviewed-by: Eric Anholt <eric@anholt.net>

Thanks!  If Stefan doesn't pick this up shortly, I can.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

  parent reply	other threads:[~2019-03-04 20:27 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-04 18:54 rpi-b-rev2 can't detect hdmi display due to wrong hpd gpio pull in dts Helen Koike
2019-03-04 18:54 ` Helen Koike
2019-03-04 20:15 ` Stefan Wahren
2019-03-04 20:15   ` Stefan Wahren
2019-03-04 21:52   ` Helen Koike
2019-03-04 21:52     ` Helen Koike
2019-03-04 20:27 ` Eric Anholt [this message]
2019-03-04 20:27   ` Eric Anholt
2019-03-04 21:54   ` Helen Koike
2019-03-04 21:54     ` Helen Koike

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=8736o2tmg0.fsf@anholt.net \
    --to=eric@anholt.net \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=devicetree@vger.kernel.org \
    --cc=helen.koike@collabora.com \
    --cc=kernel@collabora.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=lkundrak@v3.sk \
    --cc=stefan.wahren@i2se.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.