From: Eric Anholt <eric@anholt.net>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Vaishali Thakkar <vthakkar1994@gmail.com>
Subject: Re: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static
Date: Mon, 30 Apr 2018 14:04:11 -0700 [thread overview]
Message-ID: <8736zce790.fsf@anholt.net> (raw)
In-Reply-To: <20180425070953.17933-1-vthakkar1994@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Vaishali Thakkar <vthakkar1994@gmail.com> writes:
> Sparse complains with following warning:
> drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol
> 'vc4_allocate_bin_bo' was not declared. Should it be static?
>
> Make vc4_allocate_bin static as it is not used outside of
> vc4_v3d.c.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied to drm-misc-next. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Vaishali Thakkar <vthakkar1994@gmail.com>
Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org,
Vaishali Thakkar <vthakkar1994@gmail.com>
Subject: Re: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static
Date: Mon, 30 Apr 2018 14:04:11 -0700 [thread overview]
Message-ID: <8736zce790.fsf@anholt.net> (raw)
In-Reply-To: <20180425070953.17933-1-vthakkar1994@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 384 bytes --]
Vaishali Thakkar <vthakkar1994@gmail.com> writes:
> Sparse complains with following warning:
> drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol
> 'vc4_allocate_bin_bo' was not declared. Should it be static?
>
> Make vc4_allocate_bin static as it is not used outside of
> vc4_v3d.c.
>
> Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com>
Applied to drm-misc-next. Thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-04-30 21:04 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-25 7:09 [PATCH] drm/vc4: make function vc4_allocate_bin_bo static Vaishali Thakkar
2018-04-30 21:04 ` Eric Anholt [this message]
2018-04-30 21:04 ` Eric Anholt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8736zce790.fsf@anholt.net \
--to=eric@anholt.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vthakkar1994@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.