* [PATCH] drm/vc4: make function vc4_allocate_bin_bo static @ 2018-04-25 7:09 Vaishali Thakkar 2018-04-30 21:04 ` Eric Anholt 0 siblings, 1 reply; 3+ messages in thread From: Vaishali Thakkar @ 2018-04-25 7:09 UTC (permalink / raw) To: eric; +Cc: dri-devel, linux-kernel, Vaishali Thakkar Sparse complains with following warning: drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol 'vc4_allocate_bin_bo' was not declared. Should it be static? Make vc4_allocate_bin static as it is not used outside of vc4_v3d.c. Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> --- drivers/gpu/drm/vc4/vc4_v3d.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index bfc2fa73d2ae..e47e29426078 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -218,8 +218,7 @@ int vc4_v3d_get_bin_slot(struct vc4_dev *vc4) * overall CMA pool before they make scenes complicated enough to run * out of bin space. */ -int -vc4_allocate_bin_bo(struct drm_device *drm) +static int vc4_allocate_bin_bo(struct drm_device *drm) { struct vc4_dev *vc4 = to_vc4_dev(drm); struct vc4_v3d *v3d = vc4->v3d; -- 2.14.1 ^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static 2018-04-25 7:09 [PATCH] drm/vc4: make function vc4_allocate_bin_bo static Vaishali Thakkar @ 2018-04-30 21:04 ` Eric Anholt 0 siblings, 0 replies; 3+ messages in thread From: Eric Anholt @ 2018-04-30 21:04 UTC (permalink / raw) Cc: dri-devel, linux-kernel, Vaishali Thakkar [-- Attachment #1: Type: text/plain, Size: 384 bytes --] Vaishali Thakkar <vthakkar1994@gmail.com> writes: > Sparse complains with following warning: > drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol > 'vc4_allocate_bin_bo' was not declared. Should it be static? > > Make vc4_allocate_bin static as it is not used outside of > vc4_v3d.c. > > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Applied to drm-misc-next. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] drm/vc4: make function vc4_allocate_bin_bo static @ 2018-04-30 21:04 ` Eric Anholt 0 siblings, 0 replies; 3+ messages in thread From: Eric Anholt @ 2018-04-30 21:04 UTC (permalink / raw) To: Vaishali Thakkar; +Cc: dri-devel, linux-kernel, Vaishali Thakkar [-- Attachment #1: Type: text/plain, Size: 384 bytes --] Vaishali Thakkar <vthakkar1994@gmail.com> writes: > Sparse complains with following warning: > drivers/gpu/drm/vc4/vc4_v3d.c:222:1: warning: symbol > 'vc4_allocate_bin_bo' was not declared. Should it be static? > > Make vc4_allocate_bin static as it is not used outside of > vc4_v3d.c. > > Signed-off-by: Vaishali Thakkar <vthakkar1994@gmail.com> Applied to drm-misc-next. Thanks! [-- Attachment #2: signature.asc --] [-- Type: application/pgp-signature, Size: 832 bytes --] ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-04-30 21:04 UTC | newest] Thread overview: 3+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-04-25 7:09 [PATCH] drm/vc4: make function vc4_allocate_bin_bo static Vaishali Thakkar 2018-04-30 21:04 ` Eric Anholt 2018-04-30 21:04 ` Eric Anholt
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.