From: Kevin Hilman <khilman@ti.com>
To: "Menon, Nishanth" <nm@ti.com>
Cc: Shweta Gulati <shweta.gulati@ti.com>,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
Date: Wed, 16 Mar 2011 08:35:18 -0700 [thread overview]
Message-ID: <8739mngjt5.fsf@ti.com> (raw)
In-Reply-To: <AANLkTinympnok4Qw_n15ukDNE2L5yp9xvuhoP64B=2wJ@mail.gmail.com> (Nishanth Menon's message of "Tue, 15 Mar 2011 10:48:37 +0530")
"Menon, Nishanth" <nm@ti.com> writes:
> On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
>> OMAP4 has two different Devices IVA and DSP. DSP is bound
>> with IVA for DVFS. The registration of IVA dev in API
>> 'omap2_init_processor_devices' was missing. Init dev for
>> 'iva_dev' is added.
>>
>> This also fixes the following error seen during boot as
>> omap2_set_init_voltage can now find the iva device
>>
>> omap2_set_init_voltage: Invalid parameters!
>> omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>>
>> Tested on OMAP4430 SDP Board.
>> Baseline:
>> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>> Branch :pm-core
>>
>> V2:
>> Rephrased the Commit log.
>>
>> arch/arm/mach-omap2/pm.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
>> index 30af335..49486f5 100644
>> --- a/arch/arm/mach-omap2/pm.c
>> +++ b/arch/arm/mach-omap2/pm.c
>> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
>> if (cpu_is_omap44xx()) {
>> _init_omap_device("l3_main_1", &l3_dev);
>> _init_omap_device("dsp", &dsp_dev);
>> + _init_omap_device("iva", &iva_dev);
>> } else {
>> _init_omap_device("l3_main", &l3_dev);
>> }
>> --
> Looks fine to me.
Thanks, I'll take this as an ack.
Will queue as a fix for the .39-rc fixes cycle.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
Date: Wed, 16 Mar 2011 08:35:18 -0700 [thread overview]
Message-ID: <8739mngjt5.fsf@ti.com> (raw)
In-Reply-To: <AANLkTinympnok4Qw_n15ukDNE2L5yp9xvuhoP64B=2wJ@mail.gmail.com> (Nishanth Menon's message of "Tue, 15 Mar 2011 10:48:37 +0530")
"Menon, Nishanth" <nm@ti.com> writes:
> On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
>> OMAP4 has two different Devices IVA and DSP. DSP is bound
>> with IVA for DVFS. The registration of IVA dev in API
>> 'omap2_init_processor_devices' was missing. Init dev for
>> 'iva_dev' is added.
>>
>> This also fixes the following error seen during boot as
>> omap2_set_init_voltage can now find the iva device
>>
>> ? ? ? ?omap2_set_init_voltage: Invalid parameters!
>> ? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>>
>> Tested on OMAP4430 SDP Board.
>> Baseline:
>> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>> Branch :pm-core
>>
>> V2:
>> Rephrased the Commit log.
>>
>> ?arch/arm/mach-omap2/pm.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
>> index 30af335..49486f5 100644
>> --- a/arch/arm/mach-omap2/pm.c
>> +++ b/arch/arm/mach-omap2/pm.c
>> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
>> ? ? ? ?if (cpu_is_omap44xx()) {
>> ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev);
>> ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev);
>> + ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev);
>> ? ? ? ?} else {
>> ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev);
>> ? ? ? ?}
>> --
> Looks fine to me.
Thanks, I'll take this as an ack.
Will queue as a fix for the .39-rc fixes cycle.
Kevin
next prev parent reply other threads:[~2011-03-16 15:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-03-12 10:39 [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device Shweta Gulati
2011-03-12 10:39 ` Shweta Gulati
2011-03-15 5:18 ` Menon, Nishanth
2011-03-15 5:18 ` Menon, Nishanth
2011-03-16 15:35 ` Kevin Hilman [this message]
2011-03-16 15:35 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8739mngjt5.fsf@ti.com \
--to=khilman@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=nm@ti.com \
--cc=shweta.gulati@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.