* [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
@ 2011-03-12 10:39 ` Shweta Gulati
0 siblings, 0 replies; 6+ messages in thread
From: Shweta Gulati @ 2011-03-12 10:39 UTC (permalink / raw)
To: linux-omap; +Cc: linux-arm-kernel, Shweta Gulati
OMAP4 has two different Devices IVA and DSP. DSP is bound
with IVA for DVFS. The registration of IVA dev in API
'omap2_init_processor_devices' was missing. Init dev for
'iva_dev' is added.
This also fixes the following error seen during boot as
omap2_set_init_voltage can now find the iva device
omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
---
Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core
V2:
Rephrased the Commit log.
arch/arm/mach-omap2/pm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 30af335..49486f5 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
if (cpu_is_omap44xx()) {
_init_omap_device("l3_main_1", &l3_dev);
_init_omap_device("dsp", &dsp_dev);
+ _init_omap_device("iva", &iva_dev);
} else {
_init_omap_device("l3_main", &l3_dev);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
@ 2011-03-12 10:39 ` Shweta Gulati
0 siblings, 0 replies; 6+ messages in thread
From: Shweta Gulati @ 2011-03-12 10:39 UTC (permalink / raw)
To: linux-arm-kernel
OMAP4 has two different Devices IVA and DSP. DSP is bound
with IVA for DVFS. The registration of IVA dev in API
'omap2_init_processor_devices' was missing. Init dev for
'iva_dev' is added.
This also fixes the following error seen during boot as
omap2_set_init_voltage can now find the iva device
omap2_set_init_voltage: Invalid parameters!
omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
---
Tested on OMAP4430 SDP Board.
Baseline:
http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
Branch :pm-core
V2:
Rephrased the Commit log.
arch/arm/mach-omap2/pm.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
index 30af335..49486f5 100644
--- a/arch/arm/mach-omap2/pm.c
+++ b/arch/arm/mach-omap2/pm.c
@@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
if (cpu_is_omap44xx()) {
_init_omap_device("l3_main_1", &l3_dev);
_init_omap_device("dsp", &dsp_dev);
+ _init_omap_device("iva", &iva_dev);
} else {
_init_omap_device("l3_main", &l3_dev);
}
--
1.7.0.4
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
2011-03-12 10:39 ` Shweta Gulati
@ 2011-03-15 5:18 ` Menon, Nishanth
-1 siblings, 0 replies; 6+ messages in thread
From: Menon, Nishanth @ 2011-03-15 5:18 UTC (permalink / raw)
To: Shweta Gulati; +Cc: linux-omap, linux-arm-kernel
On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
> OMAP4 has two different Devices IVA and DSP. DSP is bound
> with IVA for DVFS. The registration of IVA dev in API
> 'omap2_init_processor_devices' was missing. Init dev for
> 'iva_dev' is added.
>
> This also fixes the following error seen during boot as
> omap2_set_init_voltage can now find the iva device
>
> omap2_set_init_voltage: Invalid parameters!
> omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>
> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
> ---
>
> Tested on OMAP4430 SDP Board.
> Baseline:
> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
> Branch :pm-core
>
> V2:
> Rephrased the Commit log.
>
> arch/arm/mach-omap2/pm.c | 1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index 30af335..49486f5 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
> if (cpu_is_omap44xx()) {
> _init_omap_device("l3_main_1", &l3_dev);
> _init_omap_device("dsp", &dsp_dev);
> + _init_omap_device("iva", &iva_dev);
> } else {
> _init_omap_device("l3_main", &l3_dev);
> }
> --
Looks fine to me.
Regards,
Nishanth Menon
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
@ 2011-03-15 5:18 ` Menon, Nishanth
0 siblings, 0 replies; 6+ messages in thread
From: Menon, Nishanth @ 2011-03-15 5:18 UTC (permalink / raw)
To: linux-arm-kernel
On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
> OMAP4 has two different Devices IVA and DSP. DSP is bound
> with IVA for DVFS. The registration of IVA dev in API
> 'omap2_init_processor_devices' was missing. Init dev for
> 'iva_dev' is added.
>
> This also fixes the following error seen during boot as
> omap2_set_init_voltage can now find the iva device
>
> ? ? ? ?omap2_set_init_voltage: Invalid parameters!
> ? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>
> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
> ---
>
> Tested on OMAP4430 SDP Board.
> Baseline:
> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
> Branch :pm-core
>
> V2:
> Rephrased the Commit log.
>
> ?arch/arm/mach-omap2/pm.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
> index 30af335..49486f5 100644
> --- a/arch/arm/mach-omap2/pm.c
> +++ b/arch/arm/mach-omap2/pm.c
> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
> ? ? ? ?if (cpu_is_omap44xx()) {
> ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev);
> ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev);
> + ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev);
> ? ? ? ?} else {
> ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev);
> ? ? ? ?}
> --
Looks fine to me.
Regards,
Nishanth Menon
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
2011-03-15 5:18 ` Menon, Nishanth
@ 2011-03-16 15:35 ` Kevin Hilman
-1 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2011-03-16 15:35 UTC (permalink / raw)
To: Menon, Nishanth; +Cc: Shweta Gulati, linux-omap, linux-arm-kernel
"Menon, Nishanth" <nm@ti.com> writes:
> On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
>> OMAP4 has two different Devices IVA and DSP. DSP is bound
>> with IVA for DVFS. The registration of IVA dev in API
>> 'omap2_init_processor_devices' was missing. Init dev for
>> 'iva_dev' is added.
>>
>> This also fixes the following error seen during boot as
>> omap2_set_init_voltage can now find the iva device
>>
>> omap2_set_init_voltage: Invalid parameters!
>> omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>>
>> Tested on OMAP4430 SDP Board.
>> Baseline:
>> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>> Branch :pm-core
>>
>> V2:
>> Rephrased the Commit log.
>>
>> arch/arm/mach-omap2/pm.c | 1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
>> index 30af335..49486f5 100644
>> --- a/arch/arm/mach-omap2/pm.c
>> +++ b/arch/arm/mach-omap2/pm.c
>> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
>> if (cpu_is_omap44xx()) {
>> _init_omap_device("l3_main_1", &l3_dev);
>> _init_omap_device("dsp", &dsp_dev);
>> + _init_omap_device("iva", &iva_dev);
>> } else {
>> _init_omap_device("l3_main", &l3_dev);
>> }
>> --
> Looks fine to me.
Thanks, I'll take this as an ack.
Will queue as a fix for the .39-rc fixes cycle.
Kevin
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device.
@ 2011-03-16 15:35 ` Kevin Hilman
0 siblings, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2011-03-16 15:35 UTC (permalink / raw)
To: linux-arm-kernel
"Menon, Nishanth" <nm@ti.com> writes:
> On Sat, Mar 12, 2011 at 16:09, Shweta Gulati <shweta.gulati@ti.com> wrote:
>> OMAP4 has two different Devices IVA and DSP. DSP is bound
>> with IVA for DVFS. The registration of IVA dev in API
>> 'omap2_init_processor_devices' was missing. Init dev for
>> 'iva_dev' is added.
>>
>> This also fixes the following error seen during boot as
>> omap2_set_init_voltage can now find the iva device
>>
>> ? ? ? ?omap2_set_init_voltage: Invalid parameters!
>> ? ? ? ?omap2_set_init_voltage: Unable to put vdd_iva to its init voltage
>>
>> Signed-off-by: Shweta Gulati <shweta.gulati@ti.com>
>> ---
>>
>> Tested on OMAP4430 SDP Board.
>> Baseline:
>> http://git.kernel.org/pub/scm/linux/kernel/git/khilman/linux-omap-pm.git
>> Branch :pm-core
>>
>> V2:
>> Rephrased the Commit log.
>>
>> ?arch/arm/mach-omap2/pm.c | ? ?1 +
>> ?1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/mach-omap2/pm.c b/arch/arm/mach-omap2/pm.c
>> index 30af335..49486f5 100644
>> --- a/arch/arm/mach-omap2/pm.c
>> +++ b/arch/arm/mach-omap2/pm.c
>> @@ -89,6 +89,7 @@ static void omap2_init_processor_devices(void)
>> ? ? ? ?if (cpu_is_omap44xx()) {
>> ? ? ? ? ? ? ? ?_init_omap_device("l3_main_1", &l3_dev);
>> ? ? ? ? ? ? ? ?_init_omap_device("dsp", &dsp_dev);
>> + ? ? ? ? ? ? ? _init_omap_device("iva", &iva_dev);
>> ? ? ? ?} else {
>> ? ? ? ? ? ? ? ?_init_omap_device("l3_main", &l3_dev);
>> ? ? ? ?}
>> --
> Looks fine to me.
Thanks, I'll take this as an ack.
Will queue as a fix for the .39-rc fixes cycle.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-03-16 15:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-03-12 10:39 [PATCH V2] OMAP4: Intialize IVA Device in addition to DSP device Shweta Gulati
2011-03-12 10:39 ` Shweta Gulati
2011-03-15 5:18 ` Menon, Nishanth
2011-03-15 5:18 ` Menon, Nishanth
2011-03-16 15:35 ` Kevin Hilman
2011-03-16 15:35 ` Kevin Hilman
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.