[PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy

[PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy

[Petr Rockai]

Hi,

I'm attaching a draft version of basic configuration capability for automatic
mirror repairs. This will make dmeventd respect the two lvm.conf options
setting failed mirror replacement policies. It doesn't affect the basic
(manual) lvconvert --repair mode (I have added --auto for that purpose; it
might need a better name though).

Please note that the patch is untested yet, but I'd like to get feedback
anyway. Thanks!

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-repair-auto.diff
Type: text/x-diff
Size: 4768 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090521/8df90306/attachment.bin>
-------------- next part --------------

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation

[PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy

[Jonathan Brassow]

On May 21, 2009, at 10:20 AM, Petr Rockai wrote:

> I'm attaching a draft version of basic configuration capability for  
> automatic
> mirror repairs. This will make dmeventd respect the two lvm.conf  
> options
> setting failed mirror replacement policies. It doesn't affect the  
> basic
> (manual) lvconvert --repair mode (I have added --auto for that  
> purpose; it
> might need a better name though).

I like this better.  (Agree that we need different name than '--auto'.)

thanks,
  brassow

[PATCH] [draft] add lvconvert --repair --auto that honours lvm.conf mirror policy

[Petr Rockai]

Hi again,

I have now tested the patch, and following is (obviously) also needed to make
it work. Other than that, everything seems to work as expected (most
importantly, the mirror_device_fault_policy is obeyed by dmeventd).

The missing patch bit:

===================================================================
RCS file: /cvs/lvm2/LVM2/tools/commands.h,v
retrieving revision 1.125
diff -u -p -r1.125 commands.h
--- tools/commands.h	25 Apr 2009 01:18:00 -0000	1.125
+++ tools/commands.h	23 May 2009 09:31:29 -0000
@@ -94,7 +94,7 @@ xx(lvconvert,
    0,
    "lvconvert "
    "[-m|--mirrors Mirrors [{--mirrorlog {disk|core}|--corelog}]]\n"
-   "\t[--repair]\n"
+   "\t[--repair [--auto]]\n"
    "\t[-R|--regionsize MirrorLogRegionSize]\n"
    "\t[--alloc AllocationPolicy]\n"
    "\t[-b|--background]\n"
@@ -116,8 +116,8 @@ xx(lvconvert,
    "\tOriginalLogicalVolume[Path] SnapshotLogicalVolume[Path]\n",
 
    alloc_ARG, background_ARG, chunksize_ARG, corelog_ARG, interval_ARG,
-   mirrorlog_ARG, mirrors_ARG, regionsize_ARG, repair_ARG, snapshot_ARG,
-   test_ARG, zero_ARG)
+   mirrorlog_ARG, mirrors_ARG, regionsize_ARG, repair_ARG, auto_ARG,
+   snapshot_ARG, test_ARG, zero_ARG)
 
 xx(lvcreate,
    "Create a logical volume",

Is this version OK to commit, then? (Better option names than --repair --auto
are still solicited, but probably not such a high priority anyway...)

Yours,
   Petr.

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation

[PATCH] lvconvert --repair prompts and policies

[Petr Rockai]

Hi,

this is a new iteration of the patch, that hopefully addresses everyone's
concerns. For "normal" use (manual), it will prompt whether replacement of
devices is desired, with -y and -f to select yes and no respectively. Moreover,
--use-policies is provided that will read and use the lvm.conf mirror policy
settings.

We use --use-policies for dmeventd.

Yours,
   Petr.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: lvconvert-repair-policies.diff
Type: text/x-diff
Size: 8138 bytes
Desc: not available
URL: <http://listman.redhat.com/archives/lvm-devel/attachments/20090602/d6471f13/attachment.bin>
-------------- next part --------------

-- 
Peter Rockai | me()mornfall!net | prockai()redhat!com
 http://blog.mornfall.net | http://web.mornfall.net

"In My Egotistical Opinion, most people's C programs should be
 indented six feet downward and covered with dirt."
     -- Blair P. Houghton on the subject of C program indentation