Re: [ppc] [patch] more cleanups

[Marco Gerards <metgerards@student.han.nl>]

Hollis Blanchard <hollis@penguinppc.org> writes:

> I've found a few more things that needed cleaning, so here is the
> updated patch. I have tested it.

It looks fine to me.  I have a few questions:

> 	(grub_ieee1275_next_property): Likewise. Change type of first argument
> 	to grub_ieee1275_phandle_t.

Please use double spaces.

> --- include/grub/powerpc/ieee1275/kernel.h	4 Jan 2005 14:01:45 -0000	1.1
> +++ include/grub/powerpc/ieee1275/kernel.h	10 May 2005 01:27:36 -0000
> @@ -21,6 +21,6 @@
>  #define GRUB_KERNEL_MACHINE_HEADER	1
>  
>  /* Where grub-mkimage places the core modules in memory.  */
> -#define GRUB_IEEE1275_MODULE_BASE 0x0300000
> +#define GRUB_IEEE1275_MODULE_BASE 0x00300000

Huh? Can you explain this?  I would even prefer:

#define GRUB_IEEE1275_MODULE_BASE 0x300000

> Index: loader/powerpc/ieee1275/linux.c

[...]

> -      initrd_addr = 0xc0000000;
> +      initrd_addr = 0;

Does loading linux with an initrd still work?

Thanks,
Marco