From: Marco Gerards <metgerards@student.han.nl>
To: The development of GRUB 2 <grub-devel@gnu.org>
Subject: Re: [ppc] [patch] more cleanups
Date: Wed, 11 May 2005 08:37:27 +0200 [thread overview]
Message-ID: <87zmv2clp4.fsf@student.han.nl> (raw)
In-Reply-To: <be21309862846e2079e1aff6a630ff77@penguinppc.org> (Hollis Blanchard's message of "Tue, 10 May 2005 17:34:02 -0500")
Hollis Blanchard <hollis@penguinppc.org> writes:
>>> /* Where grub-mkimage places the core modules in memory. */
>>> -#define GRUB_IEEE1275_MODULE_BASE 0x0300000
>>> +#define GRUB_IEEE1275_MODULE_BASE 0x00300000
>>
>> Huh? Can you explain this? I would even prefer:
>>
>> #define GRUB_IEEE1275_MODULE_BASE 0x300000
>
> What is to explain? The address has 7 chars in it when it should have
> 8. The leading zeroes make it easier to read.
Ok, that makes sense.
>> Does loading linux with an initrd still work?
>
> I said it did...
I must have missed that, sorry.
Feel free to commit your patch.
Thanks,
Marco
prev parent reply other threads:[~2005-05-11 6:44 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-10 1:39 [ppc] [patch] more cleanups Hollis Blanchard
2005-05-10 18:01 ` Marco Gerards
2005-05-10 22:34 ` Hollis Blanchard
2005-05-11 6:37 ` Marco Gerards [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87zmv2clp4.fsf@student.han.nl \
--to=metgerards@student.han.nl \
--cc=grub-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.