From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Frank.Rowand@sony.com, David Airlie <airlied@linux.ie>,
niklas.soderlund+renesas@ragnatech.se,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>
Subject: Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build
Date: Tue, 20 Mar 2018 15:15:37 +0200 [thread overview]
Message-ID: <8748007.hiNNEuVPPY@avalon> (raw)
In-Reply-To: <CAK8P3a0kEqZ265bG+S7JWgR47A_H2QjAT_+v+AKrFab+wN6AQg@mail.gmail.com>
Hi Arnd,
On Friday, 16 March 2018 10:25:25 EET Arnd Bergmann wrote:
> On Fri, Mar 16, 2018 at 2:39 AM, <Frank.Rowand@sony.com> wrote:
> > On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann wrote:
> >> The *.dtb and *.dtb.S files get removed by 'make' during the build
> >> process,
> >> and later seem to be missed during the 'modpost' stage:
> >>
> >> rm drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb.S
> >> WARNING: could not open
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S: No such file or
> >> directory
> >>
> >> As a workaround, this adds all those files to the 'extra-y' target list,
> >> but that's really ugly. Any ideas for a better fix?
> >
> > Does this work for you (untested, but the way it is done in
> > drivers/of/unittest-data/Makefile):
> >
> > .PRECIOUS: \
> >
> > $(obj)/%.dtb.S \
> > $(obj)/%.dtb
>
> Yes, that works and looks much better than my version.
Thank you for your patch, and sorry for breaking the build. Do you plan to
submit a new version based on Frank's approach ?
--
Regards,
Laurent Pinchart
WARNING: multiple messages have this Message-ID (diff)
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: niklas.soderlund+renesas@ragnatech.se,
David Airlie <airlied@linux.ie>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
dri-devel <dri-devel@lists.freedesktop.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
Frank Rowand <frowand.list@gmail.com>,
Frank.Rowand@sony.com
Subject: Re: [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build
Date: Tue, 20 Mar 2018 15:15:37 +0200 [thread overview]
Message-ID: <8748007.hiNNEuVPPY@avalon> (raw)
In-Reply-To: <CAK8P3a0kEqZ265bG+S7JWgR47A_H2QjAT_+v+AKrFab+wN6AQg@mail.gmail.com>
Hi Arnd,
On Friday, 16 March 2018 10:25:25 EET Arnd Bergmann wrote:
> On Fri, Mar 16, 2018 at 2:39 AM, <Frank.Rowand@sony.com> wrote:
> > On Thursday, March 15, 2018 8:37 AM, Arnd Bergmann wrote:
> >> The *.dtb and *.dtb.S files get removed by 'make' during the build
> >> process,
> >> and later seem to be missed during the 'modpost' stage:
> >>
> >> rm drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7791.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7795.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7796.dtb.S
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7793.dtb.S
> >> WARNING: could not open
> >> drivers/gpu/drm/rcar-du/rcar_du_of_lvds_r8a7790.dtb.S: No such file or
> >> directory
> >>
> >> As a workaround, this adds all those files to the 'extra-y' target list,
> >> but that's really ugly. Any ideas for a better fix?
> >
> > Does this work for you (untested, but the way it is done in
> > drivers/of/unittest-data/Makefile):
> >
> > .PRECIOUS: \
> >
> > $(obj)/%.dtb.S \
> > $(obj)/%.dtb
>
> Yes, that works and looks much better than my version.
Thank you for your patch, and sorry for breaking the build. Do you plan to
submit a new version based on Frank's approach ?
--
Regards,
Laurent Pinchart
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
next prev parent reply other threads:[~2018-03-20 13:14 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-15 15:37 [PATCH] [RFC] drm: rcar-du: keep temporary dtb files around during build Arnd Bergmann
2018-03-15 15:37 ` Arnd Bergmann
2018-03-16 1:39 ` Frank.Rowand
2018-03-16 1:39 ` Frank.Rowand
2018-03-16 8:25 ` Arnd Bergmann
2018-03-16 8:25 ` Arnd Bergmann
2018-03-20 13:15 ` Laurent Pinchart [this message]
2018-03-20 13:15 ` Laurent Pinchart
2018-03-21 7:38 ` Arnd Bergmann
2018-03-21 7:38 ` Arnd Bergmann
2018-03-21 9:58 ` Laurent Pinchart
2018-03-21 9:58 ` Laurent Pinchart
2018-03-22 14:26 ` Geert Uytterhoeven
2018-03-22 14:26 ` Geert Uytterhoeven
2018-03-22 14:50 ` Laurent Pinchart
2018-03-22 15:13 ` Geert Uytterhoeven
2018-03-22 15:13 ` Geert Uytterhoeven
2018-03-22 17:47 ` Masahiro Yamada
2018-03-23 13:27 ` Masahiro Yamada
2018-03-24 1:31 ` Frank Rowand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8748007.hiNNEuVPPY@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=Frank.Rowand@sony.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=dri-devel@lists.freedesktop.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.