[PATCH i-g-t 1/8] tests/gem_exec_flush: Tune down BAT timeout to ~1sec.

[PATCH i-g-t 1/8] tests/gem_exec_flush: Tune down BAT timeout to ~1sec.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_exec_flush.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_exec_flush.c b/tests/gem_exec_flush.c
index d08b843..b608060 100644
--- a/tests/gem_exec_flush.c
+++ b/tests/gem_exec_flush.c
@@ -523,7 +523,7 @@ igt_main
 
 	for (e = intel_execution_engines; e->name; e++) igt_subtest_group {
 		unsigned ring = e->exec_id | e->flags;
-		unsigned timeout = 5 + 120*!!e->exec_id;
+		unsigned timeout = 1 + 120*!!e->exec_id;
 
 		igt_fixture {
 			gem_require_ring(fd, ring);
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 2/8] tests/gem_ctx_switch: Tune down for BAT ~1s.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_ctx_switch.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/gem_ctx_switch.c b/tests/gem_ctx_switch.c
index 7b27336..066a5fc 100644
--- a/tests/gem_ctx_switch.c
+++ b/tests/gem_ctx_switch.c
@@ -73,6 +73,7 @@ static void single(int fd, uint32_t handle,
 	struct drm_i915_gem_exec_object2 obj;
 	struct drm_i915_gem_relocation_entry reloc;
 	uint32_t contexts[64];
+	uint32_t timeout = 1;
 	int n;
 
 	gem_require_ring(fd, e->exec_id | e->flags);
@@ -125,7 +126,7 @@ static void single(int fd, uint32_t handle,
 				count += 1024;
 			}
 			clock_gettime(CLOCK_MONOTONIC, &now);
-		} while (elapsed(&start, &now) < 20.);
+		} while (elapsed(&start, &now) < timeout);
 		gem_sync(fd, handle);
 		clock_gettime(CLOCK_MONOTONIC, &now);
 
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 2/8] tests/gem_ctx_switch: Tune down for BAT ~1s.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:32PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

Nak. Please suggest how to improve reliablity first.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 3/8] tests/gem_exec_nop: Tune down timeout for BAT ~1s.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_exec_nop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_exec_nop.c b/tests/gem_exec_nop.c
index e90d5eb..1b2d144 100644
--- a/tests/gem_exec_nop.c
+++ b/tests/gem_exec_nop.c
@@ -213,7 +213,7 @@ igt_main
 	igt_fork_hang_detector(device);
 
 	igt_subtest("basic")
-		all(device, handle, 10);
+		all(device, handle, 1);
 
 	for (e = intel_execution_engines; e->name; e++)
 		igt_subtest_f("%s", e->name)
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 3/8] tests/gem_exec_nop: Tune down timeout for BAT ~1s.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:33PM +0300, Marius Vlad wrote:

You need some explanation here to explain how you believe that all the
corner-cases from this minimal stress test are covered elsewhere.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_close_race.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_close_race.c b/tests/gem_close_race.c
index 94fb905..45aa2cc 100644
--- a/tests/gem_close_race.c
+++ b/tests/gem_close_race.c
@@ -232,7 +232,7 @@ igt_main
 	}
 
 	igt_subtest("basic-threads")
-		threads(10);
+		threads(1);
 
 	igt_subtest("process-exit") {
 		igt_fork(child, 768)
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

Nak. It's a race detector. Please suggest how to increase detection
rates.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Tvrtko Ursulin]

On 27/05/16 12:58, Chris Wilson wrote:
> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>
> Nak. It's a race detector. Please suggest how to increase detection
> rates.

As a more or less well know TV personality would say - "it's better than 
nothing"! :))

Seriously, under the new rules this is all we can do. Full 
gem-close-race will (will it?) run in the nightly run so a little bit 
more pain while bisecting breakages but those are the rules. We can give 
them a go and see how it works out.

Regards,

Tvrtko

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Chris Wilson]

On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
> 
> On 27/05/16 12:58, Chris Wilson wrote:
> >On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> >>Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> >
> >Nak. It's a race detector. Please suggest how to increase detection
> >rates.
> 
> As a more or less well know TV personality would say - "it's better
> than nothing"! :))
> 
> Seriously, under the new rules this is all we can do. Full
> gem-close-race will (will it?) run in the nightly run so a little
> bit more pain while bisecting breakages but those are the rules. We
> can give them a go and see how it works out.

Wrong approach. Right approach would be to add a new test that reliably
detected a checklist of the most common races in under 1s. Nerfing a
test to make it useless makes BAT equally useless.

So we are giving up on BAT?
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Tvrtko Ursulin]

On 27/05/16 13:16, Chris Wilson wrote:
> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
>>
>> On 27/05/16 12:58, Chris Wilson wrote:
>>> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
>>>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>>>
>>> Nak. It's a race detector. Please suggest how to increase detection
>>> rates.
>>
>> As a more or less well know TV personality would say - "it's better
>> than nothing"! :))
>>
>> Seriously, under the new rules this is all we can do. Full
>> gem-close-race will (will it?) run in the nightly run so a little
>> bit more pain while bisecting breakages but those are the rules. We
>> can give them a go and see how it works out.
>
> Wrong approach. Right approach would be to add a new test that reliably
> detected a checklist of the most common races in under 1s. Nerfing a
> test to make it useless makes BAT equally useless.
>
> So we are giving up on BAT?

If it is not possible to stuff everything into the allocated budget, and 
in cases where it may not be possible to come up with a 1s race 
detector, it makes sense to move the test out of BAT and into the 
nightly runs.

Agreement was that the time limits are hard limits so thats pretty much 
it. We can do this now and hit the targets and them add more tests if 
and when someone manages to implement them.

I don't have a problem with that, B in BAT stands for basic anyway.

We just adjust the model that when nightly test run fails someone from 
QA gets tasked with bisection etc as a top priority.

Regards,

Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Chris Wilson]

On Fri, May 27, 2016 at 01:31:10PM +0100, Tvrtko Ursulin wrote:
> 
> On 27/05/16 13:16, Chris Wilson wrote:
> >On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
> >>
> >>On 27/05/16 12:58, Chris Wilson wrote:
> >>>On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> >>>>Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> >>>
> >>>Nak. It's a race detector. Please suggest how to increase detection
> >>>rates.
> >>
> >>As a more or less well know TV personality would say - "it's better
> >>than nothing"! :))
> >>
> >>Seriously, under the new rules this is all we can do. Full
> >>gem-close-race will (will it?) run in the nightly run so a little
> >>bit more pain while bisecting breakages but those are the rules. We
> >>can give them a go and see how it works out.
> >
> >Wrong approach. Right approach would be to add a new test that reliably
> >detected a checklist of the most common races in under 1s. Nerfing a
> >test to make it useless makes BAT equally useless.
> >
> >So we are giving up on BAT?
> 
> If it is not possible to stuff everything into the allocated budget,
> and in cases where it may not be possible to come up with a 1s race
> detector, it makes sense to move the test out of BAT and into the
> nightly runs.
> 
> Agreement was that the time limits are hard limits so thats pretty
> much it. We can do this now and hit the targets and them add more
> tests if and when someone manages to implement them.

1s is totally arbitrary, setting it as a hard limit is ridiculous.

> I don't have a problem with that, B in BAT stands for basic anyway.

The most basic userspace appears far more complex than igt. Quite often
BAT passes, but a couple of seconds of dogfooding reveals an unusable
mess. Basic Acceptance Testing is failing in its task, and we seem to
heading down the path of making it fail harder.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Mika Kuoppala]

Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> writes:

> [ text/plain ]
>
> On 27/05/16 13:16, Chris Wilson wrote:
>> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
>>>
>>> On 27/05/16 12:58, Chris Wilson wrote:
>>>> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
>>>>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
>>>>
>>>> Nak. It's a race detector. Please suggest how to increase detection
>>>> rates.
>>>
>>> As a more or less well know TV personality would say - "it's better
>>> than nothing"! :))
>>>
>>> Seriously, under the new rules this is all we can do. Full
>>> gem-close-race will (will it?) run in the nightly run so a little
>>> bit more pain while bisecting breakages but those are the rules. We
>>> can give them a go and see how it works out.
>>
>> Wrong approach. Right approach would be to add a new test that reliably
>> detected a checklist of the most common races in under 1s. Nerfing a
>> test to make it useless makes BAT equally useless.
>>
>> So we are giving up on BAT?
>
> If it is not possible to stuff everything into the allocated budget, and 
> in cases where it may not be possible to come up with a 1s race 
> detector, it makes sense to move the test out of BAT and into the 
> nightly runs.
>

With tests to poke out races, I think the best way is to take
them out from BAT and move to nightly.

As A is for acceptance, it is not much value as some poor soul
will hit the race 1 month after we regressed it.

- Mika


> Agreement was that the time limits are hard limits so thats pretty much 
> it. We can do this now and hit the targets and them add more tests if 
> and when someone manages to implement them.
>
> I don't have a problem with that, B in BAT stands for basic anyway.
>
> We just adjust the model that when nightly test run fails someone from 
> QA gets tasked with bisection etc as a top priority.
>
> Regards,
>
> Tvrtko
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Marius Vlad]

[-- Attachment #1.1: Type: text/plain, Size: 2236 bytes --]

On Fri, May 27, 2016 at 03:44:20PM +0300, Mika Kuoppala wrote:
> Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com> writes:
> 
> > [ text/plain ]
> >
> > On 27/05/16 13:16, Chris Wilson wrote:
> >> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
> >>>
> >>> On 27/05/16 12:58, Chris Wilson wrote:
> >>>> On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> >>>>> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> >>>>
> >>>> Nak. It's a race detector. Please suggest how to increase detection
> >>>> rates.
> >>>
> >>> As a more or less well know TV personality would say - "it's better
> >>> than nothing"! :))
> >>>
> >>> Seriously, under the new rules this is all we can do. Full
> >>> gem-close-race will (will it?) run in the nightly run so a little
> >>> bit more pain while bisecting breakages but those are the rules. We
> >>> can give them a go and see how it works out.
> >>
> >> Wrong approach. Right approach would be to add a new test that reliably
> >> detected a checklist of the most common races in under 1s. Nerfing a
> >> test to make it useless makes BAT equally useless.
> >>
> >> So we are giving up on BAT?
> >
> > If it is not possible to stuff everything into the allocated budget, and 
> > in cases where it may not be possible to come up with a 1s race 
> > detector, it makes sense to move the test out of BAT and into the 
> > nightly runs.
> >
> 
> With tests to poke out races, I think the best way is to take
> them out from BAT and move to nightly.

Right, going to send another series with them removed if everyone
agrees on this.

> 
> As A is for acceptance, it is not much value as some poor soul
> will hit the race 1 month after we regressed it.
> 
> - Mika
> 
> 
> > Agreement was that the time limits are hard limits so thats pretty much 
> > it. We can do this now and hit the targets and them add more tests if 
> > and when someone manages to implement them.
> >
> > I don't have a problem with that, B in BAT stands for basic anyway.
> >
> > We just adjust the model that when nightly test run fails someone from 
> > QA gets tasked with bisection etc as a top priority.
> >
> > Regards,
> >
> > Tvrtko

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Marius Vlad]

[-- Attachment #1.1: Type: text/plain, Size: 1129 bytes --]

On Fri, May 27, 2016 at 01:16:06PM +0100, Chris Wilson wrote:
> On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
> > 
> > On 27/05/16 12:58, Chris Wilson wrote:
> > >On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> > >>Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> > >
> > >Nak. It's a race detector. Please suggest how to increase detection
> > >rates.
> > 
> > As a more or less well know TV personality would say - "it's better
> > than nothing"! :))
> > 
> > Seriously, under the new rules this is all we can do. Full
> > gem-close-race will (will it?) run in the nightly run so a little
> > bit more pain while bisecting breakages but those are the rules. We
> > can give them a go and see how it works out.
> 
> Wrong approach. Right approach would be to add a new test that reliably
> detected a checklist of the most common races in under 1s. Nerfing a
> test to make it useless makes BAT equally useless.
> 
> So we are giving up on BAT?
It is a compromise. Either this or nigthly.

> -Chris
> 
> -- 
> Chris Wilson, Intel Open Source Technology Centre

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 4/8] tests/gem_close_race: Tune down for BAT ~1s.

[Marius Vlad]

[-- Attachment #1.1: Type: text/plain, Size: 985 bytes --]

On Fri, May 27, 2016 at 01:10:07PM +0100, Tvrtko Ursulin wrote:
> 
> On 27/05/16 12:58, Chris Wilson wrote:
> >On Fri, May 27, 2016 at 02:50:34PM +0300, Marius Vlad wrote:
> >>Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
> >
> >Nak. It's a race detector. Please suggest how to increase detection
> >rates.
> 
> As a more or less well know TV personality would say - "it's better than
> nothing"! :))
> 
> Seriously, under the new rules this is all we can do. Full gem-close-race
> will (will it?) run in the nightly run so a little bit more pain while
> bisecting breakages but those are the rules. We can give them a go and see
> how it works out.

Combinatorial tests (gem_concurrent_all/blit) and gem_evict_everything
are the only exceptions. We've been running nightly for over a week now.

You can have a look under /archive/results/Nightly/.

I'm not saying its perfect, but at least we have somewhere to start.

> 
> Regards,
> 
> Tvrtko
> 

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

[-- Attachment #2: Type: text/plain, Size: 160 bytes --]

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 5/8] tests/gem_sync: Tune down for BAT to ~1s for basic-each and ~2s for basic-all.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_sync.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/tests/gem_sync.c b/tests/gem_sync.c
index 320bce3..f824d1e 100644
--- a/tests/gem_sync.c
+++ b/tests/gem_sync.c
@@ -126,7 +126,7 @@ sync_ring(int fd, unsigned ring, int num_children)
 				gem_execbuf(fd, &execbuf);
 				gem_sync(fd, object.handle);
 			} while (++cycles & 1023);
-		} while ((elapsed = gettime() - start) < SLOW_QUICK(10, 1));
+		} while ((elapsed = gettime() - start) < 1);
 		igt_info("%s%sompleted %ld cycles: %.3f us\n",
 			 names[child % num_engines] ?: "",
 			 names[child % num_engines] ? " c" : "C",
@@ -191,7 +191,7 @@ sync_all(int fd, int num_children)
 				}
 				gem_sync(fd, object.handle);
 			} while (++cycles & 1023);
-		} while ((elapsed = gettime() - start) < SLOW_QUICK(10, 1));
+		} while ((elapsed = gettime() - start) < SLOW_QUICK(2, 1));
 		igt_info("Completed %ld cycles: %.3f us\n",
 			 cycles, elapsed*1e6/cycles);
 
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 5/8] tests/gem_sync: Tune down for BAT to ~1s for basic-each and ~2s for basic-all.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:35PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

NAK. gem_sync is not reliable enough, please suggest how to improve
detection rates for *existing* issues.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 6/8] tests/gem_exec_fault: Decrease the counts to lower the time for BAT.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_storedw_loop.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_storedw_loop.c b/tests/gem_storedw_loop.c
index 317b8c6..89f0182 100644
--- a/tests/gem_storedw_loop.c
+++ b/tests/gem_storedw_loop.c
@@ -187,7 +187,7 @@ igt_main
 	for (e = intel_execution_engines; e->name; e++) {
 		igt_subtest_f("basic-%s", e->name) {
 			check_test_requirements(fd, e->exec_id);
-			store_test(fd, e->exec_id | e->flags, 16*1024);
+			store_test(fd, e->exec_id | e->flags, 4*1024);
 		}
 
 		igt_subtest_f("long-%s", e->name) {
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 6/8] tests/gem_exec_fault: Decrease the counts to lower the time for BAT.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:36PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

Summary and patch do not match.

But you could remove gem_storedw_loop as everything BAT about it is
tested elsewhere.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 7/8] tests/gem_tiled_pread_basic: Rename test and BATify.

[Marius Vlad]

Add a extended subtest and reduce the number of iteration to qualify
for BAT. Renamed to test to gem_tiled_pread.

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/Makefile.sources        |   2 +-
 tests/gem_tiled_pread.c       | 231 ++++++++++++++++++++++++++++++++++++++++++
 tests/gem_tiled_pread_basic.c | 215 ---------------------------------------
 3 files changed, 232 insertions(+), 216 deletions(-)
 create mode 100644 tests/gem_tiled_pread.c
 delete mode 100644 tests/gem_tiled_pread_basic.c

diff --git a/tests/Makefile.sources b/tests/Makefile.sources
index c81eeeb..86328cb 100644
--- a/tests/Makefile.sources
+++ b/tests/Makefile.sources
@@ -175,7 +175,7 @@ TESTS_progs = \
 	gem_sync \
 	gem_threaded_access_tiled \
 	gem_tiled_fence_blits \
-	gem_tiled_pread_basic \
+	gem_tiled_pread \
 	gem_tiled_pread_pwrite \
 	gem_tiled_swapping \
 	gem_tiled_wb \
diff --git a/tests/gem_tiled_pread.c b/tests/gem_tiled_pread.c
new file mode 100644
index 0000000..bb05ac3
--- /dev/null
+++ b/tests/gem_tiled_pread.c
@@ -0,0 +1,231 @@
+/*
+ * Copyright © 2009 Intel Corporation
+ *
+ * Permission is hereby granted, free of charge, to any person obtaining a
+ * copy of this software and associated documentation files (the "Software"),
+ * to deal in the Software without restriction, including without limitation
+ * the rights to use, copy, modify, merge, publish, distribute, sublicense,
+ * and/or sell copies of the Software, and to permit persons to whom the
+ * Software is furnished to do so, subject to the following conditions:
+ *
+ * The above copyright notice and this permission notice (including the next
+ * paragraph) shall be included in all copies or substantial portions of the
+ * Software.
+ *
+ * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
+ * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
+ * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
+ * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
+ * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
+ * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
+ * IN THE SOFTWARE.
+ *
+ * Authors:
+ *    Eric Anholt <eric@anholt.net>
+ *
+ */
+
+/** @file gem_tiled_pread.c
+ *
+ * This is a test of pread's behavior on tiled objects with respect to the
+ * reported swizzling value.
+ *
+ * The goal is to exercise the slow_bit17_copy path for reading on bit17
+ * machines, but will also be useful for catching swizzling value bugs on
+ * other systems.
+ */
+
+#include "igt.h"
+#include <stdlib.h>
+#include <stdio.h>
+#include <string.h>
+#include <fcntl.h>
+#include <inttypes.h>
+#include <errno.h>
+#include <sys/stat.h>
+#include <sys/time.h>
+#include <sys/ioctl.h>
+#include "drm.h"
+
+
+IGT_TEST_DESCRIPTION("Test pread behavior on tiled objects with respect to the"
+		     " reported swizzling value.");
+
+#define WIDTH 512
+#define HEIGHT 512
+static uint32_t linear[WIDTH * HEIGHT];
+
+#define PAGE_SIZE 4096
+
+static int tile_width;
+static int tile_height;
+static int tile_size;
+
+static uint32_t
+create_bo(int fd)
+{
+	uint32_t handle;
+	uint32_t *data;
+	int i;
+
+	handle = gem_create(fd, sizeof(linear));
+	gem_set_tiling(fd, handle, I915_TILING_X, WIDTH * sizeof(uint32_t));
+
+	/* Fill the BO with dwords starting at start_val */
+	data = gem_mmap__gtt(fd, handle, sizeof(linear),
+			     PROT_READ | PROT_WRITE);
+	for (i = 0; i < WIDTH*HEIGHT; i++)
+		data[i] = i;
+	munmap(data, sizeof(linear));
+
+	return handle;
+}
+
+static int
+swizzle_bit(int bit, int offset)
+{
+	return (offset & (1 << bit)) >> (bit - 6);
+}
+
+/* Translate from a swizzled offset in the tiled buffer to the corresponding
+ * value from the original linear buffer.
+ */
+static uint32_t
+calculate_expected(int offset)
+{
+	int tile_off = offset & (tile_size - 1);
+	int tile_base = offset & -tile_size;
+	int tile_index = tile_base / tile_size;
+	int tiles_per_row = 4*WIDTH / tile_width;
+
+	/* base x,y values from the tile (page) index. */
+	int base_y = tile_index / tiles_per_row * tile_height;
+	int base_x = tile_index % tiles_per_row * (tile_width/4);
+
+	/* x, y offsets within the tile */
+	int tile_y = tile_off / tile_width;
+	int tile_x = (tile_off % tile_width) / 4;
+
+	igt_debug("%3d, %3d, %3d,%3d\n", base_x, base_y, tile_x, tile_y);
+	return (base_y + tile_y) * WIDTH + base_x + tile_x;
+}
+
+static void
+run(int fd, uint32_t handle, uint32_t swizzle, int iter)
+{
+	int i;
+
+	/* Read a bunch of random subsets of the data and check that they come
+	 * out right.
+	 */
+	for (i = 0; i < iter; i++) {
+		int size = WIDTH * HEIGHT * 4;
+		int offset = (random() % size) & ~3;
+		int len = (random() % size) & ~3;
+		int j;
+
+		if (len == 0)
+			len = 4;
+
+		if (offset + len > size)
+			len = size - offset;
+
+		if (i == 0) {
+			offset = 0;
+			len = size;
+		}
+
+		gem_read(fd, handle, offset, linear, len);
+
+		/* Translate from offsets in the read buffer to the swizzled
+		 * address that it corresponds to.  This is the opposite of
+		 * what Mesa does (calculate offset to be read given the linear
+		 * offset it's looking for).
+		 */
+		for (j = offset; j < offset + len; j += 4) {
+			uint32_t expected_val, found_val;
+			int swizzled_offset;
+			const char *swizzle_str;
+
+			switch (swizzle) {
+			case I915_BIT_6_SWIZZLE_NONE:
+				swizzled_offset = j;
+				swizzle_str = "none";
+				break;
+			case I915_BIT_6_SWIZZLE_9:
+				swizzled_offset = j ^
+					swizzle_bit(9, j);
+				swizzle_str = "bit9";
+				break;
+			case I915_BIT_6_SWIZZLE_9_10:
+				swizzled_offset = j ^
+					swizzle_bit(9, j) ^
+					swizzle_bit(10, j);
+				swizzle_str = "bit9^10";
+				break;
+			case I915_BIT_6_SWIZZLE_9_11:
+				swizzled_offset = j ^
+					swizzle_bit(9, j) ^
+					swizzle_bit(11, j);
+				swizzle_str = "bit9^11";
+				break;
+			case I915_BIT_6_SWIZZLE_9_10_11:
+				swizzled_offset = j ^
+					swizzle_bit(9, j) ^
+					swizzle_bit(10, j) ^
+					swizzle_bit(11, j);
+				swizzle_str = "bit9^10^11";
+				break;
+			default:
+				igt_assert_f(0, "Bad swizzle bits; %d\n",
+					     swizzle);
+			}
+			expected_val = calculate_expected(swizzled_offset);
+			found_val = linear[(j - offset) / 4];
+			igt_assert_f(expected_val == found_val,
+				     "Bad read [%d]: %d instead of %d at 0x%08x "
+				     "for read from 0x%08x to 0x%08x, swizzle=%s\n",
+				     i, found_val, expected_val, j,
+				     offset, offset + len,
+				     swizzle_str);
+		}
+	}
+}
+
+igt_main
+{
+	int fd;
+
+	uint32_t tiling, swizzle;
+	uint32_t handle;
+	uint32_t devid;
+
+	igt_fixture {
+		fd = drm_open_driver(DRIVER_INTEL);
+
+		handle = create_bo(fd);
+		gem_get_tiling(fd, handle, &tiling, &swizzle);
+
+		devid = intel_get_drm_devid(fd);
+	}
+
+	if (IS_GEN2(devid)) {
+		tile_height = 16;
+		tile_width = 128;
+		tile_size = 2048;
+	} else {
+		tile_height = 8;
+		tile_width = 512;
+		tile_size = PAGE_SIZE;
+	}
+
+	igt_subtest("basic")
+		run(fd, handle, swizzle, 10);
+
+	igt_subtest("extended")
+		run(fd, handle, swizzle, 100);
+
+	igt_fixture {
+		close(fd);
+	}
+}
diff --git a/tests/gem_tiled_pread_basic.c b/tests/gem_tiled_pread_basic.c
deleted file mode 100644
index 1dfd87c..0000000
--- a/tests/gem_tiled_pread_basic.c
+++ /dev/null
@@ -1,215 +0,0 @@
-/*
- * Copyright © 2009 Intel Corporation
- *
- * Permission is hereby granted, free of charge, to any person obtaining a
- * copy of this software and associated documentation files (the "Software"),
- * to deal in the Software without restriction, including without limitation
- * the rights to use, copy, modify, merge, publish, distribute, sublicense,
- * and/or sell copies of the Software, and to permit persons to whom the
- * Software is furnished to do so, subject to the following conditions:
- *
- * The above copyright notice and this permission notice (including the next
- * paragraph) shall be included in all copies or substantial portions of the
- * Software.
- *
- * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
- * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
- * FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT.  IN NO EVENT SHALL
- * THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
- * LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING
- * FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS
- * IN THE SOFTWARE.
- *
- * Authors:
- *    Eric Anholt <eric@anholt.net>
- *
- */
-
-/** @file gem_tiled_pread.c
- *
- * This is a test of pread's behavior on tiled objects with respect to the
- * reported swizzling value.
- *
- * The goal is to exercise the slow_bit17_copy path for reading on bit17
- * machines, but will also be useful for catching swizzling value bugs on
- * other systems.
- */
-
-#include "igt.h"
-#include <stdlib.h>
-#include <stdio.h>
-#include <string.h>
-#include <fcntl.h>
-#include <inttypes.h>
-#include <errno.h>
-#include <sys/stat.h>
-#include <sys/time.h>
-#include <sys/ioctl.h>
-#include "drm.h"
-
-
-IGT_TEST_DESCRIPTION("Test pread behavior on tiled objects with respect to the"
-		     " reported swizzling value.");
-
-#define WIDTH 512
-#define HEIGHT 512
-static uint32_t linear[WIDTH * HEIGHT];
-
-#define PAGE_SIZE 4096
-
-static int tile_width;
-static int tile_height;
-static int tile_size;
-
-static uint32_t
-create_bo(int fd)
-{
-	uint32_t handle;
-	uint32_t *data;
-	int i;
-
-	handle = gem_create(fd, sizeof(linear));
-	gem_set_tiling(fd, handle, I915_TILING_X, WIDTH * sizeof(uint32_t));
-
-	/* Fill the BO with dwords starting at start_val */
-	data = gem_mmap__gtt(fd, handle, sizeof(linear),
-			     PROT_READ | PROT_WRITE);
-	for (i = 0; i < WIDTH*HEIGHT; i++)
-		data[i] = i;
-	munmap(data, sizeof(linear));
-
-	return handle;
-}
-
-static int
-swizzle_bit(int bit, int offset)
-{
-	return (offset & (1 << bit)) >> (bit - 6);
-}
-
-/* Translate from a swizzled offset in the tiled buffer to the corresponding
- * value from the original linear buffer.
- */
-static uint32_t
-calculate_expected(int offset)
-{
-	int tile_off = offset & (tile_size - 1);
-	int tile_base = offset & -tile_size;
-	int tile_index = tile_base / tile_size;
-	int tiles_per_row = 4*WIDTH / tile_width;
-
-	/* base x,y values from the tile (page) index. */
-	int base_y = tile_index / tiles_per_row * tile_height;
-	int base_x = tile_index % tiles_per_row * (tile_width/4);
-
-	/* x, y offsets within the tile */
-	int tile_y = tile_off / tile_width;
-	int tile_x = (tile_off % tile_width) / 4;
-
-	igt_debug("%3d, %3d, %3d,%3d\n", base_x, base_y, tile_x, tile_y);
-	return (base_y + tile_y) * WIDTH + base_x + tile_x;
-}
-
-igt_simple_main
-{
-	int fd;
-	int i, iter = 100;
-	uint32_t tiling, swizzle;
-	uint32_t handle;
-	uint32_t devid;
-
-	fd = drm_open_driver(DRIVER_INTEL);
-
-	handle = create_bo(fd);
-	gem_get_tiling(fd, handle, &tiling, &swizzle);
-
-	devid = intel_get_drm_devid(fd);
-
-	if (IS_GEN2(devid)) {
-		tile_height = 16;
-		tile_width = 128;
-		tile_size = 2048;
-	} else {
-		tile_height = 8;
-		tile_width = 512;
-		tile_size = PAGE_SIZE;
-	}
-
-	/* Read a bunch of random subsets of the data and check that they come
-	 * out right.
-	 */
-	for (i = 0; i < iter; i++) {
-		int size = WIDTH * HEIGHT * 4;
-		int offset = (random() % size) & ~3;
-		int len = (random() % size) & ~3;
-		int j;
-
-		if (len == 0)
-			len = 4;
-
-		if (offset + len > size)
-			len = size - offset;
-
-		if (i == 0) {
-			offset = 0;
-			len = size;
-		}
-
-		gem_read(fd, handle, offset, linear, len);
-
-		/* Translate from offsets in the read buffer to the swizzled
-		 * address that it corresponds to.  This is the opposite of
-		 * what Mesa does (calculate offset to be read given the linear
-		 * offset it's looking for).
-		 */
-		for (j = offset; j < offset + len; j += 4) {
-			uint32_t expected_val, found_val;
-			int swizzled_offset;
-			const char *swizzle_str;
-
-			switch (swizzle) {
-			case I915_BIT_6_SWIZZLE_NONE:
-				swizzled_offset = j;
-				swizzle_str = "none";
-				break;
-			case I915_BIT_6_SWIZZLE_9:
-				swizzled_offset = j ^
-					swizzle_bit(9, j);
-				swizzle_str = "bit9";
-				break;
-			case I915_BIT_6_SWIZZLE_9_10:
-				swizzled_offset = j ^
-					swizzle_bit(9, j) ^
-					swizzle_bit(10, j);
-				swizzle_str = "bit9^10";
-				break;
-			case I915_BIT_6_SWIZZLE_9_11:
-				swizzled_offset = j ^
-					swizzle_bit(9, j) ^
-					swizzle_bit(11, j);
-				swizzle_str = "bit9^11";
-				break;
-			case I915_BIT_6_SWIZZLE_9_10_11:
-				swizzled_offset = j ^
-					swizzle_bit(9, j) ^
-					swizzle_bit(10, j) ^
-					swizzle_bit(11, j);
-				swizzle_str = "bit9^10^11";
-				break;
-			default:
-				igt_assert_f(0, "Bad swizzle bits; %d\n",
-					     swizzle);
-			}
-			expected_val = calculate_expected(swizzled_offset);
-			found_val = linear[(j - offset) / 4];
-			igt_assert_f(expected_val == found_val,
-				     "Bad read [%d]: %d instead of %d at 0x%08x "
-				     "for read from 0x%08x to 0x%08x, swizzle=%s\n",
-				     i, found_val, expected_val, j,
-				     offset, offset + len,
-				     swizzle_str);
-		}
-	}
-
-	close(fd);
-}
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 7/8] tests/gem_tiled_pread_basic: Rename test and BATify.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:37PM +0300, Marius Vlad wrote:
> Add a extended subtest and reduce the number of iteration to qualify
> for BAT. Renamed to test to gem_tiled_pread.

No. This doesn't increase coverage.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

[PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate test from BAT.

[Marius Vlad]

Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>
---
 tests/gem_exec_suspend.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/gem_exec_suspend.c b/tests/gem_exec_suspend.c
index cd133cc..3d529bd 100644
--- a/tests/gem_exec_suspend.c
+++ b/tests/gem_exec_suspend.c
@@ -247,7 +247,7 @@ igt_main
 		run_test(fd, -1, NOSLEEP);
 	igt_subtest("basic-S3")
 		run_test(fd, -1, SUSPEND);
-	igt_subtest("basic-S4")
+	igt_subtest("S4")
 		run_test(fd, -1, HIBERNATE);
 
 	for (e = intel_execution_engines; e->name; e++) {
-- 
2.5.0

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 8/8] tests/gem_exec_suspend: Remove hibernate test from BAT.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:38PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

Nak. Please suggest how to fix the broken machines first.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [PATCH i-g-t 1/8] tests/gem_exec_flush: Tune down BAT timeout to ~1sec.

[Chris Wilson]

On Fri, May 27, 2016 at 02:50:31PM +0300, Marius Vlad wrote:
> Signed-off-by: Marius Vlad <marius.c.vlad@intel.com>

Nak. Please suggest how to make this test reliable first. At the moment,
we need to increase the time.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx