From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: linux-wireless <linux-wireless@vger.kernel.org>,
"ath10k@lists.infradead.org" <ath10k@lists.infradead.org>
Subject: Re: [PATCH 2/2] ath10k: make core registering async
Date: Fri, 23 May 2014 10:16:27 +0300 [thread overview]
Message-ID: <874n0hvub8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmxGEFSxyw84wQUrkbyq55UqMgwR2Vt+1nd29sTn=g7kQ@mail.gmail.com> (Michal Kazior's message of "Fri, 23 May 2014 09:13:09 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
>>> --- a/drivers/net/wireless/ath/ath10k/pci.c
>>> +++ b/drivers/net/wireless/ath/ath10k/pci.c
>>> @@ -2758,8 +2758,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev)
>>> if (!ar_pci)
>>> return;
>>>
>>> - tasklet_kill(&ar_pci->msi_fw_err);
>>
>> Why this? That's not obvious to me.
>
> It might end up not being initialized: If you, say, quickly insert and
> eject a device you might not even initialize the tasklet (it's done
> elsewhere; I suppose we could move it too) before ath10k_pci_remove()
> is called. Also the tasklet is already killed elsewhere on the
> teardown code path.
>
> I'll split it into a separate patch that simply removes this line as
> it's meaningless to call it here in the first place.
Yeah, it's a good idea to have a separate patch for this.
--
Kalle Valo
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@qca.qualcomm.com>
To: Michal Kazior <michal.kazior@tieto.com>
Cc: "ath10k@lists.infradead.org" <ath10k@lists.infradead.org>,
linux-wireless <linux-wireless@vger.kernel.org>
Subject: Re: [PATCH 2/2] ath10k: make core registering async
Date: Fri, 23 May 2014 10:16:27 +0300 [thread overview]
Message-ID: <874n0hvub8.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <CA+BoTQmxGEFSxyw84wQUrkbyq55UqMgwR2Vt+1nd29sTn=g7kQ@mail.gmail.com> (Michal Kazior's message of "Fri, 23 May 2014 09:13:09 +0200")
Michal Kazior <michal.kazior@tieto.com> writes:
>>> --- a/drivers/net/wireless/ath/ath10k/pci.c
>>> +++ b/drivers/net/wireless/ath/ath10k/pci.c
>>> @@ -2758,8 +2758,6 @@ static void ath10k_pci_remove(struct pci_dev *pdev)
>>> if (!ar_pci)
>>> return;
>>>
>>> - tasklet_kill(&ar_pci->msi_fw_err);
>>
>> Why this? That's not obvious to me.
>
> It might end up not being initialized: If you, say, quickly insert and
> eject a device you might not even initialize the tasklet (it's done
> elsewhere; I suppose we could move it too) before ath10k_pci_remove()
> is called. Also the tasklet is already killed elsewhere on the
> teardown code path.
>
> I'll split it into a separate patch that simply removes this line as
> it's meaningless to call it here in the first place.
Yeah, it's a good idea to have a separate patch for this.
--
Kalle Valo
next prev parent reply other threads:[~2014-05-23 7:16 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-22 14:12 [PATCH 0/2] ath10k: async pci probing Michal Kazior
2014-05-22 14:12 ` Michal Kazior
2014-05-22 14:12 ` [PATCH 1/2] ath10k: relocate core create/destroy functions Michal Kazior
2014-05-22 14:12 ` Michal Kazior
2014-05-22 14:12 ` [PATCH 2/2] ath10k: make core registering async Michal Kazior
2014-05-22 14:12 ` Michal Kazior
2014-05-22 14:41 ` Johannes Berg
2014-05-22 14:41 ` Johannes Berg
2014-05-23 7:08 ` Michal Kazior
2014-05-23 7:08 ` Michal Kazior
2014-06-23 10:19 ` Michal Kazior
2014-06-23 10:19 ` Michal Kazior
2014-06-23 11:51 ` Johannes Berg
2014-06-23 11:51 ` Johannes Berg
2014-06-23 12:17 ` Michal Kazior
2014-06-23 12:17 ` Michal Kazior
2014-06-23 12:32 ` Johannes Berg
2014-06-23 12:32 ` Johannes Berg
2014-06-23 12:59 ` Michal Kazior
2014-06-23 12:59 ` Michal Kazior
2014-06-23 14:10 ` Johannes Berg
2014-06-23 14:10 ` Johannes Berg
2014-05-22 16:40 ` Kalle Valo
2014-05-22 16:40 ` Kalle Valo
2014-05-23 7:09 ` Michal Kazior
2014-05-23 7:09 ` Michal Kazior
2014-05-22 16:42 ` Kalle Valo
2014-05-22 16:42 ` Kalle Valo
2014-05-23 7:13 ` Michal Kazior
2014-05-23 7:13 ` Michal Kazior
2014-05-23 7:16 ` Kalle Valo [this message]
2014-05-23 7:16 ` Kalle Valo
2014-05-23 10:28 ` [PATCH 0/3] ath10k: async pci probing Michal Kazior
2014-05-23 10:28 ` Michal Kazior
2014-05-23 10:28 ` [PATCH v2 1/3] ath10k: relocate core create/destroy functions Michal Kazior
2014-05-23 10:28 ` Michal Kazior
2014-05-23 10:28 ` [PATCH v2 2/3] ath10k: remove unnecessary tasklet_kill() Michal Kazior
2014-05-23 10:28 ` Michal Kazior
2014-05-23 10:28 ` [PATCH v2 3/3] ath10k: make core registering async Michal Kazior
2014-05-23 10:28 ` Michal Kazior
2014-05-26 9:45 ` [PATCH 0/3] ath10k: async pci probing Kalle Valo
2014-05-26 9:45 ` Kalle Valo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874n0hvub8.fsf@kamboji.qca.qualcomm.com \
--to=kvalo@qca.qualcomm.com \
--cc=ath10k@lists.infradead.org \
--cc=linux-wireless@vger.kernel.org \
--cc=michal.kazior@tieto.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.