From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
Daniel Vetter <daniel@ffwll.ch>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
David Airlie <airlied@gmail.com>
Subject: Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO
Date: Tue, 21 Nov 2023 12:28:37 +0200 [thread overview]
Message-ID: <875y1vo0x6.fsf@intel.com> (raw)
In-Reply-To: <ZVfVsVDQ9j7nMsnW@smile.fi.intel.com>
On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>>
>> Thanks Andy & Hans!
>>
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>>
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?
Nah, they're benign.
BR,
Jani.
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org,
dri-devel@lists.freedesktop.org,
Hans de Goede <hdegoede@redhat.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO
Date: Tue, 21 Nov 2023 12:28:37 +0200 [thread overview]
Message-ID: <875y1vo0x6.fsf@intel.com> (raw)
In-Reply-To: <ZVfVsVDQ9j7nMsnW@smile.fi.intel.com>
On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>>
>> Thanks Andy & Hans!
>>
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>>
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?
Nah, they're benign.
BR,
Jani.
--
Jani Nikula, Intel
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula@intel.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>,
intel-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org,
Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Rodrigo Vivi <rodrigo.vivi@intel.com>,
Tvrtko Ursulin <tvrtko.ursulin@linux.intel.com>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>
Subject: Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO
Date: Tue, 21 Nov 2023 12:28:37 +0200 [thread overview]
Message-ID: <875y1vo0x6.fsf@intel.com> (raw)
In-Reply-To: <ZVfVsVDQ9j7nMsnW@smile.fi.intel.com>
On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>>
>> Thanks Andy & Hans!
>>
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>>
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?
Nah, they're benign.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2023-11-21 10:28 UTC|newest]
Thread overview: 87+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-03 20:18 [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915 Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value() Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else' Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init() Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value() Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio() Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` [Intel-gfx] [PATCH v4 16/16] drm/i915/iosf: Drop unused APIs Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 20:18 ` Andy Shevchenko
2023-11-03 22:22 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO Patchwork
2023-11-03 22:41 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-16 8:58 ` [Intel-gfx] [rft, PATCH v4 00/16] " Hans de Goede
2023-11-16 8:58 ` Hans de Goede
2023-11-16 8:58 ` Hans de Goede
2023-11-16 10:15 ` [Intel-gfx] " Jani Nikula
2023-11-16 10:15 ` Jani Nikula
2023-11-16 10:15 ` Jani Nikula
2023-11-17 21:05 ` [Intel-gfx] " Andy Shevchenko
2023-11-17 21:05 ` Andy Shevchenko
2023-11-17 21:05 ` Andy Shevchenko
2023-11-21 10:28 ` Jani Nikula [this message]
2023-11-21 10:28 ` Jani Nikula
2023-11-21 10:28 ` Jani Nikula
2023-11-17 21:06 ` [Intel-gfx] " Andy Shevchenko
2023-11-17 21:06 ` Andy Shevchenko
2023-11-17 21:06 ` Andy Shevchenko
2023-11-16 12:39 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2) Patchwork
2023-11-16 12:57 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-16 16:59 ` Jani Nikula
2023-11-21 10:43 ` Illipilli, TejasreeX
2023-11-22 10:55 ` Jani Nikula
2023-11-22 11:14 ` Andy Shevchenko
2023-11-22 13:38 ` Musial, Ewelina
2023-11-22 14:04 ` Saarinen, Jani
2023-11-22 14:24 ` Musial, Ewelina
2023-11-22 15:01 ` Saarinen, Jani
2023-11-22 17:17 ` Jani Nikula
2023-11-22 17:30 ` Andy Shevchenko
2023-11-23 6:46 ` Musial, Ewelina
2023-11-16 18:41 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4) Patchwork
2023-11-16 18:59 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-20 23:55 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5) Patchwork
2023-11-21 0:14 ` [Intel-gfx] ✗ Fi.CI.BAT: failure " Patchwork
2023-11-21 9:27 ` Jani Nikula
2023-11-21 10:22 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y1vo0x6.fsf@intel.com \
--to=jani.nikula@intel.com \
--cc=airlied@gmail.com \
--cc=andriy.shevchenko@linux.intel.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=hdegoede@redhat.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rodrigo.vivi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.