[Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
talking to GPIO IP behind the actual driver's back. A second attempt
to fix that is here.

If I understood correctly, my approach should work in the similar way as
the current IOSF GPIO.

Hans, I believe you have some devices that use this piece of code,
is it possible to give a test run on (one of) them?

In v4:
- fixed compile time errors in patch 14 (Hans, LKP)
- fixed cover letter Subject
- added patch 15 (as suggested by Ville)
- added Ack tag (Jani)

In v3:
- incorporated series by Jani
- incorporated couple of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View

In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well

Andy Shevchenko (9):
  drm/i915/dsi: Replace while(1) with one with clear exit condition
  drm/i915/dsi: Get rid of redundant 'else'
  drm/i915/dsi: Replace check with a (missing) MIPI sequence name
  drm/i915/dsi: Extract common soc_gpio_set_value() helper
  drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
  drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
    communities
  drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
  drm/i915/dsi: Combine checks in mipi_exec_gpio()
  drm/i915/iosf: Drop unused APIs

Hans de Goede (2):
  drm/i915/dsi: Remove GPIO lookup table at the end of
    intel_dsi_vbt_gpio_init()
  drm/i915/dsi: Fix wrong initial value for GPIOs in
    bxt_gpio_set_value()

Jani Nikula (5):
  drm/i915/dsi: assume BXT gpio works for non-native GPIO
  drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
  drm/i915/dsi: clarify GPIO exec sequence
  drm/i915/dsi: rename platform specific *_exec_gpio() to
    *_gpio_set_value()
  drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
 drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
 drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
 3 files changed, 136 insertions(+), 239 deletions(-)

-- 
2.40.0.1.gaa8946217a0b

[rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
talking to GPIO IP behind the actual driver's back. A second attempt
to fix that is here.

If I understood correctly, my approach should work in the similar way as
the current IOSF GPIO.

Hans, I believe you have some devices that use this piece of code,
is it possible to give a test run on (one of) them?

In v4:
- fixed compile time errors in patch 14 (Hans, LKP)
- fixed cover letter Subject
- added patch 15 (as suggested by Ville)
- added Ack tag (Jani)

In v3:
- incorporated series by Jani
- incorporated couple of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View

In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well

Andy Shevchenko (9):
  drm/i915/dsi: Replace while(1) with one with clear exit condition
  drm/i915/dsi: Get rid of redundant 'else'
  drm/i915/dsi: Replace check with a (missing) MIPI sequence name
  drm/i915/dsi: Extract common soc_gpio_set_value() helper
  drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
  drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
    communities
  drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
  drm/i915/dsi: Combine checks in mipi_exec_gpio()
  drm/i915/iosf: Drop unused APIs

Hans de Goede (2):
  drm/i915/dsi: Remove GPIO lookup table at the end of
    intel_dsi_vbt_gpio_init()
  drm/i915/dsi: Fix wrong initial value for GPIOs in
    bxt_gpio_set_value()

Jani Nikula (5):
  drm/i915/dsi: assume BXT gpio works for non-native GPIO
  drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
  drm/i915/dsi: clarify GPIO exec sequence
  drm/i915/dsi: rename platform specific *_exec_gpio() to
    *_gpio_set_value()
  drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
 drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
 drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
 3 files changed, 136 insertions(+), 239 deletions(-)

-- 
2.40.0.1.gaa8946217a0b

[rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
talking to GPIO IP behind the actual driver's back. A second attempt
to fix that is here.

If I understood correctly, my approach should work in the similar way as
the current IOSF GPIO.

Hans, I believe you have some devices that use this piece of code,
is it possible to give a test run on (one of) them?

In v4:
- fixed compile time errors in patch 14 (Hans, LKP)
- fixed cover letter Subject
- added patch 15 (as suggested by Ville)
- added Ack tag (Jani)

In v3:
- incorporated series by Jani
- incorporated couple of precursor patches by Hans
- added Rb tag for used to be first three patches (Andi)
- rebased on top of the above changes
- fixed indexing for multi-community devices, such as Cherry View

In v2:
- added a few cleanup patches
- reworked to use dynamic GPIO lookup tables
- converted CHV as well

Andy Shevchenko (9):
  drm/i915/dsi: Replace while(1) with one with clear exit condition
  drm/i915/dsi: Get rid of redundant 'else'
  drm/i915/dsi: Replace check with a (missing) MIPI sequence name
  drm/i915/dsi: Extract common soc_gpio_set_value() helper
  drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
  drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
    communities
  drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
  drm/i915/dsi: Combine checks in mipi_exec_gpio()
  drm/i915/iosf: Drop unused APIs

Hans de Goede (2):
  drm/i915/dsi: Remove GPIO lookup table at the end of
    intel_dsi_vbt_gpio_init()
  drm/i915/dsi: Fix wrong initial value for GPIOs in
    bxt_gpio_set_value()

Jani Nikula (5):
  drm/i915/dsi: assume BXT gpio works for non-native GPIO
  drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
  drm/i915/dsi: clarify GPIO exec sequence
  drm/i915/dsi: rename platform specific *_exec_gpio() to
    *_gpio_set_value()
  drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
 drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
 drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
 3 files changed, 136 insertions(+), 239 deletions(-)

-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Purely a guess. Drop the nop function.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 24b2cbcfc1ef..b2c0cc11f8c1 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -372,14 +372,6 @@ static void bxt_exec_gpio(struct intel_connector *connector,
 	gpiod_set_value(gpio_desc, value);
 }
 
-static void icl_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
-{
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-
-	drm_dbg_kms(&dev_priv->drm, "Skipping ICL GPIO element execution\n");
-}
-
 enum {
 	MIPI_RESET_1 = 0,
 	MIPI_AVDD_EN_1,
@@ -491,7 +483,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(dev_priv, gpio_number, value);
 	else if (DISPLAY_VER(dev_priv) >= 11)
-		icl_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(dev_priv))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(dev_priv))
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Purely a guess. Drop the nop function.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 24b2cbcfc1ef..b2c0cc11f8c1 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -372,14 +372,6 @@ static void bxt_exec_gpio(struct intel_connector *connector,
 	gpiod_set_value(gpio_desc, value);
 }
 
-static void icl_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
-{
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-
-	drm_dbg_kms(&dev_priv->drm, "Skipping ICL GPIO element execution\n");
-}
-
 enum {
 	MIPI_RESET_1 = 0,
 	MIPI_AVDD_EN_1,
@@ -491,7 +483,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(dev_priv, gpio_number, value);
 	else if (DISPLAY_VER(dev_priv) >= 11)
-		icl_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(dev_priv))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(dev_priv))
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 01/16] drm/i915/dsi: assume BXT gpio works for non-native GPIO

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Purely a guess. Drop the nop function.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 10 +---------
 1 file changed, 1 insertion(+), 9 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 24b2cbcfc1ef..b2c0cc11f8c1 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -372,14 +372,6 @@ static void bxt_exec_gpio(struct intel_connector *connector,
 	gpiod_set_value(gpio_desc, value);
 }
 
-static void icl_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
-{
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-
-	drm_dbg_kms(&dev_priv->drm, "Skipping ICL GPIO element execution\n");
-}
-
 enum {
 	MIPI_RESET_1 = 0,
 	MIPI_AVDD_EN_1,
@@ -491,7 +483,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(dev_priv, gpio_number, value);
 	else if (DISPLAY_VER(dev_priv) >= 11)
-		icl_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(dev_priv))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(dev_priv))
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Follow the contemporary conventions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b2c0cc11f8c1..8b962f2ac475 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -454,11 +454,11 @@ static void icl_native_gpio_set_value(struct drm_i915_private *dev_priv,
 static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 {
 	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	u8 gpio_source, gpio_index = 0, gpio_number;
 	bool value;
-	bool native = DISPLAY_VER(dev_priv) >= 11;
+	bool native = DISPLAY_VER(i915) >= 11;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		gpio_index = *data++;
@@ -477,16 +477,16 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	/* pull up/down */
 	value = *data++ & 1;
 
-	drm_dbg_kms(&dev_priv->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
+	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
 
 	if (native)
-		icl_native_gpio_set_value(dev_priv, gpio_number, value);
-	else if (DISPLAY_VER(dev_priv) >= 11)
+		icl_native_gpio_set_value(i915, gpio_number, value);
+	else if (DISPLAY_VER(i915) >= 11)
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-	else if (IS_VALLEYVIEW(dev_priv))
+	else if (IS_VALLEYVIEW(i915))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
-	else if (IS_CHERRYVIEW(dev_priv))
+	else if (IS_CHERRYVIEW(i915))
 		chv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Follow the contemporary conventions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b2c0cc11f8c1..8b962f2ac475 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -454,11 +454,11 @@ static void icl_native_gpio_set_value(struct drm_i915_private *dev_priv,
 static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 {
 	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	u8 gpio_source, gpio_index = 0, gpio_number;
 	bool value;
-	bool native = DISPLAY_VER(dev_priv) >= 11;
+	bool native = DISPLAY_VER(i915) >= 11;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		gpio_index = *data++;
@@ -477,16 +477,16 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	/* pull up/down */
 	value = *data++ & 1;
 
-	drm_dbg_kms(&dev_priv->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
+	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
 
 	if (native)
-		icl_native_gpio_set_value(dev_priv, gpio_number, value);
-	else if (DISPLAY_VER(dev_priv) >= 11)
+		icl_native_gpio_set_value(i915, gpio_number, value);
+	else if (DISPLAY_VER(i915) >= 11)
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-	else if (IS_VALLEYVIEW(dev_priv))
+	else if (IS_VALLEYVIEW(i915))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
-	else if (IS_CHERRYVIEW(dev_priv))
+	else if (IS_CHERRYVIEW(i915))
 		chv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 02/16] drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Follow the contemporary conventions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b2c0cc11f8c1..8b962f2ac475 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -454,11 +454,11 @@ static void icl_native_gpio_set_value(struct drm_i915_private *dev_priv,
 static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 {
 	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
+	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	u8 gpio_source, gpio_index = 0, gpio_number;
 	bool value;
-	bool native = DISPLAY_VER(dev_priv) >= 11;
+	bool native = DISPLAY_VER(i915) >= 11;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		gpio_index = *data++;
@@ -477,16 +477,16 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	/* pull up/down */
 	value = *data++ & 1;
 
-	drm_dbg_kms(&dev_priv->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
+	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
 
 	if (native)
-		icl_native_gpio_set_value(dev_priv, gpio_number, value);
-	else if (DISPLAY_VER(dev_priv) >= 11)
+		icl_native_gpio_set_value(i915, gpio_number, value);
+	else if (DISPLAY_VER(i915) >= 11)
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-	else if (IS_VALLEYVIEW(dev_priv))
+	else if (IS_VALLEYVIEW(i915))
 		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
-	else if (IS_CHERRYVIEW(dev_priv))
+	else if (IS_CHERRYVIEW(i915))
 		chv_exec_gpio(connector, gpio_source, gpio_number, value);
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 31 +++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8b962f2ac475..11073efe26c0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -456,26 +456,29 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	struct drm_device *dev = intel_dsi->base.base.dev;
 	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
-	u8 gpio_source, gpio_index = 0, gpio_number;
+	u8 gpio_source = 0, gpio_index = 0, gpio_number;
 	bool value;
+	int size;
 	bool native = DISPLAY_VER(i915) >= 11;
 
-	if (connector->panel.vbt.dsi.seq_version >= 3)
-		gpio_index = *data++;
+	if (connector->panel.vbt.dsi.seq_version >= 3) {
+		size = 3;
 
-	gpio_number = *data++;
+		gpio_index = data[0];
+		gpio_number = data[1];
+		value = data[2] & BIT(0);
 
-	/* gpio source in sequence v2 only */
-	if (connector->panel.vbt.dsi.seq_version == 2)
-		gpio_source = (*data >> 1) & 3;
-	else
-		gpio_source = 0;
+		if (connector->panel.vbt.dsi.seq_version >= 4 && data[2] & BIT(1))
+			native = false;
+	} else {
+		size = 2;
 
-	if (connector->panel.vbt.dsi.seq_version >= 4 && *data & BIT(1))
-		native = false;
+		gpio_number = data[0];
+		value = data[1] & BIT(0);
 
-	/* pull up/down */
-	value = *data++ & 1;
+		if (connector->panel.vbt.dsi.seq_version == 2)
+			gpio_source = (data[1] >> 1) & 3;
+	}
 
 	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
@@ -491,7 +494,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 
-	return data;
+	return data + size;
 }
 
 #ifdef CONFIG_ACPI
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 31 +++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8b962f2ac475..11073efe26c0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -456,26 +456,29 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	struct drm_device *dev = intel_dsi->base.base.dev;
 	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
-	u8 gpio_source, gpio_index = 0, gpio_number;
+	u8 gpio_source = 0, gpio_index = 0, gpio_number;
 	bool value;
+	int size;
 	bool native = DISPLAY_VER(i915) >= 11;
 
-	if (connector->panel.vbt.dsi.seq_version >= 3)
-		gpio_index = *data++;
+	if (connector->panel.vbt.dsi.seq_version >= 3) {
+		size = 3;
 
-	gpio_number = *data++;
+		gpio_index = data[0];
+		gpio_number = data[1];
+		value = data[2] & BIT(0);
 
-	/* gpio source in sequence v2 only */
-	if (connector->panel.vbt.dsi.seq_version == 2)
-		gpio_source = (*data >> 1) & 3;
-	else
-		gpio_source = 0;
+		if (connector->panel.vbt.dsi.seq_version >= 4 && data[2] & BIT(1))
+			native = false;
+	} else {
+		size = 2;
 
-	if (connector->panel.vbt.dsi.seq_version >= 4 && *data & BIT(1))
-		native = false;
+		gpio_number = data[0];
+		value = data[1] & BIT(0);
 
-	/* pull up/down */
-	value = *data++ & 1;
+		if (connector->panel.vbt.dsi.seq_version == 2)
+			gpio_source = (data[1] >> 1) & 3;
+	}
 
 	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
@@ -491,7 +494,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 
-	return data;
+	return data + size;
 }
 
 #ifdef CONFIG_ACPI
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 03/16] drm/i915/dsi: clarify GPIO exec sequence

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

With the various sequence versions and pointer increments interleaved,
it's a bit hard to decipher what's going on. Add separate paths for
different sequence versions.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 31 +++++++++++---------
 1 file changed, 17 insertions(+), 14 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8b962f2ac475..11073efe26c0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -456,26 +456,29 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	struct drm_device *dev = intel_dsi->base.base.dev;
 	struct drm_i915_private *i915 = to_i915(dev);
 	struct intel_connector *connector = intel_dsi->attached_connector;
-	u8 gpio_source, gpio_index = 0, gpio_number;
+	u8 gpio_source = 0, gpio_index = 0, gpio_number;
 	bool value;
+	int size;
 	bool native = DISPLAY_VER(i915) >= 11;
 
-	if (connector->panel.vbt.dsi.seq_version >= 3)
-		gpio_index = *data++;
+	if (connector->panel.vbt.dsi.seq_version >= 3) {
+		size = 3;
 
-	gpio_number = *data++;
+		gpio_index = data[0];
+		gpio_number = data[1];
+		value = data[2] & BIT(0);
 
-	/* gpio source in sequence v2 only */
-	if (connector->panel.vbt.dsi.seq_version == 2)
-		gpio_source = (*data >> 1) & 3;
-	else
-		gpio_source = 0;
+		if (connector->panel.vbt.dsi.seq_version >= 4 && data[2] & BIT(1))
+			native = false;
+	} else {
+		size = 2;
 
-	if (connector->panel.vbt.dsi.seq_version >= 4 && *data & BIT(1))
-		native = false;
+		gpio_number = data[0];
+		value = data[1] & BIT(0);
 
-	/* pull up/down */
-	value = *data++ & 1;
+		if (connector->panel.vbt.dsi.seq_version == 2)
+			gpio_source = (data[1] >> 1) & 3;
+	}
 
 	drm_dbg_kms(&i915->drm, "GPIO index %u, number %u, source %u, native %s, set to %s\n",
 		    gpio_index, gpio_number, gpio_source, str_yes_no(native), str_on_off(value));
@@ -491,7 +494,7 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	else
 		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
 
-	return data;
+	return data + size;
 }
 
 #ifdef CONFIG_ACPI
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 11073efe26c0..f977d63a0ad4 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,8 +243,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void vlv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void vlv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct gpio_map *map;
@@ -291,8 +291,8 @@ static void vlv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void chv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void chv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	u16 cfg0, cfg1;
@@ -345,8 +345,8 @@ static void chv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void bxt_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void bxt_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
-		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
+		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
-		chv_exec_gpio(connector, gpio_source, gpio_number, value);
+		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 11073efe26c0..f977d63a0ad4 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,8 +243,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void vlv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void vlv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct gpio_map *map;
@@ -291,8 +291,8 @@ static void vlv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void chv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void chv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	u16 cfg0, cfg1;
@@ -345,8 +345,8 @@ static void chv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void bxt_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void bxt_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
-		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
+		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
-		chv_exec_gpio(connector, gpio_source, gpio_number, value);
+		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 04/16] drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

The lowest level functions are about setting GPIO values, not about
executing any sequences anymore.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 11073efe26c0..f977d63a0ad4 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,8 +243,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void vlv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void vlv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	struct gpio_map *map;
@@ -291,8 +291,8 @@ static void vlv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void chv_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void chv_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	u16 cfg0, cfg1;
@@ -345,8 +345,8 @@ static void chv_exec_gpio(struct intel_connector *connector,
 	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
-static void bxt_exec_gpio(struct intel_connector *connector,
-			  u8 gpio_source, u8 gpio_index, bool value)
+static void bxt_gpio_set_value(struct intel_connector *connector,
+			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
-		vlv_exec_gpio(connector, gpio_source, gpio_number, value);
+		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
-		chv_exec_gpio(connector, gpio_source, gpio_number, value);
+		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_exec_gpio(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Drop the unused parameter.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index f977d63a0ad4..4af43cf3cee0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -346,7 +346,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-			       u8 gpio_source, u8 gpio_index, bool value)
+			       u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Drop the unused parameter.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index f977d63a0ad4..4af43cf3cee0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -346,7 +346,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-			       u8 gpio_source, u8 gpio_index, bool value)
+			       u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 05/16] drm/i915/dsi: bxt/icl GPIO set value do not need gpio source

[Andy Shevchenko]

From: Jani Nikula <jani.nikula@intel.com>

Drop the unused parameter.

Cc: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Jani Nikula <jani.nikula@intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index f977d63a0ad4..4af43cf3cee0 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -346,7 +346,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-			       u8 gpio_source, u8 gpio_index, bool value)
+			       u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -486,13 +486,13 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
 	else if (DISPLAY_VER(i915) >= 11)
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else
-		bxt_gpio_set_value(connector, gpio_source, gpio_index, value);
+		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition

[Andy Shevchenko]

Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4af43cf3cee0..290a112f1b63 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -702,13 +702,10 @@ static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		data += 4;
 
-	while (1) {
+	while (*data != MIPI_SEQ_ELEM_END) {
 		u8 operation_byte = *data++;
 		u8 operation_size = 0;
 
-		if (operation_byte == MIPI_SEQ_ELEM_END)
-			break;
-
 		if (operation_byte < ARRAY_SIZE(exec_elem))
 			mipi_elem_exec = exec_elem[operation_byte];
 		else
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition

[Andy Shevchenko]

Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4af43cf3cee0..290a112f1b63 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -702,13 +702,10 @@ static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		data += 4;
 
-	while (1) {
+	while (*data != MIPI_SEQ_ELEM_END) {
 		u8 operation_byte = *data++;
 		u8 operation_size = 0;
 
-		if (operation_byte == MIPI_SEQ_ELEM_END)
-			break;
-
 		if (operation_byte < ARRAY_SIZE(exec_elem))
 			mipi_elem_exec = exec_elem[operation_byte];
 		else
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 06/16] drm/i915/dsi: Replace while(1) with one with clear exit condition

[Andy Shevchenko]

Move existing condition to while(), so it will be clear on what
circumstances the loop is successfully finishing.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4af43cf3cee0..290a112f1b63 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -702,13 +702,10 @@ static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
 	if (connector->panel.vbt.dsi.seq_version >= 3)
 		data += 4;
 
-	while (1) {
+	while (*data != MIPI_SEQ_ELEM_END) {
 		u8 operation_byte = *data++;
 		u8 operation_size = 0;
 
-		if (operation_byte == MIPI_SEQ_ELEM_END)
-			break;
-
 		if (operation_byte < ARRAY_SIZE(exec_elem))
 			mipi_elem_exec = exec_elem[operation_byte];
 		else
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else'

[Andy Shevchenko]

In the snippets like the following

	if (...)
		return / goto / break / continue ...;
	else
		...

the 'else' is redundant. Get rid of it.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 58 ++++++++++----------
 1 file changed, 28 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 290a112f1b63..4ed5ede9ec5b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -142,7 +142,7 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
 	if (seq_port) {
 		if (intel_dsi->ports & BIT(PORT_B))
 			return PORT_B;
-		else if (intel_dsi->ports & BIT(PORT_C))
+		if (intel_dsi->ports & BIT(PORT_C))
 			return PORT_C;
 	}
 
@@ -670,8 +670,8 @@ static const char *sequence_name(enum mipi_seq seq_id)
 {
 	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
 		return seq_name[seq_id];
-	else
-		return "(unknown)";
+
+	return "(unknown)";
 }
 
 static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
@@ -865,36 +865,34 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id)
 	 * multiply by 100 to preserve remainder
 	 */
 	if (intel_dsi->video_mode == BURST_MODE) {
-		if (mipi_config->target_burst_mode_freq) {
-			u32 bitrate = intel_dsi_bitrate(intel_dsi);
+		u32 bitrate;
 
-			/*
-			 * Sometimes the VBT contains a slightly lower clock,
-			 * then the bitrate we have calculated, in this case
-			 * just replace it with the calculated bitrate.
-			 */
-			if (mipi_config->target_burst_mode_freq < bitrate &&
-			    intel_fuzzy_clock_check(
-					mipi_config->target_burst_mode_freq,
-					bitrate))
-				mipi_config->target_burst_mode_freq = bitrate;
-
-			if (mipi_config->target_burst_mode_freq < bitrate) {
-				drm_err(&dev_priv->drm,
-					"Burst mode freq is less than computed\n");
-				return false;
-			}
-
-			burst_mode_ratio = DIV_ROUND_UP(
-				mipi_config->target_burst_mode_freq * 100,
-				bitrate);
-
-			intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
-		} else {
-			drm_err(&dev_priv->drm,
-				"Burst mode target is not set\n");
+		if (mipi_config->target_burst_mode_freq == 0) {
+			drm_err(&dev_priv->drm, "Burst mode target is not set\n");
 			return false;
 		}
+
+		bitrate = intel_dsi_bitrate(intel_dsi);
+
+		/*
+		 * Sometimes the VBT contains a slightly lower clock, then
+		 * the bitrate we have calculated, in this case just replace it
+		 * with the calculated bitrate.
+		 */
+		if (mipi_config->target_burst_mode_freq < bitrate &&
+		    intel_fuzzy_clock_check(mipi_config->target_burst_mode_freq,
+					    bitrate))
+			mipi_config->target_burst_mode_freq = bitrate;
+
+		if (mipi_config->target_burst_mode_freq < bitrate) {
+			drm_err(&dev_priv->drm, "Burst mode freq is less than computed\n");
+			return false;
+		}
+
+		burst_mode_ratio =
+			DIV_ROUND_UP(mipi_config->target_burst_mode_freq * 100, bitrate);
+
+		intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
 	} else
 		burst_mode_ratio = 100;
 
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else'

[Andy Shevchenko]

In the snippets like the following

	if (...)
		return / goto / break / continue ...;
	else
		...

the 'else' is redundant. Get rid of it.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 58 ++++++++++----------
 1 file changed, 28 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 290a112f1b63..4ed5ede9ec5b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -142,7 +142,7 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
 	if (seq_port) {
 		if (intel_dsi->ports & BIT(PORT_B))
 			return PORT_B;
-		else if (intel_dsi->ports & BIT(PORT_C))
+		if (intel_dsi->ports & BIT(PORT_C))
 			return PORT_C;
 	}
 
@@ -670,8 +670,8 @@ static const char *sequence_name(enum mipi_seq seq_id)
 {
 	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
 		return seq_name[seq_id];
-	else
-		return "(unknown)";
+
+	return "(unknown)";
 }
 
 static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
@@ -865,36 +865,34 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id)
 	 * multiply by 100 to preserve remainder
 	 */
 	if (intel_dsi->video_mode == BURST_MODE) {
-		if (mipi_config->target_burst_mode_freq) {
-			u32 bitrate = intel_dsi_bitrate(intel_dsi);
+		u32 bitrate;
 
-			/*
-			 * Sometimes the VBT contains a slightly lower clock,
-			 * then the bitrate we have calculated, in this case
-			 * just replace it with the calculated bitrate.
-			 */
-			if (mipi_config->target_burst_mode_freq < bitrate &&
-			    intel_fuzzy_clock_check(
-					mipi_config->target_burst_mode_freq,
-					bitrate))
-				mipi_config->target_burst_mode_freq = bitrate;
-
-			if (mipi_config->target_burst_mode_freq < bitrate) {
-				drm_err(&dev_priv->drm,
-					"Burst mode freq is less than computed\n");
-				return false;
-			}
-
-			burst_mode_ratio = DIV_ROUND_UP(
-				mipi_config->target_burst_mode_freq * 100,
-				bitrate);
-
-			intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
-		} else {
-			drm_err(&dev_priv->drm,
-				"Burst mode target is not set\n");
+		if (mipi_config->target_burst_mode_freq == 0) {
+			drm_err(&dev_priv->drm, "Burst mode target is not set\n");
 			return false;
 		}
+
+		bitrate = intel_dsi_bitrate(intel_dsi);
+
+		/*
+		 * Sometimes the VBT contains a slightly lower clock, then
+		 * the bitrate we have calculated, in this case just replace it
+		 * with the calculated bitrate.
+		 */
+		if (mipi_config->target_burst_mode_freq < bitrate &&
+		    intel_fuzzy_clock_check(mipi_config->target_burst_mode_freq,
+					    bitrate))
+			mipi_config->target_burst_mode_freq = bitrate;
+
+		if (mipi_config->target_burst_mode_freq < bitrate) {
+			drm_err(&dev_priv->drm, "Burst mode freq is less than computed\n");
+			return false;
+		}
+
+		burst_mode_ratio =
+			DIV_ROUND_UP(mipi_config->target_burst_mode_freq * 100, bitrate);
+
+		intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
 	} else
 		burst_mode_ratio = 100;
 
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 07/16] drm/i915/dsi: Get rid of redundant 'else'

[Andy Shevchenko]

In the snippets like the following

	if (...)
		return / goto / break / continue ...;
	else
		...

the 'else' is redundant. Get rid of it.

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 58 ++++++++++----------
 1 file changed, 28 insertions(+), 30 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 290a112f1b63..4ed5ede9ec5b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -142,7 +142,7 @@ static enum port intel_dsi_seq_port_to_port(struct intel_dsi *intel_dsi,
 	if (seq_port) {
 		if (intel_dsi->ports & BIT(PORT_B))
 			return PORT_B;
-		else if (intel_dsi->ports & BIT(PORT_C))
+		if (intel_dsi->ports & BIT(PORT_C))
 			return PORT_C;
 	}
 
@@ -670,8 +670,8 @@ static const char *sequence_name(enum mipi_seq seq_id)
 {
 	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
 		return seq_name[seq_id];
-	else
-		return "(unknown)";
+
+	return "(unknown)";
 }
 
 static void intel_dsi_vbt_exec(struct intel_dsi *intel_dsi,
@@ -865,36 +865,34 @@ bool intel_dsi_vbt_init(struct intel_dsi *intel_dsi, u16 panel_id)
 	 * multiply by 100 to preserve remainder
 	 */
 	if (intel_dsi->video_mode == BURST_MODE) {
-		if (mipi_config->target_burst_mode_freq) {
-			u32 bitrate = intel_dsi_bitrate(intel_dsi);
+		u32 bitrate;
 
-			/*
-			 * Sometimes the VBT contains a slightly lower clock,
-			 * then the bitrate we have calculated, in this case
-			 * just replace it with the calculated bitrate.
-			 */
-			if (mipi_config->target_burst_mode_freq < bitrate &&
-			    intel_fuzzy_clock_check(
-					mipi_config->target_burst_mode_freq,
-					bitrate))
-				mipi_config->target_burst_mode_freq = bitrate;
-
-			if (mipi_config->target_burst_mode_freq < bitrate) {
-				drm_err(&dev_priv->drm,
-					"Burst mode freq is less than computed\n");
-				return false;
-			}
-
-			burst_mode_ratio = DIV_ROUND_UP(
-				mipi_config->target_burst_mode_freq * 100,
-				bitrate);
-
-			intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
-		} else {
-			drm_err(&dev_priv->drm,
-				"Burst mode target is not set\n");
+		if (mipi_config->target_burst_mode_freq == 0) {
+			drm_err(&dev_priv->drm, "Burst mode target is not set\n");
 			return false;
 		}
+
+		bitrate = intel_dsi_bitrate(intel_dsi);
+
+		/*
+		 * Sometimes the VBT contains a slightly lower clock, then
+		 * the bitrate we have calculated, in this case just replace it
+		 * with the calculated bitrate.
+		 */
+		if (mipi_config->target_burst_mode_freq < bitrate &&
+		    intel_fuzzy_clock_check(mipi_config->target_burst_mode_freq,
+					    bitrate))
+			mipi_config->target_burst_mode_freq = bitrate;
+
+		if (mipi_config->target_burst_mode_freq < bitrate) {
+			drm_err(&dev_priv->drm, "Burst mode freq is less than computed\n");
+			return false;
+		}
+
+		burst_mode_ratio =
+			DIV_ROUND_UP(mipi_config->target_burst_mode_freq * 100, bitrate);
+
+		intel_dsi->pclk = DIV_ROUND_UP(intel_dsi->pclk * burst_mode_ratio, 100);
 	} else
 		burst_mode_ratio = 100;
 
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name

[Andy Shevchenko]

Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4ed5ede9ec5b..d270437217b3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -653,6 +653,7 @@ static const fn_mipi_elem_exec exec_elem[] = {
  */
 
 static const char * const seq_name[] = {
+	[MIPI_SEQ_END] = "MIPI_SEQ_END",
 	[MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
 	[MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP",
 	[MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON",
@@ -668,7 +669,7 @@ static const char * const seq_name[] = {
 
 static const char *sequence_name(enum mipi_seq seq_id)
 {
-	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
+	if (seq_id < ARRAY_SIZE(seq_name))
 		return seq_name[seq_id];
 
 	return "(unknown)";
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name

[Andy Shevchenko]

Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4ed5ede9ec5b..d270437217b3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -653,6 +653,7 @@ static const fn_mipi_elem_exec exec_elem[] = {
  */
 
 static const char * const seq_name[] = {
+	[MIPI_SEQ_END] = "MIPI_SEQ_END",
 	[MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
 	[MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP",
 	[MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON",
@@ -668,7 +669,7 @@ static const char * const seq_name[] = {
 
 static const char *sequence_name(enum mipi_seq seq_id)
 {
-	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
+	if (seq_id < ARRAY_SIZE(seq_name))
 		return seq_name[seq_id];
 
 	return "(unknown)";
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 08/16] drm/i915/dsi: Replace check with a (missing) MIPI sequence name

[Andy Shevchenko]

Names of the MIPI sequence steps are sequential and defined, no
need to check for the gaps. However in seq_name the MIPI_SEQ_END
is missing. Add it there, and drop unneeded NULL check in
sequence_name().

Reviewed-by: Andi Shyti <andi.shyti@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 4ed5ede9ec5b..d270437217b3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -653,6 +653,7 @@ static const fn_mipi_elem_exec exec_elem[] = {
  */
 
 static const char * const seq_name[] = {
+	[MIPI_SEQ_END] = "MIPI_SEQ_END",
 	[MIPI_SEQ_DEASSERT_RESET] = "MIPI_SEQ_DEASSERT_RESET",
 	[MIPI_SEQ_INIT_OTP] = "MIPI_SEQ_INIT_OTP",
 	[MIPI_SEQ_DISPLAY_ON] = "MIPI_SEQ_DISPLAY_ON",
@@ -668,7 +669,7 @@ static const char * const seq_name[] = {
 
 static const char *sequence_name(enum mipi_seq seq_id)
 {
-	if (seq_id < ARRAY_SIZE(seq_name) && seq_name[seq_id])
+	if (seq_id < ARRAY_SIZE(seq_name))
 		return seq_name[seq_id];
 
 	return "(unknown)";
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

To properly deal with GPIOs used in MIPI panel sequences a temporary
GPIO lookup will be used. Since there can only be 1 GPIO lookup table
for the "0000:00:02.0" device this will not work if the GPIO lookup
table used by intel_dsi_vbt_gpio_init() is still registered.

After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the "0000:00:02.0"
device can be added.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 25 +++++++-------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index d270437217b3..8e6beef90e5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -955,6 +955,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
 	enum gpiod_flags flags = panel_is_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
+	struct gpiod_lookup_table *gpiod_lookup_table = NULL;
 	bool want_backlight_gpio = false;
 	bool want_panel_gpio = false;
 	struct pinctrl *pinctrl;
@@ -962,12 +963,12 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 
 	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
 	    mipi_config->pwm_blc == PPS_BLC_PMIC) {
-		gpiod_add_lookup_table(&pmic_panel_gpio_table);
+		gpiod_lookup_table = &pmic_panel_gpio_table;
 		want_panel_gpio = true;
 	}
 
 	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		gpiod_add_lookup_table(&soc_panel_gpio_table);
+		gpiod_lookup_table = &soc_panel_gpio_table;
 		want_panel_gpio = true;
 		want_backlight_gpio = true;
 
@@ -984,6 +985,9 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 				"Failed to set pinmux to PWM\n");
 	}
 
+	if (gpiod_lookup_table)
+		gpiod_add_lookup_table(gpiod_lookup_table);
+
 	if (want_panel_gpio) {
 		intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags);
 		if (IS_ERR(intel_dsi->gpio_panel)) {
@@ -1002,15 +1006,13 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 			intel_dsi->gpio_backlight = NULL;
 		}
 	}
+
+	if (gpiod_lookup_table)
+		gpiod_remove_lookup_table(gpiod_lookup_table);
 }
 
 void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 {
-	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
-	struct intel_connector *connector = intel_dsi->attached_connector;
-	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
-
 	if (intel_dsi->gpio_panel) {
 		gpiod_put(intel_dsi->gpio_panel);
 		intel_dsi->gpio_panel = NULL;
@@ -1020,13 +1022,4 @@ void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 		gpiod_put(intel_dsi->gpio_backlight);
 		intel_dsi->gpio_backlight = NULL;
 	}
-
-	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
-	    mipi_config->pwm_blc == PPS_BLC_PMIC)
-		gpiod_remove_lookup_table(&pmic_panel_gpio_table);
-
-	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		pinctrl_unregister_mappings(soc_pwm_pinctrl_map);
-		gpiod_remove_lookup_table(&soc_panel_gpio_table);
-	}
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

To properly deal with GPIOs used in MIPI panel sequences a temporary
GPIO lookup will be used. Since there can only be 1 GPIO lookup table
for the "0000:00:02.0" device this will not work if the GPIO lookup
table used by intel_dsi_vbt_gpio_init() is still registered.

After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the "0000:00:02.0"
device can be added.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 25 +++++++-------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index d270437217b3..8e6beef90e5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -955,6 +955,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
 	enum gpiod_flags flags = panel_is_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
+	struct gpiod_lookup_table *gpiod_lookup_table = NULL;
 	bool want_backlight_gpio = false;
 	bool want_panel_gpio = false;
 	struct pinctrl *pinctrl;
@@ -962,12 +963,12 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 
 	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
 	    mipi_config->pwm_blc == PPS_BLC_PMIC) {
-		gpiod_add_lookup_table(&pmic_panel_gpio_table);
+		gpiod_lookup_table = &pmic_panel_gpio_table;
 		want_panel_gpio = true;
 	}
 
 	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		gpiod_add_lookup_table(&soc_panel_gpio_table);
+		gpiod_lookup_table = &soc_panel_gpio_table;
 		want_panel_gpio = true;
 		want_backlight_gpio = true;
 
@@ -984,6 +985,9 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 				"Failed to set pinmux to PWM\n");
 	}
 
+	if (gpiod_lookup_table)
+		gpiod_add_lookup_table(gpiod_lookup_table);
+
 	if (want_panel_gpio) {
 		intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags);
 		if (IS_ERR(intel_dsi->gpio_panel)) {
@@ -1002,15 +1006,13 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 			intel_dsi->gpio_backlight = NULL;
 		}
 	}
+
+	if (gpiod_lookup_table)
+		gpiod_remove_lookup_table(gpiod_lookup_table);
 }
 
 void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 {
-	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
-	struct intel_connector *connector = intel_dsi->attached_connector;
-	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
-
 	if (intel_dsi->gpio_panel) {
 		gpiod_put(intel_dsi->gpio_panel);
 		intel_dsi->gpio_panel = NULL;
@@ -1020,13 +1022,4 @@ void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 		gpiod_put(intel_dsi->gpio_backlight);
 		intel_dsi->gpio_backlight = NULL;
 	}
-
-	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
-	    mipi_config->pwm_blc == PPS_BLC_PMIC)
-		gpiod_remove_lookup_table(&pmic_panel_gpio_table);
-
-	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		pinctrl_unregister_mappings(soc_pwm_pinctrl_map);
-		gpiod_remove_lookup_table(&soc_panel_gpio_table);
-	}
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 09/16] drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

To properly deal with GPIOs used in MIPI panel sequences a temporary
GPIO lookup will be used. Since there can only be 1 GPIO lookup table
for the "0000:00:02.0" device this will not work if the GPIO lookup
table used by intel_dsi_vbt_gpio_init() is still registered.

After getting the "backlight" and "panel" GPIOs the lookup table
registered by intel_dsi_vbt_gpio_init() is no longer necessary,
remove it so that another temporary lookup-table for the "0000:00:02.0"
device can be added.

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 25 +++++++-------------
 1 file changed, 9 insertions(+), 16 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index d270437217b3..8e6beef90e5e 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -955,6 +955,7 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 	struct intel_connector *connector = intel_dsi->attached_connector;
 	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
 	enum gpiod_flags flags = panel_is_on ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW;
+	struct gpiod_lookup_table *gpiod_lookup_table = NULL;
 	bool want_backlight_gpio = false;
 	bool want_panel_gpio = false;
 	struct pinctrl *pinctrl;
@@ -962,12 +963,12 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 
 	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
 	    mipi_config->pwm_blc == PPS_BLC_PMIC) {
-		gpiod_add_lookup_table(&pmic_panel_gpio_table);
+		gpiod_lookup_table = &pmic_panel_gpio_table;
 		want_panel_gpio = true;
 	}
 
 	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		gpiod_add_lookup_table(&soc_panel_gpio_table);
+		gpiod_lookup_table = &soc_panel_gpio_table;
 		want_panel_gpio = true;
 		want_backlight_gpio = true;
 
@@ -984,6 +985,9 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 				"Failed to set pinmux to PWM\n");
 	}
 
+	if (gpiod_lookup_table)
+		gpiod_add_lookup_table(gpiod_lookup_table);
+
 	if (want_panel_gpio) {
 		intel_dsi->gpio_panel = gpiod_get(dev->dev, "panel", flags);
 		if (IS_ERR(intel_dsi->gpio_panel)) {
@@ -1002,15 +1006,13 @@ void intel_dsi_vbt_gpio_init(struct intel_dsi *intel_dsi, bool panel_is_on)
 			intel_dsi->gpio_backlight = NULL;
 		}
 	}
+
+	if (gpiod_lookup_table)
+		gpiod_remove_lookup_table(gpiod_lookup_table);
 }
 
 void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 {
-	struct drm_device *dev = intel_dsi->base.base.dev;
-	struct drm_i915_private *dev_priv = to_i915(dev);
-	struct intel_connector *connector = intel_dsi->attached_connector;
-	struct mipi_config *mipi_config = connector->panel.vbt.dsi.config;
-
 	if (intel_dsi->gpio_panel) {
 		gpiod_put(intel_dsi->gpio_panel);
 		intel_dsi->gpio_panel = NULL;
@@ -1020,13 +1022,4 @@ void intel_dsi_vbt_gpio_cleanup(struct intel_dsi *intel_dsi)
 		gpiod_put(intel_dsi->gpio_backlight);
 		intel_dsi->gpio_backlight = NULL;
 	}
-
-	if ((IS_VALLEYVIEW(dev_priv) || IS_CHERRYVIEW(dev_priv)) &&
-	    mipi_config->pwm_blc == PPS_BLC_PMIC)
-		gpiod_remove_lookup_table(&pmic_panel_gpio_table);
-
-	if (IS_VALLEYVIEW(dev_priv) && mipi_config->pwm_blc == PPS_BLC_SOC) {
-		pinctrl_unregister_mappings(soc_pwm_pinctrl_map);
-		gpiod_remove_lookup_table(&soc_panel_gpio_table);
-	}
 }
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

Fix wrong initial value for GPIOs in bxt_gpio_set_value().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8e6beef90e5e..0f9da0168a7b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -356,9 +356,7 @@ static void bxt_gpio_set_value(struct intel_connector *connector,
 	if (!gpio_desc) {
 		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
 						 NULL, gpio_index,
-						 value ? GPIOD_OUT_LOW :
-						 GPIOD_OUT_HIGH);
-
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR_OR_NULL(gpio_desc)) {
 			drm_err(&dev_priv->drm,
 				"GPIO index %u request failed (%ld)\n",
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

Fix wrong initial value for GPIOs in bxt_gpio_set_value().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8e6beef90e5e..0f9da0168a7b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -356,9 +356,7 @@ static void bxt_gpio_set_value(struct intel_connector *connector,
 	if (!gpio_desc) {
 		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
 						 NULL, gpio_index,
-						 value ? GPIOD_OUT_LOW :
-						 GPIOD_OUT_HIGH);
-
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR_OR_NULL(gpio_desc)) {
 			drm_err(&dev_priv->drm,
 				"GPIO index %u request failed (%ld)\n",
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 10/16] drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()

[Andy Shevchenko]

From: Hans de Goede <hdegoede@redhat.com>

Fix wrong initial value for GPIOs in bxt_gpio_set_value().

Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 8e6beef90e5e..0f9da0168a7b 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -356,9 +356,7 @@ static void bxt_gpio_set_value(struct intel_connector *connector,
 	if (!gpio_desc) {
 		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
 						 NULL, gpio_index,
-						 value ? GPIOD_OUT_LOW :
-						 GPIOD_OUT_HIGH);
-
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR_OR_NULL(gpio_desc)) {
 			drm_err(&dev_priv->drm,
 				"GPIO index %u request failed (%ld)\n",
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper

[Andy Shevchenko]

Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++++++++++---------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 0f9da0168a7b..9847a92fdfc3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,6 +243,31 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
+static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
+			       u8 gpio_index, bool value)
+{
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	/* XXX: this table is a quick ugly hack. */
+	static struct gpio_desc *soc_gpio_table[U8_MAX + 1];
+	struct gpio_desc *gpio_desc = soc_gpio_table[gpio_index];
+
+	if (gpio_desc) {
+		gpiod_set_value(gpio_desc, value);
+	} else {
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
+						 con_id, gpio_index,
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
+		if (IS_ERR(gpio_desc)) {
+			drm_err(&dev_priv->drm,
+				"GPIO index %u request failed (%pe)\n",
+				gpio_index, gpio_desc);
+			return;
+		}
+
+		soc_gpio_table[gpio_index] = gpio_desc;
+	}
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
@@ -348,26 +373,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	/* XXX: this table is a quick ugly hack. */
-	static struct gpio_desc *bxt_gpio_table[U8_MAX + 1];
-	struct gpio_desc *gpio_desc = bxt_gpio_table[gpio_index];
-
-	if (!gpio_desc) {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 NULL, gpio_index,
-						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
-		if (IS_ERR_OR_NULL(gpio_desc)) {
-			drm_err(&dev_priv->drm,
-				"GPIO index %u request failed (%ld)\n",
-				gpio_index, PTR_ERR(gpio_desc));
-			return;
-		}
-
-		bxt_gpio_table[gpio_index] = gpio_desc;
-	}
-
-	gpiod_set_value(gpio_desc, value);
+	soc_gpio_set_value(connector, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper

[Andy Shevchenko]

Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++++++++++---------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 0f9da0168a7b..9847a92fdfc3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,6 +243,31 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
+static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
+			       u8 gpio_index, bool value)
+{
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	/* XXX: this table is a quick ugly hack. */
+	static struct gpio_desc *soc_gpio_table[U8_MAX + 1];
+	struct gpio_desc *gpio_desc = soc_gpio_table[gpio_index];
+
+	if (gpio_desc) {
+		gpiod_set_value(gpio_desc, value);
+	} else {
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
+						 con_id, gpio_index,
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
+		if (IS_ERR(gpio_desc)) {
+			drm_err(&dev_priv->drm,
+				"GPIO index %u request failed (%pe)\n",
+				gpio_index, gpio_desc);
+			return;
+		}
+
+		soc_gpio_table[gpio_index] = gpio_desc;
+	}
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
@@ -348,26 +373,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	/* XXX: this table is a quick ugly hack. */
-	static struct gpio_desc *bxt_gpio_table[U8_MAX + 1];
-	struct gpio_desc *gpio_desc = bxt_gpio_table[gpio_index];
-
-	if (!gpio_desc) {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 NULL, gpio_index,
-						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
-		if (IS_ERR_OR_NULL(gpio_desc)) {
-			drm_err(&dev_priv->drm,
-				"GPIO index %u request failed (%ld)\n",
-				gpio_index, PTR_ERR(gpio_desc));
-			return;
-		}
-
-		bxt_gpio_table[gpio_index] = gpio_desc;
-	}
-
-	gpiod_set_value(gpio_desc, value);
+	soc_gpio_set_value(connector, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 11/16] drm/i915/dsi: Extract common soc_gpio_set_value() helper

[Andy Shevchenko]

Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 46 +++++++++++---------
 1 file changed, 26 insertions(+), 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 0f9da0168a7b..9847a92fdfc3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -243,6 +243,31 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
+static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
+			       u8 gpio_index, bool value)
+{
+	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
+	/* XXX: this table is a quick ugly hack. */
+	static struct gpio_desc *soc_gpio_table[U8_MAX + 1];
+	struct gpio_desc *gpio_desc = soc_gpio_table[gpio_index];
+
+	if (gpio_desc) {
+		gpiod_set_value(gpio_desc, value);
+	} else {
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
+						 con_id, gpio_index,
+						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
+		if (IS_ERR(gpio_desc)) {
+			drm_err(&dev_priv->drm,
+				"GPIO index %u request failed (%pe)\n",
+				gpio_index, gpio_desc);
+			return;
+		}
+
+		soc_gpio_table[gpio_index] = gpio_desc;
+	}
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
@@ -348,26 +373,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	/* XXX: this table is a quick ugly hack. */
-	static struct gpio_desc *bxt_gpio_table[U8_MAX + 1];
-	struct gpio_desc *gpio_desc = bxt_gpio_table[gpio_index];
-
-	if (!gpio_desc) {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 NULL, gpio_index,
-						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
-		if (IS_ERR_OR_NULL(gpio_desc)) {
-			drm_err(&dev_priv->drm,
-				"GPIO index %u request failed (%ld)\n",
-				gpio_index, PTR_ERR(gpio_desc));
-			return;
-		}
-
-		bxt_gpio_table[gpio_index] = gpio_desc;
-	}
-
-	gpiod_set_value(gpio_desc, value);
+	soc_gpio_set_value(connector, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 40ecab551232 ("pinctrl:
baytrail: Really serialize all register accesses") for the details.
Taking all this into consideration replace the hack with proper
GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++++++--------------
 1 file changed, 28 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9847a92fdfc3..552bc6564d79 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -55,43 +55,6 @@
 #define MIPI_VIRTUAL_CHANNEL_SHIFT	1
 #define MIPI_PORT_SHIFT			3
 
-/* base offsets for gpio pads */
-#define VLV_GPIO_NC_0_HV_DDI0_HPD	0x4130
-#define VLV_GPIO_NC_1_HV_DDI0_DDC_SDA	0x4120
-#define VLV_GPIO_NC_2_HV_DDI0_DDC_SCL	0x4110
-#define VLV_GPIO_NC_3_PANEL0_VDDEN	0x4140
-#define VLV_GPIO_NC_4_PANEL0_BKLTEN	0x4150
-#define VLV_GPIO_NC_5_PANEL0_BKLTCTL	0x4160
-#define VLV_GPIO_NC_6_HV_DDI1_HPD	0x4180
-#define VLV_GPIO_NC_7_HV_DDI1_DDC_SDA	0x4190
-#define VLV_GPIO_NC_8_HV_DDI1_DDC_SCL	0x4170
-#define VLV_GPIO_NC_9_PANEL1_VDDEN	0x4100
-#define VLV_GPIO_NC_10_PANEL1_BKLTEN	0x40E0
-#define VLV_GPIO_NC_11_PANEL1_BKLTCTL	0x40F0
-
-#define VLV_GPIO_PCONF0(base_offset)	(base_offset)
-#define VLV_GPIO_PAD_VAL(base_offset)	((base_offset) + 8)
-
-struct gpio_map {
-	u16 base_offset;
-	bool init;
-};
-
-static struct gpio_map vlv_gpio_table[] = {
-	{ VLV_GPIO_NC_0_HV_DDI0_HPD },
-	{ VLV_GPIO_NC_1_HV_DDI0_DDC_SDA },
-	{ VLV_GPIO_NC_2_HV_DDI0_DDC_SCL },
-	{ VLV_GPIO_NC_3_PANEL0_VDDEN },
-	{ VLV_GPIO_NC_4_PANEL0_BKLTEN },
-	{ VLV_GPIO_NC_5_PANEL0_BKLTCTL },
-	{ VLV_GPIO_NC_6_HV_DDI1_HPD },
-	{ VLV_GPIO_NC_7_HV_DDI1_DDC_SDA },
-	{ VLV_GPIO_NC_8_HV_DDI1_DDC_SCL },
-	{ VLV_GPIO_NC_9_PANEL1_VDDEN },
-	{ VLV_GPIO_NC_10_PANEL1_BKLTEN },
-	{ VLV_GPIO_NC_11_PANEL1_BKLTCTL },
-};
-
 struct i2c_adapter_lookup {
 	u16 slave_addr;
 	struct intel_dsi *intel_dsi;
@@ -268,52 +231,47 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	}
 }
 
+static void soc_opaque_gpio_set_value(struct intel_connector *connector,
+				      const char *chip, const char *con_id,
+				      u8 gpio_index, bool value)
+{
+	struct gpiod_lookup_table *lookup;
+
+	lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL);
+	if (!lookup)
+		return;
+
+	lookup->dev_id = "0000:00:02.0";
+	lookup->table[0] =
+		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+
+	gpiod_add_lookup_table(lookup);
+
+	soc_gpio_set_value(connector, con_id, gpio_index, value);
+
+	gpiod_remove_lookup_table(lookup);
+	kfree(lookup);
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	struct gpio_map *map;
-	u16 pconf0, padval;
-	u32 tmp;
-	u8 port;
 
-	if (gpio_index >= ARRAY_SIZE(vlv_gpio_table)) {
-		drm_dbg_kms(&dev_priv->drm, "unknown gpio index %u\n",
-			    gpio_index);
-		return;
-	}
-
-	map = &vlv_gpio_table[gpio_index];
-
-	if (connector->panel.vbt.dsi.seq_version >= 3) {
-		/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
-		port = IOSF_PORT_GPIO_NC;
-	} else {
-		if (gpio_source == 0) {
-			port = IOSF_PORT_GPIO_NC;
-		} else if (gpio_source == 1) {
+	/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
+	if (connector->panel.vbt.dsi.seq_version < 3) {
+		if (gpio_source == 1) {
 			drm_dbg_kms(&dev_priv->drm, "SC gpio not supported\n");
 			return;
-		} else {
+		}
+		if (gpio_source > 1) {
 			drm_dbg_kms(&dev_priv->drm,
 				    "unknown gpio source %u\n", gpio_source);
 			return;
 		}
 	}
 
-	pconf0 = VLV_GPIO_PCONF0(map->base_offset);
-	padval = VLV_GPIO_PAD_VAL(map->base_offset);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	if (!map->init) {
-		/* FIXME: remove constant below */
-		vlv_iosf_sb_write(dev_priv, port, pconf0, 0x2000CC00);
-		map->init = true;
-	}
-
-	tmp = 0x4 | value;
-	vlv_iosf_sb_write(dev_priv, port, padval, tmp);
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
+	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 40ecab551232 ("pinctrl:
baytrail: Really serialize all register accesses") for the details.
Taking all this into consideration replace the hack with proper
GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++++++--------------
 1 file changed, 28 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9847a92fdfc3..552bc6564d79 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -55,43 +55,6 @@
 #define MIPI_VIRTUAL_CHANNEL_SHIFT	1
 #define MIPI_PORT_SHIFT			3
 
-/* base offsets for gpio pads */
-#define VLV_GPIO_NC_0_HV_DDI0_HPD	0x4130
-#define VLV_GPIO_NC_1_HV_DDI0_DDC_SDA	0x4120
-#define VLV_GPIO_NC_2_HV_DDI0_DDC_SCL	0x4110
-#define VLV_GPIO_NC_3_PANEL0_VDDEN	0x4140
-#define VLV_GPIO_NC_4_PANEL0_BKLTEN	0x4150
-#define VLV_GPIO_NC_5_PANEL0_BKLTCTL	0x4160
-#define VLV_GPIO_NC_6_HV_DDI1_HPD	0x4180
-#define VLV_GPIO_NC_7_HV_DDI1_DDC_SDA	0x4190
-#define VLV_GPIO_NC_8_HV_DDI1_DDC_SCL	0x4170
-#define VLV_GPIO_NC_9_PANEL1_VDDEN	0x4100
-#define VLV_GPIO_NC_10_PANEL1_BKLTEN	0x40E0
-#define VLV_GPIO_NC_11_PANEL1_BKLTCTL	0x40F0
-
-#define VLV_GPIO_PCONF0(base_offset)	(base_offset)
-#define VLV_GPIO_PAD_VAL(base_offset)	((base_offset) + 8)
-
-struct gpio_map {
-	u16 base_offset;
-	bool init;
-};
-
-static struct gpio_map vlv_gpio_table[] = {
-	{ VLV_GPIO_NC_0_HV_DDI0_HPD },
-	{ VLV_GPIO_NC_1_HV_DDI0_DDC_SDA },
-	{ VLV_GPIO_NC_2_HV_DDI0_DDC_SCL },
-	{ VLV_GPIO_NC_3_PANEL0_VDDEN },
-	{ VLV_GPIO_NC_4_PANEL0_BKLTEN },
-	{ VLV_GPIO_NC_5_PANEL0_BKLTCTL },
-	{ VLV_GPIO_NC_6_HV_DDI1_HPD },
-	{ VLV_GPIO_NC_7_HV_DDI1_DDC_SDA },
-	{ VLV_GPIO_NC_8_HV_DDI1_DDC_SCL },
-	{ VLV_GPIO_NC_9_PANEL1_VDDEN },
-	{ VLV_GPIO_NC_10_PANEL1_BKLTEN },
-	{ VLV_GPIO_NC_11_PANEL1_BKLTCTL },
-};
-
 struct i2c_adapter_lookup {
 	u16 slave_addr;
 	struct intel_dsi *intel_dsi;
@@ -268,52 +231,47 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	}
 }
 
+static void soc_opaque_gpio_set_value(struct intel_connector *connector,
+				      const char *chip, const char *con_id,
+				      u8 gpio_index, bool value)
+{
+	struct gpiod_lookup_table *lookup;
+
+	lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL);
+	if (!lookup)
+		return;
+
+	lookup->dev_id = "0000:00:02.0";
+	lookup->table[0] =
+		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+
+	gpiod_add_lookup_table(lookup);
+
+	soc_gpio_set_value(connector, con_id, gpio_index, value);
+
+	gpiod_remove_lookup_table(lookup);
+	kfree(lookup);
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	struct gpio_map *map;
-	u16 pconf0, padval;
-	u32 tmp;
-	u8 port;
 
-	if (gpio_index >= ARRAY_SIZE(vlv_gpio_table)) {
-		drm_dbg_kms(&dev_priv->drm, "unknown gpio index %u\n",
-			    gpio_index);
-		return;
-	}
-
-	map = &vlv_gpio_table[gpio_index];
-
-	if (connector->panel.vbt.dsi.seq_version >= 3) {
-		/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
-		port = IOSF_PORT_GPIO_NC;
-	} else {
-		if (gpio_source == 0) {
-			port = IOSF_PORT_GPIO_NC;
-		} else if (gpio_source == 1) {
+	/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
+	if (connector->panel.vbt.dsi.seq_version < 3) {
+		if (gpio_source == 1) {
 			drm_dbg_kms(&dev_priv->drm, "SC gpio not supported\n");
 			return;
-		} else {
+		}
+		if (gpio_source > 1) {
 			drm_dbg_kms(&dev_priv->drm,
 				    "unknown gpio source %u\n", gpio_source);
 			return;
 		}
 	}
 
-	pconf0 = VLV_GPIO_PCONF0(map->base_offset);
-	padval = VLV_GPIO_PAD_VAL(map->base_offset);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	if (!map->init) {
-		/* FIXME: remove constant below */
-		vlv_iosf_sb_write(dev_priv, port, pconf0, 0x2000CC00);
-		map->init = true;
-	}
-
-	tmp = 0x4 | value;
-	vlv_iosf_sb_write(dev_priv, port, padval, tmp);
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
+	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 12/16] drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 40ecab551232 ("pinctrl:
baytrail: Really serialize all register accesses") for the details.
Taking all this into consideration replace the hack with proper
GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 98 ++++++--------------
 1 file changed, 28 insertions(+), 70 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9847a92fdfc3..552bc6564d79 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -55,43 +55,6 @@
 #define MIPI_VIRTUAL_CHANNEL_SHIFT	1
 #define MIPI_PORT_SHIFT			3
 
-/* base offsets for gpio pads */
-#define VLV_GPIO_NC_0_HV_DDI0_HPD	0x4130
-#define VLV_GPIO_NC_1_HV_DDI0_DDC_SDA	0x4120
-#define VLV_GPIO_NC_2_HV_DDI0_DDC_SCL	0x4110
-#define VLV_GPIO_NC_3_PANEL0_VDDEN	0x4140
-#define VLV_GPIO_NC_4_PANEL0_BKLTEN	0x4150
-#define VLV_GPIO_NC_5_PANEL0_BKLTCTL	0x4160
-#define VLV_GPIO_NC_6_HV_DDI1_HPD	0x4180
-#define VLV_GPIO_NC_7_HV_DDI1_DDC_SDA	0x4190
-#define VLV_GPIO_NC_8_HV_DDI1_DDC_SCL	0x4170
-#define VLV_GPIO_NC_9_PANEL1_VDDEN	0x4100
-#define VLV_GPIO_NC_10_PANEL1_BKLTEN	0x40E0
-#define VLV_GPIO_NC_11_PANEL1_BKLTCTL	0x40F0
-
-#define VLV_GPIO_PCONF0(base_offset)	(base_offset)
-#define VLV_GPIO_PAD_VAL(base_offset)	((base_offset) + 8)
-
-struct gpio_map {
-	u16 base_offset;
-	bool init;
-};
-
-static struct gpio_map vlv_gpio_table[] = {
-	{ VLV_GPIO_NC_0_HV_DDI0_HPD },
-	{ VLV_GPIO_NC_1_HV_DDI0_DDC_SDA },
-	{ VLV_GPIO_NC_2_HV_DDI0_DDC_SCL },
-	{ VLV_GPIO_NC_3_PANEL0_VDDEN },
-	{ VLV_GPIO_NC_4_PANEL0_BKLTEN },
-	{ VLV_GPIO_NC_5_PANEL0_BKLTCTL },
-	{ VLV_GPIO_NC_6_HV_DDI1_HPD },
-	{ VLV_GPIO_NC_7_HV_DDI1_DDC_SDA },
-	{ VLV_GPIO_NC_8_HV_DDI1_DDC_SCL },
-	{ VLV_GPIO_NC_9_PANEL1_VDDEN },
-	{ VLV_GPIO_NC_10_PANEL1_BKLTEN },
-	{ VLV_GPIO_NC_11_PANEL1_BKLTCTL },
-};
-
 struct i2c_adapter_lookup {
 	u16 slave_addr;
 	struct intel_dsi *intel_dsi;
@@ -268,52 +231,47 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	}
 }
 
+static void soc_opaque_gpio_set_value(struct intel_connector *connector,
+				      const char *chip, const char *con_id,
+				      u8 gpio_index, bool value)
+{
+	struct gpiod_lookup_table *lookup;
+
+	lookup = kzalloc(struct_size(lookup, table, 2), GFP_KERNEL);
+	if (!lookup)
+		return;
+
+	lookup->dev_id = "0000:00:02.0";
+	lookup->table[0] =
+		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+
+	gpiod_add_lookup_table(lookup);
+
+	soc_gpio_set_value(connector, con_id, gpio_index, value);
+
+	gpiod_remove_lookup_table(lookup);
+	kfree(lookup);
+}
+
 static void vlv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	struct gpio_map *map;
-	u16 pconf0, padval;
-	u32 tmp;
-	u8 port;
 
-	if (gpio_index >= ARRAY_SIZE(vlv_gpio_table)) {
-		drm_dbg_kms(&dev_priv->drm, "unknown gpio index %u\n",
-			    gpio_index);
-		return;
-	}
-
-	map = &vlv_gpio_table[gpio_index];
-
-	if (connector->panel.vbt.dsi.seq_version >= 3) {
-		/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
-		port = IOSF_PORT_GPIO_NC;
-	} else {
-		if (gpio_source == 0) {
-			port = IOSF_PORT_GPIO_NC;
-		} else if (gpio_source == 1) {
+	/* XXX: this assumes vlv_gpio_table only has NC GPIOs. */
+	if (connector->panel.vbt.dsi.seq_version < 3) {
+		if (gpio_source == 1) {
 			drm_dbg_kms(&dev_priv->drm, "SC gpio not supported\n");
 			return;
-		} else {
+		}
+		if (gpio_source > 1) {
 			drm_dbg_kms(&dev_priv->drm,
 				    "unknown gpio source %u\n", gpio_source);
 			return;
 		}
 	}
 
-	pconf0 = VLV_GPIO_PCONF0(map->base_offset);
-	padval = VLV_GPIO_PAD_VAL(map->base_offset);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	if (!map->init) {
-		/* FIXME: remove constant below */
-		vlv_iosf_sb_write(dev_priv, port, pconf0, 0x2000CC00);
-		map->init = true;
-	}
-
-	tmp = 0x4 | value;
-	vlv_iosf_sb_write(dev_priv, port, padval, tmp);
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
+	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities

[Andy Shevchenko]

Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 552bc6564d79..b1736c1301ea 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -206,8 +206,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
-			       u8 gpio_index, bool value)
+static void soc_gpio_set_value(struct intel_connector *connector, u8 gpio_index,
+			       const char *con_id, u8 idx, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -217,8 +217,7 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	if (gpio_desc) {
 		gpiod_set_value(gpio_desc, value);
 	} else {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 con_id, gpio_index,
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev, con_id, idx,
 						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR(gpio_desc)) {
 			drm_err(&dev_priv->drm,
@@ -232,8 +231,8 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 }
 
 static void soc_opaque_gpio_set_value(struct intel_connector *connector,
-				      const char *chip, const char *con_id,
-				      u8 gpio_index, bool value)
+				      u8 gpio_index, const char *chip,
+				      const char *con_id, u8 idx, bool value)
 {
 	struct gpiod_lookup_table *lookup;
 
@@ -243,11 +242,11 @@ static void soc_opaque_gpio_set_value(struct intel_connector *connector,
 
 	lookup->dev_id = "0000:00:02.0";
 	lookup->table[0] =
-		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+		GPIO_LOOKUP_IDX(chip, idx, con_id, idx, GPIO_ACTIVE_HIGH);
 
 	gpiod_add_lookup_table(lookup);
 
-	soc_gpio_set_value(connector, con_id, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, con_id, idx, value);
 
 	gpiod_remove_lookup_table(lookup);
 	kfree(lookup);
@@ -271,7 +270,8 @@ static void vlv_gpio_set_value(struct intel_connector *connector,
 		}
 	}
 
-	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
+	soc_opaque_gpio_set_value(connector, gpio_index,
+				  "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
@@ -331,7 +331,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	soc_gpio_set_value(connector, NULL, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities

[Andy Shevchenko]

Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 552bc6564d79..b1736c1301ea 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -206,8 +206,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
-			       u8 gpio_index, bool value)
+static void soc_gpio_set_value(struct intel_connector *connector, u8 gpio_index,
+			       const char *con_id, u8 idx, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -217,8 +217,7 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	if (gpio_desc) {
 		gpiod_set_value(gpio_desc, value);
 	} else {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 con_id, gpio_index,
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev, con_id, idx,
 						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR(gpio_desc)) {
 			drm_err(&dev_priv->drm,
@@ -232,8 +231,8 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 }
 
 static void soc_opaque_gpio_set_value(struct intel_connector *connector,
-				      const char *chip, const char *con_id,
-				      u8 gpio_index, bool value)
+				      u8 gpio_index, const char *chip,
+				      const char *con_id, u8 idx, bool value)
 {
 	struct gpiod_lookup_table *lookup;
 
@@ -243,11 +242,11 @@ static void soc_opaque_gpio_set_value(struct intel_connector *connector,
 
 	lookup->dev_id = "0000:00:02.0";
 	lookup->table[0] =
-		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+		GPIO_LOOKUP_IDX(chip, idx, con_id, idx, GPIO_ACTIVE_HIGH);
 
 	gpiod_add_lookup_table(lookup);
 
-	soc_gpio_set_value(connector, con_id, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, con_id, idx, value);
 
 	gpiod_remove_lookup_table(lookup);
 	kfree(lookup);
@@ -271,7 +270,8 @@ static void vlv_gpio_set_value(struct intel_connector *connector,
 		}
 	}
 
-	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
+	soc_opaque_gpio_set_value(connector, gpio_index,
+				  "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
@@ -331,7 +331,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	soc_gpio_set_value(connector, NULL, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 13/16] drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities

[Andy Shevchenko]

Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.
For CHV case, for example, we will need to distinguish community based index
from the one that VBT is using. Introduce an additional parameter to
soc_gpio_set_value() and its callers.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++++++----------
 1 file changed, 10 insertions(+), 10 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 552bc6564d79..b1736c1301ea 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -206,8 +206,8 @@ static const u8 *mipi_exec_delay(struct intel_dsi *intel_dsi, const u8 *data)
 	return data;
 }
 
-static void soc_gpio_set_value(struct intel_connector *connector, const char *con_id,
-			       u8 gpio_index, bool value)
+static void soc_gpio_set_value(struct intel_connector *connector, u8 gpio_index,
+			       const char *con_id, u8 idx, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
 	/* XXX: this table is a quick ugly hack. */
@@ -217,8 +217,7 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 	if (gpio_desc) {
 		gpiod_set_value(gpio_desc, value);
 	} else {
-		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev,
-						 con_id, gpio_index,
+		gpio_desc = devm_gpiod_get_index(dev_priv->drm.dev, con_id, idx,
 						 value ? GPIOD_OUT_HIGH : GPIOD_OUT_LOW);
 		if (IS_ERR(gpio_desc)) {
 			drm_err(&dev_priv->drm,
@@ -232,8 +231,8 @@ static void soc_gpio_set_value(struct intel_connector *connector, const char *co
 }
 
 static void soc_opaque_gpio_set_value(struct intel_connector *connector,
-				      const char *chip, const char *con_id,
-				      u8 gpio_index, bool value)
+				      u8 gpio_index, const char *chip,
+				      const char *con_id, u8 idx, bool value)
 {
 	struct gpiod_lookup_table *lookup;
 
@@ -243,11 +242,11 @@ static void soc_opaque_gpio_set_value(struct intel_connector *connector,
 
 	lookup->dev_id = "0000:00:02.0";
 	lookup->table[0] =
-		GPIO_LOOKUP_IDX(chip, gpio_index, con_id, gpio_index, GPIO_ACTIVE_HIGH);
+		GPIO_LOOKUP_IDX(chip, idx, con_id, idx, GPIO_ACTIVE_HIGH);
 
 	gpiod_add_lookup_table(lookup);
 
-	soc_gpio_set_value(connector, con_id, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, con_id, idx, value);
 
 	gpiod_remove_lookup_table(lookup);
 	kfree(lookup);
@@ -271,7 +270,8 @@ static void vlv_gpio_set_value(struct intel_connector *connector,
 		}
 	}
 
-	soc_opaque_gpio_set_value(connector, "INT33FC:01", "Panel N", gpio_index, value);
+	soc_opaque_gpio_set_value(connector, gpio_index,
+				  "INT33FC:01", "Panel N", gpio_index, value);
 }
 
 static void chv_gpio_set_value(struct intel_connector *connector,
@@ -331,7 +331,7 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 static void bxt_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_index, bool value)
 {
-	soc_gpio_set_value(connector, NULL, gpio_index, value);
+	soc_gpio_set_value(connector, gpio_index, NULL, gpio_index, value);
 }
 
 enum {
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl:
cherryview: prevent concurrent access to GPIO controllers") for
the details. Taking all this into consideration replace the hack
with proper GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +++++---------------
 1 file changed, 10 insertions(+), 37 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b1736c1301ea..9c6946ccb193 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -66,19 +66,6 @@ struct i2c_adapter_lookup {
 #define CHV_GPIO_IDX_START_SW		100
 #define CHV_GPIO_IDX_START_SE		198
 
-#define CHV_VBT_MAX_PINS_PER_FMLY	15
-
-#define CHV_GPIO_PAD_CFG0(f, i)		(0x4400 + (f) * 0x400 + (i) * 8)
-#define  CHV_GPIO_GPIOEN		(1 << 15)
-#define  CHV_GPIO_GPIOCFG_GPIO		(0 << 8)
-#define  CHV_GPIO_GPIOCFG_GPO		(1 << 8)
-#define  CHV_GPIO_GPIOCFG_GPI		(2 << 8)
-#define  CHV_GPIO_GPIOCFG_HIZ		(3 << 8)
-#define  CHV_GPIO_GPIOTXSTATE(state)	((!!(state)) << 1)
-
-#define CHV_GPIO_PAD_CFG1(f, i)		(0x4400 + (f) * 0x400 + (i) * 8 + 4)
-#define  CHV_GPIO_CFGLOCK		(1 << 31)
-
 /* ICL DSI Display GPIO Pins */
 #define  ICL_GPIO_DDSP_HPD_A		0
 #define  ICL_GPIO_L_VDDEN_1		1
@@ -278,23 +265,21 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	u16 cfg0, cfg1;
-	u16 family_num;
-	u8 port;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3) {
 		if (gpio_index >= CHV_GPIO_IDX_START_SE) {
 			/* XXX: it's unclear whether 255->57 is part of SE. */
-			gpio_index -= CHV_GPIO_IDX_START_SE;
-			port = CHV_IOSF_PORT_GPIO_SE;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:03", "Panel SE",
+						  gpio_index - CHV_GPIO_IDX_START_SE, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_SW) {
-			gpio_index -= CHV_GPIO_IDX_START_SW;
-			port = CHV_IOSF_PORT_GPIO_SW;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:00", "Panel SW",
+						  gpio_index - CHV_GPIO_IDX_START_SW, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_E) {
-			gpio_index -= CHV_GPIO_IDX_START_E;
-			port = CHV_IOSF_PORT_GPIO_E;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:02", "Panel E",
+						  gpio_index - CHV_GPIO_IDX_START_E, value);
 		} else {
-			port = CHV_IOSF_PORT_GPIO_N;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+						  gpio_index - CHV_GPIO_IDX_START_N, value);
 		}
 	} else {
 		/* XXX: The spec is unclear about CHV GPIO on seq v2 */
@@ -311,21 +296,9 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			return;
 		}
 
-		port = CHV_IOSF_PORT_GPIO_N;
+		soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+					  gpio_index - CHV_GPIO_IDX_START_N, value);
 	}
-
-	family_num = gpio_index / CHV_VBT_MAX_PINS_PER_FMLY;
-	gpio_index = gpio_index % CHV_VBT_MAX_PINS_PER_FMLY;
-
-	cfg0 = CHV_GPIO_PAD_CFG0(family_num, gpio_index);
-	cfg1 = CHV_GPIO_PAD_CFG1(family_num, gpio_index);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	vlv_iosf_sb_write(dev_priv, port, cfg1, 0);
-	vlv_iosf_sb_write(dev_priv, port, cfg0,
-			  CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO |
-			  CHV_GPIO_GPIOTXSTATE(value));
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl:
cherryview: prevent concurrent access to GPIO controllers") for
the details. Taking all this into consideration replace the hack
with proper GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +++++---------------
 1 file changed, 10 insertions(+), 37 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b1736c1301ea..9c6946ccb193 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -66,19 +66,6 @@ struct i2c_adapter_lookup {
 #define CHV_GPIO_IDX_START_SW		100
 #define CHV_GPIO_IDX_START_SE		198
 
-#define CHV_VBT_MAX_PINS_PER_FMLY	15
-
-#define CHV_GPIO_PAD_CFG0(f, i)		(0x4400 + (f) * 0x400 + (i) * 8)
-#define  CHV_GPIO_GPIOEN		(1 << 15)
-#define  CHV_GPIO_GPIOCFG_GPIO		(0 << 8)
-#define  CHV_GPIO_GPIOCFG_GPO		(1 << 8)
-#define  CHV_GPIO_GPIOCFG_GPI		(2 << 8)
-#define  CHV_GPIO_GPIOCFG_HIZ		(3 << 8)
-#define  CHV_GPIO_GPIOTXSTATE(state)	((!!(state)) << 1)
-
-#define CHV_GPIO_PAD_CFG1(f, i)		(0x4400 + (f) * 0x400 + (i) * 8 + 4)
-#define  CHV_GPIO_CFGLOCK		(1 << 31)
-
 /* ICL DSI Display GPIO Pins */
 #define  ICL_GPIO_DDSP_HPD_A		0
 #define  ICL_GPIO_L_VDDEN_1		1
@@ -278,23 +265,21 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	u16 cfg0, cfg1;
-	u16 family_num;
-	u8 port;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3) {
 		if (gpio_index >= CHV_GPIO_IDX_START_SE) {
 			/* XXX: it's unclear whether 255->57 is part of SE. */
-			gpio_index -= CHV_GPIO_IDX_START_SE;
-			port = CHV_IOSF_PORT_GPIO_SE;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:03", "Panel SE",
+						  gpio_index - CHV_GPIO_IDX_START_SE, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_SW) {
-			gpio_index -= CHV_GPIO_IDX_START_SW;
-			port = CHV_IOSF_PORT_GPIO_SW;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:00", "Panel SW",
+						  gpio_index - CHV_GPIO_IDX_START_SW, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_E) {
-			gpio_index -= CHV_GPIO_IDX_START_E;
-			port = CHV_IOSF_PORT_GPIO_E;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:02", "Panel E",
+						  gpio_index - CHV_GPIO_IDX_START_E, value);
 		} else {
-			port = CHV_IOSF_PORT_GPIO_N;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+						  gpio_index - CHV_GPIO_IDX_START_N, value);
 		}
 	} else {
 		/* XXX: The spec is unclear about CHV GPIO on seq v2 */
@@ -311,21 +296,9 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			return;
 		}
 
-		port = CHV_IOSF_PORT_GPIO_N;
+		soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+					  gpio_index - CHV_GPIO_IDX_START_N, value);
 	}
-
-	family_num = gpio_index / CHV_VBT_MAX_PINS_PER_FMLY;
-	gpio_index = gpio_index % CHV_VBT_MAX_PINS_PER_FMLY;
-
-	cfg0 = CHV_GPIO_PAD_CFG0(family_num, gpio_index);
-	cfg1 = CHV_GPIO_PAD_CFG1(family_num, gpio_index);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	vlv_iosf_sb_write(dev_priv, port, cfg1, 0);
-	vlv_iosf_sb_write(dev_priv, port, cfg0,
-			  CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO |
-			  CHV_GPIO_GPIOTXSTATE(value));
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 14/16] drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back

[Andy Shevchenko]

It's a dirty hack in the driver that pokes GPIO registers behind
the driver's back. Moreoever it might be problematic as simultaneous
I/O may hang the system, see the commit 0bd50d719b00 ("pinctrl:
cherryview: prevent concurrent access to GPIO controllers") for
the details. Taking all this into consideration replace the hack
with proper GPIO APIs being used.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 47 +++++---------------
 1 file changed, 10 insertions(+), 37 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index b1736c1301ea..9c6946ccb193 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -66,19 +66,6 @@ struct i2c_adapter_lookup {
 #define CHV_GPIO_IDX_START_SW		100
 #define CHV_GPIO_IDX_START_SE		198
 
-#define CHV_VBT_MAX_PINS_PER_FMLY	15
-
-#define CHV_GPIO_PAD_CFG0(f, i)		(0x4400 + (f) * 0x400 + (i) * 8)
-#define  CHV_GPIO_GPIOEN		(1 << 15)
-#define  CHV_GPIO_GPIOCFG_GPIO		(0 << 8)
-#define  CHV_GPIO_GPIOCFG_GPO		(1 << 8)
-#define  CHV_GPIO_GPIOCFG_GPI		(2 << 8)
-#define  CHV_GPIO_GPIOCFG_HIZ		(3 << 8)
-#define  CHV_GPIO_GPIOTXSTATE(state)	((!!(state)) << 1)
-
-#define CHV_GPIO_PAD_CFG1(f, i)		(0x4400 + (f) * 0x400 + (i) * 8 + 4)
-#define  CHV_GPIO_CFGLOCK		(1 << 31)
-
 /* ICL DSI Display GPIO Pins */
 #define  ICL_GPIO_DDSP_HPD_A		0
 #define  ICL_GPIO_L_VDDEN_1		1
@@ -278,23 +265,21 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			       u8 gpio_source, u8 gpio_index, bool value)
 {
 	struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
-	u16 cfg0, cfg1;
-	u16 family_num;
-	u8 port;
 
 	if (connector->panel.vbt.dsi.seq_version >= 3) {
 		if (gpio_index >= CHV_GPIO_IDX_START_SE) {
 			/* XXX: it's unclear whether 255->57 is part of SE. */
-			gpio_index -= CHV_GPIO_IDX_START_SE;
-			port = CHV_IOSF_PORT_GPIO_SE;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:03", "Panel SE",
+						  gpio_index - CHV_GPIO_IDX_START_SE, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_SW) {
-			gpio_index -= CHV_GPIO_IDX_START_SW;
-			port = CHV_IOSF_PORT_GPIO_SW;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:00", "Panel SW",
+						  gpio_index - CHV_GPIO_IDX_START_SW, value);
 		} else if (gpio_index >= CHV_GPIO_IDX_START_E) {
-			gpio_index -= CHV_GPIO_IDX_START_E;
-			port = CHV_IOSF_PORT_GPIO_E;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:02", "Panel E",
+						  gpio_index - CHV_GPIO_IDX_START_E, value);
 		} else {
-			port = CHV_IOSF_PORT_GPIO_N;
+			soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+						  gpio_index - CHV_GPIO_IDX_START_N, value);
 		}
 	} else {
 		/* XXX: The spec is unclear about CHV GPIO on seq v2 */
@@ -311,21 +296,9 @@ static void chv_gpio_set_value(struct intel_connector *connector,
 			return;
 		}
 
-		port = CHV_IOSF_PORT_GPIO_N;
+		soc_opaque_gpio_set_value(connector, gpio_index, "INT33FF:01", "Panel N",
+					  gpio_index - CHV_GPIO_IDX_START_N, value);
 	}
-
-	family_num = gpio_index / CHV_VBT_MAX_PINS_PER_FMLY;
-	gpio_index = gpio_index % CHV_VBT_MAX_PINS_PER_FMLY;
-
-	cfg0 = CHV_GPIO_PAD_CFG0(family_num, gpio_index);
-	cfg1 = CHV_GPIO_PAD_CFG1(family_num, gpio_index);
-
-	vlv_iosf_sb_get(dev_priv, BIT(VLV_IOSF_SB_GPIO));
-	vlv_iosf_sb_write(dev_priv, port, cfg1, 0);
-	vlv_iosf_sb_write(dev_priv, port, cfg0,
-			  CHV_GPIO_GPIOEN | CHV_GPIO_GPIOCFG_GPO |
-			  CHV_GPIO_GPIOTXSTATE(value));
-	vlv_iosf_sb_put(dev_priv, BIT(VLV_IOSF_SB_GPIO));
 }
 
 static void bxt_gpio_set_value(struct intel_connector *connector,
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio()

[Andy Shevchenko]

For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9c6946ccb193..275d0218394c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -420,14 +420,12 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
-	else if (DISPLAY_VER(i915) >= 11)
+	else if (DISPLAY_VER(i915) >= 9)
 		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
-	else
-		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio()

[Andy Shevchenko]

For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9c6946ccb193..275d0218394c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -420,14 +420,12 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
-	else if (DISPLAY_VER(i915) >= 11)
+	else if (DISPLAY_VER(i915) >= 9)
 		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
-	else
-		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 15/16] drm/i915/dsi: Combine checks in mipi_exec_gpio()

[Andy Shevchenko]

For a couple of cases the branches call the same bxt_gpio_set_value().
As Ville suggested they can be combined by dropping the DISPLAY_VER()
check from Gen 11 to Gen 9. Do it that way.

Suggested-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
index 9c6946ccb193..275d0218394c 100644
--- a/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
+++ b/drivers/gpu/drm/i915/display/intel_dsi_vbt.c
@@ -420,14 +420,12 @@ static const u8 *mipi_exec_gpio(struct intel_dsi *intel_dsi, const u8 *data)
 
 	if (native)
 		icl_native_gpio_set_value(i915, gpio_number, value);
-	else if (DISPLAY_VER(i915) >= 11)
+	else if (DISPLAY_VER(i915) >= 9)
 		bxt_gpio_set_value(connector, gpio_index, value);
 	else if (IS_VALLEYVIEW(i915))
 		vlv_gpio_set_value(connector, gpio_source, gpio_number, value);
 	else if (IS_CHERRYVIEW(i915))
 		chv_gpio_set_value(connector, gpio_source, gpio_number, value);
-	else
-		bxt_gpio_set_value(connector, gpio_index, value);
 
 	return data + size;
 }
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] [PATCH v4 16/16] drm/i915/iosf: Drop unused APIs

[Andy Shevchenko]

Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/vlv_sideband.c | 17 -----------------
 drivers/gpu/drm/i915/vlv_sideband.h |  3 ---
 2 files changed, 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/vlv_sideband.c b/drivers/gpu/drm/i915/vlv_sideband.c
index b98dec3ad817..13b644958e38 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.c
+++ b/drivers/gpu/drm/i915/vlv_sideband.c
@@ -166,23 +166,6 @@ u32 vlv_nc_read(struct drm_i915_private *i915, u8 addr)
 	return val;
 }
 
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg)
-{
-	u32 val = 0;
-
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRRDDA_NP, reg, &val);
-
-	return val;
-}
-
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val)
-{
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRWRDA_NP, reg, &val);
-}
-
 u32 vlv_cck_read(struct drm_i915_private *i915, u32 reg)
 {
 	u32 val = 0;
diff --git a/drivers/gpu/drm/i915/vlv_sideband.h b/drivers/gpu/drm/i915/vlv_sideband.h
index 9ce283d96b80..8b4495e14bce 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.h
+++ b/drivers/gpu/drm/i915/vlv_sideband.h
@@ -26,9 +26,6 @@ enum {
 };
 
 void vlv_iosf_sb_get(struct drm_i915_private *i915, unsigned long ports);
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg);
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val);
 void vlv_iosf_sb_put(struct drm_i915_private *i915, unsigned long ports);
 
 static inline void vlv_bunit_get(struct drm_i915_private *i915)
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 16/16] drm/i915/iosf: Drop unused APIs

[Andy Shevchenko]

Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/vlv_sideband.c | 17 -----------------
 drivers/gpu/drm/i915/vlv_sideband.h |  3 ---
 2 files changed, 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/vlv_sideband.c b/drivers/gpu/drm/i915/vlv_sideband.c
index b98dec3ad817..13b644958e38 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.c
+++ b/drivers/gpu/drm/i915/vlv_sideband.c
@@ -166,23 +166,6 @@ u32 vlv_nc_read(struct drm_i915_private *i915, u8 addr)
 	return val;
 }
 
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg)
-{
-	u32 val = 0;
-
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRRDDA_NP, reg, &val);
-
-	return val;
-}
-
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val)
-{
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRWRDA_NP, reg, &val);
-}
-
 u32 vlv_cck_read(struct drm_i915_private *i915, u32 reg)
 {
 	u32 val = 0;
diff --git a/drivers/gpu/drm/i915/vlv_sideband.h b/drivers/gpu/drm/i915/vlv_sideband.h
index 9ce283d96b80..8b4495e14bce 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.h
+++ b/drivers/gpu/drm/i915/vlv_sideband.h
@@ -26,9 +26,6 @@ enum {
 };
 
 void vlv_iosf_sb_get(struct drm_i915_private *i915, unsigned long ports);
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg);
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val);
 void vlv_iosf_sb_put(struct drm_i915_private *i915, unsigned long ports);
 
 static inline void vlv_bunit_get(struct drm_i915_private *i915)
-- 
2.40.0.1.gaa8946217a0b

[PATCH v4 16/16] drm/i915/iosf: Drop unused APIs

[Andy Shevchenko]

Drop unused vlv_iosf_sb_read() and vlv_iosf_sb_write().

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
---
 drivers/gpu/drm/i915/vlv_sideband.c | 17 -----------------
 drivers/gpu/drm/i915/vlv_sideband.h |  3 ---
 2 files changed, 20 deletions(-)

diff --git a/drivers/gpu/drm/i915/vlv_sideband.c b/drivers/gpu/drm/i915/vlv_sideband.c
index b98dec3ad817..13b644958e38 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.c
+++ b/drivers/gpu/drm/i915/vlv_sideband.c
@@ -166,23 +166,6 @@ u32 vlv_nc_read(struct drm_i915_private *i915, u8 addr)
 	return val;
 }
 
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg)
-{
-	u32 val = 0;
-
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRRDDA_NP, reg, &val);
-
-	return val;
-}
-
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val)
-{
-	vlv_sideband_rw(i915, PCI_DEVFN(0, 0), port,
-			SB_CRWRDA_NP, reg, &val);
-}
-
 u32 vlv_cck_read(struct drm_i915_private *i915, u32 reg)
 {
 	u32 val = 0;
diff --git a/drivers/gpu/drm/i915/vlv_sideband.h b/drivers/gpu/drm/i915/vlv_sideband.h
index 9ce283d96b80..8b4495e14bce 100644
--- a/drivers/gpu/drm/i915/vlv_sideband.h
+++ b/drivers/gpu/drm/i915/vlv_sideband.h
@@ -26,9 +26,6 @@ enum {
 };
 
 void vlv_iosf_sb_get(struct drm_i915_private *i915, unsigned long ports);
-u32 vlv_iosf_sb_read(struct drm_i915_private *i915, u8 port, u32 reg);
-void vlv_iosf_sb_write(struct drm_i915_private *i915,
-		       u8 port, u32 reg, u32 val);
 void vlv_iosf_sb_put(struct drm_i915_private *i915, unsigned long ports);
 
 static inline void vlv_bunit_get(struct drm_i915_private *i915)
-- 
2.40.0.1.gaa8946217a0b

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Patchwork]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO
URL   : https://patchwork.freedesktop.org/series/125977/
State : warning

== Summary ==

Error: dim checkpatch failed
cf6ba57516da drm/i915/dsi: assume BXT gpio works for non-native GPIO
481d4ce37fe4 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
b80582bcf739 drm/i915/dsi: clarify GPIO exec sequence
54a9044c6b7d drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
d3cef67d2948 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
312e37a9127d drm/i915/dsi: Replace while(1) with one with clear exit condition
427e3034b75e drm/i915/dsi: Get rid of redundant 'else'
5af3f32b334f drm/i915/dsi: Replace check with a (missing) MIPI sequence name
02afcfea30ea drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
bf81f18f5ffd drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
aa88caa8c7f5 drm/i915/dsi: Extract common soc_gpio_set_value() helper
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
30ced6d15ea3 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
66a96cfbc330 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
5484103c5d64 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
a4d061726bbd drm/i915/dsi: Combine checks in mipi_exec_gpio()
49380e2b55f6 drm/i915/iosf: Drop unused APIs

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 11625 bytes --]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO
URL   : https://patchwork.freedesktop.org/series/125977/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13835 -> Patchwork_125977v1
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_125977v1 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_125977v1, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/index.html

Participating hosts (36 -> 37)
------------------------------

  Additional (2): fi-kbl-soraka bat-dg2-9 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_125977v1:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@hangcheck:
    - bat-atsm-1:         [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13835/bat-atsm-1/igt@i915_selftest@live@hangcheck.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-atsm-1/igt@i915_selftest@live@hangcheck.html

  
Known issues
------------

  Here are the changes found in Patchwork_125977v1 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@gem_mmap@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][5] ([i915#4083])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@gem_mmap@basic.html

  * igt@gem_mmap_gtt@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][6] ([i915#4077]) +2 other tests skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@gem_mmap_gtt@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][7] ([i915#4079]) +1 other test skip
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@gem_render_tiled_blits@basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-9:          NOTRUN -> [SKIP][8] ([i915#6621])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@i915_pm_rps@basic-api.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][9] ([i915#1886])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][10] ([i915#5190])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][11] ([i915#4215] / [i915#5190])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - bat-dg2-9:          NOTRUN -> [SKIP][12] ([i915#4212]) +6 other tests skip
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg2-9:          NOTRUN -> [SKIP][13] ([i915#4212] / [i915#5608])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][14] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_dsc@dsc-basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][15] ([fdo#109271]) +9 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html

  * igt@kms_force_connector_basic@force-load-detect:
    - bat-dg2-9:          NOTRUN -> [SKIP][16] ([fdo#109285])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-dg2-9:          NOTRUN -> [SKIP][17] ([i915#5274])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_psr@sprite_plane_onoff:
    - bat-dg2-9:          NOTRUN -> [SKIP][18] ([i915#1072]) +3 other tests skip
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_psr@sprite_plane_onoff.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-dg2-9:          NOTRUN -> [SKIP][19] ([i915#3555] / [i915#4098])
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-dg2-9:          NOTRUN -> [SKIP][20] ([i915#3708])
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-fence-mmap:
    - bat-dg2-9:          NOTRUN -> [SKIP][21] ([i915#3708] / [i915#4077]) +1 other test skip
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html

  * igt@prime_vgem@basic-write:
    - bat-dg2-9:          NOTRUN -> [SKIP][22] ([i915#3291] / [i915#3708]) +2 other tests skip
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-dg2-9/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][23] ([i915#5334]) -> [PASS][24]
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13835/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-5:
    - bat-adlp-11:        [DMESG-FAIL][25] ([i915#6868]) -> [PASS][26]
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13835/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-5.html
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-b-dp-5.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5:
    - bat-adlp-11:        [FAIL][27] ([i915#9047]) -> [PASS][28]
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13835/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5.html
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-c-dp-5.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5:
    - bat-adlp-11:        [ABORT][29] ([i915#8668]) -> [PASS][30]
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13835/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5.html
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/bat-adlp-11/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-dp-5.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#1072]: https://gitlab.freedesktop.org/drm/intel/issues/1072
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6868]: https://gitlab.freedesktop.org/drm/intel/issues/6868
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#9047]: https://gitlab.freedesktop.org/drm/intel/issues/9047


Build changes
-------------

  * Linux: CI_DRM_13835 -> Patchwork_125977v1

  CI-20190529: 20190529
  CI_DRM_13835: ca1fcd4faf444fc6d8b3cf88a17e2eb7765c1299 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7573: 69485d223b256208614e9949a4a7e84bde52d5f5 @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_125977v1: ca1fcd4faf444fc6d8b3cf88a17e2eb7765c1299 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

93470f577390 drm/i915/iosf: Drop unused APIs
4128b35ca632 drm/i915/dsi: Combine checks in mipi_exec_gpio()
97962cd0ed44 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
0579908adec8 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
2ef615b233a7 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
d73ccb903a71 drm/i915/dsi: Extract common soc_gpio_set_value() helper
f680845a2fad drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
749a9f0c04f2 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
52a68de4016c drm/i915/dsi: Replace check with a (missing) MIPI sequence name
e9b877d6439a drm/i915/dsi: Get rid of redundant 'else'
862489c3ce26 drm/i915/dsi: Replace while(1) with one with clear exit condition
9bba1b9fcf75 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
6327a4cc9ef3 drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
ffa435f57462 drm/i915/dsi: clarify GPIO exec sequence
625d10010e2a drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
90abe29951af drm/i915/dsi: assume BXT gpio works for non-native GPIO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v1/index.html

[-- Attachment #2: Type: text/html, Size: 13371 bytes --]

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Hans de Goede]

Hi,

On 11/3/23 21:18, Andy Shevchenko wrote:
> DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> talking to GPIO IP behind the actual driver's back. A second attempt
> to fix that is here.
> 
> If I understood correctly, my approach should work in the similar way as
> the current IOSF GPIO.
> 
> Hans, I believe you have some devices that use this piece of code,
> is it possible to give a test run on (one of) them?

Ok, this now has been testen on both a BYT and a CHT device which
actually use GPIO controls in their MIPI sequences so this
series is:

Tested-by: Hans de Goede <hdegoede@redhat.com>

And the code of the entire series also looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> In v4:
> - fixed compile time errors in patch 14 (Hans, LKP)
> - fixed cover letter Subject
> - added patch 15 (as suggested by Ville)
> - added Ack tag (Jani)
> 
> In v3:
> - incorporated series by Jani
> - incorporated couple of precursor patches by Hans
> - added Rb tag for used to be first three patches (Andi)
> - rebased on top of the above changes
> - fixed indexing for multi-community devices, such as Cherry View
> 
> In v2:
> - added a few cleanup patches
> - reworked to use dynamic GPIO lookup tables
> - converted CHV as well
> 
> Andy Shevchenko (9):
>   drm/i915/dsi: Replace while(1) with one with clear exit condition
>   drm/i915/dsi: Get rid of redundant 'else'
>   drm/i915/dsi: Replace check with a (missing) MIPI sequence name
>   drm/i915/dsi: Extract common soc_gpio_set_value() helper
>   drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
>   drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
>     communities
>   drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
>   drm/i915/dsi: Combine checks in mipi_exec_gpio()
>   drm/i915/iosf: Drop unused APIs
> 
> Hans de Goede (2):
>   drm/i915/dsi: Remove GPIO lookup table at the end of
>     intel_dsi_vbt_gpio_init()
>   drm/i915/dsi: Fix wrong initial value for GPIOs in
>     bxt_gpio_set_value()
> 
> Jani Nikula (5):
>   drm/i915/dsi: assume BXT gpio works for non-native GPIO
>   drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
>   drm/i915/dsi: clarify GPIO exec sequence
>   drm/i915/dsi: rename platform specific *_exec_gpio() to
>     *_gpio_set_value()
>   drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
> 
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
>  drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
>  drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
>  3 files changed, 136 insertions(+), 239 deletions(-)
> 

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Hans de Goede]

Hi,

On 11/3/23 21:18, Andy Shevchenko wrote:
> DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> talking to GPIO IP behind the actual driver's back. A second attempt
> to fix that is here.
> 
> If I understood correctly, my approach should work in the similar way as
> the current IOSF GPIO.
> 
> Hans, I believe you have some devices that use this piece of code,
> is it possible to give a test run on (one of) them?

Ok, this now has been testen on both a BYT and a CHT device which
actually use GPIO controls in their MIPI sequences so this
series is:

Tested-by: Hans de Goede <hdegoede@redhat.com>

And the code of the entire series also looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> In v4:
> - fixed compile time errors in patch 14 (Hans, LKP)
> - fixed cover letter Subject
> - added patch 15 (as suggested by Ville)
> - added Ack tag (Jani)
> 
> In v3:
> - incorporated series by Jani
> - incorporated couple of precursor patches by Hans
> - added Rb tag for used to be first three patches (Andi)
> - rebased on top of the above changes
> - fixed indexing for multi-community devices, such as Cherry View
> 
> In v2:
> - added a few cleanup patches
> - reworked to use dynamic GPIO lookup tables
> - converted CHV as well
> 
> Andy Shevchenko (9):
>   drm/i915/dsi: Replace while(1) with one with clear exit condition
>   drm/i915/dsi: Get rid of redundant 'else'
>   drm/i915/dsi: Replace check with a (missing) MIPI sequence name
>   drm/i915/dsi: Extract common soc_gpio_set_value() helper
>   drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
>   drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
>     communities
>   drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
>   drm/i915/dsi: Combine checks in mipi_exec_gpio()
>   drm/i915/iosf: Drop unused APIs
> 
> Hans de Goede (2):
>   drm/i915/dsi: Remove GPIO lookup table at the end of
>     intel_dsi_vbt_gpio_init()
>   drm/i915/dsi: Fix wrong initial value for GPIOs in
>     bxt_gpio_set_value()
> 
> Jani Nikula (5):
>   drm/i915/dsi: assume BXT gpio works for non-native GPIO
>   drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
>   drm/i915/dsi: clarify GPIO exec sequence
>   drm/i915/dsi: rename platform specific *_exec_gpio() to
>     *_gpio_set_value()
>   drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
> 
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
>  drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
>  drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
>  3 files changed, 136 insertions(+), 239 deletions(-)
> 

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Hans de Goede]

Hi,

On 11/3/23 21:18, Andy Shevchenko wrote:
> DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> talking to GPIO IP behind the actual driver's back. A second attempt
> to fix that is here.
> 
> If I understood correctly, my approach should work in the similar way as
> the current IOSF GPIO.
> 
> Hans, I believe you have some devices that use this piece of code,
> is it possible to give a test run on (one of) them?

Ok, this now has been testen on both a BYT and a CHT device which
actually use GPIO controls in their MIPI sequences so this
series is:

Tested-by: Hans de Goede <hdegoede@redhat.com>

And the code of the entire series also looks good to me:

Reviewed-by: Hans de Goede <hdegoede@redhat.com>

for the series.

Regards,

Hans




> In v4:
> - fixed compile time errors in patch 14 (Hans, LKP)
> - fixed cover letter Subject
> - added patch 15 (as suggested by Ville)
> - added Ack tag (Jani)
> 
> In v3:
> - incorporated series by Jani
> - incorporated couple of precursor patches by Hans
> - added Rb tag for used to be first three patches (Andi)
> - rebased on top of the above changes
> - fixed indexing for multi-community devices, such as Cherry View
> 
> In v2:
> - added a few cleanup patches
> - reworked to use dynamic GPIO lookup tables
> - converted CHV as well
> 
> Andy Shevchenko (9):
>   drm/i915/dsi: Replace while(1) with one with clear exit condition
>   drm/i915/dsi: Get rid of redundant 'else'
>   drm/i915/dsi: Replace check with a (missing) MIPI sequence name
>   drm/i915/dsi: Extract common soc_gpio_set_value() helper
>   drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
>   drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO
>     communities
>   drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
>   drm/i915/dsi: Combine checks in mipi_exec_gpio()
>   drm/i915/iosf: Drop unused APIs
> 
> Hans de Goede (2):
>   drm/i915/dsi: Remove GPIO lookup table at the end of
>     intel_dsi_vbt_gpio_init()
>   drm/i915/dsi: Fix wrong initial value for GPIOs in
>     bxt_gpio_set_value()
> 
> Jani Nikula (5):
>   drm/i915/dsi: assume BXT gpio works for non-native GPIO
>   drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
>   drm/i915/dsi: clarify GPIO exec sequence
>   drm/i915/dsi: rename platform specific *_exec_gpio() to
>     *_gpio_set_value()
>   drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
> 
>  drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 355 +++++++------------
>  drivers/gpu/drm/i915/vlv_sideband.c          |  17 -
>  drivers/gpu/drm/i915/vlv_sideband.h          |   3 -
>  3 files changed, 136 insertions(+), 239 deletions(-)
> 

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
>
> And the code of the entire series also looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> for the series.

Thanks Andy & Hans!

I'll merge this once the test results are in. The BAT results have been
a bit flaky recently, so needed to do a rerun.

That said, I'm not sure if we have any hardware in CI that would
actually exercise the modifications, so in that sense I trust Hans'
testing much more.

BR,
Jani.


-- 
Jani Nikula, Intel

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
>
> And the code of the entire series also looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> for the series.

Thanks Andy & Hans!

I'll merge this once the test results are in. The BAT results have been
a bit flaky recently, so needed to do a rerun.

That said, I'm not sure if we have any hardware in CI that would
actually exercise the modifications, so in that sense I trust Hans'
testing much more.

BR,
Jani.


-- 
Jani Nikula, Intel

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
>
> Tested-by: Hans de Goede <hdegoede@redhat.com>
>
> And the code of the entire series also looks good to me:
>
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>
> for the series.

Thanks Andy & Hans!

I'll merge this once the test results are in. The BAT results have been
a bit flaky recently, so needed to do a rerun.

That said, I'm not sure if we have any hardware in CI that would
actually exercise the modifications, so in that sense I trust Hans'
testing much more.

BR,
Jani.


-- 
Jani Nikula, Intel

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> > Ok, this now has been testen on both a BYT and a CHT device which
> > actually use GPIO controls in their MIPI sequences so this
> > series is:
> >
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> >
> > And the code of the entire series also looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > for the series.
> 
> Thanks Andy & Hans!
> 
> I'll merge this once the test results are in. The BAT results have been
> a bit flaky recently, so needed to do a rerun.
> 
> That said, I'm not sure if we have any hardware in CI that would
> actually exercise the modifications, so in that sense I trust Hans'
> testing much more.

Thank you!
Should I fix checkpatch warnings CI reported about?

-- 
With Best Regards,
Andy Shevchenko

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> > Ok, this now has been testen on both a BYT and a CHT device which
> > actually use GPIO controls in their MIPI sequences so this
> > series is:
> >
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> >
> > And the code of the entire series also looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > for the series.
> 
> Thanks Andy & Hans!
> 
> I'll merge this once the test results are in. The BAT results have been
> a bit flaky recently, so needed to do a rerun.
> 
> That said, I'm not sure if we have any hardware in CI that would
> actually exercise the modifications, so in that sense I trust Hans'
> testing much more.

Thank you!
Should I fix checkpatch warnings CI reported about?

-- 
With Best Regards,
Andy Shevchenko

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
> > Ok, this now has been testen on both a BYT and a CHT device which
> > actually use GPIO controls in their MIPI sequences so this
> > series is:
> >
> > Tested-by: Hans de Goede <hdegoede@redhat.com>
> >
> > And the code of the entire series also looks good to me:
> >
> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> >
> > for the series.
> 
> Thanks Andy & Hans!
> 
> I'll merge this once the test results are in. The BAT results have been
> a bit flaky recently, so needed to do a rerun.
> 
> That said, I'm not sure if we have any hardware in CI that would
> actually exercise the modifications, so in that sense I trust Hans'
> testing much more.

Thank you!
Should I fix checkpatch warnings CI reported about?

-- 
With Best Regards,
Andy Shevchenko

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>> 
>> Thanks Andy & Hans!
>> 
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>> 
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?

Nah, they're benign.

BR,
Jani.

-- 
Jani Nikula, Intel

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>> 
>> Thanks Andy & Hans!
>> 
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>> 
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?

Nah, they're benign.

BR,
Jani.

-- 
Jani Nikula, Intel

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Jani Nikula]

On Fri, 17 Nov 2023, Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> On Thu, Nov 16, 2023 at 12:15:03PM +0200, Jani Nikula wrote:
>> On Thu, 16 Nov 2023, Hans de Goede <hdegoede@redhat.com> wrote:
>> > Ok, this now has been testen on both a BYT and a CHT device which
>> > actually use GPIO controls in their MIPI sequences so this
>> > series is:
>> >
>> > Tested-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > And the code of the entire series also looks good to me:
>> >
>> > Reviewed-by: Hans de Goede <hdegoede@redhat.com>
>> >
>> > for the series.
>> 
>> Thanks Andy & Hans!
>> 
>> I'll merge this once the test results are in. The BAT results have been
>> a bit flaky recently, so needed to do a rerun.
>> 
>> That said, I'm not sure if we have any hardware in CI that would
>> actually exercise the modifications, so in that sense I trust Hans'
>> testing much more.
>
> Thank you!
> Should I fix checkpatch warnings CI reported about?

Nah, they're benign.

BR,
Jani.

-- 
Jani Nikula, Intel

Re: [Intel-gfx] [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote:
> On 11/3/23 21:18, Andy Shevchenko wrote:
> > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> > talking to GPIO IP behind the actual driver's back. A second attempt
> > to fix that is here.
> > 
> > If I understood correctly, my approach should work in the similar way as
> > the current IOSF GPIO.
> > 
> > Hans, I believe you have some devices that use this piece of code,
> > is it possible to give a test run on (one of) them?
> 
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
> 
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> 
> And the code of the entire series also looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> for the series.

Good news so far, thank you!

-- 
With Best Regards,
Andy Shevchenko

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote:
> On 11/3/23 21:18, Andy Shevchenko wrote:
> > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> > talking to GPIO IP behind the actual driver's back. A second attempt
> > to fix that is here.
> > 
> > If I understood correctly, my approach should work in the similar way as
> > the current IOSF GPIO.
> > 
> > Hans, I believe you have some devices that use this piece of code,
> > is it possible to give a test run on (one of) them?
> 
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
> 
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> 
> And the code of the entire series also looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> for the series.

Good news so far, thank you!

-- 
With Best Regards,
Andy Shevchenko

Re: [rft, PATCH v4 00/16] drm/i915/dsi: 4th attempt to get rid of IOSF GPIO

[Andy Shevchenko]

On Thu, Nov 16, 2023 at 09:58:06AM +0100, Hans de Goede wrote:
> On 11/3/23 21:18, Andy Shevchenko wrote:
> > DSI code for VBT has a set of ugly GPIO hacks, one of which is direct
> > talking to GPIO IP behind the actual driver's back. A second attempt
> > to fix that is here.
> > 
> > If I understood correctly, my approach should work in the similar way as
> > the current IOSF GPIO.
> > 
> > Hans, I believe you have some devices that use this piece of code,
> > is it possible to give a test run on (one of) them?
> 
> Ok, this now has been testen on both a BYT and a CHT device which
> actually use GPIO controls in their MIPI sequences so this
> series is:
> 
> Tested-by: Hans de Goede <hdegoede@redhat.com>
> 
> And the code of the entire series also looks good to me:
> 
> Reviewed-by: Hans de Goede <hdegoede@redhat.com>
> 
> for the series.

Good news so far, thank you!

-- 
With Best Regards,
Andy Shevchenko

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
URL   : https://patchwork.freedesktop.org/series/125977/
State : warning

== Summary ==

Error: dim checkpatch failed
585aceddae24 drm/i915/dsi: assume BXT gpio works for non-native GPIO
0491ae016322 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
1ccc0b7f1dd4 drm/i915/dsi: clarify GPIO exec sequence
341947fdbe5e drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
db1262dbd6af drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
d33f3eb47d6d drm/i915/dsi: Replace while(1) with one with clear exit condition
097d9253b98e drm/i915/dsi: Get rid of redundant 'else'
cca9caf84fd6 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
ade7c1e74668 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
afd644675571 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
4ef4185927d2 drm/i915/dsi: Extract common soc_gpio_set_value() helper
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
6a7015a6f16b drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
bb115405c875 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
2cba7ec1f8ca drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
be79538d8d4a drm/i915/dsi: Combine checks in mipi_exec_gpio()
164335fa97c2 drm/i915/iosf: Drop unused APIs

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 25846 bytes --]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
URL   : https://patchwork.freedesktop.org/series/125977/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html

Participating hosts (23 -> 36)
------------------------------

  Additional (16): fi-kbl-7567u fi-skl-guc fi-tgl-1115g4 bat-dg2-9 fi-cfl-guc fi-ilk-650 fi-kbl-guc fi-kbl-x1275 fi-pnv-d510 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-dg2-14 bat-dg2-13 bat-dg2-11 bat-mtlp-6 
  Missing    (3): bat-mtlp-8 fi-snb-2520m bat-dg1-5 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_125977v2:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_selftest@live@gt_pm:
    - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-4770/igt@i915_selftest@live@gt_pm.html

  
Known issues
------------

  Here are the changes found in Patchwork_125977v2 that come from known issues:

### CI changes ###

#### Possible fixes ####

  * boot:
    - fi-bsw-n3050:       [FAIL][2] ([i915#8293]) -> [PASS][3]
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-bsw-n3050/boot.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/boot.html

  

### IGT changes ###

#### Issues hit ####

  * igt@debugfs_test@basic-hwmon:
    - bat-jsl-3:          NOTRUN -> [SKIP][4] ([i915#9318])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#9318])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][6] ([i915#9318])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@debugfs_test@basic-hwmon.html

  * igt@fbdev@info:
    - fi-kbl-x1275:       NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1849])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@fbdev@info.html
    - fi-kbl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1849])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@fbdev@info.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@fbdev@info.html

  * igt@fbdev@write:
    - bat-mtlp-6:         NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@fbdev@write.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-7567u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
    - fi-ivb-3770:        NOTRUN -> [SKIP][12] ([fdo#109271]) +15 other tests skip
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ivb-3770/igt@gem_huc_copy@huc-copy.html
    - fi-elk-e7500:       NOTRUN -> [SKIP][13] ([fdo#109271]) +17 other tests skip
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-elk-e7500/igt@gem_huc_copy@huc-copy.html
    - fi-ilk-650:         NOTRUN -> [SKIP][14] ([fdo#109271]) +15 other tests skip
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ilk-650/igt@gem_huc_copy@huc-copy.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][15] ([i915#2190])
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
    - bat-jsl-3:          NOTRUN -> [SKIP][16] ([i915#2190])
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_huc_copy@huc-copy.html
    - fi-kbl-x1275:       NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-pnv-d510:        NOTRUN -> [SKIP][18] ([fdo#109271]) +25 other tests skip
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
    - bat-jsl-3:          NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_lmem_swapping@basic.html
    - fi-skl-guc:         NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@gem_lmem_swapping@basic.html
    - fi-kbl-7567u:       NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_lmem_swapping@basic.html

  * igt@gem_lmem_swapping@parallel-random-engines:
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
   [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html

  * igt@gem_lmem_swapping@random-engines:
    - fi-bsw-n3050:       NOTRUN -> [SKIP][23] ([fdo#109271]) +14 other tests skip
   [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html

  * igt@gem_lmem_swapping@verify-random:
    - fi-cfl-guc:         NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@gem_lmem_swapping@verify-random.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][25] ([i915#4613]) +3 other tests skip
   [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
    - fi-kbl-x1275:       NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
    - fi-kbl-guc:         NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@gem_lmem_swapping@verify-random.html

  * igt@gem_mmap@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][28] ([i915#4083])
   [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap@basic.html
    - bat-dg2-11:         NOTRUN -> [SKIP][29] ([i915#4083])
   [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_mmap@basic.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][30] ([i915#4083])
   [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_mmap@basic.html

  * igt@gem_mmap_gtt@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][31] ([i915#4077]) +2 other tests skip
   [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap_gtt@basic.html

  * igt@gem_render_tiled_blits@basic:
    - bat-dg2-9:          NOTRUN -> [SKIP][32] ([i915#4079]) +1 other test skip
   [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_render_tiled_blits@basic.html

  * igt@gem_tiled_blits@basic:
    - bat-mtlp-6:         NOTRUN -> [SKIP][33] ([i915#4077]) +2 other tests skip
   [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_tiled_blits@basic.html

  * igt@gem_tiled_fence_blits@basic:
    - bat-dg2-11:         NOTRUN -> [SKIP][34] ([i915#4077]) +2 other tests skip
   [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html

  * igt@gem_tiled_pread_basic:
    - bat-dg2-11:         NOTRUN -> [SKIP][35] ([i915#4079]) +1 other test skip
   [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_pread_basic.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][36] ([i915#4079]) +1 other test skip
   [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_tiled_pread_basic.html

  * igt@i915_pm_rps@basic-api:
    - bat-dg2-9:          NOTRUN -> [SKIP][37] ([i915#6621])
   [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@i915_pm_rps@basic-api.html
    - bat-dg2-11:         NOTRUN -> [SKIP][38] ([i915#6621])
   [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][39] ([i915#6621])
   [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@i915_pm_rps@basic-api.html

  * igt@i915_suspend@basic-s3-without-i915:
    - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][40] ([i915#7443])
   [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][41] ([i915#6645])
   [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@i915_suspend@basic-s3-without-i915.html

  * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
    - bat-mtlp-6:         NOTRUN -> [SKIP][42] ([i915#4212]) +8 other tests skip
   [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html

  * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
    - bat-dg2-11:         NOTRUN -> [SKIP][43] ([i915#4212]) +6 other tests skip
   [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][44] ([i915#5190])
   [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][45] ([i915#5190])
   [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
    - bat-dg2-11:         NOTRUN -> [SKIP][46] ([i915#5190])
   [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - bat-dg2-9:          NOTRUN -> [SKIP][47] ([i915#4215] / [i915#5190])
   [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
    - bat-dg2-11:         NOTRUN -> [SKIP][48] ([i915#4215] / [i915#5190])
   [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
    - bat-dg2-9:          NOTRUN -> [SKIP][49] ([i915#4212]) +6 other tests skip
   [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html

  * igt@kms_addfb_basic@tile-pitch-mismatch:
    - bat-dg2-9:          NOTRUN -> [SKIP][50] ([i915#4212] / [i915#5608])
   [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
    - bat-dg2-11:         NOTRUN -> [SKIP][51] ([i915#4212] / [i915#5608])
   [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@tile-pitch-mismatch.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
    - bat-dg2-11:         NOTRUN -> [SKIP][52] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
   [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][53] ([i915#4103]) +1 other test skip
   [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html

  * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
    - fi-cfl-guc:         NOTRUN -> [SKIP][54] ([fdo#109271]) +6 other tests skip
   [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-jsl-3:          NOTRUN -> [SKIP][55] ([i915#4103]) +1 other test skip
   [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
    - bat-dg2-9:          NOTRUN -> [SKIP][56] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
   [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html

  * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
    - bat-mtlp-6:         NOTRUN -> [SKIP][57] ([i915#1845]) +12 other tests skip
   [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html

  * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
    - fi-kbl-guc:         NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1845]) +14 other tests skip
   [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html

  * igt@kms_dsc@dsc-basic:
    - fi-skl-guc:         NOTRUN -> [SKIP][59] ([fdo#109271]) +8 other tests skip
   [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_dsc@dsc-basic.html
    - bat-dg2-11:         NOTRUN -> [SKIP][60] ([i915#3555] / [i915#3840])
   [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_dsc@dsc-basic.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][61] ([i915#3555] / [i915#3840])
   [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_dsc@dsc-basic.html

  * igt@kms_flip@basic-flip-vs-dpms:
    - bat-mtlp-6:         NOTRUN -> [SKIP][62] ([i915#3637]) +3 other tests skip
   [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_flip@basic-flip-vs-dpms.html

  * igt@kms_force_connector_basic@force-load-detect:
    - fi-kbl-7567u:       NOTRUN -> [SKIP][63] ([fdo#109271]) +6 other tests skip
   [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][64] ([fdo#109285])
   [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][65] ([fdo#109285])
   [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html
    - bat-jsl-3:          NOTRUN -> [SKIP][66] ([fdo#109285])
   [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_force_connector_basic@force-load-detect.html
    - bat-dg2-9:          NOTRUN -> [SKIP][67] ([fdo#109285])
   [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
    - bat-dg2-11:         NOTRUN -> [SKIP][68] ([fdo#109285])
   [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html

  * igt@kms_force_connector_basic@prune-stale-modes:
    - bat-dg2-9:          NOTRUN -> [SKIP][69] ([i915#5274])
   [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
    - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#5274])
   [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][71] ([i915#5274])
   [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@prune-stale-modes.html

  * igt@kms_frontbuffer_tracking@basic:
    - fi-kbl-x1275:       NOTRUN -> [SKIP][72] ([fdo#109271]) +17 other tests skip
   [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
    - fi-kbl-guc:         NOTRUN -> [SKIP][73] ([fdo#109271]) +15 other tests skip
   [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][74] ([i915#4342])
   [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_frontbuffer_tracking@basic.html

  * igt@kms_hdmi_inject@inject-audio:
    - fi-skl-guc:         NOTRUN -> [FAIL][75] ([IGT#3])
   [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_hdmi_inject@inject-audio.html
    - fi-bsw-n3050:       NOTRUN -> [FAIL][76] ([IGT#3])
   [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_pipe_crc_basic@read-crc:
    - fi-kbl-x1275:       NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#1845]) +14 other tests skip
   [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc.html

  * igt@kms_pipe_crc_basic@suspend-read-crc:
    - bat-mtlp-6:         NOTRUN -> [SKIP][78] ([i915#1845] / [i915#4078]) +4 other tests skip
   [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_pipe_crc_basic@suspend-read-crc.html

  * igt@kms_setmode@basic-clone-single-crtc:
    - bat-jsl-3:          NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
   [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_setmode@basic-clone-single-crtc.html
    - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3555] / [i915#4098])
   [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
    - bat-dg2-11:         NOTRUN -> [SKIP][81] ([i915#3555] / [i915#4098])
   [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
    - fi-tgl-1115g4:      NOTRUN -> [SKIP][82] ([i915#3555])
   [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8809])
   [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_setmode@basic-clone-single-crtc.html

  * igt@prime_vgem@basic-fence-flip:
    - bat-dg2-9:          NOTRUN -> [SKIP][84] ([i915#3708])
   [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
    - bat-dg2-11:         NOTRUN -> [SKIP][85] ([i915#3708])
   [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][86] ([i915#1845] / [i915#3708])
   [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-flip.html

  * igt@prime_vgem@basic-fence-mmap:
    - bat-dg2-11:         NOTRUN -> [SKIP][87] ([i915#3708] / [i915#4077]) +1 other test skip
   [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][88] ([i915#3708] / [i915#4077]) +1 other test skip
   [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
    - bat-dg2-9:          NOTRUN -> [SKIP][89] ([i915#3708] / [i915#4077]) +1 other test skip
   [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html

  * igt@prime_vgem@basic-read:
    - bat-dg2-11:         NOTRUN -> [SKIP][90] ([i915#3291] / [i915#3708]) +2 other tests skip
   [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-read.html

  * igt@prime_vgem@basic-write:
    - bat-dg2-9:          NOTRUN -> [SKIP][91] ([i915#3291] / [i915#3708]) +2 other tests skip
   [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-write.html
    - bat-mtlp-6:         NOTRUN -> [SKIP][92] ([i915#3708]) +2 other tests skip
   [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-write.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_timelines:
    - fi-hsw-4770:        [INCOMPLETE][93] ([i915#9527]) -> [PASS][94]
   [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
   [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
  [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
  [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
  [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
  [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
  [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
  [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
  [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
  [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
  [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
  [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
  [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
  [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
  [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
  [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
  [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
  [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
  [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
  [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
  [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
  [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
  [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
  [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
  [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
  [i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
  [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
  [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
  [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
  [i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
  [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673


Build changes
-------------

  * Linux: CI_DRM_13883 -> Patchwork_125977v2

  CI-20190529: 20190529
  CI_DRM_13883: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_125977v2: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

88bdd4e021ea drm/i915/iosf: Drop unused APIs
a77c188e1c5e drm/i915/dsi: Combine checks in mipi_exec_gpio()
0d4f7726f12e drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
676e85ad0140 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
243097ffab80 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
2ba66360f03d drm/i915/dsi: Extract common soc_gpio_set_value() helper
4272788720c6 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
08cf117983e4 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
ab1ce1add06d drm/i915/dsi: Replace check with a (missing) MIPI sequence name
6104bf6004b4 drm/i915/dsi: Get rid of redundant 'else'
17366b81dadb drm/i915/dsi: Replace while(1) with one with clear exit condition
21b1b71e73f1 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
60c4936330be drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
4beabfe83d0f drm/i915/dsi: clarify GPIO exec sequence
47de5df0986b drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
7f9c22df7f34 drm/i915/dsi: assume BXT gpio works for non-native GPIO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html

[-- Attachment #2: Type: text/html, Size: 34139 bytes --]

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Jani Nikula]

On Thu, 16 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
> URL   : https://patchwork.freedesktop.org/series/125977/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
>   to document this new failure mode, which will reduce false positives in CI.

The reported issue is unrelated to the series.

Please consider adding

Reply-To: lgci.bug.filing@intel.com

message header to these status mails, so the right mail gets added
automatically.


Thanks,
Jani.


>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html
>
> Participating hosts (23 -> 36)
> ------------------------------
>
>   Additional (16): fi-kbl-7567u fi-skl-guc fi-tgl-1115g4 bat-dg2-9 fi-cfl-guc fi-ilk-650 fi-kbl-guc fi-kbl-x1275 fi-pnv-d510 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-dg2-14 bat-dg2-13 bat-dg2-11 bat-mtlp-6 
>   Missing    (3): bat-mtlp-8 fi-snb-2520m bat-dg1-5 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_125977v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_selftest@live@gt_pm:
>     - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-4770/igt@i915_selftest@live@gt_pm.html
>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_125977v2 that come from known issues:
>
> ### CI changes ###
>
> #### Possible fixes ####
>
>   * boot:
>     - fi-bsw-n3050:       [FAIL][2] ([i915#8293]) -> [PASS][3]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-bsw-n3050/boot.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/boot.html
>
>   
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@debugfs_test@basic-hwmon:
>     - bat-jsl-3:          NOTRUN -> [SKIP][4] ([i915#9318])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#9318])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][6] ([i915#9318])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@debugfs_test@basic-hwmon.html
>
>   * igt@fbdev@info:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1849])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@fbdev@info.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1849])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@fbdev@info.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582])
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@fbdev@info.html
>
>   * igt@fbdev@write:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@fbdev@write.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
>     - fi-ivb-3770:        NOTRUN -> [SKIP][12] ([fdo#109271]) +15 other tests skip
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ivb-3770/igt@gem_huc_copy@huc-copy.html
>     - fi-elk-e7500:       NOTRUN -> [SKIP][13] ([fdo#109271]) +17 other tests skip
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-elk-e7500/igt@gem_huc_copy@huc-copy.html
>     - fi-ilk-650:         NOTRUN -> [SKIP][14] ([fdo#109271]) +15 other tests skip
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ilk-650/igt@gem_huc_copy@huc-copy.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][15] ([i915#2190])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][16] ([i915#2190])
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_huc_copy@huc-copy.html
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@basic:
>     - fi-pnv-d510:        NOTRUN -> [SKIP][18] ([fdo#109271]) +25 other tests skip
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_lmem_swapping@basic.html
>     - fi-skl-guc:         NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@gem_lmem_swapping@basic.html
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [21]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_lmem_swapping@basic.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
>    [22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@gem_lmem_swapping@random-engines:
>     - fi-bsw-n3050:       NOTRUN -> [SKIP][23] ([fdo#109271]) +14 other tests skip
>    [23]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/igt@gem_lmem_swapping@random-engines.html
>
>   * igt@gem_lmem_swapping@verify-random:
>     - fi-cfl-guc:         NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@gem_lmem_swapping@verify-random.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][25] ([i915#4613]) +3 other tests skip
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [27]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@gem_lmem_swapping@verify-random.html
>
>   * igt@gem_mmap@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][28] ([i915#4083])
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap@basic.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][29] ([i915#4083])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_mmap@basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][30] ([i915#4083])
>    [30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_mmap@basic.html
>
>   * igt@gem_mmap_gtt@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][31] ([i915#4077]) +2 other tests skip
>    [31]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap_gtt@basic.html
>
>   * igt@gem_render_tiled_blits@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][32] ([i915#4079]) +1 other test skip
>    [32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_render_tiled_blits@basic.html
>
>   * igt@gem_tiled_blits@basic:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][33] ([i915#4077]) +2 other tests skip
>    [33]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_tiled_blits@basic.html
>
>   * igt@gem_tiled_fence_blits@basic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][34] ([i915#4077]) +2 other tests skip
>    [34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_fence_blits@basic.html
>
>   * igt@gem_tiled_pread_basic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][35] ([i915#4079]) +1 other test skip
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_pread_basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][36] ([i915#4079]) +1 other test skip
>    [36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_tiled_pread_basic.html
>
>   * igt@i915_pm_rps@basic-api:
>     - bat-dg2-9:          NOTRUN -> [SKIP][37] ([i915#6621])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@i915_pm_rps@basic-api.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][38] ([i915#6621])
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][39] ([i915#6621])
>    [39]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@i915_pm_rps@basic-api.html
>
>   * igt@i915_suspend@basic-s3-without-i915:
>     - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][40] ([i915#7443])
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][41] ([i915#6645])
>    [41]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@i915_suspend@basic-s3-without-i915.html
>
>   * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][42] ([i915#4212]) +8 other tests skip
>    [42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
>
>   * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
>     - bat-dg2-11:         NOTRUN -> [SKIP][43] ([i915#4212]) +6 other tests skip
>    [43]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
>
>   * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>     - bat-dg2-9:          NOTRUN -> [SKIP][44] ([i915#5190])
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][45] ([i915#5190])
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][46] ([i915#5190])
>    [46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>
>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>     - bat-dg2-9:          NOTRUN -> [SKIP][47] ([i915#4215] / [i915#5190])
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][48] ([i915#4215] / [i915#5190])
>    [48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>
>   * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
>     - bat-dg2-9:          NOTRUN -> [SKIP][49] ([i915#4212]) +6 other tests skip
>    [49]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
>
>   * igt@kms_addfb_basic@tile-pitch-mismatch:
>     - bat-dg2-9:          NOTRUN -> [SKIP][50] ([i915#4212] / [i915#5608])
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][51] ([i915#4212] / [i915#5608])
>    [51]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_addfb_basic@tile-pitch-mismatch.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][52] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][53] ([i915#4103]) +1 other test skip
>    [53]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - fi-cfl-guc:         NOTRUN -> [SKIP][54] ([fdo#109271]) +6 other tests skip
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][55] ([i915#4103]) +1 other test skip
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][56] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>    [56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][57] ([i915#1845]) +12 other tests skip
>    [57]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>
>   * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
>     - fi-kbl-guc:         NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1845]) +14 other tests skip
>    [58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
>
>   * igt@kms_dsc@dsc-basic:
>     - fi-skl-guc:         NOTRUN -> [SKIP][59] ([fdo#109271]) +8 other tests skip
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_dsc@dsc-basic.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][60] ([i915#3555] / [i915#3840])
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_dsc@dsc-basic.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][61] ([i915#3555] / [i915#3840])
>    [61]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_dsc@dsc-basic.html
>
>   * igt@kms_flip@basic-flip-vs-dpms:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][62] ([i915#3637]) +3 other tests skip
>    [62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_flip@basic-flip-vs-dpms.html
>
>   * igt@kms_force_connector_basic@force-load-detect:
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][63] ([fdo#109271]) +6 other tests skip
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][64] ([fdo#109285])
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][65] ([fdo#109285])
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][66] ([fdo#109285])
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][67] ([fdo#109285])
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][68] ([fdo#109285])
>    [68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@force-load-detect.html
>
>   * igt@kms_force_connector_basic@prune-stale-modes:
>     - bat-dg2-9:          NOTRUN -> [SKIP][69] ([i915#5274])
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#5274])
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][71] ([i915#5274])
>    [71]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@prune-stale-modes.html
>
>   * igt@kms_frontbuffer_tracking@basic:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][72] ([fdo#109271]) +17 other tests skip
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][73] ([fdo#109271]) +15 other tests skip
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][74] ([i915#4342])
>    [74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_frontbuffer_tracking@basic.html
>
>   * igt@kms_hdmi_inject@inject-audio:
>     - fi-skl-guc:         NOTRUN -> [FAIL][75] ([IGT#3])
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_hdmi_inject@inject-audio.html
>     - fi-bsw-n3050:       NOTRUN -> [FAIL][76] ([IGT#3])
>    [76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3050/igt@kms_hdmi_inject@inject-audio.html
>
>   * igt@kms_pipe_crc_basic@read-crc:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#1845]) +14 other tests skip
>    [77]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_pipe_crc_basic@read-crc.html
>
>   * igt@kms_pipe_crc_basic@suspend-read-crc:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][78] ([i915#1845] / [i915#4078]) +4 other tests skip
>    [78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_pipe_crc_basic@suspend-read-crc.html
>
>   * igt@kms_setmode@basic-clone-single-crtc:
>     - bat-jsl-3:          NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3555] / [i915#4098])
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][81] ([i915#3555] / [i915#4098])
>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][82] ([i915#3555])
>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8809])
>    [83]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_setmode@basic-clone-single-crtc.html
>
>   * igt@prime_vgem@basic-fence-flip:
>     - bat-dg2-9:          NOTRUN -> [SKIP][84] ([i915#3708])
>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][85] ([i915#3708])
>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][86] ([i915#1845] / [i915#3708])
>    [86]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-flip.html
>
>   * igt@prime_vgem@basic-fence-mmap:
>     - bat-dg2-11:         NOTRUN -> [SKIP][87] ([i915#3708] / [i915#4077]) +1 other test skip
>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][88] ([i915#3708] / [i915#4077]) +1 other test skip
>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][89] ([i915#3708] / [i915#4077]) +1 other test skip
>    [89]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-mmap.html
>
>   * igt@prime_vgem@basic-read:
>     - bat-dg2-11:         NOTRUN -> [SKIP][90] ([i915#3291] / [i915#3708]) +2 other tests skip
>    [90]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-read.html
>
>   * igt@prime_vgem@basic-write:
>     - bat-dg2-9:          NOTRUN -> [SKIP][91] ([i915#3291] / [i915#3708]) +2 other tests skip
>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-write.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][92] ([i915#3708]) +2 other tests skip
>    [92]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-write.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@gt_timelines:
>     - fi-hsw-4770:        [INCOMPLETE][93] ([i915#9527]) -> [PASS][94]
>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
>    [94]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>   [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
>   [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>   [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
>   [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>   [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
>   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>   [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
>   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
>   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>   [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
>   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>   [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>   [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>   [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
>   [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
>   [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
>   [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
>   [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
>   [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
>   [i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
>   [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
>   [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
>   [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
>   [i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
>   [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_13883 -> Patchwork_125977v2
>
>   CI-20190529: 20190529
>   CI_DRM_13883: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_125977v2: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> 88bdd4e021ea drm/i915/iosf: Drop unused APIs
> a77c188e1c5e drm/i915/dsi: Combine checks in mipi_exec_gpio()
> 0d4f7726f12e drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
> 676e85ad0140 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
> 243097ffab80 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
> 2ba66360f03d drm/i915/dsi: Extract common soc_gpio_set_value() helper
> 4272788720c6 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
> 08cf117983e4 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
> ab1ce1add06d drm/i915/dsi: Replace check with a (missing) MIPI sequence name
> 6104bf6004b4 drm/i915/dsi: Get rid of redundant 'else'
> 17366b81dadb drm/i915/dsi: Replace while(1) with one with clear exit condition
> 21b1b71e73f1 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
> 60c4936330be drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
> 4beabfe83d0f drm/i915/dsi: clarify GPIO exec sequence
> 47de5df0986b drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
> 7f9c22df7f34 drm/i915/dsi: assume BXT gpio works for non-native GPIO
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html

-- 
Jani Nikula, Intel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Illipilli, TejasreeX]

Hi ,

https://patchwork.freedesktop.org/series/125977/

Thanks,
Tejasree

-----Original Message-----
From: Jani Nikula <jani.nikula@linux.intel.com> 
Sent: Thursday, November 16, 2023 10:29 PM
To: LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

On Thu, 16 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
> URL   : https://patchwork.freedesktop.org/series/125977/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
>   to document this new failure mode, which will reduce false positives in CI.

The reported issue is unrelated to the series.

Please consider adding

Reply-To: lgci.bug.filing@intel.com

message header to these status mails, so the right mail gets added automatically.


Thanks,
Jani.


>
>   External URL: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html
>
> Participating hosts (23 -> 36)
> ------------------------------
>
>   Additional (16): fi-kbl-7567u fi-skl-guc fi-tgl-1115g4 bat-dg2-9 fi-cfl-guc fi-ilk-650 fi-kbl-guc fi-kbl-x1275 fi-pnv-d510 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-dg2-14 bat-dg2-13 bat-dg2-11 bat-mtlp-6 
>   Missing    (3): bat-mtlp-8 fi-snb-2520m bat-dg1-5 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_125977v2:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@i915_selftest@live@gt_pm:
>     - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][1]
>    [1]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-477
> 0/igt@i915_selftest@live@gt_pm.html
>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_125977v2 that come from known issues:
>
> ### CI changes ###
>
> #### Possible fixes ####
>
>   * boot:
>     - fi-bsw-n3050:       [FAIL][2] ([i915#8293]) -> [PASS][3]
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-bsw-n3050/boot.html
>    [3]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
> 50/boot.html
>
>   
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@debugfs_test@basic-hwmon:
>     - bat-jsl-3:          NOTRUN -> [SKIP][4] ([i915#9318])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#9318])
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][6] ([i915#9318])
>    [6]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@debugfs_test@basic-hwmon.html
>
>   * igt@fbdev@info:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1849])
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@fbdev@info.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1849])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@fbdev@info.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582])
>    [9]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@fbdev@info.html
>
>   * igt@fbdev@write:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
>    [10]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@fbdev@write.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
>     - fi-ivb-3770:        NOTRUN -> [SKIP][12] ([fdo#109271]) +15 other tests skip
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ivb-3770/igt@gem_huc_copy@huc-copy.html
>     - fi-elk-e7500:       NOTRUN -> [SKIP][13] ([fdo#109271]) +17 other tests skip
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-elk-e7500/igt@gem_huc_copy@huc-copy.html
>     - fi-ilk-650:         NOTRUN -> [SKIP][14] ([fdo#109271]) +15 other tests skip
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ilk-650/igt@gem_huc_copy@huc-copy.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][15] ([i915#2190])
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][16] ([i915#2190])
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_huc_copy@huc-copy.html
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
>    [17]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x12
> 75/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@basic:
>     - fi-pnv-d510:        NOTRUN -> [SKIP][18] ([fdo#109271]) +25 other tests skip
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_lmem_swapping@basic.html
>     - fi-skl-guc:         NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@gem_lmem_swapping@basic.html
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [21]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-756
> 7u/igt@gem_lmem_swapping@basic.html
>
>   * igt@gem_lmem_swapping@parallel-random-engines:
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
>    [22]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
> 5g4/igt@gem_lmem_swapping@parallel-random-engines.html
>
>   * igt@gem_lmem_swapping@random-engines:
>     - fi-bsw-n3050:       NOTRUN -> [SKIP][23] ([fdo#109271]) +14 other tests skip
>    [23]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
> 50/igt@gem_lmem_swapping@random-engines.html
>
>   * igt@gem_lmem_swapping@verify-random:
>     - fi-cfl-guc:         NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@gem_lmem_swapping@verify-random.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][25] ([i915#4613]) +3 other tests skip
>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [27]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc
> /igt@gem_lmem_swapping@verify-random.html
>
>   * igt@gem_mmap@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][28] ([i915#4083])
>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap@basic.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][29] ([i915#4083])
>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_mmap@basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][30] ([i915#4083])
>    [30]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@gem_mmap@basic.html
>
>   * igt@gem_mmap_gtt@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][31] ([i915#4077]) +2 other tests skip
>    [31]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
> igt@gem_mmap_gtt@basic.html
>
>   * igt@gem_render_tiled_blits@basic:
>     - bat-dg2-9:          NOTRUN -> [SKIP][32] ([i915#4079]) +1 other test skip
>    [32]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
> igt@gem_render_tiled_blits@basic.html
>
>   * igt@gem_tiled_blits@basic:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][33] ([i915#4077]) +2 other tests skip
>    [33]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@gem_tiled_blits@basic.html
>
>   * igt@gem_tiled_fence_blits@basic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][34] ([i915#4077]) +2 other tests skip
>    [34]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@gem_tiled_fence_blits@basic.html
>
>   * igt@gem_tiled_pread_basic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][35] ([i915#4079]) +1 other test skip
>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_pread_basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][36] ([i915#4079]) +1 other test skip
>    [36]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@gem_tiled_pread_basic.html
>
>   * igt@i915_pm_rps@basic-api:
>     - bat-dg2-9:          NOTRUN -> [SKIP][37] ([i915#6621])
>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@i915_pm_rps@basic-api.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][38] ([i915#6621])
>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][39] ([i915#6621])
>    [39]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@i915_pm_rps@basic-api.html
>
>   * igt@i915_suspend@basic-s3-without-i915:
>     - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][40] ([i915#7443])
>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][41] ([i915#6645])
>    [41]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@i915_suspend@basic-s3-without-i915.html
>
>   * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][42] ([i915#4212]) +8 other tests skip
>    [42]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
>
>   * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
>     - bat-dg2-11:         NOTRUN -> [SKIP][43] ([i915#4212]) +6 other tests skip
>    [43]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
>
>   * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>     - bat-dg2-9:          NOTRUN -> [SKIP][44] ([i915#5190])
>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][45] ([i915#5190])
>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][46] ([i915#5190])
>    [46]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>
>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>     - bat-dg2-9:          NOTRUN -> [SKIP][47] ([i915#4215] / [i915#5190])
>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][48] ([i915#4215] / [i915#5190])
>    [48]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@kms_addfb_basic@basic-y-tiled-legacy.html
>
>   * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
>     - bat-dg2-9:          NOTRUN -> [SKIP][49] ([i915#4212]) +6 other tests skip
>    [49]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
> igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
>
>   * igt@kms_addfb_basic@tile-pitch-mismatch:
>     - bat-dg2-9:          NOTRUN -> [SKIP][50] ([i915#4212] / [i915#5608])
>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][51] ([i915#4212] / [i915#5608])
>    [51]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@kms_addfb_basic@tile-pitch-mismatch.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>     - bat-dg2-11:         NOTRUN -> [SKIP][52] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][53] ([i915#4103]) +1 other test skip
>    [53]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
> 5g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>
>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>     - fi-cfl-guc:         NOTRUN -> [SKIP][54] ([fdo#109271]) +6 other tests skip
>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][55] ([i915#4103]) +1 other test skip
>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][56] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>    [56]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>
>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][57] ([i915#1845]) +12 other tests skip
>    [57]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>
>   * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
>     - fi-kbl-guc:         NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1845]) +14 other tests skip
>    [58]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc
> /igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
>
>   * igt@kms_dsc@dsc-basic:
>     - fi-skl-guc:         NOTRUN -> [SKIP][59] ([fdo#109271]) +8 other tests skip
>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_dsc@dsc-basic.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][60] ([i915#3555] / [i915#3840])
>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_dsc@dsc-basic.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][61] ([i915#3555] / [i915#3840])
>    [61]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
> 5g4/igt@kms_dsc@dsc-basic.html
>
>   * igt@kms_flip@basic-flip-vs-dpms:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][62] ([i915#3637]) +3 other tests skip
>    [62]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_flip@basic-flip-vs-dpms.html
>
>   * igt@kms_force_connector_basic@force-load-detect:
>     - fi-kbl-7567u:       NOTRUN -> [SKIP][63] ([fdo#109271]) +6 other tests skip
>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][64] ([fdo#109285])
>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][65] ([fdo#109285])
>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-jsl-3:          NOTRUN -> [SKIP][66] ([fdo#109285])
>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][67] ([fdo#109285])
>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][68] ([fdo#109285])
>    [68]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@kms_force_connector_basic@force-load-detect.html
>
>   * igt@kms_force_connector_basic@prune-stale-modes:
>     - bat-dg2-9:          NOTRUN -> [SKIP][69] ([i915#5274])
>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#5274])
>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][71] ([i915#5274])
>    [71]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_force_connector_basic@prune-stale-modes.html
>
>   * igt@kms_frontbuffer_tracking@basic:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][72] ([fdo#109271]) +17 other tests skip
>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
>     - fi-kbl-guc:         NOTRUN -> [SKIP][73] ([fdo#109271]) +15 other tests skip
>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][74] ([i915#4342])
>    [74]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_frontbuffer_tracking@basic.html
>
>   * igt@kms_hdmi_inject@inject-audio:
>     - fi-skl-guc:         NOTRUN -> [FAIL][75] ([IGT#3])
>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_hdmi_inject@inject-audio.html
>     - fi-bsw-n3050:       NOTRUN -> [FAIL][76] ([IGT#3])
>    [76]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
> 50/igt@kms_hdmi_inject@inject-audio.html
>
>   * igt@kms_pipe_crc_basic@read-crc:
>     - fi-kbl-x1275:       NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#1845]) +14 other tests skip
>    [77]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x12
> 75/igt@kms_pipe_crc_basic@read-crc.html
>
>   * igt@kms_pipe_crc_basic@suspend-read-crc:
>     - bat-mtlp-6:         NOTRUN -> [SKIP][78] ([i915#1845] / [i915#4078]) +4 other tests skip
>    [78]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_pipe_crc_basic@suspend-read-crc.html
>
>   * igt@kms_setmode@basic-clone-single-crtc:
>     - bat-jsl-3:          NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3555] / [i915#4098])
>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][81] ([i915#3555] / [i915#4098])
>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][82] ([i915#3555])
>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8809])
>    [83]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@kms_setmode@basic-clone-single-crtc.html
>
>   * igt@prime_vgem@basic-fence-flip:
>     - bat-dg2-9:          NOTRUN -> [SKIP][84] ([i915#3708])
>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
>     - bat-dg2-11:         NOTRUN -> [SKIP][85] ([i915#3708])
>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][86] ([i915#1845] / [i915#3708])
>    [86]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@prime_vgem@basic-fence-flip.html
>
>   * igt@prime_vgem@basic-fence-mmap:
>     - bat-dg2-11:         NOTRUN -> [SKIP][87] ([i915#3708] / [i915#4077]) +1 other test skip
>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][88] ([i915#3708] / [i915#4077]) +1 other test skip
>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
>     - bat-dg2-9:          NOTRUN -> [SKIP][89] ([i915#3708] / [i915#4077]) +1 other test skip
>    [89]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
> igt@prime_vgem@basic-fence-mmap.html
>
>   * igt@prime_vgem@basic-read:
>     - bat-dg2-11:         NOTRUN -> [SKIP][90] ([i915#3291] / [i915#3708]) +2 other tests skip
>    [90]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
> /igt@prime_vgem@basic-read.html
>
>   * igt@prime_vgem@basic-write:
>     - bat-dg2-9:          NOTRUN -> [SKIP][91] ([i915#3291] / [i915#3708]) +2 other tests skip
>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-write.html
>     - bat-mtlp-6:         NOTRUN -> [SKIP][92] ([i915#3708]) +2 other tests skip
>    [92]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
> /igt@prime_vgem@basic-write.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@gt_timelines:
>     - fi-hsw-4770:        [INCOMPLETE][93] ([i915#9527]) -> [PASS][94]
>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
>    [94]: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-477
> 0/igt@i915_selftest@live@gt_timelines.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>   [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
>   [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>   [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
>   [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>   [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
>   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>   [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
>   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
>   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>   [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
>   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>   [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>   [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>   [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
>   [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
>   [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
>   [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
>   [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
>   [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
>   [i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
>   [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
>   [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
>   [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
>   [i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
>   [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_13883 -> Patchwork_125977v2
>
>   CI-20190529: 20190529
>   CI_DRM_13883: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_125977v2: 382a59d725202e3548f8fcbffbefe8664a921e30 @ 
> git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> 88bdd4e021ea drm/i915/iosf: Drop unused APIs a77c188e1c5e 
> drm/i915/dsi: Combine checks in mipi_exec_gpio() 0d4f7726f12e 
> drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
> 676e85ad0140 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish 
> GPIO communities
> 243097ffab80 drm/i915/dsi: Replace poking of VLV GPIOs behind the 
> driver's back 2ba66360f03d drm/i915/dsi: Extract common 
> soc_gpio_set_value() helper
> 4272788720c6 drm/i915/dsi: Fix wrong initial value for GPIOs in 
> bxt_gpio_set_value()
> 08cf117983e4 drm/i915/dsi: Remove GPIO lookup table at the end of 
> intel_dsi_vbt_gpio_init() ab1ce1add06d drm/i915/dsi: Replace check 
> with a (missing) MIPI sequence name
> 6104bf6004b4 drm/i915/dsi: Get rid of redundant 'else'
> 17366b81dadb drm/i915/dsi: Replace while(1) with one with clear exit 
> condition
> 21b1b71e73f1 drm/i915/dsi: bxt/icl GPIO set value do not need gpio 
> source 60c4936330be drm/i915/dsi: rename platform specific 
> *_exec_gpio() to *_gpio_set_value() 4beabfe83d0f drm/i915/dsi: clarify 
> GPIO exec sequence 47de5df0986b drm/i915/dsi: switch mipi_exec_gpio() 
> from dev_priv to i915
> 7f9c22df7f34 drm/i915/dsi: assume BXT gpio works for non-native GPIO
>
> == Logs ==
>
> For more details see: 
> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html

--
Jani Nikula, Intel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Jani Nikula]

On Tue, 21 Nov 2023, "Illipilli, TejasreeX" <tejasreex.illipilli@intel.com> wrote:
> Hi ,
>
> https://patchwork.freedesktop.org/series/125977/

Thanks, I guess, but now what? There are no shards results but the
series is not in the shards queue either [1].

I don't know what to do.


BR,
Jani.


[1] https://intel-gfx-ci.01.org/queue/index.html#fullshards-queue


>
> Thanks,
> Tejasree
>
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com> 
> Sent: Thursday, November 16, 2023 10:29 PM
> To: LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
>
> On Thu, 16 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
>> URL   : https://patchwork.freedesktop.org/series/125977/
>> State : failure
>>
>> == Summary ==
>>
>> CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 
>> ====================================================
>>
>> Summary
>> -------
>>
>>   **FAILURE**
>>
>>   Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
>>   verified manually.
>>   
>>   If you think the reported changes have nothing to do with the changes
>>   introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
>>   to document this new failure mode, which will reduce false positives in CI.
>
> The reported issue is unrelated to the series.
>
> Please consider adding
>
> Reply-To: lgci.bug.filing@intel.com
>
> message header to these status mails, so the right mail gets added automatically.
>
>
> Thanks,
> Jani.
>
>
>>
>>   External URL: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html
>>
>> Participating hosts (23 -> 36)
>> ------------------------------
>>
>>   Additional (16): fi-kbl-7567u fi-skl-guc fi-tgl-1115g4 bat-dg2-9 fi-cfl-guc fi-ilk-650 fi-kbl-guc fi-kbl-x1275 fi-pnv-d510 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-dg2-14 bat-dg2-13 bat-dg2-11 bat-mtlp-6 
>>   Missing    (3): bat-mtlp-8 fi-snb-2520m bat-dg1-5 
>>
>> Possible new issues
>> -------------------
>>
>>   Here are the unknown changes that may have been introduced in Patchwork_125977v2:
>>
>> ### IGT changes ###
>>
>> #### Possible regressions ####
>>
>>   * igt@i915_selftest@live@gt_pm:
>>     - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][1]
>>    [1]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-477
>> 0/igt@i915_selftest@live@gt_pm.html
>>
>>   
>> Known issues
>> ------------
>>
>>   Here are the changes found in Patchwork_125977v2 that come from known issues:
>>
>> ### CI changes ###
>>
>> #### Possible fixes ####
>>
>>   * boot:
>>     - fi-bsw-n3050:       [FAIL][2] ([i915#8293]) -> [PASS][3]
>>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-bsw-n3050/boot.html
>>    [3]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
>> 50/boot.html
>>
>>   
>>
>> ### IGT changes ###
>>
>> #### Issues hit ####
>>
>>   * igt@debugfs_test@basic-hwmon:
>>     - bat-jsl-3:          NOTRUN -> [SKIP][4] ([i915#9318])
>>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#9318])
>>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][6] ([i915#9318])
>>    [6]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@debugfs_test@basic-hwmon.html
>>
>>   * igt@fbdev@info:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1849])
>>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@fbdev@info.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1849])
>>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@fbdev@info.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582])
>>    [9]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@fbdev@info.html
>>
>>   * igt@fbdev@write:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
>>    [10]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@fbdev@write.html
>>
>>   * igt@gem_huc_copy@huc-copy:
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
>>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
>>     - fi-ivb-3770:        NOTRUN -> [SKIP][12] ([fdo#109271]) +15 other tests skip
>>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ivb-3770/igt@gem_huc_copy@huc-copy.html
>>     - fi-elk-e7500:       NOTRUN -> [SKIP][13] ([fdo#109271]) +17 other tests skip
>>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-elk-e7500/igt@gem_huc_copy@huc-copy.html
>>     - fi-ilk-650:         NOTRUN -> [SKIP][14] ([fdo#109271]) +15 other tests skip
>>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ilk-650/igt@gem_huc_copy@huc-copy.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][15] ([i915#2190])
>>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][16] ([i915#2190])
>>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_huc_copy@huc-copy.html
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
>>    [17]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x12
>> 75/igt@gem_huc_copy@huc-copy.html
>>
>>   * igt@gem_lmem_swapping@basic:
>>     - fi-pnv-d510:        NOTRUN -> [SKIP][18] ([fdo#109271]) +25 other tests skip
>>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
>>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_lmem_swapping@basic.html
>>     - fi-skl-guc:         NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@gem_lmem_swapping@basic.html
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [21]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-756
>> 7u/igt@gem_lmem_swapping@basic.html
>>
>>   * igt@gem_lmem_swapping@parallel-random-engines:
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
>>    [22]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
>> 5g4/igt@gem_lmem_swapping@parallel-random-engines.html
>>
>>   * igt@gem_lmem_swapping@random-engines:
>>     - fi-bsw-n3050:       NOTRUN -> [SKIP][23] ([fdo#109271]) +14 other tests skip
>>    [23]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
>> 50/igt@gem_lmem_swapping@random-engines.html
>>
>>   * igt@gem_lmem_swapping@verify-random:
>>     - fi-cfl-guc:         NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@gem_lmem_swapping@verify-random.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][25] ([i915#4613]) +3 other tests skip
>>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [27]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc
>> /igt@gem_lmem_swapping@verify-random.html
>>
>>   * igt@gem_mmap@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][28] ([i915#4083])
>>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap@basic.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][29] ([i915#4083])
>>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_mmap@basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][30] ([i915#4083])
>>    [30]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@gem_mmap@basic.html
>>
>>   * igt@gem_mmap_gtt@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][31] ([i915#4077]) +2 other tests skip
>>    [31]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
>> igt@gem_mmap_gtt@basic.html
>>
>>   * igt@gem_render_tiled_blits@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][32] ([i915#4079]) +1 other test skip
>>    [32]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
>> igt@gem_render_tiled_blits@basic.html
>>
>>   * igt@gem_tiled_blits@basic:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][33] ([i915#4077]) +2 other tests skip
>>    [33]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@gem_tiled_blits@basic.html
>>
>>   * igt@gem_tiled_fence_blits@basic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][34] ([i915#4077]) +2 other tests skip
>>    [34]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@gem_tiled_fence_blits@basic.html
>>
>>   * igt@gem_tiled_pread_basic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][35] ([i915#4079]) +1 other test skip
>>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_pread_basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][36] ([i915#4079]) +1 other test skip
>>    [36]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@gem_tiled_pread_basic.html
>>
>>   * igt@i915_pm_rps@basic-api:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][37] ([i915#6621])
>>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@i915_pm_rps@basic-api.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][38] ([i915#6621])
>>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][39] ([i915#6621])
>>    [39]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@i915_pm_rps@basic-api.html
>>
>>   * igt@i915_suspend@basic-s3-without-i915:
>>     - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][40] ([i915#7443])
>>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][41] ([i915#6645])
>>    [41]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@i915_suspend@basic-s3-without-i915.html
>>
>>   * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][42] ([i915#4212]) +8 other tests skip
>>    [42]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
>>
>>   * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][43] ([i915#4212]) +6 other tests skip
>>    [43]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
>>
>>   * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][44] ([i915#5190])
>>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][45] ([i915#5190])
>>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][46] ([i915#5190])
>>    [46]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>
>>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][47] ([i915#4215] / [i915#5190])
>>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][48] ([i915#4215] / [i915#5190])
>>    [48]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@kms_addfb_basic@basic-y-tiled-legacy.html
>>
>>   * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][49] ([i915#4212]) +6 other tests skip
>>    [49]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
>> igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
>>
>>   * igt@kms_addfb_basic@tile-pitch-mismatch:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][50] ([i915#4212] / [i915#5608])
>>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][51] ([i915#4212] / [i915#5608])
>>    [51]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@kms_addfb_basic@tile-pitch-mismatch.html
>>
>>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][52] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][53] ([i915#4103]) +1 other test skip
>>    [53]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
>> 5g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>>
>>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>>     - fi-cfl-guc:         NOTRUN -> [SKIP][54] ([fdo#109271]) +6 other tests skip
>>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][55] ([i915#4103]) +1 other test skip
>>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][56] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>>    [56]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
>> igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>
>>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][57] ([i915#1845]) +12 other tests skip
>>    [57]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>>
>>   * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1845]) +14 other tests skip
>>    [58]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc
>> /igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
>>
>>   * igt@kms_dsc@dsc-basic:
>>     - fi-skl-guc:         NOTRUN -> [SKIP][59] ([fdo#109271]) +8 other tests skip
>>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_dsc@dsc-basic.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][60] ([i915#3555] / [i915#3840])
>>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_dsc@dsc-basic.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][61] ([i915#3555] / [i915#3840])
>>    [61]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-111
>> 5g4/igt@kms_dsc@dsc-basic.html
>>
>>   * igt@kms_flip@basic-flip-vs-dpms:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][62] ([i915#3637]) +3 other tests skip
>>    [62]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_flip@basic-flip-vs-dpms.html
>>
>>   * igt@kms_force_connector_basic@force-load-detect:
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][63] ([fdo#109271]) +6 other tests skip
>>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][64] ([fdo#109285])
>>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][65] ([fdo#109285])
>>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][66] ([fdo#109285])
>>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][67] ([fdo#109285])
>>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][68] ([fdo#109285])
>>    [68]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@kms_force_connector_basic@force-load-detect.html
>>
>>   * igt@kms_force_connector_basic@prune-stale-modes:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][69] ([i915#5274])
>>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#5274])
>>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][71] ([i915#5274])
>>    [71]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_force_connector_basic@prune-stale-modes.html
>>
>>   * igt@kms_frontbuffer_tracking@basic:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][72] ([fdo#109271]) +17 other tests skip
>>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][73] ([fdo#109271]) +15 other tests skip
>>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][74] ([i915#4342])
>>    [74]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_frontbuffer_tracking@basic.html
>>
>>   * igt@kms_hdmi_inject@inject-audio:
>>     - fi-skl-guc:         NOTRUN -> [FAIL][75] ([IGT#3])
>>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_hdmi_inject@inject-audio.html
>>     - fi-bsw-n3050:       NOTRUN -> [FAIL][76] ([IGT#3])
>>    [76]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n30
>> 50/igt@kms_hdmi_inject@inject-audio.html
>>
>>   * igt@kms_pipe_crc_basic@read-crc:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#1845]) +14 other tests skip
>>    [77]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x12
>> 75/igt@kms_pipe_crc_basic@read-crc.html
>>
>>   * igt@kms_pipe_crc_basic@suspend-read-crc:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][78] ([i915#1845] / [i915#4078]) +4 other tests skip
>>    [78]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_pipe_crc_basic@suspend-read-crc.html
>>
>>   * igt@kms_setmode@basic-clone-single-crtc:
>>     - bat-jsl-3:          NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
>>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3555] / [i915#4098])
>>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][81] ([i915#3555] / [i915#4098])
>>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][82] ([i915#3555])
>>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8809])
>>    [83]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@kms_setmode@basic-clone-single-crtc.html
>>
>>   * igt@prime_vgem@basic-fence-flip:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][84] ([i915#3708])
>>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][85] ([i915#3708])
>>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][86] ([i915#1845] / [i915#3708])
>>    [86]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@prime_vgem@basic-fence-flip.html
>>
>>   * igt@prime_vgem@basic-fence-mmap:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][87] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][88] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][89] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [89]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/
>> igt@prime_vgem@basic-fence-mmap.html
>>
>>   * igt@prime_vgem@basic-read:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][90] ([i915#3291] / [i915#3708]) +2 other tests skip
>>    [90]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11
>> /igt@prime_vgem@basic-read.html
>>
>>   * igt@prime_vgem@basic-write:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][91] ([i915#3291] / [i915#3708]) +2 other tests skip
>>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-write.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][92] ([i915#3708]) +2 other tests skip
>>    [92]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6
>> /igt@prime_vgem@basic-write.html
>>
>>   
>> #### Possible fixes ####
>>
>>   * igt@i915_selftest@live@gt_timelines:
>>     - fi-hsw-4770:        [INCOMPLETE][93] ([i915#9527]) -> [PASS][94]
>>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
>>    [94]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-477
>> 0/igt@i915_selftest@live@gt_timelines.html
>>
>>   
>>   {name}: This element is suppressed. This means it is ignored when computing
>>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>>
>>   [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
>>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>>   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>>   [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
>>   [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
>>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>>   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>>   [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
>>   [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
>>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>>   [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
>>   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>>   [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
>>   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>>   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
>>   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>>   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>>   [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
>>   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>>   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>>   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>>   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>>   [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
>>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>>   [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>>   [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
>>   [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
>>   [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
>>   [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
>>   [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
>>   [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
>>   [i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
>>   [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
>>   [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
>>   [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
>>   [i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
>>   [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
>>
>>
>> Build changes
>> -------------
>>
>>   * Linux: CI_DRM_13883 -> Patchwork_125977v2
>>
>>   CI-20190529: 20190529
>>   CI_DRM_13883: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
>>   IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>>   Patchwork_125977v2: 382a59d725202e3548f8fcbffbefe8664a921e30 @ 
>> git://anongit.freedesktop.org/gfx-ci/linux
>>
>>
>> ### Linux commits
>>
>> 88bdd4e021ea drm/i915/iosf: Drop unused APIs a77c188e1c5e 
>> drm/i915/dsi: Combine checks in mipi_exec_gpio() 0d4f7726f12e 
>> drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
>> 676e85ad0140 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish 
>> GPIO communities
>> 243097ffab80 drm/i915/dsi: Replace poking of VLV GPIOs behind the 
>> driver's back 2ba66360f03d drm/i915/dsi: Extract common 
>> soc_gpio_set_value() helper
>> 4272788720c6 drm/i915/dsi: Fix wrong initial value for GPIOs in 
>> bxt_gpio_set_value()
>> 08cf117983e4 drm/i915/dsi: Remove GPIO lookup table at the end of 
>> intel_dsi_vbt_gpio_init() ab1ce1add06d drm/i915/dsi: Replace check 
>> with a (missing) MIPI sequence name
>> 6104bf6004b4 drm/i915/dsi: Get rid of redundant 'else'
>> 17366b81dadb drm/i915/dsi: Replace while(1) with one with clear exit 
>> condition
>> 21b1b71e73f1 drm/i915/dsi: bxt/icl GPIO set value do not need gpio 
>> source 60c4936330be drm/i915/dsi: rename platform specific 
>> *_exec_gpio() to *_gpio_set_value() 4beabfe83d0f drm/i915/dsi: clarify 
>> GPIO exec sequence 47de5df0986b drm/i915/dsi: switch mipi_exec_gpio() 
>> from dev_priv to i915
>> 7f9c22df7f34 drm/i915/dsi: assume BXT gpio works for non-native GPIO
>>
>> == Logs ==
>>
>> For more details see: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.html
>
> --
> Jani Nikula, Intel

-- 
Jani Nikula, Intel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Andy Shevchenko]

On Wed, Nov 22, 2023 at 12:55:05PM +0200, Jani Nikula wrote:
> On Tue, 21 Nov 2023, "Illipilli, TejasreeX" <tejasreex.illipilli@intel.com> wrote:
> > Hi ,
> >
> > https://patchwork.freedesktop.org/series/125977/
> 
> Thanks, I guess, but now what? There are no shards results but the
> series is not in the shards queue either [1].
> 
> I don't know what to do.

Tell me if anything I can help with.

To me sounds like CI doesn't like the series because of those checkpatch
warnings... But I'm not familiar at all with that, I might be very well
mistaken.

> [1] https://intel-gfx-ci.01.org/queue/index.html#fullshards-queue

> > -----Original Message-----
> > From: Jani Nikula <jani.nikula@linux.intel.com> 
> > Sent: Thursday, November 16, 2023 10:29 PM
> > To: LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
> >
> > On Thu, 16 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> >> == Series Details ==
> >>
> >> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
> >> URL   : https://patchwork.freedesktop.org/series/125977/
> >> State : failure
> >>
> >> == Summary ==
> >>
> >> CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 
> >> ====================================================
> >>
> >> Summary
> >> -------
> >>
> >>   **FAILURE**
> >>
> >>   Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
> >>   verified manually.
> >>   
> >>   If you think the reported changes have nothing to do with the changes
> >>   introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
> >>   to document this new failure mode, which will reduce false positives in CI.
> >
> > The reported issue is unrelated to the series.
> >
> > Please consider adding
> >
> > Reply-To: lgci.bug.filing@intel.com
> >
> > message header to these status mails, so the right mail gets added automatically.

-- 
With Best Regards,
Andy Shevchenko

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Musial, Ewelina]

Hi, I reviewed what I could, and my conclusion is that CI.FULL for this series was killed due to my work around 126526v6 - yesterday I was asked to do whatever I can to speed up shards testing for mentioned series and I killed multiple sessions which were higher in queue. We do not have option to simply bump priority for premerge series and the only way (not recommended but sometimes needed) is to drop everything what is higher. I've added this series back to queue. Sorry for inconvenience

Regards,
Ewelina

-----Original Message-----
From: Jani Nikula <jani.nikula@linux.intel.com> 
Sent: Wednesday, November 22, 2023 11:55 AM
To: Illipilli, TejasreeX <tejasreex.illipilli@intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

On Tue, 21 Nov 2023, "Illipilli, TejasreeX" <tejasreex.illipilli@intel.com> wrote:
> Hi ,
>
> https://patchwork.freedesktop.org/series/125977/

Thanks, I guess, but now what? There are no shards results but the series is not in the shards queue either [1].

I don't know what to do.


BR,
Jani.


[1] https://intel-gfx-ci.01.org/queue/index.html#fullshards-queue


>
> Thanks,
> Tejasree
>
> -----Original Message-----
> From: Jani Nikula <jani.nikula@linux.intel.com>
> Sent: Thursday, November 16, 2023 10:29 PM
> To: LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko 
> <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th 
> attempt to get rid of IOSF GPIO (rev2)
>
> On Thu, 16 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
>> == Series Details ==
>>
>> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)
>> URL   : https://patchwork.freedesktop.org/series/125977/
>> State : failure
>>
>> == Summary ==
>>
>> CI Bug Log - changes from CI_DRM_13883 -> Patchwork_125977v2 
>> ====================================================
>>
>> Summary
>> -------
>>
>>   **FAILURE**
>>
>>   Serious unknown changes coming with Patchwork_125977v2 absolutely need to be
>>   verified manually.
>>   
>>   If you think the reported changes have nothing to do with the changes
>>   introduced in Patchwork_125977v2, please notify your bug team (lgci.bug.filing@intel.com) to allow them
>>   to document this new failure mode, which will reduce false positives in CI.
>
> The reported issue is unrelated to the series.
>
> Please consider adding
>
> Reply-To: lgci.bug.filing@intel.com
>
> message header to these status mails, so the right mail gets added automatically.
>
>
> Thanks,
> Jani.
>
>
>>
>>   External URL: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.htm
>> l
>>
>> Participating hosts (23 -> 36)
>> ------------------------------
>>
>>   Additional (16): fi-kbl-7567u fi-skl-guc fi-tgl-1115g4 bat-dg2-9 fi-cfl-guc fi-ilk-650 fi-kbl-guc fi-kbl-x1275 fi-pnv-d510 fi-ivb-3770 fi-elk-e7500 bat-jsl-3 bat-dg2-14 bat-dg2-13 bat-dg2-11 bat-mtlp-6 
>>   Missing    (3): bat-mtlp-8 fi-snb-2520m bat-dg1-5 
>>
>> Possible new issues
>> -------------------
>>
>>   Here are the unknown changes that may have been introduced in Patchwork_125977v2:
>>
>> ### IGT changes ###
>>
>> #### Possible regressions ####
>>
>>   * igt@i915_selftest@live@gt_pm:
>>     - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][1]
>>    [1]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-47
>> 7
>> 0/igt@i915_selftest@live@gt_pm.html
>>
>>   
>> Known issues
>> ------------
>>
>>   Here are the changes found in Patchwork_125977v2 that come from known issues:
>>
>> ### CI changes ###
>>
>> #### Possible fixes ####
>>
>>   * boot:
>>     - fi-bsw-n3050:       [FAIL][2] ([i915#8293]) -> [PASS][3]
>>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-bsw-n3050/boot.html
>>    [3]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3
>> 0
>> 50/boot.html
>>
>>   
>>
>> ### IGT changes ###
>>
>> #### Issues hit ####
>>
>>   * igt@debugfs_test@basic-hwmon:
>>     - bat-jsl-3:          NOTRUN -> [SKIP][4] ([i915#9318])
>>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@debugfs_test@basic-hwmon.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][5] ([i915#9318])
>>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@debugfs_test@basic-hwmon.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][6] ([i915#9318])
>>    [6]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@debugfs_test@basic-hwmon.html
>>
>>   * igt@fbdev@info:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#1849])
>>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@fbdev@info.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#1849])
>>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@fbdev@info.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][9] ([i915#1849] / [i915#2582])
>>    [9]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@fbdev@info.html
>>
>>   * igt@fbdev@write:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][10] ([i915#2582]) +3 other tests skip
>>    [10]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@fbdev@write.html
>>
>>   * igt@gem_huc_copy@huc-copy:
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][11] ([fdo#109271] / [i915#2190])
>>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@gem_huc_copy@huc-copy.html
>>     - fi-ivb-3770:        NOTRUN -> [SKIP][12] ([fdo#109271]) +15 other tests skip
>>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ivb-3770/igt@gem_huc_copy@huc-copy.html
>>     - fi-elk-e7500:       NOTRUN -> [SKIP][13] ([fdo#109271]) +17 other tests skip
>>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-elk-e7500/igt@gem_huc_copy@huc-copy.html
>>     - fi-ilk-650:         NOTRUN -> [SKIP][14] ([fdo#109271]) +15 other tests skip
>>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-ilk-650/igt@gem_huc_copy@huc-copy.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][15] ([i915#2190])
>>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@gem_huc_copy@huc-copy.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][16] ([i915#2190])
>>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_huc_copy@huc-copy.html
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][17] ([fdo#109271] / [i915#2190])
>>    [17]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1
>> 2
>> 75/igt@gem_huc_copy@huc-copy.html
>>
>>   * igt@gem_lmem_swapping@basic:
>>     - fi-pnv-d510:        NOTRUN -> [SKIP][18] ([fdo#109271]) +25 other tests skip
>>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-pnv-d510/igt@gem_lmem_swapping@basic.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][19] ([i915#4613]) +3 other tests skip
>>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@gem_lmem_swapping@basic.html
>>     - fi-skl-guc:         NOTRUN -> [SKIP][20] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@gem_lmem_swapping@basic.html
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][21] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [21]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-75
>> 6
>> 7u/igt@gem_lmem_swapping@basic.html
>>
>>   * igt@gem_lmem_swapping@parallel-random-engines:
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][22] ([i915#4613]) +3 other tests skip
>>    [22]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-11
>> 1 5g4/igt@gem_lmem_swapping@parallel-random-engines.html
>>
>>   * igt@gem_lmem_swapping@random-engines:
>>     - fi-bsw-n3050:       NOTRUN -> [SKIP][23] ([fdo#109271]) +14 other tests skip
>>    [23]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3
>> 0 50/igt@gem_lmem_swapping@random-engines.html
>>
>>   * igt@gem_lmem_swapping@verify-random:
>>     - fi-cfl-guc:         NOTRUN -> [SKIP][24] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@gem_lmem_swapping@verify-random.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][25] ([i915#4613]) +3 other tests skip
>>    [25]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@gem_lmem_swapping@verify-random.html
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][26] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@gem_lmem_swapping@verify-random.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][27] ([fdo#109271] / [i915#4613]) +3 other tests skip
>>    [27]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-gu
>> c /igt@gem_lmem_swapping@verify-random.html
>>
>>   * igt@gem_mmap@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][28] ([i915#4083])
>>    [28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@gem_mmap@basic.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][29] ([i915#4083])
>>    [29]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_mmap@basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][30] ([i915#4083])
>>    [30]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@gem_mmap@basic.html
>>
>>   * igt@gem_mmap_gtt@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][31] ([i915#4077]) +2 other tests skip
>>    [31]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9
>> /
>> igt@gem_mmap_gtt@basic.html
>>
>>   * igt@gem_render_tiled_blits@basic:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][32] ([i915#4079]) +1 other test skip
>>    [32]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9
>> / igt@gem_render_tiled_blits@basic.html
>>
>>   * igt@gem_tiled_blits@basic:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][33] ([i915#4077]) +2 other tests skip
>>    [33]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@gem_tiled_blits@basic.html
>>
>>   * igt@gem_tiled_fence_blits@basic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][34] ([i915#4077]) +2 other tests skip
>>    [34]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@gem_tiled_fence_blits@basic.html
>>
>>   * igt@gem_tiled_pread_basic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][35] ([i915#4079]) +1 other test skip
>>    [35]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@gem_tiled_pread_basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][36] ([i915#4079]) +1 other test skip
>>    [36]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@gem_tiled_pread_basic.html
>>
>>   * igt@i915_pm_rps@basic-api:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][37] ([i915#6621])
>>    [37]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@i915_pm_rps@basic-api.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][38] ([i915#6621])
>>    [38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@i915_pm_rps@basic-api.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][39] ([i915#6621])
>>    [39]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@i915_pm_rps@basic-api.html
>>
>>   * igt@i915_suspend@basic-s3-without-i915:
>>     - fi-tgl-1115g4:      NOTRUN -> [INCOMPLETE][40] ([i915#7443])
>>    [40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@i915_suspend@basic-s3-without-i915.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][41] ([i915#6645])
>>    [41]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@i915_suspend@basic-s3-without-i915.html
>>
>>   * igt@kms_addfb_basic@addfb25-x-tiled-legacy:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][42] ([i915#4212]) +8 other tests skip
>>    [42]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_addfb_basic@addfb25-x-tiled-legacy.html
>>
>>   * igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][43] ([i915#4212]) +6 other tests skip
>>    [43]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@kms_addfb_basic@addfb25-x-tiled-mismatch-legacy.html
>>
>>   * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][44] ([i915#5190])
>>    [44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][45] ([i915#5190])
>>    [45]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][46] ([i915#5190])
>>    [46]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>>
>>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][47] ([i915#4215] / [i915#5190])
>>    [47]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][48] ([i915#4215] / [i915#5190])
>>    [48]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@kms_addfb_basic@basic-y-tiled-legacy.html
>>
>>   * igt@kms_addfb_basic@framebuffer-vs-set-tiling:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][49] ([i915#4212]) +6 other tests skip
>>    [49]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9
>> / igt@kms_addfb_basic@framebuffer-vs-set-tiling.html
>>
>>   * igt@kms_addfb_basic@tile-pitch-mismatch:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][50] ([i915#4212] / [i915#5608])
>>    [50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_addfb_basic@tile-pitch-mismatch.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][51] ([i915#4212] / [i915#5608])
>>    [51]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@kms_addfb_basic@tile-pitch-mismatch.html
>>
>>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][52] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>>    [52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][53] ([i915#4103]) +1 other test skip
>>    [53]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-11
>> 1 5g4/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-atomic.html
>>
>>   * igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy:
>>     - fi-cfl-guc:         NOTRUN -> [SKIP][54] ([fdo#109271]) +6 other tests skip
>>    [54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-cfl-guc/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][55] ([i915#4103]) +1 other test skip
>>    [55]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][56] ([i915#4103] / [i915#4213] / [i915#5608]) +1 other test skip
>>    [56]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9
>> / igt@kms_cursor_legacy@basic-busy-flip-before-cursor-legacy.html
>>
>>   * igt@kms_cursor_legacy@basic-flip-after-cursor-legacy:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][57] ([i915#1845]) +12 other tests skip
>>    [57]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_cursor_legacy@basic-flip-after-cursor-legacy.html
>>
>>   * igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size:
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][58] ([fdo#109271] / [i915#1845]) +14 other tests skip
>>    [58]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-gu
>> c /igt@kms_cursor_legacy@basic-flip-before-cursor-varying-size.html
>>
>>   * igt@kms_dsc@dsc-basic:
>>     - fi-skl-guc:         NOTRUN -> [SKIP][59] ([fdo#109271]) +8 other tests skip
>>    [59]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_dsc@dsc-basic.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][60] ([i915#3555] / [i915#3840])
>>    [60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_dsc@dsc-basic.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][61] ([i915#3555] / [i915#3840])
>>    [61]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-11
>> 1
>> 5g4/igt@kms_dsc@dsc-basic.html
>>
>>   * igt@kms_flip@basic-flip-vs-dpms:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][62] ([i915#3637]) +3 other tests skip
>>    [62]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_flip@basic-flip-vs-dpms.html
>>
>>   * igt@kms_force_connector_basic@force-load-detect:
>>     - fi-kbl-7567u:       NOTRUN -> [SKIP][63] ([fdo#109271]) +6 other tests skip
>>    [63]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-7567u/igt@kms_force_connector_basic@force-load-detect.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][64] ([fdo#109285])
>>    [64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][65] ([fdo#109285])
>>    [65]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-jsl-3:          NOTRUN -> [SKIP][66] ([fdo#109285])
>>    [66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][67] ([fdo#109285])
>>    [67]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@force-load-detect.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][68] ([fdo#109285])
>>    [68]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1 /igt@kms_force_connector_basic@force-load-detect.html
>>
>>   * igt@kms_force_connector_basic@prune-stale-modes:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][69] ([i915#5274])
>>    [69]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_force_connector_basic@prune-stale-modes.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][70] ([i915#5274])
>>    [70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_force_connector_basic@prune-stale-modes.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][71] ([i915#5274])
>>    [71]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_force_connector_basic@prune-stale-modes.html
>>
>>   * igt@kms_frontbuffer_tracking@basic:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][72] ([fdo#109271]) +17 other tests skip
>>    [72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1275/igt@kms_frontbuffer_tracking@basic.html
>>     - fi-kbl-guc:         NOTRUN -> [SKIP][73] ([fdo#109271]) +15 other tests skip
>>    [73]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-guc/igt@kms_frontbuffer_tracking@basic.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][74] ([i915#4342])
>>    [74]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_frontbuffer_tracking@basic.html
>>
>>   * igt@kms_hdmi_inject@inject-audio:
>>     - fi-skl-guc:         NOTRUN -> [FAIL][75] ([IGT#3])
>>    [75]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-skl-guc/igt@kms_hdmi_inject@inject-audio.html
>>     - fi-bsw-n3050:       NOTRUN -> [FAIL][76] ([IGT#3])
>>    [76]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-bsw-n3
>> 0 50/igt@kms_hdmi_inject@inject-audio.html
>>
>>   * igt@kms_pipe_crc_basic@read-crc:
>>     - fi-kbl-x1275:       NOTRUN -> [SKIP][77] ([fdo#109271] / [i915#1845]) +14 other tests skip
>>    [77]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-kbl-x1
>> 2 75/igt@kms_pipe_crc_basic@read-crc.html
>>
>>   * igt@kms_pipe_crc_basic@suspend-read-crc:
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][78] ([i915#1845] / [i915#4078]) +4 other tests skip
>>    [78]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_pipe_crc_basic@suspend-read-crc.html
>>
>>   * igt@kms_setmode@basic-clone-single-crtc:
>>     - bat-jsl-3:          NOTRUN -> [SKIP][79] ([i915#3555]) +1 other test skip
>>    [79]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-jsl-3/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][80] ([i915#3555] / [i915#4098])
>>    [80]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][81] ([i915#3555] / [i915#4098])
>>    [81]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@kms_setmode@basic-clone-single-crtc.html
>>     - fi-tgl-1115g4:      NOTRUN -> [SKIP][82] ([i915#3555])
>>    [82]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-tgl-1115g4/igt@kms_setmode@basic-clone-single-crtc.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][83] ([i915#3555] / [i915#8809])
>>    [83]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@kms_setmode@basic-clone-single-crtc.html
>>
>>   * igt@prime_vgem@basic-fence-flip:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][84] ([i915#3708])
>>    [84]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-fence-flip.html
>>     - bat-dg2-11:         NOTRUN -> [SKIP][85] ([i915#3708])
>>    [85]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-flip.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][86] ([i915#1845] / [i915#3708])
>>    [86]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6 /igt@prime_vgem@basic-fence-flip.html
>>
>>   * igt@prime_vgem@basic-fence-mmap:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][87] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [87]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-11/igt@prime_vgem@basic-fence-mmap.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][88] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [88]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-6/igt@prime_vgem@basic-fence-mmap.html
>>     - bat-dg2-9:          NOTRUN -> [SKIP][89] ([i915#3708] / [i915#4077]) +1 other test skip
>>    [89]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9
>> /
>> igt@prime_vgem@basic-fence-mmap.html
>>
>>   * igt@prime_vgem@basic-read:
>>     - bat-dg2-11:         NOTRUN -> [SKIP][90] ([i915#3291] / [i915#3708]) +2 other tests skip
>>    [90]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-1
>> 1
>> /igt@prime_vgem@basic-read.html
>>
>>   * igt@prime_vgem@basic-write:
>>     - bat-dg2-9:          NOTRUN -> [SKIP][91] ([i915#3291] / [i915#3708]) +2 other tests skip
>>    [91]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-dg2-9/igt@prime_vgem@basic-write.html
>>     - bat-mtlp-6:         NOTRUN -> [SKIP][92] ([i915#3708]) +2 other tests skip
>>    [92]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/bat-mtlp-
>> 6
>> /igt@prime_vgem@basic-write.html
>>
>>   
>> #### Possible fixes ####
>>
>>   * igt@i915_selftest@live@gt_timelines:
>>     - fi-hsw-4770:        [INCOMPLETE][93] ([i915#9527]) -> [PASS][94]
>>    [93]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13883/fi-hsw-4770/igt@i915_selftest@live@gt_timelines.html
>>    [94]: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/fi-hsw-47
>> 7 0/igt@i915_selftest@live@gt_timelines.html
>>
>>   
>>   {name}: This element is suppressed. This means it is ignored when computing
>>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>>
>>   [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
>>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>>   [fdo#109285]: https://bugs.freedesktop.org/show_bug.cgi?id=109285
>>   [i915#1845]: https://gitlab.freedesktop.org/drm/intel/issues/1845
>>   [i915#1849]: https://gitlab.freedesktop.org/drm/intel/issues/1849
>>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>>   [i915#2582]: https://gitlab.freedesktop.org/drm/intel/issues/2582
>>   [i915#3291]: https://gitlab.freedesktop.org/drm/intel/issues/3291
>>   [i915#3546]: https://gitlab.freedesktop.org/drm/intel/issues/3546
>>   [i915#3555]: https://gitlab.freedesktop.org/drm/intel/issues/3555
>>   [i915#3637]: https://gitlab.freedesktop.org/drm/intel/issues/3637
>>   [i915#3708]: https://gitlab.freedesktop.org/drm/intel/issues/3708
>>   [i915#3840]: https://gitlab.freedesktop.org/drm/intel/issues/3840
>>   [i915#4077]: https://gitlab.freedesktop.org/drm/intel/issues/4077
>>   [i915#4078]: https://gitlab.freedesktop.org/drm/intel/issues/4078
>>   [i915#4079]: https://gitlab.freedesktop.org/drm/intel/issues/4079
>>   [i915#4083]: https://gitlab.freedesktop.org/drm/intel/issues/4083
>>   [i915#4098]: https://gitlab.freedesktop.org/drm/intel/issues/4098
>>   [i915#4103]: https://gitlab.freedesktop.org/drm/intel/issues/4103
>>   [i915#4212]: https://gitlab.freedesktop.org/drm/intel/issues/4212
>>   [i915#4213]: https://gitlab.freedesktop.org/drm/intel/issues/4213
>>   [i915#4215]: https://gitlab.freedesktop.org/drm/intel/issues/4215
>>   [i915#4342]: https://gitlab.freedesktop.org/drm/intel/issues/4342
>>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>>   [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>>   [i915#5274]: https://gitlab.freedesktop.org/drm/intel/issues/5274
>>   [i915#5354]: https://gitlab.freedesktop.org/drm/intel/issues/5354
>>   [i915#5608]: https://gitlab.freedesktop.org/drm/intel/issues/5608
>>   [i915#6621]: https://gitlab.freedesktop.org/drm/intel/issues/6621
>>   [i915#6645]: https://gitlab.freedesktop.org/drm/intel/issues/6645
>>   [i915#7443]: https://gitlab.freedesktop.org/drm/intel/issues/7443
>>   [i915#7812]: https://gitlab.freedesktop.org/drm/intel/issues/7812
>>   [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
>>   [i915#8809]: https://gitlab.freedesktop.org/drm/intel/issues/8809
>>   [i915#9318]: https://gitlab.freedesktop.org/drm/intel/issues/9318
>>   [i915#9527]: https://gitlab.freedesktop.org/drm/intel/issues/9527
>>   [i915#9673]: https://gitlab.freedesktop.org/drm/intel/issues/9673
>>
>>
>> Build changes
>> -------------
>>
>>   * Linux: CI_DRM_13883 -> Patchwork_125977v2
>>
>>   CI-20190529: 20190529
>>   CI_DRM_13883: 382a59d725202e3548f8fcbffbefe8664a921e30 @ git://anongit.freedesktop.org/gfx-ci/linux
>>   IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>>   Patchwork_125977v2: 382a59d725202e3548f8fcbffbefe8664a921e30 @ 
>> git://anongit.freedesktop.org/gfx-ci/linux
>>
>>
>> ### Linux commits
>>
>> 88bdd4e021ea drm/i915/iosf: Drop unused APIs a77c188e1c5e
>> drm/i915/dsi: Combine checks in mipi_exec_gpio() 0d4f7726f12e
>> drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
>> 676e85ad0140 drm/i915/dsi: Prepare soc_gpio_set_value() to 
>> distinguish GPIO communities
>> 243097ffab80 drm/i915/dsi: Replace poking of VLV GPIOs behind the 
>> driver's back 2ba66360f03d drm/i915/dsi: Extract common
>> soc_gpio_set_value() helper
>> 4272788720c6 drm/i915/dsi: Fix wrong initial value for GPIOs in
>> bxt_gpio_set_value()
>> 08cf117983e4 drm/i915/dsi: Remove GPIO lookup table at the end of
>> intel_dsi_vbt_gpio_init() ab1ce1add06d drm/i915/dsi: Replace check 
>> with a (missing) MIPI sequence name
>> 6104bf6004b4 drm/i915/dsi: Get rid of redundant 'else'
>> 17366b81dadb drm/i915/dsi: Replace while(1) with one with clear exit 
>> condition
>> 21b1b71e73f1 drm/i915/dsi: bxt/icl GPIO set value do not need gpio 
>> source 60c4936330be drm/i915/dsi: rename platform specific
>> *_exec_gpio() to *_gpio_set_value() 4beabfe83d0f drm/i915/dsi: 
>> clarify GPIO exec sequence 47de5df0986b drm/i915/dsi: switch 
>> mipi_exec_gpio() from dev_priv to i915
>> 7f9c22df7f34 drm/i915/dsi: assume BXT gpio works for non-native GPIO
>>
>> == Logs ==
>>
>> For more details see: 
>> https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v2/index.htm
>> l
>
> --
> Jani Nikula, Intel

--
Jani Nikula, Intel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Saarinen, Jani]

HI, 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of Musial,
> Ewelina
> Sent: Wednesday, November 22, 2023 3:39 PM
> To: Jani Nikula <jani.nikula@linux.intel.com>; Illipilli, TejasreeX
> <tejasreex.illipilli@intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy
> Shevchenko <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid
> of IOSF GPIO (rev2)
> 
> Hi, I reviewed what I could, and my conclusion is that CI.FULL for this series was
> killed due to my work around 126526v6 - yesterday I was asked to do whatever I
> can to speed up shards testing for mentioned series and I killed multiple sessions
> which were higher in queue. We do not have option to simply bump priority for
> premerge series and the only way (not recommended but sometimes needed) is
> to drop everything what is higher. I've added this series back to queue. Sorry for
> inconvenience
Nope. It was not part of that list. We checked that with Jani too. See those pictures we discussed. 
> 
> Regards,
> Ewelina

Br,
Jani S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Musial, Ewelina]

But this list had only series which were in queue here https://intel-gfx-ci.01.org/queue/index.html and today I was checking exactly how queue for shards is created and there are jobs which are not displayed there. Directly in Jenkins we do have multiple more jobs than in this queue only and I also killed them. I was discussing exactly this case today with Michał and he pointed out that in explanation below queues we do have highlighted:
Due to technical limitation this is just an approximation of the queue. It is good for assessing the length of the queue, but should not be considered as completely accurate.

Regards,
Ewelina

-----Original Message-----
From: Saarinen, Jani <jani.saarinen@intel.com> 
Sent: Wednesday, November 22, 2023 3:04 PM
To: Musial, Ewelina <ewelina.musial@intel.com>; Jani Nikula <jani.nikula@linux.intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: intel-gfx@lists.freedesktop.org
Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

HI, 
> -----Original Message-----
> From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of 
> Musial, Ewelina
> Sent: Wednesday, November 22, 2023 3:39 PM
> To: Jani Nikula <jani.nikula@linux.intel.com>; Illipilli, TejasreeX 
> <tejasreex.illipilli@intel.com>; LGCI Bug Filing 
> <lgci.bug.filing@intel.com>; Andy Shevchenko 
> <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th 
> attempt to get rid of IOSF GPIO (rev2)
> 
> Hi, I reviewed what I could, and my conclusion is that CI.FULL for 
> this series was killed due to my work around 126526v6 - yesterday I 
> was asked to do whatever I can to speed up shards testing for 
> mentioned series and I killed multiple sessions which were higher in 
> queue. We do not have option to simply bump priority for premerge 
> series and the only way (not recommended but sometimes needed) is to 
> drop everything what is higher. I've added this series back to queue. 
> Sorry for inconvenience
Nope. It was not part of that list. We checked that with Jani too. See those pictures we discussed. 
> 
> Regards,
> Ewelina

Br,
Jani S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Saarinen, Jani]

Hi, 
> -----Original Message-----
> From: Musial, Ewelina <ewelina.musial@intel.com>
> Sent: Wednesday, November 22, 2023 4:25 PM
> To: Saarinen, Jani <jani.saarinen@intel.com>; Jani Nikula
> <jani.nikula@linux.intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>;
> LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid
> of IOSF GPIO (rev2)
> 
> But this list had only series which were in queue here https://intel-gfx-
> ci.01.org/queue/index.html and today I was checking exactly how queue for
> shards is created and there are jobs which are not displayed there. Directly in
> Jenkins we do have multiple more jobs than in this queue only and I also killed
> them. I was discussing exactly this case today with Michał and he pointed out that
> in explanation below queues we do have highlighted:
> Due to technical limitation this is just an approximation of the queue. It is good
> for assessing the length of the queue, but should not be considered as
> completely accurate.
OK. So could have been in the list but not sure. 
> 
> Regards,
> Ewelina
> 
> -----Original Message-----
> From: Saarinen, Jani <jani.saarinen@intel.com>
> Sent: Wednesday, November 22, 2023 3:04 PM
> To: Musial, Ewelina <ewelina.musial@intel.com>; Jani Nikula
> <jani.nikula@linux.intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>;
> LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko
> <andriy.shevchenko@linux.intel.com>
> Cc: intel-gfx@lists.freedesktop.org
> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid
> of IOSF GPIO (rev2)
> 
> HI,
> > -----Original Message-----
> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
> > Musial, Ewelina
> > Sent: Wednesday, November 22, 2023 3:39 PM
> > To: Jani Nikula <jani.nikula@linux.intel.com>; Illipilli, TejasreeX
> > <tejasreex.illipilli@intel.com>; LGCI Bug Filing
> > <lgci.bug.filing@intel.com>; Andy Shevchenko
> > <andriy.shevchenko@linux.intel.com>
> > Cc: intel-gfx@lists.freedesktop.org
> > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th
> > attempt to get rid of IOSF GPIO (rev2)
> >
> > Hi, I reviewed what I could, and my conclusion is that CI.FULL for
> > this series was killed due to my work around 126526v6 - yesterday I
> > was asked to do whatever I can to speed up shards testing for
> > mentioned series and I killed multiple sessions which were higher in
> > queue. We do not have option to simply bump priority for premerge
> > series and the only way (not recommended but sometimes needed) is to
> > drop everything what is higher. I've added this series back to queue.
> > Sorry for inconvenience
> Nope. It was not part of that list. We checked that with Jani too. See those
> pictures we discussed.
> >
> > Regards,
> > Ewelina
> 
> Br,
> Jani S

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Jani Nikula]

On Wed, 22 Nov 2023, "Saarinen, Jani" <jani.saarinen@intel.com> wrote:
> Hi, 
>> -----Original Message-----
>> From: Musial, Ewelina <ewelina.musial@intel.com>
>> Sent: Wednesday, November 22, 2023 4:25 PM
>> To: Saarinen, Jani <jani.saarinen@intel.com>; Jani Nikula
>> <jani.nikula@linux.intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>;
>> LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid
>> of IOSF GPIO (rev2)
>> 
>> But this list had only series which were in queue here https://intel-gfx-
>> ci.01.org/queue/index.html and today I was checking exactly how queue for
>> shards is created and there are jobs which are not displayed there. Directly in
>> Jenkins we do have multiple more jobs than in this queue only and I also killed
>> them. I was discussing exactly this case today with Michał and he pointed out that
>> in explanation below queues we do have highlighted:
>> Due to technical limitation this is just an approximation of the queue. It is good
>> for assessing the length of the queue, but should not be considered as
>> completely accurate.
> OK. So could have been in the list but not sure. 

Okay, timeout.

I just pushed the series. I trust Hans' testing here, considering the
likely platform impact of the series and CI coverage of said platforms.

Thanks for the patches and review.

BR,
Jani.



>> 
>> Regards,
>> Ewelina
>> 
>> -----Original Message-----
>> From: Saarinen, Jani <jani.saarinen@intel.com>
>> Sent: Wednesday, November 22, 2023 3:04 PM
>> To: Musial, Ewelina <ewelina.musial@intel.com>; Jani Nikula
>> <jani.nikula@linux.intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>;
>> LGCI Bug Filing <lgci.bug.filing@intel.com>; Andy Shevchenko
>> <andriy.shevchenko@linux.intel.com>
>> Cc: intel-gfx@lists.freedesktop.org
>> Subject: RE: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid
>> of IOSF GPIO (rev2)
>> 
>> HI,
>> > -----Original Message-----
>> > From: Intel-gfx <intel-gfx-bounces@lists.freedesktop.org> On Behalf Of
>> > Musial, Ewelina
>> > Sent: Wednesday, November 22, 2023 3:39 PM
>> > To: Jani Nikula <jani.nikula@linux.intel.com>; Illipilli, TejasreeX
>> > <tejasreex.illipilli@intel.com>; LGCI Bug Filing
>> > <lgci.bug.filing@intel.com>; Andy Shevchenko
>> > <andriy.shevchenko@linux.intel.com>
>> > Cc: intel-gfx@lists.freedesktop.org
>> > Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th
>> > attempt to get rid of IOSF GPIO (rev2)
>> >
>> > Hi, I reviewed what I could, and my conclusion is that CI.FULL for
>> > this series was killed due to my work around 126526v6 - yesterday I
>> > was asked to do whatever I can to speed up shards testing for
>> > mentioned series and I killed multiple sessions which were higher in
>> > queue. We do not have option to simply bump priority for premerge
>> > series and the only way (not recommended but sometimes needed) is to
>> > drop everything what is higher. I've added this series back to queue.
>> > Sorry for inconvenience
>> Nope. It was not part of that list. We checked that with Jani too. See those
>> pictures we discussed.
>> >
>> > Regards,
>> > Ewelina
>> 
>> Br,
>> Jani S

-- 
Jani Nikula, Intel

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Andy Shevchenko]

On Wed, Nov 22, 2023 at 07:17:48PM +0200, Jani Nikula wrote:
> On Wed, 22 Nov 2023, "Saarinen, Jani" <jani.saarinen@intel.com> wrote:
> >> From: Musial, Ewelina <ewelina.musial@intel.com>
> >> Sent: Wednesday, November 22, 2023 4:25 PM

...

> >> But this list had only series which were in queue here https://intel-gfx-
> >> ci.01.org/queue/index.html and today I was checking exactly how queue for
> >> shards is created and there are jobs which are not displayed there.
> >> Directly in Jenkins we do have multiple more jobs than in this queue only
> >> and I also killed them. I was discussing exactly this case today with
> >> Michał and he pointed out that in explanation below queues we do have
> >> highlighted: Due to technical limitation this is just an approximation of
> >> the queue. It is good for assessing the length of the queue, but should
> >> not be considered as completely accurate.

> > OK. So could have been in the list but not sure. 
> 
> Okay, timeout.
> 
> I just pushed the series. I trust Hans' testing here, considering the
> likely platform impact of the series and CI coverage of said platforms.
> 
> Thanks for the patches and review.

Thank you, Jani, Hans, Ville and others!

-- 
With Best Regards,
Andy Shevchenko

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

[Musial, Ewelina]

http://gfx-ci.igk.intel.com/cibuglog-ng/results/compare?from=CI_DRM_13901_full&to=Patchwork_126526v6_full&csrfmiddlewaretoken=LxQnwBlJ7BUCUML28uJEQTM1MHWEEflsGVkPmXKZuSrld9uiq4pf31pBdCHSixXD&query=

Comparison for your series - premerge testing completed before base build testing and report was not published automatically on PW

Regards,
Ewelina

-----Original Message-----
From: Andy Shevchenko <andriy.shevchenko@linux.intel.com> 
Sent: Wednesday, November 22, 2023 6:30 PM
To: Jani Nikula <jani.nikula@linux.intel.com>
Cc: Saarinen, Jani <jani.saarinen@intel.com>; Musial, Ewelina <ewelina.musial@intel.com>; Illipilli, TejasreeX <tejasreex.illipilli@intel.com>; LGCI Bug Filing <lgci.bug.filing@intel.com>; intel-gfx@lists.freedesktop.org; Hans de Goede <hdegoede@redhat.com>
Subject: Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev2)

On Wed, Nov 22, 2023 at 07:17:48PM +0200, Jani Nikula wrote:
> On Wed, 22 Nov 2023, "Saarinen, Jani" <jani.saarinen@intel.com> wrote:
> >> From: Musial, Ewelina <ewelina.musial@intel.com>
> >> Sent: Wednesday, November 22, 2023 4:25 PM

...

> >> But this list had only series which were in queue here 
> >> https://intel-gfx- ci.01.org/queue/index.html and today I was 
> >> checking exactly how queue for shards is created and there are jobs which are not displayed there.
> >> Directly in Jenkins we do have multiple more jobs than in this 
> >> queue only and I also killed them. I was discussing exactly this 
> >> case today with Michał and he pointed out that in explanation below 
> >> queues we do have
> >> highlighted: Due to technical limitation this is just an 
> >> approximation of the queue. It is good for assessing the length of 
> >> the queue, but should not be considered as completely accurate.

> > OK. So could have been in the list but not sure. 
> 
> Okay, timeout.
> 
> I just pushed the series. I trust Hans' testing here, considering the 
> likely platform impact of the series and CI coverage of said platforms.
> 
> Thanks for the patches and review.

Thank you, Jani, Hans, Ville and others!

--
With Best Regards,
Andy Shevchenko

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)

[Patchwork]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)
URL   : https://patchwork.freedesktop.org/series/125977/
State : warning

== Summary ==

Error: dim checkpatch failed
22cc49190b54 drm/i915/dsi: assume BXT gpio works for non-native GPIO
c6f82321ce26 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
97b3a341db08 drm/i915/dsi: clarify GPIO exec sequence
40012088170d drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
52707c61f25a drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
67b3cb7d5182 drm/i915/dsi: Replace while(1) with one with clear exit condition
ef70c8f54435 drm/i915/dsi: Get rid of redundant 'else'
37bf89dcad57 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
442a00d4167a drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
d52c6103b59b drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
2a69f0021157 drm/i915/dsi: Extract common soc_gpio_set_value() helper
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
f57a2279ae5d drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
70d39a551487 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
5e366d62b4f2 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
843000e1ccdf drm/i915/dsi: Combine checks in mipi_exec_gpio()
a08c58664016 drm/i915/iosf: Drop unused APIs

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 6002 bytes --]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev4)
URL   : https://patchwork.freedesktop.org/series/125977/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13884 -> Patchwork_125977v4
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_125977v4 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_125977v4, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/index.html

Participating hosts (39 -> 37)
------------------------------

  Additional (1): fi-kbl-soraka 
  Missing    (3): bat-dg2-8 fi-snb-2520m bat-mtlp-8 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_125977v4:

### IGT changes ###

#### Possible regressions ####

  * igt@i915_pm_rpm@module-reload:
    - fi-hsw-4770:        [PASS][1] -> [INCOMPLETE][2]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13884/fi-hsw-4770/igt@i915_pm_rpm@module-reload.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-hsw-4770/igt@i915_pm_rpm@module-reload.html

  
Known issues
------------

  Here are the changes found in Patchwork_125977v4 that come from known issues:

### IGT changes ###

#### Issues hit ####

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][3] ([fdo#109271] / [i915#2190])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][4] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][5] ([i915#1886])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_dsc@dsc-basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][6] ([fdo#109271]) +9 other tests skip
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][7] ([i915#5334]) -> [PASS][8]
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13884/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@kms_hdmi_inject@inject-audio:
    - fi-kbl-guc:         [FAIL][9] ([IGT#3]) -> [PASS][10]
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13884/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/fi-kbl-guc/igt@kms_hdmi_inject@inject-audio.html

  * igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1:
    - bat-rplp-1:         [ABORT][11] ([i915#8668]) -> [PASS][12]
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13884/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/bat-rplp-1/igt@kms_pipe_crc_basic@read-crc-frame-sequence@pipe-d-edp-1.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [IGT#3]: https://gitlab.freedesktop.org/drm/igt-gpu-tools/issues/3
  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#8668]: https://gitlab.freedesktop.org/drm/intel/issues/8668
  [i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648


Build changes
-------------

  * Linux: CI_DRM_13884 -> Patchwork_125977v4

  CI-20190529: 20190529
  CI_DRM_13884: 9739fd04dfe62f6b46eb8f6af604decabb45a87b @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7590: c484e1422184a3183d11f1595e53a6715574520f @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_125977v4: 9739fd04dfe62f6b46eb8f6af604decabb45a87b @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

cdda2b7e7c29 drm/i915/iosf: Drop unused APIs
327c58731734 drm/i915/dsi: Combine checks in mipi_exec_gpio()
25c6a8949b00 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
050254e413a6 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
dd14c1215c31 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
1162679b70aa drm/i915/dsi: Extract common soc_gpio_set_value() helper
8787a7236d02 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
d12e9cbea01b drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
09c564d78b81 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
41398cf6f0bb drm/i915/dsi: Get rid of redundant 'else'
6aff572387a5 drm/i915/dsi: Replace while(1) with one with clear exit condition
b8abc99f9ac4 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
ca0f71f2131d drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
77388ce28d31 drm/i915/dsi: clarify GPIO exec sequence
bd0e3e6011fa drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
90d8d3e9d9bc drm/i915/dsi: assume BXT gpio works for non-native GPIO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v4/index.html

[-- Attachment #2: Type: text/html, Size: 6993 bytes --]

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

[Patchwork]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)
URL   : https://patchwork.freedesktop.org/series/125977/
State : warning

== Summary ==

Error: dim checkpatch failed
718e25fcdd2a drm/i915/dsi: assume BXT gpio works for non-native GPIO
a6aab2794a1f drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
31f24aa54faf drm/i915/dsi: clarify GPIO exec sequence
a7b02c6ed548 drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
a762b420c899 drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
b6f3e6d7b766 drm/i915/dsi: Replace while(1) with one with clear exit condition
3d8f0796f518 drm/i915/dsi: Get rid of redundant 'else'
9d795115952b drm/i915/dsi: Replace check with a (missing) MIPI sequence name
720efcc63d3c drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
63632d47d629 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
9b3cf5328aeb drm/i915/dsi: Extract common soc_gpio_set_value() helper
-:6: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#6: 
Extract a common soc_gpio_set_value() helper that may be used by a few SoCs.

total: 0 errors, 1 warnings, 0 checks, 58 lines checked
640636fdac2b drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
6ae716ae2962 drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
-:7: WARNING:COMMIT_LOG_LONG_LINE: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
#7: 
Currently soc_gpio_set_value() supports only a single indexing for GPIO pin.

total: 0 errors, 1 warnings, 0 checks, 59 lines checked
84b2cbe19cbc drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
a89aed1900d4 drm/i915/dsi: Combine checks in mipi_exec_gpio()
1182cd3b53bd drm/i915/iosf: Drop unused APIs

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7839 bytes --]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)
URL   : https://patchwork.freedesktop.org/series/125977/
State : failure

== Summary ==

CI Bug Log - changes from CI_DRM_13900 -> Patchwork_125977v5
====================================================

Summary
-------

  **FAILURE**

  Serious unknown changes coming with Patchwork_125977v5 absolutely need to be
  verified manually.
  
  If you think the reported changes have nothing to do with the changes
  introduced in Patchwork_125977v5, please notify your bug team (lgci.bug.filing@intel.com) to allow them
  to document this new failure mode, which will reduce false positives in CI.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html

Participating hosts (33 -> 34)
------------------------------

  Additional (2): fi-kbl-soraka fi-hsw-4770 
  Missing    (1): fi-snb-2520m 

Possible new issues
-------------------

  Here are the unknown changes that may have been introduced in Patchwork_125977v5:

### IGT changes ###

#### Possible regressions ####

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][1]
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  
Known issues
------------

  Here are the changes found in Patchwork_125977v5 that come from known issues:

### CI changes ###

#### Issues hit ####

  * boot:
    - fi-elk-e7500:       [PASS][2] -> [FAIL][3] ([i915#8293])
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-elk-e7500/boot.html
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-elk-e7500/boot.html
    - fi-kbl-x1275:       [PASS][4] -> [FAIL][5] ([i915#8293])
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-kbl-x1275/boot.html
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-x1275/boot.html

  

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0@lmem0:
    - bat-dg2-9:          [PASS][6] -> [INCOMPLETE][7] ([i915#9275])
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gem_contexts:
    - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][10] ([i915#9307])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@i915_selftest@live@gem_contexts.html

  * igt@i915_selftest@live@gt_lrc:
    - bat-adlm-1:         [PASS][11] -> [INCOMPLETE][12] ([i915#9413])
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][13] ([i915#1886])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - fi-hsw-4770:        NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#5190])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_dsc@dsc-basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][15] ([fdo#109271]) +9 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
    - fi-hsw-4770:        NOTRUN -> [SKIP][16] ([fdo#109271]) +12 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][17] ([i915#5334]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-6:         [DMESG-WARN][19] -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
  [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
  [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
  [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
  [i915#9307]: https://gitlab.freedesktop.org/drm/intel/issues/9307
  [i915#9413]: https://gitlab.freedesktop.org/drm/intel/issues/9413
  [i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648


Build changes
-------------

  * Linux: CI_DRM_13900 -> Patchwork_125977v5

  CI-20190529: 20190529
  CI_DRM_13900: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7595: cfa00d99b1dfa0621ea552d1ed54907798da1a1a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_125977v5: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

cb7eb92e41e3 drm/i915/iosf: Drop unused APIs
44c7e68968f6 drm/i915/dsi: Combine checks in mipi_exec_gpio()
e4396287dc34 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
28e3789e862e drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
f158fdd42837 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
6d1ab8a8b97e drm/i915/dsi: Extract common soc_gpio_set_value() helper
4dfbdedecdd6 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
0cb4b3df52e7 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
fead969f21d1 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
4c9e915997f9 drm/i915/dsi: Get rid of redundant 'else'
e5900b3a5fd2 drm/i915/dsi: Replace while(1) with one with clear exit condition
2384619f40ea drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
e5c894cae398 drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
74a19c4a70c6 drm/i915/dsi: clarify GPIO exec sequence
dd72fa43d232 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
4472705c19fb drm/i915/dsi: assume BXT gpio works for non-native GPIO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html

[-- Attachment #2: Type: text/html, Size: 9045 bytes --]

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

[Jani Nikula]

On Tue, 21 Nov 2023, Patchwork <patchwork@emeril.freedesktop.org> wrote:
> == Series Details ==
>
> Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)
> URL   : https://patchwork.freedesktop.org/series/125977/
> State : failure
>
> == Summary ==
>
> CI Bug Log - changes from CI_DRM_13900 -> Patchwork_125977v5
> ====================================================
>
> Summary
> -------
>
>   **FAILURE**
>
>   Serious unknown changes coming with Patchwork_125977v5 absolutely need to be
>   verified manually.
>   
>   If you think the reported changes have nothing to do with the changes
>   introduced in Patchwork_125977v5, please notify your bug team (lgci.bug.filing@intel.com) to allow them
>   to document this new failure mode, which will reduce false positives in CI.

These patches have functional changes only for platforms that have DSI.

On this and the previous BAT failures: fi-kbl-soraka, fi-hsw-4770, and
bat-atsm-1 do not have DSI.

Please do whatever it is you do to make this continue to IGT
testing. I've asked before, I've hit re-test.


BR,
Jani.


>
>   External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html
>
> Participating hosts (33 -> 34)
> ------------------------------
>
>   Additional (2): fi-kbl-soraka fi-hsw-4770 
>   Missing    (1): fi-snb-2520m 
>
> Possible new issues
> -------------------
>
>   Here are the unknown changes that may have been introduced in Patchwork_125977v5:
>
> ### IGT changes ###
>
> #### Possible regressions ####
>
>   * igt@kms_addfb_basic@basic-y-tiled-legacy:
>     - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][1]
>    [1]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_addfb_basic@basic-y-tiled-legacy.html
>
>   
> Known issues
> ------------
>
>   Here are the changes found in Patchwork_125977v5 that come from known issues:
>
> ### CI changes ###
>
> #### Issues hit ####
>
>   * boot:
>     - fi-elk-e7500:       [PASS][2] -> [FAIL][3] ([i915#8293])
>    [2]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-elk-e7500/boot.html
>    [3]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-elk-e7500/boot.html
>     - fi-kbl-x1275:       [PASS][4] -> [FAIL][5] ([i915#8293])
>    [4]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-kbl-x1275/boot.html
>    [5]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-x1275/boot.html
>
>   
>
> ### IGT changes ###
>
> #### Issues hit ####
>
>   * igt@gem_exec_suspend@basic-s0@lmem0:
>     - bat-dg2-9:          [PASS][6] -> [INCOMPLETE][7] ([i915#9275])
>    [6]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
>    [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
>
>   * igt@gem_huc_copy@huc-copy:
>     - fi-kbl-soraka:      NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#2190])
>    [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html
>
>   * igt@gem_lmem_swapping@basic:
>     - fi-kbl-soraka:      NOTRUN -> [SKIP][9] ([fdo#109271] / [i915#4613]) +3 other tests skip
>    [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html
>
>   * igt@i915_selftest@live@gem_contexts:
>     - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][10] ([i915#9307])
>    [10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@i915_selftest@live@gem_contexts.html
>
>   * igt@i915_selftest@live@gt_lrc:
>     - bat-adlm-1:         [PASS][11] -> [INCOMPLETE][12] ([i915#9413])
>    [11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html
>    [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html
>
>   * igt@i915_selftest@live@gt_pm:
>     - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][13] ([i915#1886])
>    [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html
>
>   * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][14] ([fdo#109271] / [i915#5190])
>    [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html
>
>   * igt@kms_dsc@dsc-basic:
>     - fi-kbl-soraka:      NOTRUN -> [SKIP][15] ([fdo#109271]) +9 other tests skip
>    [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html
>
>   * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
>     - fi-hsw-4770:        NOTRUN -> [SKIP][16] ([fdo#109271]) +12 other tests skip
>    [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html
>
>   
> #### Possible fixes ####
>
>   * igt@i915_selftest@live@gt_heartbeat:
>     - fi-apl-guc:         [DMESG-FAIL][17] ([i915#5334]) -> [PASS][18]
>    [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
>    [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
>
>   * igt@i915_selftest@live@gt_mocs:
>     - bat-mtlp-6:         [DMESG-WARN][19] -> [PASS][20]
>    [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
>    [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
>
>   
>   {name}: This element is suppressed. This means it is ignored when computing
>           the status of the difference (SUCCESS, WARNING, or FAILURE).
>
>   [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
>   [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
>   [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
>   [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
>   [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
>   [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
>   [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
>   [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
>   [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
>   [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
>   [i915#9307]: https://gitlab.freedesktop.org/drm/intel/issues/9307
>   [i915#9413]: https://gitlab.freedesktop.org/drm/intel/issues/9413
>   [i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
>
>
> Build changes
> -------------
>
>   * Linux: CI_DRM_13900 -> Patchwork_125977v5
>
>   CI-20190529: 20190529
>   CI_DRM_13900: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux
>   IGT_7595: cfa00d99b1dfa0621ea552d1ed54907798da1a1a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
>   Patchwork_125977v5: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux
>
>
> ### Linux commits
>
> cb7eb92e41e3 drm/i915/iosf: Drop unused APIs
> 44c7e68968f6 drm/i915/dsi: Combine checks in mipi_exec_gpio()
> e4396287dc34 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
> 28e3789e862e drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
> f158fdd42837 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
> 6d1ab8a8b97e drm/i915/dsi: Extract common soc_gpio_set_value() helper
> 4dfbdedecdd6 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
> 0cb4b3df52e7 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
> fead969f21d1 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
> 4c9e915997f9 drm/i915/dsi: Get rid of redundant 'else'
> e5900b3a5fd2 drm/i915/dsi: Replace while(1) with one with clear exit condition
> 2384619f40ea drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
> e5c894cae398 drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
> 74a19c4a70c6 drm/i915/dsi: clarify GPIO exec sequence
> dd72fa43d232 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
> 4472705c19fb drm/i915/dsi: assume BXT gpio works for non-native GPIO
>
> == Logs ==
>
> For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html

-- 
Jani Nikula, Intel

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)

[Patchwork]

[-- Attachment #1: Type: text/plain, Size: 7404 bytes --]

== Series Details ==

Series: drm/i915/dsi: 4th attempt to get rid of IOSF GPIO (rev5)
URL   : https://patchwork.freedesktop.org/series/125977/
State : success

== Summary ==

CI Bug Log - changes from CI_DRM_13900 -> Patchwork_125977v5
====================================================

Summary
-------

  **SUCCESS**

  No regressions found.

  External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html

Participating hosts (33 -> 34)
------------------------------

  Additional (2): fi-kbl-soraka fi-hsw-4770 
  Missing    (1): fi-snb-2520m 

Known issues
------------

  Here are the changes found in Patchwork_125977v5 that come from known issues:

### CI changes ###

#### Issues hit ####

  * boot:
    - fi-elk-e7500:       [PASS][1] -> [FAIL][2] ([i915#8293])
   [1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-elk-e7500/boot.html
   [2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-elk-e7500/boot.html
    - fi-kbl-x1275:       [PASS][3] -> [FAIL][4] ([i915#8293])
   [3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-kbl-x1275/boot.html
   [4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-x1275/boot.html

  

### IGT changes ###

#### Issues hit ####

  * igt@gem_exec_suspend@basic-s0@lmem0:
    - bat-dg2-9:          [PASS][5] -> [INCOMPLETE][6] ([i915#9275])
   [5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html
   [6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-dg2-9/igt@gem_exec_suspend@basic-s0@lmem0.html

  * igt@gem_huc_copy@huc-copy:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][7] ([fdo#109271] / [i915#2190])
   [7]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_huc_copy@huc-copy.html

  * igt@gem_lmem_swapping@basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][8] ([fdo#109271] / [i915#4613]) +3 other tests skip
   [8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@gem_lmem_swapping@basic.html

  * igt@i915_selftest@live@gem_contexts:
    - fi-hsw-4770:        NOTRUN -> [INCOMPLETE][9] ([i915#9307])
   [9]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@i915_selftest@live@gem_contexts.html

  * igt@i915_selftest@live@gt_lrc:
    - bat-adlm-1:         [PASS][10] -> [INCOMPLETE][11] ([i915#9413])
   [10]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html
   [11]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-adlm-1/igt@i915_selftest@live@gt_lrc.html

  * igt@i915_selftest@live@gt_pm:
    - fi-kbl-soraka:      NOTRUN -> [DMESG-FAIL][12] ([i915#1886])
   [12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@i915_selftest@live@gt_pm.html

  * igt@kms_addfb_basic@addfb25-y-tiled-small-legacy:
    - fi-hsw-4770:        NOTRUN -> [SKIP][13] ([fdo#109271] / [i915#5190])
   [13]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_addfb_basic@addfb25-y-tiled-small-legacy.html

  * igt@kms_addfb_basic@basic-y-tiled-legacy:
    - fi-kbl-soraka:      NOTRUN -> [INCOMPLETE][14] ([i915#9691])
   [14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_addfb_basic@basic-y-tiled-legacy.html

  * igt@kms_dsc@dsc-basic:
    - fi-kbl-soraka:      NOTRUN -> [SKIP][15] ([fdo#109271]) +9 other tests skip
   [15]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-kbl-soraka/igt@kms_dsc@dsc-basic.html

  * igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1:
    - fi-hsw-4770:        NOTRUN -> [SKIP][16] ([fdo#109271]) +12 other tests skip
   [16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-hsw-4770/igt@kms_pipe_crc_basic@compare-crc-sanitycheck-nv12@pipe-a-vga-1.html

  
#### Possible fixes ####

  * igt@i915_selftest@live@gt_heartbeat:
    - fi-apl-guc:         [DMESG-FAIL][17] ([i915#5334]) -> [PASS][18]
   [17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html
   [18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/fi-apl-guc/igt@i915_selftest@live@gt_heartbeat.html

  * igt@i915_selftest@live@gt_mocs:
    - bat-mtlp-6:         [DMESG-WARN][19] -> [PASS][20]
   [19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_13900/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html
   [20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/bat-mtlp-6/igt@i915_selftest@live@gt_mocs.html

  
  {name}: This element is suppressed. This means it is ignored when computing
          the status of the difference (SUCCESS, WARNING, or FAILURE).

  [fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
  [i915#1886]: https://gitlab.freedesktop.org/drm/intel/issues/1886
  [i915#2190]: https://gitlab.freedesktop.org/drm/intel/issues/2190
  [i915#4613]: https://gitlab.freedesktop.org/drm/intel/issues/4613
  [i915#5190]: https://gitlab.freedesktop.org/drm/intel/issues/5190
  [i915#5334]: https://gitlab.freedesktop.org/drm/intel/issues/5334
  [i915#7359]: https://gitlab.freedesktop.org/drm/intel/issues/7359
  [i915#8293]: https://gitlab.freedesktop.org/drm/intel/issues/8293
  [i915#8981]: https://gitlab.freedesktop.org/drm/intel/issues/8981
  [i915#9275]: https://gitlab.freedesktop.org/drm/intel/issues/9275
  [i915#9307]: https://gitlab.freedesktop.org/drm/intel/issues/9307
  [i915#9413]: https://gitlab.freedesktop.org/drm/intel/issues/9413
  [i915#9648]: https://gitlab.freedesktop.org/drm/intel/issues/9648
  [i915#9691]: https://gitlab.freedesktop.org/drm/intel/issues/9691


Build changes
-------------

  * Linux: CI_DRM_13900 -> Patchwork_125977v5

  CI-20190529: 20190529
  CI_DRM_13900: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux
  IGT_7595: cfa00d99b1dfa0621ea552d1ed54907798da1a1a @ https://gitlab.freedesktop.org/drm/igt-gpu-tools.git
  Patchwork_125977v5: 7e7a522c80874faff37a7a66bdaff0747f978e11 @ git://anongit.freedesktop.org/gfx-ci/linux


### Linux commits

cb7eb92e41e3 drm/i915/iosf: Drop unused APIs
44c7e68968f6 drm/i915/dsi: Combine checks in mipi_exec_gpio()
e4396287dc34 drm/i915/dsi: Replace poking of CHV GPIOs behind the driver's back
28e3789e862e drm/i915/dsi: Prepare soc_gpio_set_value() to distinguish GPIO communities
f158fdd42837 drm/i915/dsi: Replace poking of VLV GPIOs behind the driver's back
6d1ab8a8b97e drm/i915/dsi: Extract common soc_gpio_set_value() helper
4dfbdedecdd6 drm/i915/dsi: Fix wrong initial value for GPIOs in bxt_gpio_set_value()
0cb4b3df52e7 drm/i915/dsi: Remove GPIO lookup table at the end of intel_dsi_vbt_gpio_init()
fead969f21d1 drm/i915/dsi: Replace check with a (missing) MIPI sequence name
4c9e915997f9 drm/i915/dsi: Get rid of redundant 'else'
e5900b3a5fd2 drm/i915/dsi: Replace while(1) with one with clear exit condition
2384619f40ea drm/i915/dsi: bxt/icl GPIO set value do not need gpio source
e5c894cae398 drm/i915/dsi: rename platform specific *_exec_gpio() to *_gpio_set_value()
74a19c4a70c6 drm/i915/dsi: clarify GPIO exec sequence
dd72fa43d232 drm/i915/dsi: switch mipi_exec_gpio() from dev_priv to i915
4472705c19fb drm/i915/dsi: assume BXT gpio works for non-native GPIO

== Logs ==

For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_125977v5/index.html

[-- Attachment #2: Type: text/html, Size: 8598 bytes --]