From: Markus Armbruster <armbru@redhat.com>
To: Thomas Huth <thuth@redhat.com>
Cc: Gurchetan Singh <gurchetansingh@chromium.org>,
qemu-devel@nongnu.org, Markus Armbruster <armbru@redhat.com>,
marcandre.lureau@redhat.com, akihiko.odaki@gmail.com,
ray.huang@amd.com, alex.bennee@linaro.org, shentey@gmail.com,
hi@alyssa.is, ernunes@redhat.com,
manos.pitsidianakis@linaro.org, philmd@linaro.org,
mark.cave-ayland@ilande.co.uk
Subject: Re: [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream
Date: Wed, 27 Sep 2023 14:24:08 +0200 [thread overview]
Message-ID: <875y3vdct3.fsf@pond.sub.org> (raw)
In-Reply-To: <921df90e-418b-5442-e84b-7ead3e75501a@redhat.com> (Thomas Huth's message of "Wed, 27 Sep 2023 13:45:45 +0200")
Thomas Huth <thuth@redhat.com> writes:
[...]
>> +static Property virtio_gpu_rutabaga_properties[] = {
>> + DEFINE_PROP_STRING("capset_names", VirtIOGPURutabaga, capset_names),
>> + DEFINE_PROP_STRING("wayland_socket_path", VirtIOGPURutabaga,
>> + wayland_socket_path),
>
> FWIW, it seems to be more common to use "-" instead of "_" to separate words in properties ... so I'd like to suggest to replace the underscores in the strings here.
Please separate words with '-', not '_', except where existing
properties all use '_'.
next prev parent reply other threads:[~2023-09-27 12:24 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-29 0:36 [PATCH v13 0/9] rutabaga_gfx + gfxstream Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 1/9] virtio: Add shared memory capability Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 2/9] virtio-gpu: CONTEXT_INIT feature Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 3/9] virtio-gpu: hostmem Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 4/9] virtio-gpu: blob prep Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 5/9] gfxstream + rutabaga prep: added need defintions, fields, and options Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 6/9] gfxstream + rutabaga: add initial support for gfxstream Gurchetan Singh
2023-09-20 11:42 ` Akihiko Odaki
2023-09-20 12:04 ` Mark Cave-Ayland
2023-09-22 0:03 ` Gurchetan Singh
2023-09-22 2:53 ` Akihiko Odaki
2023-09-22 7:42 ` Alyssa Ross
2023-09-22 7:54 ` Akihiko Odaki
2023-09-27 11:45 ` Thomas Huth
2023-09-27 12:24 ` Markus Armbruster [this message]
2023-09-27 12:26 ` Mark Cave-Ayland
2023-08-29 0:36 ` [PATCH v13 7/9] gfxstream + rutabaga: meson support Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 8/9] gfxstream + rutabaga: enable rutabaga Gurchetan Singh
2023-08-29 0:36 ` [PATCH v13 9/9] docs/system: add basic virtio-gpu documentation Gurchetan Singh
2023-08-31 2:25 ` [PATCH v13 0/9] rutabaga_gfx + gfxstream Huang Rui
2023-09-06 1:20 ` Gurchetan Singh
2023-09-06 6:25 ` Marc-André Lureau
2023-09-13 21:03 ` Bernhard Beschow
2023-09-12 13:59 ` Marc-André Lureau
2023-09-13 1:08 ` Gurchetan Singh
2023-09-13 13:49 ` Marc-André Lureau
2023-09-14 4:10 ` Gurchetan Singh
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875y3vdct3.fsf@pond.sub.org \
--to=armbru@redhat.com \
--cc=akihiko.odaki@gmail.com \
--cc=alex.bennee@linaro.org \
--cc=ernunes@redhat.com \
--cc=gurchetansingh@chromium.org \
--cc=hi@alyssa.is \
--cc=manos.pitsidianakis@linaro.org \
--cc=marcandre.lureau@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=philmd@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=ray.huang@amd.com \
--cc=shentey@gmail.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.