From: Jani Nikula <jani.nikula@linux.intel.com>
To: Nathan Huckleberry <nhuck@google.com>,
jsanka@codeaurora.org, robdclark@gmail.com, sean@poorly.run,
airlied@linux.ie, daniel@ffwll.ch
Cc: linux-arm-msm@vger.kernel.org, freedreno@lists.freedesktop.org,
dri-devel@lists.freedesktop.org,
clang-built-linux@googlegroups.com
Subject: Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
Date: Fri, 14 Jun 2019 12:46:44 +0300 [thread overview]
Message-ID: <875zp8wlbv.fsf@intel.com> (raw)
In-Reply-To: <CAJkfWY50geqLZv=dnchNEGp4i1yy0QfmTSz30uL6DXJXAq3VuA@mail.gmail.com>
On Thu, 13 Jun 2019, Nathan Huckleberry <nhuck@google.com> wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
Wholeheartedly agreed on the goal.
> There are several unused variables in dpu_formats.c
> ('dpu_format_map_tile', 'dpu_format_map_p010',
> 'dpu_format_map_p010_ubwc', 'dpu_format_map_tp10_ubwc').
> They look like modifiers that were never implemented. I'd like to
> remove these variables if there are no plans moving forward to
> implement them. Otherwise I'll just leave them.
>
> https://github.com/ClangBuiltLinux/linux/issues/528
No opinion on the said variables above, but, FWIW, personally I think
it's fine to add the cflags to supress warnings locally where needed in
order to be able to achieve the greater goal of removing the cflags
globally.
In drivers/gpu/drm/i915/Makefile we actually go for much stricter
warnings than the kernel defaults, and disable a more limited and
tailored set of warnings.
You can do this both on a subdir and file level with subdir-ccflags-y
and CFLAGS_filename.o, respectively.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
WARNING: multiple messages have this Message-ID (diff)
From: Jani Nikula <jani.nikula-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>
To: Nathan Huckleberry
<nhuck-hpIqsD4AKlfQT0dZR+AlfA@public.gmane.org>,
jsanka-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org,
robdclark-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sean-p7yTbzM4H96eqtR555YLDQ@public.gmane.org,
airlied-cv59FeDIM0c@public.gmane.org,
daniel-/w4YWyX8dFk@public.gmane.org
Cc: linux-arm-msm-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
freedreno-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
dri-devel-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org,
clang-built-linux-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org
Subject: Re: Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c
Date: Fri, 14 Jun 2019 12:46:44 +0300 [thread overview]
Message-ID: <875zp8wlbv.fsf@intel.com> (raw)
In-Reply-To: <CAJkfWY50geqLZv=dnchNEGp4i1yy0QfmTSz30uL6DXJXAq3VuA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
On Thu, 13 Jun 2019, Nathan Huckleberry <nhuck@google.com> wrote:
> Hey all,
>
> I'm looking into cleaning up ignored warnings in the kernel so we can
> remove compiler flags to ignore warnings.
Wholeheartedly agreed on the goal.
> There are several unused variables in dpu_formats.c
> ('dpu_format_map_tile', 'dpu_format_map_p010',
> 'dpu_format_map_p010_ubwc', 'dpu_format_map_tp10_ubwc').
> They look like modifiers that were never implemented. I'd like to
> remove these variables if there are no plans moving forward to
> implement them. Otherwise I'll just leave them.
>
> https://github.com/ClangBuiltLinux/linux/issues/528
No opinion on the said variables above, but, FWIW, personally I think
it's fine to add the cflags to supress warnings locally where needed in
order to be able to achieve the greater goal of removing the cflags
globally.
In drivers/gpu/drm/i915/Makefile we actually go for much stricter
warnings than the kernel defaults, and disable a more limited and
tailored set of warnings.
You can do this both on a subdir and file level with subdir-ccflags-y
and CFLAGS_filename.o, respectively.
BR,
Jani.
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Freedreno mailing list
Freedreno@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/freedreno
next prev parent reply other threads:[~2019-06-14 9:43 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 20:13 Cleanup of -Wunused-const-variable in drivers/gpu/drm/msm/disp/dpu1/dpu_formats.c Nathan Huckleberry
2019-06-13 20:13 ` Nathan Huckleberry
2019-06-13 20:49 ` Sean Paul
2019-06-13 20:49 ` Sean Paul
2019-06-14 18:55 ` Nick Desaulniers
2019-06-14 18:55 ` Nick Desaulniers
2019-06-13 20:52 ` Rob Clark
2019-06-13 20:52 ` Rob Clark
2019-06-14 7:17 ` Daniel Vetter
2019-06-14 7:17 ` Daniel Vetter
2019-06-14 9:46 ` Jani Nikula [this message]
2019-06-14 9:46 ` Jani Nikula
2019-06-14 18:59 ` Nick Desaulniers
2019-06-14 18:59 ` Nick Desaulniers
2019-06-14 20:56 ` [PATCH] drm/msm/dpu: Fix Wunused-const-variable Nathan Huckleberry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zp8wlbv.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@linux.ie \
--cc=clang-built-linux@googlegroups.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=jsanka@codeaurora.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=nhuck@google.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.