From: Eric Anholt <eric@anholt.net>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats
Date: Fri, 27 Jul 2018 13:55:03 -0700 [thread overview]
Message-ID: <8760101jrs.fsf@anholt.net> (raw)
In-Reply-To: <20180725122907.13702-1-boris.brezillon@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
Boris Brezillon <boris.brezillon@bootlin.com> writes:
> When there's no scaling requested ->is_unity should be true no matter
> the format.
>
> Also, when no scaling is requested and we have a multi-planar YUV
> format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only
> set ->x_scaling[0] to VC4_SCALING_PPF.
>
> Doing this fixes an hardly visible artifact (seen when using modetest
> and a rather big overlay plane in YUV420).
>
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Eric Anholt <eric@anholt.net>
To: Boris Brezillon <boris.brezillon@bootlin.com>
Cc: David Airlie <airlied@linux.ie>, Daniel Vetter <daniel@ffwll.ch>,
dri-devel@lists.freedesktop.org,
Boris Brezillon <boris.brezillon@bootlin.com>,
stable@vger.kernel.org
Subject: Re: [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats
Date: Fri, 27 Jul 2018 13:55:03 -0700 [thread overview]
Message-ID: <8760101jrs.fsf@anholt.net> (raw)
In-Reply-To: <20180725122907.13702-1-boris.brezillon@bootlin.com>
[-- Attachment #1: Type: text/plain, Size: 644 bytes --]
Boris Brezillon <boris.brezillon@bootlin.com> writes:
> When there's no scaling requested ->is_unity should be true no matter
> the format.
>
> Also, when no scaling is requested and we have a multi-planar YUV
> format, we should leave ->y_scaling[0] to VC4_SCALING_NONE and only
> set ->x_scaling[0] to VC4_SCALING_PPF.
>
> Doing this fixes an hardly visible artifact (seen when using modetest
> and a rather big overlay plane in YUV420).
>
> Fixes: fc04023fafec ("drm/vc4: Add support for YUV planes.")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Boris Brezillon <boris.brezillon@bootlin.com>
Reviewed-by: Eric Anholt <eric@anholt.net>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-07-27 20:55 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 12:29 [PATCH] drm/vc4: Fix the "no scaling" case on multi-planar YUV formats Boris Brezillon
2018-07-27 20:55 ` Eric Anholt [this message]
2018-07-27 20:55 ` Eric Anholt
2018-08-03 8:11 ` Boris Brezillon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760101jrs.fsf@anholt.net \
--to=eric@anholt.net \
--cc=airlied@linux.ie \
--cc=boris.brezillon@bootlin.com \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.