From: David Kastrup <dak@gnu.org>
To: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/4] Good bye fnmatch
Date: Sat, 15 Feb 2014 09:23:24 +0100 [thread overview]
Message-ID: <8761og3htv.fsf@fencepost.gnu.org> (raw)
In-Reply-To: <1392429709-9237-1-git-send-email-pclouds@gmail.com> ("Nguyễn Thái Ngọc Duy"'s message of "Sat, 15 Feb 2014 09:01:45 +0700")
Nguyễn Thái Ngọc Duy <pclouds@gmail.com> writes:
> Long story short, we wanted globbing wildcard "**" so I ripped
> wildmatch library from rsync to do it.
Since version 3.0.0, rsync is GPLv3
<URL:https://rsync.samba.org/GPL.html>. So be sure to take an older
version.
> And it opened a possibility to replace fnmatch completely, which would
> provide consistent behavior across platforms (native fnmatch behaves
> differently on many corner cases), and some performance gains. I
> started fnmatch replacement with 4917e1e (Makefile: promote wildmatch
> to be the default fnmatch implementation - 2013-05-30). This is the
> final step.
Sounds like I'm, uh, somewhat late in the game. More likely than not
you've taken care of that aspect long ago. Just thought I'd mention it.
--
David Kastrup
next prev parent reply other threads:[~2014-02-15 8:24 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-15 2:01 [PATCH 0/4] Good bye fnmatch Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 1/4] Use wildmatch() directly without fnmatch() wrapper Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 2/4] Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch" Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 3/4] Stop using fnmatch (either native or compat) Nguyễn Thái Ngọc Duy
2014-02-15 2:01 ` [PATCH 4/4] Actually remove compat fnmatch source code Nguyễn Thái Ngọc Duy
2014-02-15 8:23 ` David Kastrup [this message]
2014-02-15 8:29 ` [PATCH 0/4] Good bye fnmatch Duy Nguyen
2014-02-15 8:49 ` David Kastrup
2014-02-18 19:28 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761og3htv.fsf@fencepost.gnu.org \
--to=dak@gnu.org \
--cc=git@vger.kernel.org \
--cc=pclouds@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.