Re: [PATCH 0/4] Good bye fnmatch

[Junio C Hamano <gitster@pobox.com>]

Nguyễn Thái Ngọc Duy  <pclouds@gmail.com> writes:

> Long story short, we wanted globbing wildcard "**" so I ripped
> wildmatch library from rsync to do it. And it opened a possibility
> to replace fnmatch completely, which would provide consistent behavior
> across platforms (native fnmatch behaves differently on many corner
> cases), and some performance gains. I started fnmatch replacement with
> 4917e1e (Makefile: promote wildmatch to be the default fnmatch
> implementation - 2013-05-30). This is the final step.

Nice.

>
> Nguyễn Thái Ngọc Duy (4):
>   Use wildmatch() directly without fnmatch() wrapper
>   Revert "test-wildmatch: add "perf" command to compare wildmatch and fnmatch"
>   Stop using fnmatch (either native or compat)
>   Actually remove compat fnmatch source code
>
>  Makefile                        |  22 --
>  builtin/apply.c                 |   2 +-
>  builtin/branch.c                |   2 +-
>  builtin/describe.c              |   2 +-
>  builtin/for-each-ref.c          |   2 +-
>  builtin/ls-remote.c             |   2 +-
>  builtin/name-rev.c              |   2 +-
>  builtin/reflog.c                |   2 +-
>  builtin/replace.c               |   2 +-
>  builtin/show-branch.c           |   2 +-
>  builtin/tag.c                   |   2 +-
>  compat/fnmatch/fnmatch.c (gone) | 494 ----------------------------------------
>  compat/fnmatch/fnmatch.h (gone) |  84 -------
>  config.mak.uname                |  10 -
>  configure.ac                    |  28 ---
>  diffcore-order.c                |   2 +-
>  dir.c                           |  11 +-
>  git-compat-util.h               |  12 -
>  refs.c                          |   2 +-
>  revision.c                      |   2 +-
>  t/t3070-wildmatch.sh            |  13 --
>  test-wildmatch.c                |  79 -------
>  22 files changed, 20 insertions(+), 759 deletions(-)