From: Kevin Hilman <khilman@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Koyamangalath, Abhilash" <abhilash.kv@ti.com>
Subject: Re: [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present
Date: Thu, 10 Nov 2011 10:33:48 -0800 [thread overview]
Message-ID: <8762irg73n.fsf@ti.com> (raw)
In-Reply-To: <E28AAFD00EFAA646AE3DF9B89CD24A89036E64@DBDE01.ent.ti.com> (Sanjeev Premi's message of "Wed, 9 Nov 2011 10:11:03 +0000")
"Premi, Sanjeev" <premi@ti.com> writes:
>> Current code registers voltage layer details for TWL PMIC even when a
>> TWL has not been registered. Fix this to only register the TWL with
>> voltage layer when the TWL PMIC is initialized by board-level code.
>>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
[...]
> I have been out-of-loop from PM for some time. So my query may be
> redundant:
>
> 1) What happens when different PMIC (not TWL series) is registered
> for AM35x? e.g. TPS65023
> http://www.spinics.net/lists/linux-omap/msg48630.html
>
> 2) Wouldn't we still fall back into omap3_twl_init()?
I'm not sure I follow the question.
If you're not using a TWL PMIC (or similar derivative) then
omap*_twl_init() should not be called.
If you are using a TWL PMIC, then no, the omap*_twl_init functions
should not be called.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present
Date: Thu, 10 Nov 2011 10:33:48 -0800 [thread overview]
Message-ID: <8762irg73n.fsf@ti.com> (raw)
In-Reply-To: <E28AAFD00EFAA646AE3DF9B89CD24A89036E64@DBDE01.ent.ti.com> (Sanjeev Premi's message of "Wed, 9 Nov 2011 10:11:03 +0000")
"Premi, Sanjeev" <premi@ti.com> writes:
>> Current code registers voltage layer details for TWL PMIC even when a
>> TWL has not been registered. Fix this to only register the TWL with
>> voltage layer when the TWL PMIC is initialized by board-level code.
>>
>> Signed-off-by: Kevin Hilman <khilman@ti.com>
[...]
> I have been out-of-loop from PM for some time. So my query may be
> redundant:
>
> 1) What happens when different PMIC (not TWL series) is registered
> for AM35x? e.g. TPS65023
> http://www.spinics.net/lists/linux-omap/msg48630.html
>
> 2) Wouldn't we still fall back into omap3_twl_init()?
I'm not sure I follow the question.
If you're not using a TWL PMIC (or similar derivative) then
omap*_twl_init() should not be called.
If you are using a TWL PMIC, then no, the omap*_twl_init functions
should not be called.
Kevin
next prev parent reply other threads:[~2011-11-10 18:33 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:14 [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present Kevin Hilman
2011-11-09 0:14 ` Kevin Hilman
2011-11-09 10:11 ` Premi, Sanjeev
2011-11-09 10:11 ` Premi, Sanjeev
2011-11-10 18:33 ` Kevin Hilman [this message]
2011-11-10 18:33 ` Kevin Hilman
2011-11-11 10:21 ` Premi, Sanjeev
2011-11-11 10:21 ` Premi, Sanjeev
2011-11-16 23:54 ` Kevin Hilman
2011-11-16 23:54 ` Kevin Hilman
2011-11-17 13:20 ` Premi, Sanjeev
2011-11-17 13:20 ` Premi, Sanjeev
2011-11-17 19:20 ` Kevin Hilman
2011-11-17 19:20 ` Kevin Hilman
2011-11-18 17:58 ` Premi, Sanjeev
2011-11-18 17:58 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8762irg73n.fsf@ti.com \
--to=khilman@ti.com \
--cc=abhilash.kv@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.