From: Kevin Hilman <khilman@ti.com>
To: "Premi, Sanjeev" <premi@ti.com>
Cc: "linux-omap@vger.kernel.org" <linux-omap@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"Koyamangalath, Abhilash" <abhilash.kv@ti.com>
Subject: Re: [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present
Date: Thu, 17 Nov 2011 11:20:39 -0800 [thread overview]
Message-ID: <878vne5zeg.fsf@ti.com> (raw)
In-Reply-To: <E28AAFD00EFAA646AE3DF9B89CD24A8904BF32@DBDE01.ent.ti.com> (Sanjeev Premi's message of "Thu, 17 Nov 2011 13:20:04 +0000")
"Premi, Sanjeev" <premi@ti.com> writes:
[...]
>>
>> If PMIC is not TWL family, then I don't expect any functions in
>> twl_common.c to be called.
>
> This is the reason I wanted to know if the check on ".irq" in the
> patch is sufficient. If any PMIC requires & sets "pmic_i2c_board_info.irq"
> then both omap3_twl_init() and omap4_twl_init() will be called.
Only TWL PMICs should be calling these functions, as they are in code
for TWL PMICs *only*.
If you have a non-TWL PMIC, then you should not be using the omap_pmic_*
functions.
Admittedly, these omap_pmic_* functions should be renamed to be clear
that they are TWL specific.
Kevin
WARNING: multiple messages have this Message-ID (diff)
From: khilman@ti.com (Kevin Hilman)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present
Date: Thu, 17 Nov 2011 11:20:39 -0800 [thread overview]
Message-ID: <878vne5zeg.fsf@ti.com> (raw)
In-Reply-To: <E28AAFD00EFAA646AE3DF9B89CD24A8904BF32@DBDE01.ent.ti.com> (Sanjeev Premi's message of "Thu, 17 Nov 2011 13:20:04 +0000")
"Premi, Sanjeev" <premi@ti.com> writes:
[...]
>>
>> If PMIC is not TWL family, then I don't expect any functions in
>> twl_common.c to be called.
>
> This is the reason I wanted to know if the check on ".irq" in the
> patch is sufficient. If any PMIC requires & sets "pmic_i2c_board_info.irq"
> then both omap3_twl_init() and omap4_twl_init() will be called.
Only TWL PMICs should be calling these functions, as they are in code
for TWL PMICs *only*.
If you have a non-TWL PMIC, then you should not be using the omap_pmic_*
functions.
Admittedly, these omap_pmic_* functions should be renamed to be clear
that they are TWL specific.
Kevin
next prev parent reply other threads:[~2011-11-17 19:20 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:14 [PATCH] ARM: OMAP: PM: only register TWL with voltage layer when device is present Kevin Hilman
2011-11-09 0:14 ` Kevin Hilman
2011-11-09 10:11 ` Premi, Sanjeev
2011-11-09 10:11 ` Premi, Sanjeev
2011-11-10 18:33 ` Kevin Hilman
2011-11-10 18:33 ` Kevin Hilman
2011-11-11 10:21 ` Premi, Sanjeev
2011-11-11 10:21 ` Premi, Sanjeev
2011-11-16 23:54 ` Kevin Hilman
2011-11-16 23:54 ` Kevin Hilman
2011-11-17 13:20 ` Premi, Sanjeev
2011-11-17 13:20 ` Premi, Sanjeev
2011-11-17 19:20 ` Kevin Hilman [this message]
2011-11-17 19:20 ` Kevin Hilman
2011-11-18 17:58 ` Premi, Sanjeev
2011-11-18 17:58 ` Premi, Sanjeev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=878vne5zeg.fsf@ti.com \
--to=khilman@ti.com \
--cc=abhilash.kv@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-omap@vger.kernel.org \
--cc=premi@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.