From: Juan Quintela <quintela@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: qemu-devel@nongnu.org, "Daniel P. Berrange" <berrange@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Richard Henderson" <richard.henderson@linaro.org>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Thomas Huth" <huth@tuxfamily.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Bandan Das" <bsd@redhat.com>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Huacai Chen" <chenhuacai@kernel.org>,
"Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Pavel Pisa" <pisa@cmp.felk.cvut.cz>,
"Vikram Garhwal" <fnu.vikram@xilinx.com>,
"Jason Wang" <jasowang@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
"Klaus Jensen" <its@irrelevant.dk>,
"Cornelia Huck" <cohuck@redhat.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"David Hildenbrand" <david@redhat.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Vijai Kumar K" <vijai@behindbytes.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Bin Meng" <bin.meng@windriver.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Corey Minyard" <minyard@acm.org>,
"Cédric Le Goater" <clg@kaod.org>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Joel Stanley" <joel@jms.id.au>,
"Francisco Iglesias" <francisco.iglesias@xilinx.com>,
"David Gibson" <david@gibson.dropbear.id.au>,
"Greg Kurz" <groug@kaod.org>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
"Taylor Simpson" <tsimpson@quicinc.com>,
qemu-arm@nongnu.org, qemu-block@nongnu.org,
qemu-s390x@nongnu.org, qemu-riscv@nongnu.org,
qemu-ppc@nongnu.org
Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes
Date: Tue, 10 Aug 2021 14:01:40 +0200 [thread overview]
Message-ID: <877dgt1paz.fsf@secure.mitica> (raw)
In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400")
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Some typedefs and macros are defined after the type check macros.
> This makes it difficult to automatically replace their
> definitions with OBJECT_DECLARE_TYPE.
>
> Patch generated using:
>
> $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \
> $(git grep -l '' -- '*.[ch]')
>
> which will:
> - split "typdef struct { ... } TypedefName" declarations
> - move the typedefs and #defines above the type check macros
> - add missing #include "qom/object.h" lines if necessary
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Just curious, how did my name ended on the CC'd list? I don't see any
file that I touched or that is migration related.
Later, Juan.
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Jason Wang" <jasowang@redhat.com>,
"Bin Meng" <bin.meng@windriver.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-devel@nongnu.org, "Jiaxun Yang" <jiaxun.yang@flygoat.com>,
"Laurent Vivier" <laurent@vivier.eu>,
"Vijai Kumar K" <vijai@behindbytes.com>,
"Taylor Simpson" <tsimpson@quicinc.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Vikram Garhwal" <fnu.vikram@xilinx.com>,
qemu-block@nongnu.org,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, "Huacai Chen" <chenhuacai@kernel.org>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Pavel Pisa" <pisa@cmp.felk.cvut.cz>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Corey Minyard" <minyard@acm.org>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Bandan Das" <bsd@redhat.com>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
qemu-riscv@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Francisco Iglesias" <francisco.iglesias@xilinx.com>,
"Thomas Huth" <huth@tuxfamily.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes
Date: Tue, 10 Aug 2021 14:01:40 +0200 [thread overview]
Message-ID: <877dgt1paz.fsf@secure.mitica> (raw)
In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400")
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Some typedefs and macros are defined after the type check macros.
> This makes it difficult to automatically replace their
> definitions with OBJECT_DECLARE_TYPE.
>
> Patch generated using:
>
> $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \
> $(git grep -l '' -- '*.[ch]')
>
> which will:
> - split "typdef struct { ... } TypedefName" declarations
> - move the typedefs and #defines above the type check macros
> - add missing #include "qom/object.h" lines if necessary
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Just curious, how did my name ended on the CC'd list? I don't see any
file that I touched or that is migration related.
Later, Juan.
WARNING: multiple messages have this Message-ID (diff)
From: Juan Quintela <quintela@redhat.com>
To: Eduardo Habkost <ehabkost@redhat.com>
Cc: "Peter Maydell" <peter.maydell@linaro.org>,
"Michael S. Tsirkin" <mst@redhat.com>,
"Alexey Kardashevskiy" <aik@ozlabs.ru>,
"Andrew Jeffery" <andrew@aj.id.au>,
"Jason Wang" <jasowang@redhat.com>,
"Bin Meng" <bin.meng@windriver.com>,
"David Hildenbrand" <david@redhat.com>,
qemu-devel@nongnu.org, "Laurent Vivier" <laurent@vivier.eu>,
"Vijai Kumar K" <vijai@behindbytes.com>,
"Taylor Simpson" <tsimpson@quicinc.com>,
"Alistair Francis" <Alistair.Francis@wdc.com>,
"Gerd Hoffmann" <kraxel@redhat.com>,
"Klaus Jensen" <its@irrelevant.dk>,
"Edgar E. Iglesias" <edgar.iglesias@gmail.com>,
"Vikram Garhwal" <fnu.vikram@xilinx.com>,
qemu-block@nongnu.org,
"Stefan Berger" <stefanb@linux.vnet.ibm.com>,
qemu-ppc@nongnu.org, "Huacai Chen" <chenhuacai@kernel.org>,
"Havard Skinnemoen" <hskinnemoen@google.com>,
"Halil Pasic" <pasic@linux.ibm.com>,
"Christian Borntraeger" <borntraeger@de.ibm.com>,
"Hervé Poussineau" <hpoussin@reactos.org>,
"Joel Stanley" <joel@jms.id.au>,
"Marc-André Lureau" <marcandre.lureau@redhat.com>,
"Pavel Pisa" <pisa@cmp.felk.cvut.cz>,
"Aleksandar Rikalo" <aleksandar.rikalo@syrmia.com>,
"Corey Minyard" <minyard@acm.org>,
qemu-s390x@nongnu.org,
"Richard Henderson" <richard.henderson@linaro.org>,
"Greg Kurz" <groug@kaod.org>,
"Dr. David Alan Gilbert" <dgilbert@redhat.com>,
"Alexander Bulekov" <alxndr@bu.edu>,
"Bandan Das" <bsd@redhat.com>,
qemu-arm@nongnu.org, "Cédric Le Goater" <clg@kaod.org>,
"Stefan Hajnoczi" <stefanha@redhat.com>,
"Paolo Bonzini" <pbonzini@redhat.com>,
"Keith Busch" <kbusch@kernel.org>,
qemu-riscv@nongnu.org,
"David Gibson" <david@gibson.dropbear.id.au>,
"Daniel P. Berrange" <berrange@redhat.com>,
"Francisco Iglesias" <francisco.iglesias@xilinx.com>,
"Thomas Huth" <huth@tuxfamily.org>,
"Bastian Koppelmann" <kbastian@mail.uni-paderborn.de>,
"Cornelia Huck" <cohuck@redhat.com>,
"Philippe Mathieu-Daudé" <f4bug@amsat.org>,
"Andrew Baumann" <Andrew.Baumann@microsoft.com>,
"Tyrone Ting" <kfting@nuvoton.com>,
"Palmer Dabbelt" <palmer@dabbelt.com>,
"Igor Mammedov" <imammedo@redhat.com>,
"Aurelien Jarno" <aurelien@aurel32.net>
Subject: Re: [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes
Date: Tue, 10 Aug 2021 14:01:40 +0200 [thread overview]
Message-ID: <877dgt1paz.fsf@secure.mitica> (raw)
In-Reply-To: <20210806211127.646908-6-ehabkost@redhat.com> (Eduardo Habkost's message of "Fri, 6 Aug 2021 17:11:20 -0400")
Eduardo Habkost <ehabkost@redhat.com> wrote:
> Some typedefs and macros are defined after the type check macros.
> This makes it difficult to automatically replace their
> definitions with OBJECT_DECLARE_TYPE.
>
> Patch generated using:
>
> $ ./scripts/codeconverter/converter.py -i --pattern=MoveSymbols \
> $(git grep -l '' -- '*.[ch]')
>
> which will:
> - split "typdef struct { ... } TypedefName" declarations
> - move the typedefs and #defines above the type check macros
> - add missing #include "qom/object.h" lines if necessary
>
> Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Just curious, how did my name ended on the CC'd list? I don't see any
file that I touched or that is migration related.
Later, Juan.
next prev parent reply other threads:[~2021-08-10 12:01 UTC|newest]
Thread overview: 54+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-06 21:11 [PATCH for-6.2 00/12] qom: Get rid of all manual usage of OBJECT_CHECK & friends Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 01/12] accel: Rename TYPE_ACCEL to TYPE_ACCEL_BASE Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 02/12] qom: Use DEVICE_*CLASS instead of OBJECT_*CLASS Eduardo Habkost
2021-08-07 8:17 ` Philippe Mathieu-Daudé
2021-08-10 11:56 ` Juan Quintela
2021-08-10 14:22 ` Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 03/12] scripts/codeconverter: Update to latest version Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 04/12] [automated] Add struct names to typedefs used by QOM types Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-07 8:03 ` Philippe Mathieu-Daudé
2021-08-07 8:03 ` Philippe Mathieu-Daudé
2021-08-06 21:11 ` [PATCH for-6.2 05/12] [automated] Move QOM typedefs and add missing includes Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-07 8:13 ` Philippe Mathieu-Daudé
2021-08-07 8:13 ` Philippe Mathieu-Daudé
2021-08-07 8:13 ` Philippe Mathieu-Daudé
2021-08-10 6:06 ` Cornelia Huck
2021-08-10 6:06 ` Cornelia Huck
2021-08-10 12:01 ` Juan Quintela [this message]
2021-08-10 12:01 ` Juan Quintela
2021-08-10 12:01 ` Juan Quintela
2021-08-10 13:06 ` Eduardo Habkost
2021-08-10 13:06 ` Eduardo Habkost
2021-08-10 13:06 ` Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 06/12] [automated] Split QOM "typedef struct T { ... } T" declarations Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-10 6:08 ` Cornelia Huck
2021-08-10 6:08 ` Cornelia Huck
2021-08-10 6:08 ` Cornelia Huck
2021-08-06 21:11 ` [PATCH for-6.2 07/12] [automated] Use DECLARE_*CHECKER* macros when possible Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-10 6:09 ` Cornelia Huck
2021-08-10 6:09 ` Cornelia Huck
2021-08-10 6:09 ` Cornelia Huck
2021-08-06 21:11 ` [PATCH for-6.2 08/12] npcm7xx_clk: Use DECLARE_INSTANCE_CHECKER Eduardo Habkost
2021-08-07 7:59 ` Philippe Mathieu-Daudé
2021-08-06 21:11 ` [PATCH for-6.2 09/12] npcm7xx_otp: Use DECLARE_CLASS_CHECKERS Eduardo Habkost
2021-08-07 8:00 ` Philippe Mathieu-Daudé
2021-08-06 21:11 ` [PATCH for-6.2 10/12] [automated] Use DECLARE_OBJ_CHECKERS when possible Eduardo Habkost
2021-08-06 21:11 ` [PATCH for-6.2 11/12] [automated] Use OBJECT_DECLARE_TYPE " Eduardo Habkost
2021-08-07 8:02 ` Philippe Mathieu-Daudé
2021-08-06 21:11 ` [PATCH for-6.2 12/12] [automated] Use OBJECT_DECLARE_SIMPLE_TYPE " Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-06 21:11 ` Eduardo Habkost
2021-08-07 8:09 ` Philippe Mathieu-Daudé
2021-08-07 8:09 ` Philippe Mathieu-Daudé
2021-08-07 8:09 ` Philippe Mathieu-Daudé
2021-08-10 6:12 ` Cornelia Huck
2021-08-10 6:12 ` Cornelia Huck
2021-08-10 6:12 ` Cornelia Huck
2021-08-07 8:15 ` [PATCH for-6.2 00/12] qom: Get rid of all manual usage of OBJECT_CHECK & friends Philippe Mathieu-Daudé
2021-08-09 18:00 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877dgt1paz.fsf@secure.mitica \
--to=quintela@redhat.com \
--cc=Alistair.Francis@wdc.com \
--cc=Andrew.Baumann@microsoft.com \
--cc=aik@ozlabs.ru \
--cc=aleksandar.rikalo@syrmia.com \
--cc=alxndr@bu.edu \
--cc=andrew@aj.id.au \
--cc=aurelien@aurel32.net \
--cc=berrange@redhat.com \
--cc=bin.meng@windriver.com \
--cc=borntraeger@de.ibm.com \
--cc=bsd@redhat.com \
--cc=chenhuacai@kernel.org \
--cc=clg@kaod.org \
--cc=cohuck@redhat.com \
--cc=david@gibson.dropbear.id.au \
--cc=david@redhat.com \
--cc=dgilbert@redhat.com \
--cc=edgar.iglesias@gmail.com \
--cc=ehabkost@redhat.com \
--cc=f4bug@amsat.org \
--cc=fnu.vikram@xilinx.com \
--cc=francisco.iglesias@xilinx.com \
--cc=groug@kaod.org \
--cc=hpoussin@reactos.org \
--cc=hskinnemoen@google.com \
--cc=huth@tuxfamily.org \
--cc=imammedo@redhat.com \
--cc=its@irrelevant.dk \
--cc=jasowang@redhat.com \
--cc=jiaxun.yang@flygoat.com \
--cc=joel@jms.id.au \
--cc=kbastian@mail.uni-paderborn.de \
--cc=kbusch@kernel.org \
--cc=kfting@nuvoton.com \
--cc=kraxel@redhat.com \
--cc=laurent@vivier.eu \
--cc=marcandre.lureau@redhat.com \
--cc=minyard@acm.org \
--cc=mst@redhat.com \
--cc=palmer@dabbelt.com \
--cc=pasic@linux.ibm.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=pisa@cmp.felk.cvut.cz \
--cc=qemu-arm@nongnu.org \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
--cc=qemu-riscv@nongnu.org \
--cc=qemu-s390x@nongnu.org \
--cc=richard.henderson@linaro.org \
--cc=stefanb@linux.vnet.ibm.com \
--cc=stefanha@redhat.com \
--cc=tsimpson@quicinc.com \
--cc=vijai@behindbytes.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.