All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] drm/i915/display: fix missing null check on allocated dsb object
@ 2020-06-16 11:42 ` Colin King
  0 siblings, 0 replies; 19+ messages in thread
From: Colin King @ 2020-06-16 11:42 UTC (permalink / raw)
  To: Jani Nikula, Joonas Lahtinen, Rodrigo Vivi, David Airlie,
	Daniel Vetter, Animesh Manna, Maarten Lankhorst, intel-gfx,
	dri-devel
  Cc: kernel-janitors, linux-kernel

From: Colin Ian King <colin.king@canonical.com>

Currently there is no null check for a failed memory allocation
on the dsb object and without this a null pointer dereference
error can occur. Fix this by adding a null check.

Note: added a drm_err message in keeping with the error message style
in the function.

Addresses-Coverity: ("Dereference null return")
Fixes: afeda4f3b1c8 ("drm/i915/dsb: Pre allocate and late cleanup of cmd buffer")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
 drivers/gpu/drm/i915/display/intel_dsb.c | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/drivers/gpu/drm/i915/display/intel_dsb.c b/drivers/gpu/drm/i915/display/intel_dsb.c
index 24e6d63e2d47..566fa72427b3 100644
--- a/drivers/gpu/drm/i915/display/intel_dsb.c
+++ b/drivers/gpu/drm/i915/display/intel_dsb.c
@@ -271,6 +271,10 @@ void intel_dsb_prepare(struct intel_crtc_state *crtc_state)
 		return;
 
 	dsb = kmalloc(sizeof(*dsb), GFP_KERNEL);
+	if (!dsb) {
+		drm_err(&i915->drm, "DSB object creation failed\n");
+		return;
+	}
 
 	wakeref = intel_runtime_pm_get(&i915->runtime_pm);
 
-- 
2.27.0.rc0

^ permalink raw reply related	[flat|nested] 19+ messages in thread

end of thread, other threads:[~2020-06-30 11:28 UTC | newest]

Thread overview: 19+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2020-06-16 11:42 [PATCH] drm/i915/display: fix missing null check on allocated dsb object Colin King
2020-06-16 11:42 ` Colin King
2020-06-16 11:42 ` [Intel-gfx] " Colin King
2020-06-16 11:42 ` Colin King
2020-06-16 11:54 ` Dan Carpenter
2020-06-16 11:54   ` Dan Carpenter
2020-06-16 11:54   ` [Intel-gfx] " Dan Carpenter
2020-06-16 11:54   ` Dan Carpenter
2020-06-16 11:56   ` Colin Ian King
2020-06-16 11:56     ` Colin Ian King
2020-06-16 11:56     ` [Intel-gfx] " Colin Ian King
2020-06-16 11:56     ` Colin Ian King
2020-06-30 11:28     ` Jani Nikula
2020-06-30 11:28       ` Jani Nikula
2020-06-30 11:28       ` [Intel-gfx] " Jani Nikula
2020-06-30 11:28       ` Jani Nikula
2020-06-16 19:03 ` [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2020-06-16 19:24 ` [Intel-gfx] ✓ Fi.CI.BAT: success " Patchwork
2020-06-16 21:33 ` [Intel-gfx] ✓ Fi.CI.IGT: " Patchwork

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.