All of lore.kernel.org
 help / color / mirror / Atom feed
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: improve power save performance for sdio
Date: Thu, 16 Apr 2020 15:38:48 +0300	[thread overview]
Message-ID: <877dyfr4fb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <0101016ed9241282-73dd8b35-e2e5-4f37-9b50-cf2fb6524dfc-000000@us-west-2.amazonses.com> (Wen Gong's message of "Fri, 6 Dec 2019 02:57:30 +0000")

Wen Gong <wgong@codeaurora.org> writes:

> This patch is to set register to allow the mbox enter sleep status
> if it does not have tx traffic and wakeup it if tx traffic arrive.
> After mbox enter sleep status, the soc will enter sleep status by
> firmware, this will save power. The power consume drops from about
> 90mW to about 10mW with this patch.
>
> This patch only effect sdio chip.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

[...]

> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool enable_sleep)
> +{
> +	if (ar->hif.ops->set_mbox_sleep)
> +		return ar->hif.ops->set_mbox_sleep(ar, enable_sleep);
> +	return 0;
> +}

I don't think we need to add another hif op for this. I sent v2 which
uses existing op.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k

WARNING: multiple messages have this Message-ID (diff)
From: Kalle Valo <kvalo@codeaurora.org>
To: Wen Gong <wgong@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: improve power save performance for sdio
Date: Thu, 16 Apr 2020 15:38:48 +0300	[thread overview]
Message-ID: <877dyfr4fb.fsf@kamboji.qca.qualcomm.com> (raw)
In-Reply-To: <0101016ed9241282-73dd8b35-e2e5-4f37-9b50-cf2fb6524dfc-000000@us-west-2.amazonses.com> (Wen Gong's message of "Fri, 6 Dec 2019 02:57:30 +0000")

Wen Gong <wgong@codeaurora.org> writes:

> This patch is to set register to allow the mbox enter sleep status
> if it does not have tx traffic and wakeup it if tx traffic arrive.
> After mbox enter sleep status, the soc will enter sleep status by
> firmware, this will save power. The power consume drops from about
> 90mW to about 10mW with this patch.
>
> This patch only effect sdio chip.
>
> Tested with QCA6174 SDIO with firmware WLAN.RMH.4.4.1-00029.
>
> Signed-off-by: Wen Gong <wgong@codeaurora.org>

[...]

> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool enable_sleep)
> +{
> +	if (ar->hif.ops->set_mbox_sleep)
> +		return ar->hif.ops->set_mbox_sleep(ar, enable_sleep);
> +	return 0;
> +}

I don't think we need to add another hif op for this. I sent v2 which
uses existing op.

-- 
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches

  reply	other threads:[~2020-04-16 12:39 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-12-06  2:57 [PATCH] ath10k: improve power save performance for sdio Wen Gong
2020-04-16 12:38 ` Kalle Valo [this message]
2020-04-16 12:38   ` Kalle Valo
2020-04-17  4:32   ` Wen Gong
2020-04-17  4:32     ` Wen Gong
2020-04-17  7:17     ` Kalle Valo
2020-04-17  7:17       ` Kalle Valo
2020-04-17  7:23       ` Wen Gong
2020-04-17  7:23         ` Wen Gong
  -- strict thread matches above, loose matches on Subject: below --
2019-12-06  2:57 Wen Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=877dyfr4fb.fsf@kamboji.qca.qualcomm.com \
    --to=kvalo@codeaurora.org \
    --cc=ath10k@lists.infradead.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=wgong@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.