From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: linux-wireless@vger.kernel.org, ath10k@lists.infradead.org
Subject: Re: [PATCH] ath10k: improve power save performance for sdio
Date: Fri, 17 Apr 2020 12:32:09 +0800 [thread overview]
Message-ID: <b9f680d57a6fbc9ac59dc5fc281d0af3@codeaurora.org> (raw)
In-Reply-To: <877dyfr4fb.fsf@kamboji.qca.qualcomm.com>
On 2020-04-16 20:38, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>
>> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool
>> enable_sleep)
>> +{
>> + if (ar->hif.ops->set_mbox_sleep)
>> + return ar->hif.ops->set_mbox_sleep(ar, enable_sleep);
>> + return 0;
>> +}
>
> I don't think we need to add another hif op for this. I sent v2 which
> uses existing op.
Yes, I see it.
but I see it removed ath10k_hif_set_mbox_sleep in ath10k_core_start,
expected it will not effect the patch's power save.
_______________________________________________
ath10k mailing list
ath10k@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/ath10k
WARNING: multiple messages have this Message-ID (diff)
From: Wen Gong <wgong@codeaurora.org>
To: Kalle Valo <kvalo@codeaurora.org>
Cc: ath10k@lists.infradead.org, linux-wireless@vger.kernel.org
Subject: Re: [PATCH] ath10k: improve power save performance for sdio
Date: Fri, 17 Apr 2020 12:32:09 +0800 [thread overview]
Message-ID: <b9f680d57a6fbc9ac59dc5fc281d0af3@codeaurora.org> (raw)
In-Reply-To: <877dyfr4fb.fsf@kamboji.qca.qualcomm.com>
On 2020-04-16 20:38, Kalle Valo wrote:
> Wen Gong <wgong@codeaurora.org> writes:
>
>
>> +static inline int ath10k_hif_set_mbox_sleep(struct ath10k *ar, bool
>> enable_sleep)
>> +{
>> + if (ar->hif.ops->set_mbox_sleep)
>> + return ar->hif.ops->set_mbox_sleep(ar, enable_sleep);
>> + return 0;
>> +}
>
> I don't think we need to add another hif op for this. I sent v2 which
> uses existing op.
Yes, I see it.
but I see it removed ath10k_hif_set_mbox_sleep in ath10k_core_start,
expected it will not effect the patch's power save.
next prev parent reply other threads:[~2020-04-17 4:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-06 2:57 [PATCH] ath10k: improve power save performance for sdio Wen Gong
2020-04-16 12:38 ` Kalle Valo
2020-04-16 12:38 ` Kalle Valo
2020-04-17 4:32 ` Wen Gong [this message]
2020-04-17 4:32 ` Wen Gong
2020-04-17 7:17 ` Kalle Valo
2020-04-17 7:17 ` Kalle Valo
2020-04-17 7:23 ` Wen Gong
2020-04-17 7:23 ` Wen Gong
-- strict thread matches above, loose matches on Subject: below --
2019-12-06 2:57 Wen Gong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b9f680d57a6fbc9ac59dc5fc281d0af3@codeaurora.org \
--to=wgong@codeaurora.org \
--cc=ath10k@lists.infradead.org \
--cc=kvalo@codeaurora.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.