* [V2] drm/i915: Add icl mipi dsi properties
@ 2019-06-26 9:27 Vandita Kulkarni
2019-06-26 11:35 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
` (3 more replies)
0 siblings, 4 replies; 7+ messages in thread
From: Vandita Kulkarni @ 2019-06-26 9:27 UTC (permalink / raw)
To: intel-gfx; +Cc: jani.nikula, ville.syrjala
Add scaling and panel orientation properties for
icl mipi dsi.
v2: Add platform specific function (Ville)
Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
---
drivers/gpu/drm/i915/display/icl_dsi.c | 30 ++++++++++++++++++++++++++
drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++--
2 files changed, 32 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
index b8673debf932..002db3300f40 100644
--- a/drivers/gpu/drm/i915/display/icl_dsi.c
+++ b/drivers/gpu/drm/i915/display/icl_dsi.c
@@ -1255,9 +1255,14 @@ static int gen11_dsi_compute_config(struct intel_encoder *encoder,
intel_connector->panel.fixed_mode;
struct drm_display_mode *adjusted_mode =
&pipe_config->base.adjusted_mode;
+ int ret = 0;
pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
intel_fixed_panel_mode(fixed_mode, adjusted_mode);
+
+ ret = skl_update_scaler_crtc(pipe_config);
+ if (ret)
+ return ret;
intel_pch_panel_fitting(crtc, pipe_config, conn_state->scaling_mode);
adjusted_mode->flags = 0;
@@ -1508,6 +1513,29 @@ static void icl_dphy_param_init(struct intel_dsi *intel_dsi)
intel_dsi_log_params(intel_dsi);
}
+static void icl_dsi_add_properties(struct intel_connector *connector)
+{
+ u32 allowed_scalers;
+
+ if (!connector->panel.fixed_mode)
+ return;
+
+ allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
+ BIT(DRM_MODE_SCALE_FULLSCREEN) |
+ BIT(DRM_MODE_SCALE_CENTER);
+
+ drm_connector_attach_scaling_mode_property(&connector->base,
+ allowed_scalers);
+
+ connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
+
+ connector->base.display_info.panel_orientation =
+ intel_dsi_get_panel_orientation(connector);
+ drm_connector_init_panel_orientation_property(&connector->base,
+ connector->panel.fixed_mode->hdisplay,
+ connector->panel.fixed_mode->vdisplay);
+}
+
void icl_dsi_init(struct drm_i915_private *dev_priv)
{
struct drm_device *dev = &dev_priv->drm;
@@ -1601,6 +1629,8 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
}
icl_dphy_param_init(intel_dsi);
+
+ icl_dsi_add_properties(intel_connector);
return;
err:
diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
index e272d826210a..c8002ffd29e7 100644
--- a/drivers/gpu/drm/i915/display/vlv_dsi.c
+++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
@@ -1644,7 +1644,7 @@ vlv_dsi_get_panel_orientation(struct intel_connector *connector)
return intel_dsi_get_panel_orientation(connector);
}
-static void intel_dsi_add_properties(struct intel_connector *connector)
+static void vlv_dsi_add_properties(struct intel_connector *connector)
{
struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
@@ -1983,7 +1983,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
intel_panel_setup_backlight(connector, INVALID_PIPE);
- intel_dsi_add_properties(intel_connector);
+ vlv_dsi_add_properties(intel_connector);
return;
--
2.21.0.5.gaeb582a
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 7+ messages in thread
* ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add icl mipi dsi properties
2019-06-26 9:27 [V2] drm/i915: Add icl mipi dsi properties Vandita Kulkarni
@ 2019-06-26 11:35 ` Patchwork
2019-06-26 12:04 ` ✓ Fi.CI.BAT: success " Patchwork
` (2 subsequent siblings)
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-06-26 11:35 UTC (permalink / raw)
To: Vandita Kulkarni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add icl mipi dsi properties
URL : https://patchwork.freedesktop.org/series/62770/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
c3eee71d5187 drm/i915: Add icl mipi dsi properties
-:48: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#48: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:1528:
+ drm_connector_attach_scaling_mode_property(&connector->base,
+ allowed_scalers);
-:55: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#55: FILE: drivers/gpu/drm/i915/display/icl_dsi.c:1535:
+ drm_connector_init_panel_orientation_property(&connector->base,
+ connector->panel.fixed_mode->hdisplay,
total: 0 errors, 0 warnings, 2 checks, 67 lines checked
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.BAT: success for drm/i915: Add icl mipi dsi properties
2019-06-26 9:27 [V2] drm/i915: Add icl mipi dsi properties Vandita Kulkarni
2019-06-26 11:35 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
@ 2019-06-26 12:04 ` Patchwork
2019-06-26 12:53 ` [V2] " Jani Nikula
2019-06-26 20:25 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-06-26 12:04 UTC (permalink / raw)
To: Vandita Kulkarni; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add icl mipi dsi properties
URL : https://patchwork.freedesktop.org/series/62770/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6357 -> Patchwork_13436
====================================================
Summary
-------
**SUCCESS**
No regressions found.
External URL: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/
Known issues
------------
Here are the changes found in Patchwork_13436 that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_create@basic-files:
- fi-icl-dsi: [PASS][1] -> [INCOMPLETE][2] ([fdo#107713] / [fdo#109100])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/fi-icl-dsi/igt@gem_ctx_create@basic-files.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/fi-icl-dsi/igt@gem_ctx_create@basic-files.html
* igt@gem_ctx_param@basic-default:
- fi-icl-u3: [PASS][3] -> [DMESG-WARN][4] ([fdo#107724])
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/fi-icl-u3/igt@gem_ctx_param@basic-default.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/fi-icl-u3/igt@gem_ctx_param@basic-default.html
#### Possible fixes ####
* igt@gem_ctx_create@basic-files:
- fi-icl-guc: [INCOMPLETE][5] ([fdo#107713] / [fdo#109100]) -> [PASS][6]
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/fi-icl-guc/igt@gem_ctx_create@basic-files.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/fi-icl-guc/igt@gem_ctx_create@basic-files.html
* igt@gem_exec_suspend@basic-s3:
- fi-blb-e6850: [INCOMPLETE][7] ([fdo#107718]) -> [PASS][8]
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/fi-blb-e6850/igt@gem_exec_suspend@basic-s3.html
* igt@kms_chamelium@hdmi-hpd-fast:
- fi-kbl-7500u: [FAIL][9] ([fdo#109485]) -> [PASS][10]
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/fi-kbl-7500u/igt@kms_chamelium@hdmi-hpd-fast.html
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#107718]: https://bugs.freedesktop.org/show_bug.cgi?id=107718
[fdo#107724]: https://bugs.freedesktop.org/show_bug.cgi?id=107724
[fdo#109100]: https://bugs.freedesktop.org/show_bug.cgi?id=109100
[fdo#109485]: https://bugs.freedesktop.org/show_bug.cgi?id=109485
Participating hosts (53 -> 46)
------------------------------
Additional (1): fi-bsw-n3050
Missing (8): fi-kbl-soraka fi-ilk-m540 fi-hsw-4200u fi-byt-squawks fi-bsw-cyan fi-icl-y fi-byt-clapper fi-bdw-samus
Build changes
-------------
* Linux: CI_DRM_6357 -> Patchwork_13436
CI_DRM_6357: b98734fa89ed90d3309c54bac90d83402c5ab0a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5068: 15ad664534413628f06c0f172aac11598bfdb895 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13436: c3eee71d5187876a0ffc8637f8a8d479a57603dd @ git://anongit.freedesktop.org/gfx-ci/linux
== Linux commits ==
c3eee71d5187 drm/i915: Add icl mipi dsi properties
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [V2] drm/i915: Add icl mipi dsi properties
2019-06-26 9:27 [V2] drm/i915: Add icl mipi dsi properties Vandita Kulkarni
2019-06-26 11:35 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-26 12:04 ` ✓ Fi.CI.BAT: success " Patchwork
@ 2019-06-26 12:53 ` Jani Nikula
2019-06-26 13:59 ` Ville Syrjälä
2019-06-26 20:25 ` ✓ Fi.CI.IGT: success for " Patchwork
3 siblings, 1 reply; 7+ messages in thread
From: Jani Nikula @ 2019-06-26 12:53 UTC (permalink / raw)
To: Vandita Kulkarni, intel-gfx; +Cc: ville.syrjala
On Wed, 26 Jun 2019, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> Add scaling and panel orientation properties for
> icl mipi dsi.
>
> v2: Add platform specific function (Ville)
>
> Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> ---
> drivers/gpu/drm/i915/display/icl_dsi.c | 30 ++++++++++++++++++++++++++
> drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++--
> 2 files changed, 32 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> index b8673debf932..002db3300f40 100644
> --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> @@ -1255,9 +1255,14 @@ static int gen11_dsi_compute_config(struct intel_encoder *encoder,
> intel_connector->panel.fixed_mode;
> struct drm_display_mode *adjusted_mode =
> &pipe_config->base.adjusted_mode;
> + int ret = 0;
No ned to initialize.
>
> pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> intel_fixed_panel_mode(fixed_mode, adjusted_mode);
> +
> + ret = skl_update_scaler_crtc(pipe_config);
> + if (ret)
> + return ret;
> intel_pch_panel_fitting(crtc, pipe_config, conn_state->scaling_mode);
>
> adjusted_mode->flags = 0;
> @@ -1508,6 +1513,29 @@ static void icl_dphy_param_init(struct intel_dsi *intel_dsi)
> intel_dsi_log_params(intel_dsi);
> }
>
> +static void icl_dsi_add_properties(struct intel_connector *connector)
> +{
> + u32 allowed_scalers;
> +
> + if (!connector->panel.fixed_mode)
> + return;
This is a redundant check, as the caller bails out if fixed_mode is
NULL.
Otherwise LGTM, maybe Ville has more nitpicks? ;)
BR,
Jani.
> +
> + allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
> + BIT(DRM_MODE_SCALE_FULLSCREEN) |
> + BIT(DRM_MODE_SCALE_CENTER);
> +
> + drm_connector_attach_scaling_mode_property(&connector->base,
> + allowed_scalers);
> +
> + connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
> +
> + connector->base.display_info.panel_orientation =
> + intel_dsi_get_panel_orientation(connector);
> + drm_connector_init_panel_orientation_property(&connector->base,
> + connector->panel.fixed_mode->hdisplay,
> + connector->panel.fixed_mode->vdisplay);
> +}
> +
> void icl_dsi_init(struct drm_i915_private *dev_priv)
> {
> struct drm_device *dev = &dev_priv->drm;
> @@ -1601,6 +1629,8 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
> }
>
> icl_dphy_param_init(intel_dsi);
> +
> + icl_dsi_add_properties(intel_connector);
> return;
>
> err:
> diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
> index e272d826210a..c8002ffd29e7 100644
> --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> @@ -1644,7 +1644,7 @@ vlv_dsi_get_panel_orientation(struct intel_connector *connector)
> return intel_dsi_get_panel_orientation(connector);
> }
>
> -static void intel_dsi_add_properties(struct intel_connector *connector)
> +static void vlv_dsi_add_properties(struct intel_connector *connector)
> {
> struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
>
> @@ -1983,7 +1983,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
> intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
> intel_panel_setup_backlight(connector, INVALID_PIPE);
>
> - intel_dsi_add_properties(intel_connector);
> + vlv_dsi_add_properties(intel_connector);
>
> return;
--
Jani Nikula, Intel Open Source Graphics Center
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [V2] drm/i915: Add icl mipi dsi properties
2019-06-26 12:53 ` [V2] " Jani Nikula
@ 2019-06-26 13:59 ` Ville Syrjälä
2019-06-26 15:08 ` Kulkarni, Vandita
0 siblings, 1 reply; 7+ messages in thread
From: Ville Syrjälä @ 2019-06-26 13:59 UTC (permalink / raw)
To: Jani Nikula; +Cc: intel-gfx, ville.syrjala
On Wed, Jun 26, 2019 at 03:53:19PM +0300, Jani Nikula wrote:
> On Wed, 26 Jun 2019, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> > Add scaling and panel orientation properties for
> > icl mipi dsi.
> >
> > v2: Add platform specific function (Ville)
> >
> > Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > ---
> > drivers/gpu/drm/i915/display/icl_dsi.c | 30 ++++++++++++++++++++++++++
> > drivers/gpu/drm/i915/display/vlv_dsi.c | 4 ++--
> > 2 files changed, 32 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c b/drivers/gpu/drm/i915/display/icl_dsi.c
> > index b8673debf932..002db3300f40 100644
> > --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> > @@ -1255,9 +1255,14 @@ static int gen11_dsi_compute_config(struct intel_encoder *encoder,
> > intel_connector->panel.fixed_mode;
> > struct drm_display_mode *adjusted_mode =
> > &pipe_config->base.adjusted_mode;
> > + int ret = 0;
>
> No ned to initialize.
>
> >
> > pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> > intel_fixed_panel_mode(fixed_mode, adjusted_mode);
> > +
> > + ret = skl_update_scaler_crtc(pipe_config);
> > + if (ret)
> > + return ret;
This function call is not needed IIRC. The calls we already have
in dp/hdmi are redundant. I have a branch somewhere where I remove
them.
> > intel_pch_panel_fitting(crtc, pipe_config, conn_state->scaling_mode);
> >
> > adjusted_mode->flags = 0;
> > @@ -1508,6 +1513,29 @@ static void icl_dphy_param_init(struct intel_dsi *intel_dsi)
> > intel_dsi_log_params(intel_dsi);
> > }
> >
> > +static void icl_dsi_add_properties(struct intel_connector *connector)
> > +{
> > + u32 allowed_scalers;
> > +
> > + if (!connector->panel.fixed_mode)
> > + return;
>
> This is a redundant check, as the caller bails out if fixed_mode is
> NULL.
>
> Otherwise LGTM, maybe Ville has more nitpicks? ;)
My only other nitpick is that this was cc:d to my wrong address.
>
> BR,
> Jani.
>
> > +
> > + allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
> > + BIT(DRM_MODE_SCALE_FULLSCREEN) |
> > + BIT(DRM_MODE_SCALE_CENTER);
> > +
> > + drm_connector_attach_scaling_mode_property(&connector->base,
> > + allowed_scalers);
> > +
> > + connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
> > +
> > + connector->base.display_info.panel_orientation =
> > + intel_dsi_get_panel_orientation(connector);
> > + drm_connector_init_panel_orientation_property(&connector->base,
> > + connector->panel.fixed_mode->hdisplay,
> > + connector->panel.fixed_mode->vdisplay);
> > +}
> > +
> > void icl_dsi_init(struct drm_i915_private *dev_priv)
> > {
> > struct drm_device *dev = &dev_priv->drm;
> > @@ -1601,6 +1629,8 @@ void icl_dsi_init(struct drm_i915_private *dev_priv)
> > }
> >
> > icl_dphy_param_init(intel_dsi);
> > +
> > + icl_dsi_add_properties(intel_connector);
> > return;
> >
> > err:
> > diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c b/drivers/gpu/drm/i915/display/vlv_dsi.c
> > index e272d826210a..c8002ffd29e7 100644
> > --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> > +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> > @@ -1644,7 +1644,7 @@ vlv_dsi_get_panel_orientation(struct intel_connector *connector)
> > return intel_dsi_get_panel_orientation(connector);
> > }
> >
> > -static void intel_dsi_add_properties(struct intel_connector *connector)
> > +static void vlv_dsi_add_properties(struct intel_connector *connector)
> > {
> > struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
> >
> > @@ -1983,7 +1983,7 @@ void vlv_dsi_init(struct drm_i915_private *dev_priv)
> > intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
> > intel_panel_setup_backlight(connector, INVALID_PIPE);
> >
> > - intel_dsi_add_properties(intel_connector);
> > + vlv_dsi_add_properties(intel_connector);
> >
> > return;
>
> --
> Jani Nikula, Intel Open Source Graphics Center
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx
--
Ville Syrjälä
Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [V2] drm/i915: Add icl mipi dsi properties
2019-06-26 13:59 ` Ville Syrjälä
@ 2019-06-26 15:08 ` Kulkarni, Vandita
0 siblings, 0 replies; 7+ messages in thread
From: Kulkarni, Vandita @ 2019-06-26 15:08 UTC (permalink / raw)
To: Ville Syrjälä, Nikula, Jani; +Cc: intel-gfx@lists.freedesktop.org
> -----Original Message-----
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
> Sent: Wednesday, June 26, 2019 7:29 PM
> To: Nikula, Jani <jani.nikula@intel.com>
> Cc: Kulkarni, Vandita <vandita.kulkarni@intel.com>; intel-
> gfx@lists.freedesktop.org; Syrjala, Ville <ville.syrjala@intel.com>
> Subject: Re: [Intel-gfx] [V2] drm/i915: Add icl mipi dsi properties
>
> On Wed, Jun 26, 2019 at 03:53:19PM +0300, Jani Nikula wrote:
> > On Wed, 26 Jun 2019, Vandita Kulkarni <vandita.kulkarni@intel.com> wrote:
> > > Add scaling and panel orientation properties for icl mipi dsi.
> > >
> > > v2: Add platform specific function (Ville)
> > >
> > > Signed-off-by: Vandita Kulkarni <vandita.kulkarni@intel.com>
> > > ---
> > > drivers/gpu/drm/i915/display/icl_dsi.c | 30
> > > ++++++++++++++++++++++++++ drivers/gpu/drm/i915/display/vlv_dsi.c |
> > > 4 ++--
> > > 2 files changed, 32 insertions(+), 2 deletions(-)
> > >
> > > diff --git a/drivers/gpu/drm/i915/display/icl_dsi.c
> > > b/drivers/gpu/drm/i915/display/icl_dsi.c
> > > index b8673debf932..002db3300f40 100644
> > > --- a/drivers/gpu/drm/i915/display/icl_dsi.c
> > > +++ b/drivers/gpu/drm/i915/display/icl_dsi.c
> > > @@ -1255,9 +1255,14 @@ static int gen11_dsi_compute_config(struct
> intel_encoder *encoder,
> > > intel_connector->panel.fixed_mode;
> > > struct drm_display_mode *adjusted_mode =
> > > &pipe_config->base.adjusted_mode;
> > > + int ret = 0;
> >
> > No ned to initialize.
Ok.
> >
> > >
> > > pipe_config->output_format = INTEL_OUTPUT_FORMAT_RGB;
> > > intel_fixed_panel_mode(fixed_mode, adjusted_mode);
> > > +
> > > + ret = skl_update_scaler_crtc(pipe_config);
> > > + if (ret)
> > > + return ret;
>
> This function call is not needed IIRC. The calls we already have in dp/hdmi are
> redundant. I have a branch somewhere where I remove them.
Ok.
>
> > > intel_pch_panel_fitting(crtc, pipe_config,
> > > conn_state->scaling_mode);
> > >
> > > adjusted_mode->flags = 0;
> > > @@ -1508,6 +1513,29 @@ static void icl_dphy_param_init(struct intel_dsi
> *intel_dsi)
> > > intel_dsi_log_params(intel_dsi);
> > > }
> > >
> > > +static void icl_dsi_add_properties(struct intel_connector
> > > +*connector) {
> > > + u32 allowed_scalers;
> > > +
> > > + if (!connector->panel.fixed_mode)
> > > + return;
> >
> > This is a redundant check, as the caller bails out if fixed_mode is
> > NULL.
Ok.
> >
> > Otherwise LGTM, maybe Ville has more nitpicks? ;)
>
> My only other nitpick is that this was cc:d to my wrong address.
Dropping it.
Thanks for the reviews. Will fix and send V3.
-Vandita
>
> >
> > BR,
> > Jani.
> >
> > > +
> > > + allowed_scalers = BIT(DRM_MODE_SCALE_ASPECT) |
> > > + BIT(DRM_MODE_SCALE_FULLSCREEN) |
> > > + BIT(DRM_MODE_SCALE_CENTER);
> > > +
> > > + drm_connector_attach_scaling_mode_property(&connector->base,
> > > + allowed_scalers);
> > > +
> > > + connector->base.state->scaling_mode = DRM_MODE_SCALE_ASPECT;
> > > +
> > > + connector->base.display_info.panel_orientation =
> > > + intel_dsi_get_panel_orientation(connector);
> > > + drm_connector_init_panel_orientation_property(&connector->base,
> > > + connector->panel.fixed_mode->hdisplay,
> > > + connector->panel.fixed_mode->vdisplay);
> > > +}
> > > +
> > > void icl_dsi_init(struct drm_i915_private *dev_priv) {
> > > struct drm_device *dev = &dev_priv->drm; @@ -1601,6 +1629,8 @@
> > > void icl_dsi_init(struct drm_i915_private *dev_priv)
> > > }
> > >
> > > icl_dphy_param_init(intel_dsi);
> > > +
> > > + icl_dsi_add_properties(intel_connector);
> > > return;
> > >
> > > err:
> > > diff --git a/drivers/gpu/drm/i915/display/vlv_dsi.c
> > > b/drivers/gpu/drm/i915/display/vlv_dsi.c
> > > index e272d826210a..c8002ffd29e7 100644
> > > --- a/drivers/gpu/drm/i915/display/vlv_dsi.c
> > > +++ b/drivers/gpu/drm/i915/display/vlv_dsi.c
> > > @@ -1644,7 +1644,7 @@ vlv_dsi_get_panel_orientation(struct
> intel_connector *connector)
> > > return intel_dsi_get_panel_orientation(connector);
> > > }
> > >
> > > -static void intel_dsi_add_properties(struct intel_connector
> > > *connector)
> > > +static void vlv_dsi_add_properties(struct intel_connector
> > > +*connector)
> > > {
> > > struct drm_i915_private *dev_priv = to_i915(connector->base.dev);
> > >
> > > @@ -1983,7 +1983,7 @@ void vlv_dsi_init(struct drm_i915_private
> *dev_priv)
> > > intel_panel_init(&intel_connector->panel, fixed_mode, NULL);
> > > intel_panel_setup_backlight(connector, INVALID_PIPE);
> > >
> > > - intel_dsi_add_properties(intel_connector);
> > > + vlv_dsi_add_properties(intel_connector);
> > >
> > > return;
> >
> > --
> > Jani Nikula, Intel Open Source Graphics Center
> > _______________________________________________
> > Intel-gfx mailing list
> > Intel-gfx@lists.freedesktop.org
> > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
>
> --
> Ville Syrjälä
> Intel
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
* ✓ Fi.CI.IGT: success for drm/i915: Add icl mipi dsi properties
2019-06-26 9:27 [V2] drm/i915: Add icl mipi dsi properties Vandita Kulkarni
` (2 preceding siblings ...)
2019-06-26 12:53 ` [V2] " Jani Nikula
@ 2019-06-26 20:25 ` Patchwork
3 siblings, 0 replies; 7+ messages in thread
From: Patchwork @ 2019-06-26 20:25 UTC (permalink / raw)
To: Kulkarni, Vandita; +Cc: intel-gfx
== Series Details ==
Series: drm/i915: Add icl mipi dsi properties
URL : https://patchwork.freedesktop.org/series/62770/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_6357_full -> Patchwork_13436_full
====================================================
Summary
-------
**SUCCESS**
No regressions found.
Known issues
------------
Here are the changes found in Patchwork_13436_full that come from known issues:
### IGT changes ###
#### Issues hit ####
* igt@gem_ctx_isolation@rcs0-reset:
- shard-hsw: [PASS][1] -> [DMESG-WARN][2] ([fdo#110789] / [fdo#110913 ])
[1]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw6/igt@gem_ctx_isolation@rcs0-reset.html
[2]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw4/igt@gem_ctx_isolation@rcs0-reset.html
* igt@gem_eio@in-flight-contexts-1us:
- shard-apl: [PASS][3] -> [DMESG-WARN][4] ([fdo#110913 ]) +4 similar issues
[3]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-apl3/igt@gem_eio@in-flight-contexts-1us.html
[4]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-apl7/igt@gem_eio@in-flight-contexts-1us.html
* igt@gem_eio@in-flight-suspend:
- shard-glk: [PASS][5] -> [FAIL][6] ([fdo#110667])
[5]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk1/igt@gem_eio@in-flight-suspend.html
[6]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk2/igt@gem_eio@in-flight-suspend.html
* igt@gem_eio@wait-wedge-immediate:
- shard-skl: [PASS][7] -> [DMESG-WARN][8] ([fdo#110913 ])
[7]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl4/igt@gem_eio@wait-wedge-immediate.html
[8]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl2/igt@gem_eio@wait-wedge-immediate.html
* igt@gem_partial_pwrite_pread@writes-after-reads-uncached:
- shard-kbl: [PASS][9] -> [DMESG-WARN][10] ([fdo#110913 ]) +1 similar issue
[9]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-kbl3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
[10]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-kbl3/igt@gem_partial_pwrite_pread@writes-after-reads-uncached.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-snb: [PASS][11] -> [DMESG-WARN][12] ([fdo#110789] / [fdo#110913 ]) +2 similar issues
[11]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-snb6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[12]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-snb4/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy:
- shard-glk: [PASS][13] -> [DMESG-WARN][14] ([fdo#110913 ]) +2 similar issues
[13]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk4/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
[14]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk8/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy.html
* igt@i915_pm_rpm@i2c:
- shard-hsw: [PASS][15] -> [FAIL][16] ([fdo#104097])
[15]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw2/igt@i915_pm_rpm@i2c.html
[16]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw1/igt@i915_pm_rpm@i2c.html
* igt@i915_suspend@debugfs-reader:
- shard-apl: [PASS][17] -> [DMESG-WARN][18] ([fdo#108566])
[17]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-apl6/igt@i915_suspend@debugfs-reader.html
[18]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-apl4/igt@i915_suspend@debugfs-reader.html
* igt@kms_flip@2x-plain-flip:
- shard-hsw: [PASS][19] -> [SKIP][20] ([fdo#109271]) +36 similar issues
[19]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw2/igt@kms_flip@2x-plain-flip.html
[20]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw1/igt@kms_flip@2x-plain-flip.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-glk: [PASS][21] -> [INCOMPLETE][22] ([fdo#103359] / [k.org#198133])
[21]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk1/igt@kms_flip@flip-vs-suspend-interruptible.html
[22]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk7/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite:
- shard-iclb: [PASS][23] -> [FAIL][24] ([fdo#103167]) +3 similar issues
[23]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
[24]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb4/igt@kms_frontbuffer_tracking@fbc-rgb565-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min:
- shard-skl: [PASS][25] -> [FAIL][26] ([fdo#108145])
[25]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl3/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
[26]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl10/igt@kms_plane_alpha_blend@pipe-a-constant-alpha-min.html
* igt@kms_plane_alpha_blend@pipe-b-coverage-7efc:
- shard-skl: [PASS][27] -> [FAIL][28] ([fdo#108145] / [fdo#110403])
[27]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl6/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
[28]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl8/igt@kms_plane_alpha_blend@pipe-b-coverage-7efc.html
* igt@kms_plane_cursor@pipe-b-primary-size-64:
- shard-iclb: [PASS][29] -> [INCOMPLETE][30] ([fdo#107713])
[29]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb7/igt@kms_plane_cursor@pipe-b-primary-size-64.html
[30]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb7/igt@kms_plane_cursor@pipe-b-primary-size-64.html
* igt@kms_plane_lowres@pipe-a-tiling-y:
- shard-iclb: [PASS][31] -> [FAIL][32] ([fdo#103166])
[31]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb6/igt@kms_plane_lowres@pipe-a-tiling-y.html
[32]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb5/igt@kms_plane_lowres@pipe-a-tiling-y.html
* igt@kms_setmode@basic:
- shard-skl: [PASS][33] -> [FAIL][34] ([fdo#99912])
[33]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl6/igt@kms_setmode@basic.html
[34]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl8/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-iclb: [PASS][35] -> [FAIL][36] ([fdo#100047])
[35]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb6/igt@kms_sysfs_edid_timing.html
[36]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb3/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-c-ts-continuation-suspend:
- shard-skl: [PASS][37] -> [INCOMPLETE][38] ([fdo#104108])
[37]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
[38]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl4/igt@kms_vblank@pipe-c-ts-continuation-suspend.html
* igt@perf@blocking:
- shard-skl: [PASS][39] -> [FAIL][40] ([fdo#110728])
[39]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl6/igt@perf@blocking.html
[40]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl8/igt@perf@blocking.html
#### Possible fixes ####
* igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive:
- shard-apl: [DMESG-WARN][41] ([fdo#110913 ]) -> [PASS][42] +3 similar issues
[41]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-apl3/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
[42]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-apl2/igt@gem_persistent_relocs@forked-faulting-reloc-thrash-inactive.html
* igt@gem_persistent_relocs@forked-faulting-reloc-thrashing:
- shard-kbl: [DMESG-WARN][43] ([fdo#110913 ]) -> [PASS][44]
[43]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-kbl6/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
[44]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-kbl1/igt@gem_persistent_relocs@forked-faulting-reloc-thrashing.html
* igt@gem_softpin@evict-active:
- shard-glk: [DMESG-WARN][45] ([fdo#110913 ]) -> [PASS][46] +1 similar issue
[45]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk4/igt@gem_softpin@evict-active.html
[46]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk6/igt@gem_softpin@evict-active.html
* igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup:
- shard-skl: [DMESG-WARN][47] ([fdo#110913 ]) -> [PASS][48]
[47]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
[48]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl2/igt@gem_userptr_blits@map-fixed-invalidate-overlap-busy-gup.html
* igt@gem_userptr_blits@sync-unmap:
- shard-snb: [DMESG-WARN][49] ([fdo#110789] / [fdo#110913 ]) -> [PASS][50] +2 similar issues
[49]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-snb1/igt@gem_userptr_blits@sync-unmap.html
[50]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-snb5/igt@gem_userptr_blits@sync-unmap.html
* igt@i915_pm_rc6_residency@rc6-accuracy:
- shard-kbl: [SKIP][51] ([fdo#109271]) -> [PASS][52]
[51]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-kbl2/igt@i915_pm_rc6_residency@rc6-accuracy.html
[52]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-kbl6/igt@i915_pm_rc6_residency@rc6-accuracy.html
* igt@kms_busy@extended-modeset-hang-newfb-render-b:
- shard-hsw: [DMESG-WARN][53] ([fdo#110222] / [fdo#110789] / [fdo#110913 ]) -> [PASS][54]
[53]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw1/igt@kms_busy@extended-modeset-hang-newfb-render-b.html
[54]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw2/igt@kms_busy@extended-modeset-hang-newfb-render-b.html
* igt@kms_cursor_crc@pipe-a-cursor-suspend:
- shard-kbl: [DMESG-WARN][55] ([fdo#103313]) -> [PASS][56]
[55]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-kbl6/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
[56]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-kbl1/igt@kms_cursor_crc@pipe-a-cursor-suspend.html
* igt@kms_flip@2x-flip-vs-expired-vblank-interruptible:
- shard-glk: [FAIL][57] ([fdo#105363]) -> [PASS][58]
[57]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk1/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
[58]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk7/igt@kms_flip@2x-flip-vs-expired-vblank-interruptible.html
* igt@kms_flip@flip-vs-suspend-interruptible:
- shard-apl: [DMESG-WARN][59] ([fdo#108566]) -> [PASS][60]
[59]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-apl7/igt@kms_flip@flip-vs-suspend-interruptible.html
[60]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-apl2/igt@kms_flip@flip-vs-suspend-interruptible.html
* igt@kms_flip@modeset-vs-vblank-race-interruptible:
- shard-glk: [FAIL][61] ([fdo#103060]) -> [PASS][62]
[61]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-glk7/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
[62]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-glk1/igt@kms_flip@modeset-vs-vblank-race-interruptible.html
* igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite:
- shard-iclb: [FAIL][63] ([fdo#103167]) -> [PASS][64] +4 similar issues
[63]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb2/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
[64]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb3/igt@kms_frontbuffer_tracking@fbc-1p-primscrn-spr-indfb-draw-pwrite.html
* igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite:
- shard-hsw: [SKIP][65] ([fdo#109271]) -> [PASS][66] +36 similar issues
[65]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw1/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
[66]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw4/igt@kms_frontbuffer_tracking@fbc-2p-primscrn-cur-indfb-draw-pwrite.html
* igt@kms_plane_alpha_blend@pipe-a-coverage-7efc:
- shard-iclb: [INCOMPLETE][67] ([fdo#107713]) -> [PASS][68]
[67]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb7/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
[68]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb2/igt@kms_plane_alpha_blend@pipe-a-coverage-7efc.html
* igt@kms_psr@psr2_primary_blt:
- shard-iclb: [SKIP][69] ([fdo#109441]) -> [PASS][70] +1 similar issue
[69]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-iclb1/igt@kms_psr@psr2_primary_blt.html
[70]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-iclb2/igt@kms_psr@psr2_primary_blt.html
* igt@kms_setmode@basic:
- shard-hsw: [FAIL][71] ([fdo#99912]) -> [PASS][72]
[71]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw1/igt@kms_setmode@basic.html
[72]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw4/igt@kms_setmode@basic.html
* igt@kms_sysfs_edid_timing:
- shard-hsw: [FAIL][73] ([fdo#100047]) -> [PASS][74]
[73]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-hsw1/igt@kms_sysfs_edid_timing.html
[74]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-hsw4/igt@kms_sysfs_edid_timing.html
* igt@kms_vblank@pipe-a-ts-continuation-suspend:
- shard-apl: [INCOMPLETE][75] ([fdo#103927]) -> [PASS][76]
[75]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-apl5/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
[76]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-apl1/igt@kms_vblank@pipe-a-ts-continuation-suspend.html
#### Warnings ####
* igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render:
- shard-skl: [FAIL][77] ([fdo#103167]) -> [FAIL][78] ([fdo#108040])
[77]: https://intel-gfx-ci.01.org/tree/drm-tip/CI_DRM_6357/shard-skl5/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[78]: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/shard-skl3/igt@kms_frontbuffer_tracking@fbcpsr-1p-primscrn-cur-indfb-draw-render.html
[fdo#100047]: https://bugs.freedesktop.org/show_bug.cgi?id=100047
[fdo#103060]: https://bugs.freedesktop.org/show_bug.cgi?id=103060
[fdo#103166]: https://bugs.freedesktop.org/show_bug.cgi?id=103166
[fdo#103167]: https://bugs.freedesktop.org/show_bug.cgi?id=103167
[fdo#103313]: https://bugs.freedesktop.org/show_bug.cgi?id=103313
[fdo#103359]: https://bugs.freedesktop.org/show_bug.cgi?id=103359
[fdo#103927]: https://bugs.freedesktop.org/show_bug.cgi?id=103927
[fdo#104097]: https://bugs.freedesktop.org/show_bug.cgi?id=104097
[fdo#104108]: https://bugs.freedesktop.org/show_bug.cgi?id=104108
[fdo#105363]: https://bugs.freedesktop.org/show_bug.cgi?id=105363
[fdo#107713]: https://bugs.freedesktop.org/show_bug.cgi?id=107713
[fdo#108040]: https://bugs.freedesktop.org/show_bug.cgi?id=108040
[fdo#108145]: https://bugs.freedesktop.org/show_bug.cgi?id=108145
[fdo#108566]: https://bugs.freedesktop.org/show_bug.cgi?id=108566
[fdo#109271]: https://bugs.freedesktop.org/show_bug.cgi?id=109271
[fdo#109441]: https://bugs.freedesktop.org/show_bug.cgi?id=109441
[fdo#110222]: https://bugs.freedesktop.org/show_bug.cgi?id=110222
[fdo#110403]: https://bugs.freedesktop.org/show_bug.cgi?id=110403
[fdo#110667]: https://bugs.freedesktop.org/show_bug.cgi?id=110667
[fdo#110728]: https://bugs.freedesktop.org/show_bug.cgi?id=110728
[fdo#110789]: https://bugs.freedesktop.org/show_bug.cgi?id=110789
[fdo#110913 ]: https://bugs.freedesktop.org/show_bug.cgi?id=110913
[fdo#99912]: https://bugs.freedesktop.org/show_bug.cgi?id=99912
[k.org#198133]: https://bugzilla.kernel.org/show_bug.cgi?id=198133
Participating hosts (10 -> 10)
------------------------------
No changes in participating hosts
Build changes
-------------
* Linux: CI_DRM_6357 -> Patchwork_13436
CI_DRM_6357: b98734fa89ed90d3309c54bac90d83402c5ab0a3 @ git://anongit.freedesktop.org/gfx-ci/linux
IGT_5068: 15ad664534413628f06c0f172aac11598bfdb895 @ git://anongit.freedesktop.org/xorg/app/intel-gpu-tools
Patchwork_13436: c3eee71d5187876a0ffc8637f8a8d479a57603dd @ git://anongit.freedesktop.org/gfx-ci/linux
piglit_4509: fdc5a4ca11124ab8413c7988896eec4c97336694 @ git://anongit.freedesktop.org/piglit
== Logs ==
For more details see: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_13436/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2019-06-26 20:25 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-06-26 9:27 [V2] drm/i915: Add icl mipi dsi properties Vandita Kulkarni
2019-06-26 11:35 ` ✗ Fi.CI.CHECKPATCH: warning for " Patchwork
2019-06-26 12:04 ` ✓ Fi.CI.BAT: success " Patchwork
2019-06-26 12:53 ` [V2] " Jani Nikula
2019-06-26 13:59 ` Ville Syrjälä
2019-06-26 15:08 ` Kulkarni, Vandita
2019-06-26 20:25 ` ✓ Fi.CI.IGT: success for " Patchwork
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.